virhostdev.c 60.0 KB
Newer Older
1 2
/* virhostdev.c: hostdev management
 *
3
 * Copyright (C) 2006-2007, 2009-2016 Red Hat, Inc.
4
 * Copyright (C) 2006 Daniel P. Berrange
5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20
 * Copyright (C) 2014 SUSE LINUX Products GmbH, Nuernberg, Germany.
 *
 * This library is free software; you can redistribute it and/or
 * modify it under the terms of the GNU Lesser General Public
 * License as published by the Free Software Foundation; either
 * version 2.1 of the License, or (at your option) any later version.
 *
 * This library is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
 * Lesser General Public License for more details.
 *
 * You should have received a copy of the GNU Lesser General Public
 * License along with this library.  If not, see
 * <http://www.gnu.org/licenses/>.
 *
21
 * Author: Daniel P. Berrange <berrange@redhat.com>
22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41
 * Author: Chunyan Liu <cyliu@suse.com>
 */

#include <config.h>

#include <fcntl.h>
#include <sys/ioctl.h>
#include <sys/types.h>
#include <sys/stat.h>
#include <unistd.h>
#include <stdlib.h>
#include <stdio.h>

#include "virhostdev.h"
#include "viralloc.h"
#include "virstring.h"
#include "virfile.h"
#include "virerror.h"
#include "virlog.h"
#include "virutil.h"
42
#include "virnetdev.h"
43 44 45
#include "configmake.h"

#define VIR_FROM_THIS VIR_FROM_NONE
46 47 48

VIR_LOG_INIT("util.hostdev");

49 50
#define HOSTDEV_STATE_DIR LOCALSTATEDIR "/run/libvirt/hostdevmgr"

51 52 53 54 55 56
static virHostdevManagerPtr manager; /* global hostdev manager, never freed */

static virClassPtr virHostdevManagerClass;
static void virHostdevManagerDispose(void *obj);
static virHostdevManagerPtr virHostdevManagerNew(void);

57
struct virHostdevIsPCINodeDeviceUsedData {
58
    virHostdevManagerPtr mgr;
59
    const char *domainName;
60
    const bool usesVFIO;
61 62
};

A
Andrea Bolognani 已提交
63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83
/* This module makes heavy use of bookkeeping lists contained inside a
 * virHostdevManager instance to keep track of the devices' status. To make
 * it easy to spot potential ownership errors when moving devices from one
 * list to the other, variable names should comply with the following
 * conventions when it comes to virPCIDevice and virPCIDeviceList instances:
 *
 *   pci - a short-lived virPCIDevice whose purpose is usually just to look
 *         up the actual PCI device in one of the bookkeeping lists; basically
 *         little more than a fancy virPCIDeviceAddress
 *
 *   pcidevs - a list containing a bunch of the above
 *
 *   actual - a virPCIDevice instance that has either been retrieved from one
 *            of the bookkeeping lists, or is intended to be added or copied
 *            to one at some point
 *
 * Passing an 'actual' to a function that requires a 'pci' is fine, but the
 * opposite is usually not true; as a rule of thumb, functions in the virpci
 * module usually expect an 'actual'. Even with these conventions in place,
 * adding comments to highlight ownership-related issues is recommended */

84 85
static int virHostdevIsPCINodeDeviceUsed(virPCIDeviceAddressPtr devAddr, void *opaque)
{
86
    virPCIDevicePtr actual;
87
    int ret = -1;
88
    struct virHostdevIsPCINodeDeviceUsedData *helperData = opaque;
89

90 91 92 93 94 95 96
    actual = virPCIDeviceListFindByIDs(helperData->mgr->activePCIHostdevs,
                                       devAddr->domain, devAddr->bus,
                                       devAddr->slot, devAddr->function);
    if (actual) {
        const char *actual_drvname = NULL;
        const char *actual_domname = NULL;
        virPCIDeviceGetUsedBy(actual, &actual_drvname, &actual_domname);
97

98
        if (helperData->usesVFIO &&
99 100
            (actual_domname && helperData->domainName) &&
            (STREQ(actual_domname, helperData->domainName)))
101 102
            goto iommu_owner;

103
        if (actual_drvname && actual_domname)
104 105 106
            virReportError(VIR_ERR_OPERATION_INVALID,
                           _("PCI device %s is in use by "
                             "driver %s, domain %s"),
107 108
                           virPCIDeviceGetName(actual),
                           actual_drvname, actual_domname);
109 110 111
        else
            virReportError(VIR_ERR_OPERATION_INVALID,
                           _("PCI device %s is in use"),
112
                           virPCIDeviceGetName(actual));
113 114
        goto cleanup;
    }
115
 iommu_owner:
116 117 118 119 120
    ret = 0;
 cleanup:
    return ret;
}

121 122 123 124 125 126 127 128 129 130 131 132 133 134 135
static int virHostdevManagerOnceInit(void)
{
    if (!(virHostdevManagerClass = virClassNew(virClassForObject(),
                                               "virHostdevManager",
                                               sizeof(virHostdevManager),
                                               virHostdevManagerDispose)))
        return -1;

    if (!(manager = virHostdevManagerNew()))
        return -1;

    return 0;
}

VIR_ONCE_GLOBAL_INIT(virHostdevManager)
136 137

static void
138
virHostdevManagerDispose(void *obj)
139
{
140 141
    virHostdevManagerPtr hostdevMgr = obj;

142 143 144
    if (!hostdevMgr)
        return;

145 146 147 148
    virObjectUnref(hostdevMgr->activePCIHostdevs);
    virObjectUnref(hostdevMgr->inactivePCIHostdevs);
    virObjectUnref(hostdevMgr->activeUSBHostdevs);
    virObjectUnref(hostdevMgr->activeSCSIHostdevs);
149 150 151
    VIR_FREE(hostdevMgr->stateDir);
}

152 153
static virHostdevManagerPtr
virHostdevManagerNew(void)
154
{
155
    virHostdevManagerPtr hostdevMgr;
156
    bool privileged = geteuid() == 0;
157 158 159

    if (!(hostdevMgr = virObjectNew(virHostdevManagerClass)))
        return NULL;
160

161
    if (!(hostdevMgr->activePCIHostdevs = virPCIDeviceListNew()))
162 163
        goto error;

164
    if (!(hostdevMgr->activeUSBHostdevs = virUSBDeviceListNew()))
165 166
        goto error;

167
    if (!(hostdevMgr->inactivePCIHostdevs = virPCIDeviceListNew()))
168 169
        goto error;

170
    if (!(hostdevMgr->activeSCSIHostdevs = virSCSIDeviceListNew()))
171 172
        goto error;

173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205
    if (privileged) {
        if (VIR_STRDUP(hostdevMgr->stateDir, HOSTDEV_STATE_DIR) < 0)
            goto error;

        if (virFileMakePath(hostdevMgr->stateDir) < 0) {
            virReportError(VIR_ERR_OPERATION_FAILED,
                           _("Failed to create state dir '%s'"),
                           hostdevMgr->stateDir);
            goto error;
        }
    } else {
        char *rundir = NULL;
        mode_t old_umask;

        if (!(rundir = virGetUserRuntimeDirectory()))
            goto error;

        if (virAsprintf(&hostdevMgr->stateDir, "%s/hostdevmgr", rundir) < 0) {
            VIR_FREE(rundir);
            goto error;
        }
        VIR_FREE(rundir);

        old_umask = umask(077);

        if (virFileMakePath(hostdevMgr->stateDir) < 0) {
            umask(old_umask);
            virReportError(VIR_ERR_OPERATION_FAILED,
                           _("Failed to create state dir '%s'"),
                           hostdevMgr->stateDir);
            goto error;
        }
        umask(old_umask);
206 207
    }

208
    return hostdevMgr;
209

210
 error:
211 212
    virObjectUnref(hostdevMgr);
    return NULL;
213 214 215 216 217
}

virHostdevManagerPtr
virHostdevManagerGetDefault(void)
{
218
    if (virHostdevManagerInitialize() < 0)
219
        return NULL;
220 221

    return virObjectRef(manager);
222
}
223 224

static virPCIDeviceListPtr
225
virHostdevGetPCIHostDeviceList(virDomainHostdevDefPtr *hostdevs, int nhostdevs)
226
{
227
    virPCIDeviceListPtr pcidevs;
228 229
    size_t i;

230
    if (!(pcidevs = virPCIDeviceListNew()))
231 232 233 234
        return NULL;

    for (i = 0; i < nhostdevs; i++) {
        virDomainHostdevDefPtr hostdev = hostdevs[i];
235
        virDomainHostdevSubsysPCIPtr pcisrc = &hostdev->source.subsys.u.pci;
236
        virPCIDevicePtr pci;
237 238 239 240 241 242

        if (hostdev->mode != VIR_DOMAIN_HOSTDEV_MODE_SUBSYS)
            continue;
        if (hostdev->source.subsys.type != VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_PCI)
            continue;

243
        pci = virPCIDeviceNew(pcisrc->addr.domain, pcisrc->addr.bus,
244
                              pcisrc->addr.slot, pcisrc->addr.function);
245 246
        if (!pci) {
            virObjectUnref(pcidevs);
247 248
            return NULL;
        }
249 250 251
        if (virPCIDeviceListAdd(pcidevs, pci) < 0) {
            virPCIDeviceFree(pci);
            virObjectUnref(pcidevs);
252 253 254
            return NULL;
        }

255
        virPCIDeviceSetManaged(pci, hostdev->managed);
256 257

        if (pcisrc->backend == VIR_DOMAIN_HOSTDEV_PCI_BACKEND_VFIO)
258
            virPCIDeviceSetStubDriver(pci, VIR_PCI_STUB_DRIVER_VFIO);
259
        else if (pcisrc->backend == VIR_DOMAIN_HOSTDEV_PCI_BACKEND_XEN)
260
            virPCIDeviceSetStubDriver(pci, VIR_PCI_STUB_DRIVER_XEN);
261
        else
262
            virPCIDeviceSetStubDriver(pci, VIR_PCI_STUB_DRIVER_KVM);
263 264
    }

265
    return pcidevs;
266 267 268 269
}


static int
270
virHostdevPCISysfsPath(virDomainHostdevDefPtr hostdev,
271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289
                       char **sysfs_path)
{
    virPCIDeviceAddress config_address;

    config_address.domain = hostdev->source.subsys.u.pci.addr.domain;
    config_address.bus = hostdev->source.subsys.u.pci.addr.bus;
    config_address.slot = hostdev->source.subsys.u.pci.addr.slot;
    config_address.function = hostdev->source.subsys.u.pci.addr.function;

    return virPCIDeviceAddressGetSysfsFile(&config_address, sysfs_path);
}


static int
virHostdevIsVirtualFunction(virDomainHostdevDefPtr hostdev)
{
    char *sysfs_path = NULL;
    int ret = -1;

290
    if (virHostdevPCISysfsPath(hostdev, &sysfs_path) < 0)
291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307
        return ret;

    ret = virPCIIsVirtualFunction(sysfs_path);

    VIR_FREE(sysfs_path);

    return ret;
}


static int
virHostdevNetDevice(virDomainHostdevDefPtr hostdev, char **linkdev,
                    int *vf)
{
    int ret = -1;
    char *sysfs_path = NULL;

308
    if (virHostdevPCISysfsPath(hostdev, &sysfs_path) < 0)
309 310 311 312 313 314 315 316 317 318 319 320 321 322
        return ret;

    if (virPCIIsVirtualFunction(sysfs_path) == 1) {
        if (virPCIGetVirtualFunctionInfo(sysfs_path, linkdev,
                                         vf) < 0)
            goto cleanup;
    } else {
        if (virPCIGetNetName(sysfs_path, linkdev) < 0)
            goto cleanup;
        *vf = -1;
    }

    ret = 0;

323
 cleanup:
324 325 326 327 328 329
    VIR_FREE(sysfs_path);

    return ret;
}


330
static bool
331 332 333 334 335 336 337 338 339
virHostdevIsPCINetDevice(virDomainHostdevDefPtr hostdev)
{
    return hostdev->mode == VIR_DOMAIN_HOSTDEV_MODE_SUBSYS &&
        hostdev->source.subsys.type == VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_PCI &&
        hostdev->parent.type == VIR_DOMAIN_DEVICE_NET &&
        hostdev->parent.data.net;
}


340 341 342 343 344 345 346 347 348 349 350 351 352 353
/**
 * virHostdevIsSCSIDevice:
 * @hostdev: host device to check
 *
 * Returns true if @hostdev is a SCSI device, false otherwise.
 */
bool
virHostdevIsSCSIDevice(virDomainHostdevDefPtr hostdev)
{
    return hostdev->mode == VIR_DOMAIN_HOSTDEV_MODE_SUBSYS &&
        hostdev->source.subsys.type == VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_SCSI;
}


354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396
static int
virHostdevNetConfigVirtPortProfile(const char *linkdev, int vf,
                                   virNetDevVPortProfilePtr virtPort,
                                   const virMacAddr *macaddr,
                                   const unsigned char *uuid,
                                   bool associate)
{
    int ret = -1;

    if (!virtPort)
        return ret;

    switch (virtPort->virtPortType) {
    case VIR_NETDEV_VPORT_PROFILE_NONE:
    case VIR_NETDEV_VPORT_PROFILE_OPENVSWITCH:
    case VIR_NETDEV_VPORT_PROFILE_8021QBG:
    case VIR_NETDEV_VPORT_PROFILE_LAST:
        virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
                       _("virtualport type %s is "
                         "currently not supported on interfaces of type "
                         "hostdev"),
                       virNetDevVPortTypeToString(virtPort->virtPortType));
        break;

    case VIR_NETDEV_VPORT_PROFILE_8021QBH:
        if (associate)
            ret = virNetDevVPortProfileAssociate(NULL, virtPort, macaddr,
                                                 linkdev, vf, uuid,
                                                 VIR_NETDEV_VPORT_PROFILE_OP_CREATE, false);
        else
            ret = virNetDevVPortProfileDisassociate(NULL, virtPort,
                                                    macaddr, linkdev, vf,
                                                    VIR_NETDEV_VPORT_PROFILE_OP_DESTROY);
        break;
    }

    return ret;
}


static int
virHostdevNetConfigReplace(virDomainHostdevDefPtr hostdev,
                           const unsigned char *uuid,
397
                           const char *stateDir)
398 399 400 401 402 403 404 405
{
    char *linkdev = NULL;
    virNetDevVlanPtr vlan;
    virNetDevVPortProfilePtr virtPort;
    int ret = -1;
    int vf = -1;
    bool port_profile_associate = true;

406
    if (virHostdevIsVirtualFunction(hostdev) != 1) {
407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433
        virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
                       _("Interface type hostdev is currently supported on"
                         " SR-IOV Virtual Functions only"));
        return ret;
    }

    if (virHostdevNetDevice(hostdev, &linkdev, &vf) < 0)
        return ret;

    vlan = virDomainNetGetActualVlan(hostdev->parent.data.net);
    virtPort = virDomainNetGetActualVirtPortProfile(
                                 hostdev->parent.data.net);
    if (virtPort) {
        if (vlan) {
            virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
                           _("direct setting of the vlan tag is not allowed "
                             "for hostdev devices using %s mode"),
                           virNetDevVPortTypeToString(virtPort->virtPortType));
            goto cleanup;
        }
        ret = virHostdevNetConfigVirtPortProfile(linkdev, vf,
                            virtPort, &hostdev->parent.data.net->mac, uuid,
                            port_profile_associate);
    } else {
        /* Set only mac and vlan */
        ret = virNetDevReplaceNetConfig(linkdev, vf,
                                        &hostdev->parent.data.net->mac,
434
                                        vlan, stateDir);
435
    }
436
 cleanup:
437 438 439 440 441 442 443 444
    VIR_FREE(linkdev);
    return ret;
}

/* @oldStateDir:
 * For upgrade purpose:
 * To an existing VM on QEMU, the hostdev netconfig file is originally stored
 * in cfg->stateDir (/var/run/libvirt/qemu). Switch to new version, it uses new
445
 * location (mgr->stateDir) but certainly will not find it. In this
446 447 448 449
 * case, try to find in the old state dir.
 */
static int
virHostdevNetConfigRestore(virDomainHostdevDefPtr hostdev,
450 451
                           const char *stateDir,
                           const char *oldStateDir)
452 453 454 455 456 457 458 459 460 461
{
    char *linkdev = NULL;
    virNetDevVPortProfilePtr virtPort;
    int ret = -1;
    int vf = -1;
    bool port_profile_associate = false;

    /* This is only needed for PCI devices that have been defined
     * using <interface type='hostdev'>. For all others, it is a NOP.
     */
462
    if (!virHostdevIsPCINetDevice(hostdev))
463 464
       return 0;

465
    if (virHostdevIsVirtualFunction(hostdev) != 1) {
466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493
        virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
                       _("Interface type hostdev is currently supported on"
                         " SR-IOV Virtual Functions only"));
        return ret;
    }

    if (virHostdevNetDevice(hostdev, &linkdev, &vf) < 0)
        return ret;

    virtPort = virDomainNetGetActualVirtPortProfile(
                                 hostdev->parent.data.net);
    if (virtPort) {
        ret = virHostdevNetConfigVirtPortProfile(linkdev, vf, virtPort,
                                                 &hostdev->parent.data.net->mac,
                                                 NULL,
                                                 port_profile_associate);
    } else {
        ret = virNetDevRestoreNetConfig(linkdev, vf, stateDir);
        if (ret < 0 && oldStateDir != NULL)
            ret = virNetDevRestoreNetConfig(linkdev, vf, oldStateDir);
    }

    VIR_FREE(linkdev);

    return ret;
}

int
494
virHostdevPreparePCIDevices(virHostdevManagerPtr mgr,
495
                            const char *drv_name,
496
                            const char *dom_name,
497 498 499 500 501 502 503 504 505
                            const unsigned char *uuid,
                            virDomainHostdevDefPtr *hostdevs,
                            int nhostdevs,
                            unsigned int flags)
{
    virPCIDeviceListPtr pcidevs = NULL;
    int last_processed_hostdev_vf = -1;
    size_t i;
    int ret = -1;
506
    virPCIDeviceAddressPtr devAddr = NULL;
507

508 509 510
    if (!nhostdevs)
        return 0;

511 512
    virObjectLock(mgr->activePCIHostdevs);
    virObjectLock(mgr->inactivePCIHostdevs);
513

514
    if (!(pcidevs = virHostdevGetPCIHostDeviceList(hostdevs, nhostdevs)))
515 516
        goto cleanup;

517 518 519 520 521 522 523 524
    /* Detaching devices from the host involves several steps; each
     * of them is described at length below.
     *
     * All devices must be detached before we reset any of them,
     * because in some cases you have to reset the whole PCI, which
     * impacts all devices on it. Also, all devices must be reset
     * before being marked as active */

525
    /* Step 1: Perform some initial checks on the devices */
526
    for (i = 0; i < virPCIDeviceListCount(pcidevs); i++) {
527
        virPCIDevicePtr pci = virPCIDeviceListGet(pcidevs, i);
528
        bool strict_acs_check = !!(flags & VIR_HOSTDEV_STRICT_ACS_CHECK);
529
        bool usesVFIO = (virPCIDeviceGetStubDriver(pci) == VIR_PCI_STUB_DRIVER_VFIO);
530
        struct virHostdevIsPCINodeDeviceUsedData data = { mgr, dom_name, usesVFIO };
531

532
        if (!usesVFIO && !virPCIDeviceIsAssignable(pci, strict_acs_check)) {
533 534
            virReportError(VIR_ERR_OPERATION_INVALID,
                           _("PCI device %s is not assignable"),
535
                           virPCIDeviceGetName(pci));
536 537
            goto cleanup;
        }
538

539
        /* The device is in use by other active domain if
540
         * the dev is in list activePCIHostdevs. VFIO devices
M
Martin Kletzander 已提交
541
         * belonging to same iommu group can't be shared
542
         * across guests.
543
         */
544
        devAddr = virPCIDeviceGetAddress(pci);
545
        if (usesVFIO) {
546 547
            if (virPCIDeviceAddressIOMMUGroupIterate(devAddr,
                                                     virHostdevIsPCINodeDeviceUsed,
548
                                                     &data) < 0)
549
                goto cleanup;
550
        } else if (virHostdevIsPCINodeDeviceUsed(devAddr, &data)) {
551 552 553 554
            goto cleanup;
        }
    }

555 556
    /* Step 2: detach managed devices and make sure unmanaged devices
     *         have already been taken care of */
557
    for (i = 0; i < virPCIDeviceListCount(pcidevs); i++) {
558
        virPCIDevicePtr pci = virPCIDeviceListGet(pcidevs, i);
559

560
        if (virPCIDeviceGetManaged(pci)) {
A
Andrea Bolognani 已提交
561 562 563 564 565

            /* We can't look up the actual device because it has not been
             * created yet: virPCIDeviceDetach() will insert a copy of 'pci'
             * into the list of inactive devices, and that copy will be the
             * actual device going forward */
566
            VIR_DEBUG("Detaching managed PCI device %s",
567 568
                      virPCIDeviceGetName(pci));
            if (virPCIDeviceDetach(pci,
569 570
                                   mgr->activePCIHostdevs,
                                   mgr->inactivePCIHostdevs) < 0)
571
                goto reattachdevs;
572
        } else {
573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613
            char *driverPath;
            char *driverName;
            int stub;

            /* Unmanaged devices should already have been marked as
             * inactive: if that's the case, we can simply move on */
            if (virPCIDeviceListFind(mgr->inactivePCIHostdevs, pci)) {
                VIR_DEBUG("Not detaching unmanaged PCI device %s",
                          virPCIDeviceGetName(pci));
                continue;
            }

            /* If that's not the case, though, it might be because the
             * daemon has been restarted, causing us to lose track of the
             * device. Try and recover by marking the device as inactive
             * if it happens to be bound to a known stub driver.
             *
             * FIXME Get rid of this once a proper way to keep track of
             *       information about active / inactive device across
             *       daemon restarts has been implemented */

            if (virPCIDeviceGetDriverPathAndName(pci,
                                                 &driverPath, &driverName) < 0)
                goto reattachdevs;

            stub = virPCIStubDriverTypeFromString(driverName);

            VIR_FREE(driverPath);
            VIR_FREE(driverName);

            if (stub > VIR_PCI_STUB_DRIVER_NONE &&
                stub < VIR_PCI_STUB_DRIVER_LAST) {

                /* The device is bound to a known stub driver: store this
                 * information and add a copy to the inactive list */
                virPCIDeviceSetStubDriver(pci, stub);

                VIR_DEBUG("Adding PCI device %s to inactive list",
                          virPCIDeviceGetName(pci));
                if (virPCIDeviceListAddCopy(mgr->inactivePCIHostdevs, pci) < 0)
                    goto reattachdevs;
614 615 616 617 618 619
            } else {
                virReportError(VIR_ERR_OPERATION_INVALID,
                               _("Unmanaged PCI device %s must be manually "
                               "detached from the host"),
                               virPCIDeviceGetName(pci));
                goto reattachdevs;
620
            }
621
        }
622 623
    }

624 625 626
    /* At this point, all devices are attached to the stub driver and have
     * been marked as inactive */

627
    /* Step 3: Now that all the PCI hostdevs have been detached, we
628 629
     * can safely reset them */
    for (i = 0; i < virPCIDeviceListCount(pcidevs); i++) {
630
        virPCIDevicePtr pci = virPCIDeviceListGet(pcidevs, i);
631

A
Andrea Bolognani 已提交
632 633 634
        /* We can avoid looking up the actual device here, because performing
         * a PCI reset on a device doesn't require any information other than
         * the address, which 'pci' already contains */
635 636
        VIR_DEBUG("Resetting PCI device %s", virPCIDeviceGetName(pci));
        if (virPCIDeviceReset(pci, mgr->activePCIHostdevs,
637
                              mgr->inactivePCIHostdevs) < 0)
638 639 640
            goto reattachdevs;
    }

641
    /* Step 4: For SRIOV network devices, Now that we have detached the
642 643 644
     * the network device, set the netdev config */
    for (i = 0; i < nhostdevs; i++) {
         virDomainHostdevDefPtr hostdev = hostdevs[i];
645
         if (!virHostdevIsPCINetDevice(hostdev))
646
             continue;
647
         if (virHostdevNetConfigReplace(hostdev, uuid,
648
                                        mgr->stateDir) < 0) {
649
             goto resetvfnetconfig;
650 651 652 653
         }
         last_processed_hostdev_vf = i;
    }

654
    /* Step 5: Move devices from the inactive list to the active list */
655
    for (i = 0; i < virPCIDeviceListCount(pcidevs); i++) {
656
        virPCIDevicePtr pci = virPCIDeviceListGet(pcidevs, i);
657
        virPCIDevicePtr actual;
658

659
        VIR_DEBUG("Removing PCI device %s from inactive list",
660
                  virPCIDeviceGetName(pci));
661
        actual = virPCIDeviceListSteal(mgr->inactivePCIHostdevs, pci);
662

663
        VIR_DEBUG("Adding PCI device %s to active list",
664
                  virPCIDeviceGetName(pci));
665 666
        if (!actual || virPCIDeviceListAdd(mgr->activePCIHostdevs, actual) < 0)
            goto inactivedevs;
667 668
    }

669
    /* Step 6: Set driver and domain information */
670
    for (i = 0; i < virPCIDeviceListCount(pcidevs); i++) {
671
        virPCIDevicePtr pci, actual;
672

A
Andrea Bolognani 已提交
673 674 675
        /* We need to look up the actual device and set the information
         * there because 'pci' only contain address information and will
         * be released at the end of the function */
676 677
        pci = virPCIDeviceListGet(pcidevs, i);
        actual = virPCIDeviceListFind(mgr->activePCIHostdevs, pci);
678

679
        VIR_DEBUG("Setting driver and domain information for PCI device %s",
680 681 682
                  virPCIDeviceGetName(pci));
        if (actual)
            virPCIDeviceSetUsedBy(actual, drv_name, dom_name);
683 684
    }

685
    /* Step 7: Now set the original states for hostdev def */
686
    for (i = 0; i < nhostdevs; i++) {
687
        virPCIDevicePtr actual;
688
        virDomainHostdevDefPtr hostdev = hostdevs[i];
689
        virDomainHostdevSubsysPCIPtr pcisrc = &hostdev->source.subsys.u.pci;
690 691 692 693 694 695

        if (hostdev->mode != VIR_DOMAIN_HOSTDEV_MODE_SUBSYS)
            continue;
        if (hostdev->source.subsys.type != VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_PCI)
            continue;

696 697 698 699 700 701 702 703
        /* We need to look up the actual device because it's the one
         * that contains the information we care about (unbind_from_stub,
         * remove_slot, reprobe) */
        actual = virPCIDeviceListFindByIDs(mgr->activePCIHostdevs,
                                           pcisrc->addr.domain,
                                           pcisrc->addr.bus,
                                           pcisrc->addr.slot,
                                           pcisrc->addr.function);
704

705 706 707
        /* Appropriate values for the unbind_from_stub, remove_slot
         * and reprobe properties of the device were set earlier
         * by virPCIDeviceDetach() */
708
        if (actual) {
709
            VIR_DEBUG("Saving network configuration of PCI device %s",
710
                      virPCIDeviceGetName(actual));
711
            hostdev->origstates.states.pci.unbind_from_stub =
712
                virPCIDeviceGetUnbindFromStub(actual);
713
            hostdev->origstates.states.pci.remove_slot =
714
                virPCIDeviceGetRemoveSlot(actual);
715
            hostdev->origstates.states.pci.reprobe =
716
                virPCIDeviceGetReprobe(actual);
717 718 719 720 721 722
        }
    }

    ret = 0;
    goto cleanup;

723
 inactivedevs:
724 725
    /* Move devices back to the inactive list so that they can be
     * processed properly below (reattachdevs label) */
726
    for (i = 0; i < virPCIDeviceListCount(pcidevs); i++) {
727
        virPCIDevicePtr pci = virPCIDeviceListGet(pcidevs, i);
728
        virPCIDevicePtr actual;
729 730

        VIR_DEBUG("Removing PCI device %s from active list",
731
                  virPCIDeviceGetName(pci));
732 733 734 735 736 737 738 739
        if (!(actual = virPCIDeviceListSteal(mgr->activePCIHostdevs, pci)))
            continue;

        VIR_DEBUG("Adding PCI device %s to inactive list",
                  virPCIDeviceGetName(pci));
        if (virPCIDeviceListAdd(mgr->inactivePCIHostdevs, actual) < 0)
            VIR_WARN("Failed to add PCI device %s to the inactive list",
                     virPCIDeviceGetName(pci));
740 741
    }

742
 resetvfnetconfig:
743 744
    if (last_processed_hostdev_vf >= 0) {
        for (i = 0; i <= last_processed_hostdev_vf; i++)
745
            virHostdevNetConfigRestore(hostdevs[i], mgr->stateDir, NULL);
746
    }
747

748
 reattachdevs:
749
    for (i = 0; i < virPCIDeviceListCount(pcidevs); i++) {
750
        virPCIDevicePtr pci = virPCIDeviceListGet(pcidevs, i);
751
        virPCIDevicePtr actual;
752

753 754 755 756 757 758
        /* We need to look up the actual device because that's what
         * virPCIDeviceReattach() exepects as its argument */
        if (!(actual = virPCIDeviceListFind(mgr->inactivePCIHostdevs, pci)))
            continue;

        if (virPCIDeviceGetManaged(actual)) {
759
            VIR_DEBUG("Reattaching managed PCI device %s",
760
                      virPCIDeviceGetName(pci));
761
            ignore_value(virPCIDeviceReattach(actual,
762 763
                                              mgr->activePCIHostdevs,
                                              mgr->inactivePCIHostdevs));
764 765
        } else {
            VIR_DEBUG("Not reattaching unmanaged PCI device %s",
766
                      virPCIDeviceGetName(pci));
767
        }
768 769
    }

770
 cleanup:
771
    virObjectUnref(pcidevs);
772 773
    virObjectUnlock(mgr->activePCIHostdevs);
    virObjectUnlock(mgr->inactivePCIHostdevs);
774

775 776 777 778
    return ret;
}

/*
779
 * Pre-condition: inactivePCIHostdevs & activePCIHostdevs
780 781 782
 * are locked
 */
static void
783
virHostdevReattachPCIDevice(virHostdevManagerPtr mgr,
784
                            virPCIDevicePtr actual)
785 786
{
    /* Wait for device cleanup if it is qemu/kvm */
787
    if (virPCIDeviceGetStubDriver(actual) == VIR_PCI_STUB_DRIVER_KVM) {
788
        int retries = 100;
789
        while (virPCIDeviceWaitForCleanup(actual, "kvm_assigned_device")
790 791 792 793 794 795
               && retries) {
            usleep(100*1000);
            retries--;
        }
    }

796 797
    VIR_DEBUG("Reattaching PCI device %s", virPCIDeviceGetName(actual));
    if (virPCIDeviceReattach(actual, mgr->activePCIHostdevs,
798
                             mgr->inactivePCIHostdevs) < 0) {
799
        VIR_ERROR(_("Failed to re-attach PCI device: %s"),
800 801
                  virGetLastErrorMessage());
        virResetLastError();
802 803 804 805 806 807 808
    }
}

/* @oldStateDir:
 * For upgrade purpose: see virHostdevNetConfigRestore
 */
void
809
virHostdevReAttachPCIDevices(virHostdevManagerPtr mgr,
810
                             const char *drv_name,
811
                             const char *dom_name,
812 813
                             virDomainHostdevDefPtr *hostdevs,
                             int nhostdevs,
814
                             const char *oldStateDir)
815 816 817 818
{
    virPCIDeviceListPtr pcidevs;
    size_t i;

819 820 821
    if (!nhostdevs)
        return;

822 823
    virObjectLock(mgr->activePCIHostdevs);
    virObjectLock(mgr->inactivePCIHostdevs);
824

825
    if (!(pcidevs = virHostdevGetPCIHostDeviceList(hostdevs, nhostdevs))) {
826
        VIR_ERROR(_("Failed to allocate PCI device list: %s"),
827 828
                  virGetLastErrorMessage());
        virResetLastError();
829 830 831
        goto cleanup;
    }

832 833
    /* Reattaching devices to the host involves several steps; each
     * of them is described at length below */
834

835 836
    /* Step 1: Filter out all devices that are either not active or not
     *         used by the current domain and driver */
837 838
    i = 0;
    while (i < virPCIDeviceListCount(pcidevs)) {
839 840 841
        virPCIDevicePtr pci = virPCIDeviceListGet(pcidevs, i);
        virPCIDevicePtr actual = NULL;

A
Andrea Bolognani 已提交
842 843 844 845
        /* We need to look up the actual device, which is the one containing
         * information such as by which domain and driver it is used. As a
         * side effect, by looking it up we can also tell whether it was
         * really active in the first place */
846 847 848 849 850 851 852 853 854
        actual = virPCIDeviceListFind(mgr->activePCIHostdevs, pci);
        if (actual) {
            const char *actual_drvname;
            const char *actual_domname;
            virPCIDeviceGetUsedBy(actual, &actual_drvname, &actual_domname);
            if (STRNEQ_NULLABLE(drv_name, actual_drvname) ||
                STRNEQ_NULLABLE(dom_name, actual_domname)) {

                virPCIDeviceListDel(pcidevs, pci);
A
Andrea Bolognani 已提交
855 856
                continue;
            }
857
        } else {
858
            virPCIDeviceListDel(pcidevs, pci);
859
            continue;
860 861
        }

862 863 864 865 866 867 868 869
        i++;
    }

    /* Step 2: Move devices from the active list to the inactive list */
    for (i = 0; i < virPCIDeviceListCount(pcidevs); i++) {
        virPCIDevicePtr pci = virPCIDeviceListGet(pcidevs, i);
        virPCIDevicePtr actual;

870
        VIR_DEBUG("Removing PCI device %s from active list",
871
                  virPCIDeviceGetName(pci));
872 873 874 875 876 877 878 879
        actual = virPCIDeviceListSteal(mgr->activePCIHostdevs, pci);

        VIR_DEBUG("Adding PCI device %s to inactive list",
                  virPCIDeviceGetName(pci));
        if (!actual ||
            virPCIDeviceListAdd(mgr->inactivePCIHostdevs, actual) < 0) {

            VIR_ERROR(_("Failed to add PCI device %s to the inactive list"),
880 881
                      virGetLastErrorMessage());
            virResetLastError();
882
        }
883 884
    }

885 886
    /* At this point, any device that had been used by the guest has been
     * moved to the inactive list */
887

888
    /* Step 3: restore original network config of hostdevs that used
889
     * <interface type='hostdev'>
890
     */
891 892 893 894 895
    for (i = 0; i < nhostdevs; i++) {
        virDomainHostdevDefPtr hostdev = hostdevs[i];

        if (virHostdevIsPCINetDevice(hostdev)) {
            virDomainHostdevSubsysPCIPtr pcisrc = &hostdev->source.subsys.u.pci;
896
            virPCIDevicePtr actual;
897

898 899 900 901 902
            actual = virPCIDeviceListFindByIDs(mgr->inactivePCIHostdevs,
                                               pcisrc->addr.domain,
                                               pcisrc->addr.bus,
                                               pcisrc->addr.slot,
                                               pcisrc->addr.function);
903

904
            if (actual) {
905
                VIR_DEBUG("Restoring network configuration of PCI device %s",
906
                          virPCIDeviceGetName(actual));
907
                virHostdevNetConfigRestore(hostdev, mgr->stateDir,
908
                                           oldStateDir);
909 910 911
            }
        }
    }
912

913
    /* Step 4: perform a PCI Reset on all devices */
914
    for (i = 0; i < virPCIDeviceListCount(pcidevs); i++) {
915
        virPCIDevicePtr pci = virPCIDeviceListGet(pcidevs, i);
916

A
Andrea Bolognani 已提交
917 918 919
        /* We can avoid looking up the actual device here, because performing
         * a PCI reset on a device doesn't require any information other than
         * the address, which 'pci' already contains */
920 921
        VIR_DEBUG("Resetting PCI device %s", virPCIDeviceGetName(pci));
        if (virPCIDeviceReset(pci, mgr->activePCIHostdevs,
922
                              mgr->inactivePCIHostdevs) < 0) {
923
            VIR_ERROR(_("Failed to reset PCI device: %s"),
924 925
                      virGetLastErrorMessage());
            virResetLastError();
926 927 928
        }
    }

929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944
    /* Step 5: Reattach managed devices to their host drivers; unmanaged
     *         devices don't need to be processed further */
    for (i = 0; i < virPCIDeviceListCount(pcidevs); i++) {
        virPCIDevicePtr pci = virPCIDeviceListGet(pcidevs, i);
        virPCIDevicePtr actual;

        /* We need to look up the actual device because that's what
         * virHostdevReattachPCIDevice() expects as its argument */
        if (!(actual = virPCIDeviceListFind(mgr->inactivePCIHostdevs, pci)))
            continue;

        if (virPCIDeviceGetManaged(actual))
            virHostdevReattachPCIDevice(mgr, actual);
        else
            VIR_DEBUG("Not reattaching unmanaged PCI device %s",
                      virPCIDeviceGetName(actual));
945 946
    }

947
 cleanup:
948
    virObjectUnref(pcidevs);
949 950
    virObjectUnlock(mgr->activePCIHostdevs);
    virObjectUnlock(mgr->inactivePCIHostdevs);
951
}
952 953

int
954
virHostdevUpdateActivePCIDevices(virHostdevManagerPtr mgr,
955 956
                                 virDomainHostdevDefPtr *hostdevs,
                                 int nhostdevs,
957
                                 const char *drv_name,
958
                                 const char *dom_name)
959 960
{
    virDomainHostdevDefPtr hostdev = NULL;
961
    virPCIDevicePtr actual = NULL;
962 963 964
    size_t i;
    int ret = -1;

965 966 967
    if (!nhostdevs)
        return 0;

968 969
    virObjectLock(mgr->activePCIHostdevs);
    virObjectLock(mgr->inactivePCIHostdevs);
970

971
    for (i = 0; i < nhostdevs; i++) {
972
        virDomainHostdevSubsysPCIPtr pcisrc;
973
        hostdev = hostdevs[i];
974
        pcisrc = &hostdev->source.subsys.u.pci;
975 976 977 978 979 980

        if (hostdev->mode != VIR_DOMAIN_HOSTDEV_MODE_SUBSYS)
            continue;
        if (hostdev->source.subsys.type != VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_PCI)
            continue;

981 982
        actual = virPCIDeviceNew(pcisrc->addr.domain, pcisrc->addr.bus,
                                 pcisrc->addr.slot, pcisrc->addr.function);
983

984
        if (!actual)
985 986
            goto cleanup;

987 988
        virPCIDeviceSetManaged(actual, hostdev->managed);
        virPCIDeviceSetUsedBy(actual, drv_name, dom_name);
989

990
        if (pcisrc->backend == VIR_DOMAIN_HOSTDEV_PCI_BACKEND_VFIO)
991
            virPCIDeviceSetStubDriver(actual, VIR_PCI_STUB_DRIVER_VFIO);
992
        else if (pcisrc->backend == VIR_DOMAIN_HOSTDEV_PCI_BACKEND_XEN)
993
            virPCIDeviceSetStubDriver(actual, VIR_PCI_STUB_DRIVER_XEN);
994
        else
995
            virPCIDeviceSetStubDriver(actual, VIR_PCI_STUB_DRIVER_KVM);
996

997
        /* Setup the original states for the PCI device */
998 999 1000
        virPCIDeviceSetUnbindFromStub(actual, hostdev->origstates.states.pci.unbind_from_stub);
        virPCIDeviceSetRemoveSlot(actual, hostdev->origstates.states.pci.remove_slot);
        virPCIDeviceSetReprobe(actual, hostdev->origstates.states.pci.reprobe);
1001

1002
        if (virPCIDeviceListAdd(mgr->activePCIHostdevs, actual) < 0)
1003
            goto cleanup;
1004
        actual = NULL;
1005 1006 1007
    }

    ret = 0;
1008
 cleanup:
1009
    virPCIDeviceFree(actual);
1010 1011
    virObjectUnlock(mgr->activePCIHostdevs);
    virObjectUnlock(mgr->inactivePCIHostdevs);
1012 1013 1014 1015
    return ret;
}

int
1016
virHostdevUpdateActiveUSBDevices(virHostdevManagerPtr mgr,
1017 1018
                                 virDomainHostdevDefPtr *hostdevs,
                                 int nhostdevs,
1019
                                 const char *drv_name,
1020
                                 const char *dom_name)
1021 1022 1023 1024 1025
{
    virDomainHostdevDefPtr hostdev = NULL;
    size_t i;
    int ret = -1;

1026 1027 1028
    if (!nhostdevs)
        return 0;

1029
    virObjectLock(mgr->activeUSBHostdevs);
1030
    for (i = 0; i < nhostdevs; i++) {
1031
        virDomainHostdevSubsysUSBPtr usbsrc;
1032
        virUSBDevicePtr usb = NULL;
1033
        hostdev = hostdevs[i];
1034
        usbsrc = &hostdev->source.subsys.u.usb;
1035 1036 1037 1038 1039 1040

        if (hostdev->mode != VIR_DOMAIN_HOSTDEV_MODE_SUBSYS)
            continue;
        if (hostdev->source.subsys.type != VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_USB)
            continue;

1041
        if (!(usb = virUSBDeviceNew(usbsrc->bus, usbsrc->device, NULL))) {
1042
            VIR_WARN("Unable to reattach USB device %03d.%03d on domain %s",
1043
                     usbsrc->bus, usbsrc->device, dom_name);
1044 1045 1046
            continue;
        }

1047
        virUSBDeviceSetUsedBy(usb, drv_name, dom_name);
1048

1049
        if (virUSBDeviceListAdd(mgr->activeUSBHostdevs, usb) < 0) {
1050 1051 1052 1053 1054
            virUSBDeviceFree(usb);
            goto cleanup;
        }
    }
    ret = 0;
1055
 cleanup:
1056
    virObjectUnlock(mgr->activeUSBHostdevs);
1057 1058 1059
    return ret;
}

1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091 1092 1093 1094 1095 1096
static int
virHostdevUpdateActiveSCSIHostDevices(virHostdevManagerPtr mgr,
                                      virDomainHostdevDefPtr hostdev,
                                      virDomainHostdevSubsysSCSIPtr scsisrc,
                                      const char *drv_name,
                                      const char *dom_name)
{
    virDomainHostdevSubsysSCSIHostPtr scsihostsrc = &scsisrc->u.host;
    virSCSIDevicePtr scsi = NULL;
    virSCSIDevicePtr tmp = NULL;
    int ret = -1;

    if (!(scsi = virSCSIDeviceNew(NULL,
                                  scsihostsrc->adapter, scsihostsrc->bus,
                                  scsihostsrc->target, scsihostsrc->unit,
                                  hostdev->readonly, hostdev->shareable)))
        goto cleanup;

    if ((tmp = virSCSIDeviceListFind(mgr->activeSCSIHostdevs, scsi))) {
        if (virSCSIDeviceSetUsedBy(tmp, drv_name, dom_name) < 0) {
            virSCSIDeviceFree(scsi);
            goto cleanup;
        }
        virSCSIDeviceFree(scsi);
    } else {
        if (virSCSIDeviceSetUsedBy(scsi, drv_name, dom_name) < 0 ||
            virSCSIDeviceListAdd(mgr->activeSCSIHostdevs, scsi) < 0) {
            virSCSIDeviceFree(scsi);
            goto cleanup;
        }
    }
    ret = 0;

 cleanup:
    return ret;
}

1097
int
1098
virHostdevUpdateActiveSCSIDevices(virHostdevManagerPtr mgr,
1099 1100
                                  virDomainHostdevDefPtr *hostdevs,
                                  int nhostdevs,
1101
                                  const char *drv_name,
1102
                                  const char *dom_name)
1103 1104 1105 1106 1107
{
    virDomainHostdevDefPtr hostdev = NULL;
    size_t i;
    int ret = -1;

1108 1109 1110
    if (!nhostdevs)
        return 0;

1111
    virObjectLock(mgr->activeSCSIHostdevs);
1112
    for (i = 0; i < nhostdevs; i++) {
1113
        virDomainHostdevSubsysSCSIPtr scsisrc;
1114
        hostdev = hostdevs[i];
1115
        scsisrc = &hostdev->source.subsys.u.scsi;
1116

1117
        if (!virHostdevIsSCSIDevice(hostdev))
1118 1119
            continue;

1120 1121
        if (scsisrc->protocol == VIR_DOMAIN_HOSTDEV_SCSI_PROTOCOL_TYPE_ISCSI) {
            continue;  /* Not supported for iSCSI */
1122
        } else {
1123 1124
            if (virHostdevUpdateActiveSCSIHostDevices(mgr, hostdev, scsisrc,
                                                      drv_name, dom_name) < 0)
1125 1126 1127 1128 1129
                goto cleanup;
        }
    }
    ret = 0;

1130
 cleanup:
1131
    virObjectUnlock(mgr->activeSCSIHostdevs);
1132 1133
    return ret;
}
1134 1135

static int
1136 1137 1138 1139
virHostdevMarkUSBDevices(virHostdevManagerPtr mgr,
                         const char *drv_name,
                         const char *dom_name,
                         virUSBDeviceListPtr list)
1140 1141 1142 1143 1144
{
    size_t i, j;
    unsigned int count;
    virUSBDevicePtr tmp;

1145
    virObjectLock(mgr->activeUSBHostdevs);
1146 1147 1148 1149
    count = virUSBDeviceListCount(list);

    for (i = 0; i < count; i++) {
        virUSBDevicePtr usb = virUSBDeviceListGet(list, i);
1150
        if ((tmp = virUSBDeviceListFind(mgr->activeUSBHostdevs, usb))) {
1151 1152 1153 1154 1155 1156 1157 1158 1159 1160 1161 1162 1163 1164 1165 1166 1167
            const char *other_drvname;
            const char *other_domname;

            virUSBDeviceGetUsedBy(tmp, &other_drvname, &other_domname);
            if (other_drvname && other_domname)
                virReportError(VIR_ERR_OPERATION_INVALID,
                               _("USB device %s is in use by "
                                 "driver %s, domain %s"),
                               virUSBDeviceGetName(tmp),
                               other_drvname, other_domname);
            else
                virReportError(VIR_ERR_OPERATION_INVALID,
                               _("USB device %s is already in use"),
                               virUSBDeviceGetName(tmp));
            goto error;
        }

1168
        virUSBDeviceSetUsedBy(usb, drv_name, dom_name);
1169
        VIR_DEBUG("Adding %03d.%03d dom=%s to activeUSBHostdevs",
1170 1171
                  virUSBDeviceGetBus(usb), virUSBDeviceGetDevno(usb),
                  dom_name);
1172 1173 1174 1175 1176
        /*
         * The caller is responsible to steal these usb devices
         * from the virUSBDeviceList that passed in on success,
         * perform rollback on failure.
         */
1177
        if (virUSBDeviceListAdd(mgr->activeUSBHostdevs, usb) < 0)
1178 1179 1180
            goto error;
    }

1181
    virObjectUnlock(mgr->activeUSBHostdevs);
1182 1183
    return 0;

1184
 error:
1185 1186
    for (j = 0; j < i; j++) {
        tmp = virUSBDeviceListGet(list, i);
1187
        virUSBDeviceListSteal(mgr->activeUSBHostdevs, tmp);
1188
    }
1189
    virObjectUnlock(mgr->activeUSBHostdevs);
1190 1191 1192 1193
    return -1;
}


1194
int
1195 1196 1197 1198
virHostdevFindUSBDevice(virDomainHostdevDefPtr hostdev,
                        bool mandatory,
                        virUSBDevicePtr *usb)
{
1199 1200 1201 1202 1203 1204
    virDomainHostdevSubsysUSBPtr usbsrc = &hostdev->source.subsys.u.usb;
    unsigned vendor = usbsrc->vendor;
    unsigned product = usbsrc->product;
    unsigned bus = usbsrc->bus;
    unsigned device = usbsrc->device;
    bool autoAddress = usbsrc->autoAddress;
1205 1206 1207 1208 1209 1210 1211 1212 1213 1214 1215 1216 1217 1218 1219 1220 1221 1222 1223 1224 1225 1226 1227 1228 1229 1230 1231 1232 1233 1234 1235 1236 1237 1238 1239 1240 1241 1242 1243 1244 1245 1246 1247 1248 1249 1250 1251 1252 1253 1254 1255 1256 1257 1258
    int rc;

    *usb = NULL;

    if (vendor && bus) {
        rc = virUSBDeviceFind(vendor, product, bus, device,
                              NULL,
                              autoAddress ? false : mandatory,
                              usb);
        if (rc < 0) {
            return -1;
        } else if (!autoAddress) {
            goto out;
        } else {
            VIR_INFO("USB device %x:%x could not be found at previous"
                     " address (bus:%u device:%u)",
                     vendor, product, bus, device);
        }
    }

    /* When vendor is specified, its USB address is either unspecified or the
     * device could not be found at the USB device where it had been
     * automatically found before.
     */
    if (vendor) {
        virUSBDeviceListPtr devs;

        rc = virUSBDeviceFindByVendor(vendor, product, NULL, mandatory, &devs);
        if (rc < 0)
            return -1;

        if (rc == 1) {
            *usb = virUSBDeviceListGet(devs, 0);
            virUSBDeviceListSteal(devs, *usb);
        }
        virObjectUnref(devs);

        if (rc == 0) {
            goto out;
        } else if (rc > 1) {
            if (autoAddress) {
                virReportError(VIR_ERR_OPERATION_FAILED,
                               _("Multiple USB devices for %x:%x were found,"
                                 " but none of them is at bus:%u device:%u"),
                               vendor, product, bus, device);
            } else {
                virReportError(VIR_ERR_OPERATION_FAILED,
                               _("Multiple USB devices for %x:%x, "
                                 "use <address> to specify one"),
                               vendor, product);
            }
            return -1;
        }

1259 1260 1261
        usbsrc->bus = virUSBDeviceGetBus(*usb);
        usbsrc->device = virUSBDeviceGetDevno(*usb);
        usbsrc->autoAddress = true;
1262 1263 1264 1265 1266

        if (autoAddress) {
            VIR_INFO("USB device %x:%x found at bus:%u device:%u (moved"
                     " from bus:%u device:%u)",
                     vendor, product,
1267
                     usbsrc->bus, usbsrc->device,
1268 1269 1270 1271 1272 1273 1274
                     bus, device);
        }
    } else if (!vendor && bus) {
        if (virUSBDeviceFindByBus(bus, device, NULL, mandatory, usb) < 0)
            return -1;
    }

1275
 out:
1276 1277 1278 1279 1280 1281
    if (!*usb)
        hostdev->missing = true;
    return 0;
}

int
1282
virHostdevPrepareUSBDevices(virHostdevManagerPtr mgr,
1283
                            const char *drv_name,
1284
                            const char *dom_name,
1285 1286 1287 1288 1289 1290 1291 1292 1293 1294
                            virDomainHostdevDefPtr *hostdevs,
                            int nhostdevs,
                            unsigned int flags)
{
    size_t i;
    int ret = -1;
    virUSBDeviceListPtr list;
    virUSBDevicePtr tmp;
    bool coldBoot = !!(flags & VIR_HOSTDEV_COLD_BOOT);

1295 1296 1297
    if (!nhostdevs)
        return 0;

1298 1299 1300 1301 1302 1303 1304 1305 1306 1307 1308 1309 1310 1311 1312 1313 1314 1315 1316 1317 1318 1319 1320 1321 1322 1323 1324 1325 1326 1327 1328 1329 1330 1331
    /* To prevent situation where USB device is assigned to two domains
     * we need to keep a list of currently assigned USB devices.
     * This is done in several loops which cannot be joined into one big
     * loop. See virHostdevPreparePCIDevices()
     */
    if (!(list = virUSBDeviceListNew()))
        goto cleanup;

    /* Loop 1: build temporary list
     */
    for (i = 0; i < nhostdevs; i++) {
        virDomainHostdevDefPtr hostdev = hostdevs[i];
        bool required = true;
        virUSBDevicePtr usb;

        if (hostdev->mode != VIR_DOMAIN_HOSTDEV_MODE_SUBSYS)
            continue;
        if (hostdev->source.subsys.type != VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_USB)
            continue;

        if (hostdev->startupPolicy == VIR_DOMAIN_STARTUP_POLICY_OPTIONAL ||
            (hostdev->startupPolicy == VIR_DOMAIN_STARTUP_POLICY_REQUISITE &&
             !coldBoot))
            required = false;

        if (virHostdevFindUSBDevice(hostdev, required, &usb) < 0)
            goto cleanup;

        if (usb && virUSBDeviceListAdd(list, usb) < 0) {
            virUSBDeviceFree(usb);
            goto cleanup;
        }
    }

1332
    /* Mark devices in temporary list as used by @dom_name
1333 1334 1335
     * and add them do driver list. However, if something goes
     * wrong, perform rollback.
     */
1336
    if (virHostdevMarkUSBDevices(mgr, drv_name, dom_name, list) < 0)
1337 1338 1339 1340 1341 1342 1343 1344 1345 1346 1347 1348 1349
        goto cleanup;

    /* Loop 2: Temporary list was successfully merged with
     * driver list, so steal all items to avoid freeing them
     * in cleanup label.
     */
    while (virUSBDeviceListCount(list) > 0) {
        tmp = virUSBDeviceListGet(list, 0);
        virUSBDeviceListSteal(list, tmp);
    }

    ret = 0;

1350
 cleanup:
1351 1352 1353
    virObjectUnref(list);
    return ret;
}
1354

1355 1356 1357 1358 1359 1360 1361 1362 1363 1364 1365 1366 1367 1368 1369 1370 1371 1372 1373 1374 1375 1376 1377 1378 1379 1380 1381 1382 1383 1384 1385 1386
static int
virHostdevPrepareSCSIHostDevices(virDomainHostdevDefPtr hostdev,
                                 virDomainHostdevSubsysSCSIPtr scsisrc,
                                 virSCSIDeviceListPtr list)
{
    virDomainHostdevSubsysSCSIHostPtr scsihostsrc = &scsisrc->u.host;
    virSCSIDevicePtr scsi;
    int ret = -1;

    if (hostdev->managed) {
        virReportError(VIR_ERR_XML_ERROR, "%s",
                       _("SCSI host device doesn't support managed mode"));
        goto cleanup;
    }

    if (!(scsi = virSCSIDeviceNew(NULL,
                                  scsihostsrc->adapter, scsihostsrc->bus,
                                  scsihostsrc->target, scsihostsrc->unit,
                                  hostdev->readonly, hostdev->shareable)))
        goto cleanup;

    if (virSCSIDeviceListAdd(list, scsi) < 0) {
        virSCSIDeviceFree(scsi);
        goto cleanup;
    }

    ret = 0;

 cleanup:
    return ret;
}

1387
int
1388
virHostdevPrepareSCSIDevices(virHostdevManagerPtr mgr,
1389
                             const char *drv_name,
1390
                             const char *dom_name,
1391 1392 1393 1394 1395 1396 1397 1398
                             virDomainHostdevDefPtr *hostdevs,
                             int nhostdevs)
{
    size_t i, j;
    int count;
    virSCSIDeviceListPtr list;
    virSCSIDevicePtr tmp;

1399 1400 1401
    if (!nhostdevs)
        return 0;

1402 1403 1404 1405 1406 1407 1408 1409 1410 1411 1412
    /* To prevent situation where SCSI device is assigned to two domains
     * we need to keep a list of currently assigned SCSI devices.
     * This is done in several loops which cannot be joined into one big
     * loop. See virHostdevPreparePCIDevices()
     */
    if (!(list = virSCSIDeviceListNew()))
        goto cleanup;

    /* Loop 1: build temporary list */
    for (i = 0; i < nhostdevs; i++) {
        virDomainHostdevDefPtr hostdev = hostdevs[i];
1413
        virDomainHostdevSubsysSCSIPtr scsisrc = &hostdev->source.subsys.u.scsi;
1414

1415
        if (!virHostdevIsSCSIDevice(hostdev))
1416 1417
            continue;

1418 1419 1420 1421 1422
        if (scsisrc->protocol == VIR_DOMAIN_HOSTDEV_SCSI_PROTOCOL_TYPE_ISCSI) {
            continue;  /* Not supported for iSCSI */
        } else {
            if (virHostdevPrepareSCSIHostDevices(hostdev, scsisrc, list) < 0)
                goto cleanup;
1423 1424 1425 1426 1427 1428 1429
        }
    }

    /* Loop 2: Mark devices in temporary list as used by @name
     * and add them to driver list. However, if something goes
     * wrong, perform rollback.
     */
1430
    virObjectLock(mgr->activeSCSIHostdevs);
1431 1432 1433 1434
    count = virSCSIDeviceListCount(list);

    for (i = 0; i < count; i++) {
        virSCSIDevicePtr scsi = virSCSIDeviceListGet(list, i);
1435
        if ((tmp = virSCSIDeviceListFind(mgr->activeSCSIHostdevs,
1436 1437 1438 1439 1440 1441 1442 1443 1444 1445 1446 1447 1448
                                         scsi))) {
            bool scsi_shareable = virSCSIDeviceGetShareable(scsi);
            bool tmp_shareable = virSCSIDeviceGetShareable(tmp);

            if (!(scsi_shareable && tmp_shareable)) {
                virReportError(VIR_ERR_OPERATION_INVALID,
                               _("SCSI device %s is already in use by "
                                 "other domain(s) as '%s'"),
                               virSCSIDeviceGetName(tmp),
                               tmp_shareable ? "shareable" : "non-shareable");
                goto error;
            }

1449
            if (virSCSIDeviceSetUsedBy(tmp, drv_name, dom_name) < 0)
1450 1451
                goto error;
        } else {
1452
            if (virSCSIDeviceSetUsedBy(scsi, drv_name, dom_name) < 0)
1453 1454
                goto error;

1455
            VIR_DEBUG("Adding %s to activeSCSIHostdevs", virSCSIDeviceGetName(scsi));
1456

1457
            if (virSCSIDeviceListAdd(mgr->activeSCSIHostdevs, scsi) < 0)
1458 1459 1460 1461
                goto error;
        }
    }

1462
    virObjectUnlock(mgr->activeSCSIHostdevs);
1463 1464 1465 1466 1467 1468 1469 1470 1471 1472 1473 1474 1475

    /* Loop 3: Temporary list was successfully merged with
     * driver list, so steal all items to avoid freeing them
     * when freeing temporary list.
     */
    while (virSCSIDeviceListCount(list) > 0) {
        tmp = virSCSIDeviceListGet(list, 0);
        virSCSIDeviceListSteal(list, tmp);
    }

    virObjectUnref(list);
    return 0;

1476
 error:
1477 1478
    for (j = 0; j < i; j++) {
        tmp = virSCSIDeviceListGet(list, i);
1479
        virSCSIDeviceListSteal(mgr->activeSCSIHostdevs, tmp);
1480
    }
1481
    virObjectUnlock(mgr->activeSCSIHostdevs);
1482
 cleanup:
1483 1484 1485
    virObjectUnref(list);
    return -1;
}
1486 1487

void
1488
virHostdevReAttachUSBDevices(virHostdevManagerPtr mgr,
1489 1490 1491 1492
                             const char *drv_name,
                             const char *dom_name,
                             virDomainHostdevDefPtr *hostdevs,
                             int nhostdevs)
1493 1494 1495
{
    size_t i;

1496 1497 1498
    if (!nhostdevs)
        return;

1499
    virObjectLock(mgr->activeUSBHostdevs);
1500 1501
    for (i = 0; i < nhostdevs; i++) {
        virDomainHostdevDefPtr hostdev = hostdevs[i];
1502
        virDomainHostdevSubsysUSBPtr usbsrc = &hostdev->source.subsys.u.usb;
1503 1504 1505 1506 1507 1508 1509 1510 1511 1512 1513
        virUSBDevicePtr usb, tmp;
        const char *usedby_drvname;
        const char *usedby_domname;

        if (hostdev->mode != VIR_DOMAIN_HOSTDEV_MODE_SUBSYS)
            continue;
        if (hostdev->source.subsys.type != VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_USB)
            continue;
        if (hostdev->missing)
            continue;

1514
        if (!(usb = virUSBDeviceNew(usbsrc->bus, usbsrc->device, NULL))) {
1515
            VIR_WARN("Unable to reattach USB device %03d.%03d on domain %s",
1516
                     usbsrc->bus, usbsrc->device, dom_name);
1517 1518 1519 1520 1521 1522 1523 1524 1525
            continue;
        }

        /* Delete only those USB devices which belongs
         * to domain @name because qemuProcessStart() might
         * have failed because USB device is already taken.
         * Therefore we want to steal only those devices from
         * the list which were taken by @name */

1526
        tmp = virUSBDeviceListFind(mgr->activeUSBHostdevs, usb);
1527 1528 1529 1530 1531
        virUSBDeviceFree(usb);

        if (!tmp) {
            VIR_WARN("Unable to find device %03d.%03d "
                     "in list of active USB devices",
1532
                     usbsrc->bus, usbsrc->device);
1533 1534 1535 1536 1537
            continue;
        }

        virUSBDeviceGetUsedBy(tmp, &usedby_drvname, &usedby_domname);
        if (STREQ_NULLABLE(drv_name, usedby_drvname) &&
1538
            STREQ_NULLABLE(dom_name, usedby_domname)) {
1539
            VIR_DEBUG("Removing %03d.%03d dom=%s from activeUSBHostdevs",
1540
                      usbsrc->bus, usbsrc->device, dom_name);
1541
            virUSBDeviceListDel(mgr->activeUSBHostdevs, tmp);
1542 1543
        }
    }
1544
    virObjectUnlock(mgr->activeUSBHostdevs);
1545
}
1546

1547
static void
1548
virHostdevReAttachSCSIHostDevices(virHostdevManagerPtr mgr,
1549 1550 1551 1552 1553 1554 1555 1556 1557 1558 1559 1560 1561
                                  virDomainHostdevDefPtr hostdev,
                                  virDomainHostdevSubsysSCSIPtr scsisrc,
                                  const char *drv_name,
                                  const char *dom_name)
{
    virDomainHostdevSubsysSCSIHostPtr scsihostsrc = &scsisrc->u.host;
    virSCSIDevicePtr scsi;
    virSCSIDevicePtr tmp;

    if (!(scsi = virSCSIDeviceNew(NULL,
                                  scsihostsrc->adapter, scsihostsrc->bus,
                                  scsihostsrc->target, scsihostsrc->unit,
                                  hostdev->readonly, hostdev->shareable))) {
1562
        VIR_WARN("Unable to reattach SCSI device %s:%u:%u:%llu on domain %s",
1563 1564 1565 1566 1567 1568 1569 1570
                 scsihostsrc->adapter, scsihostsrc->bus, scsihostsrc->target,
                 scsihostsrc->unit, dom_name);
        return;
    }

    /* Only delete the devices which are marked as being used by @name,
     * because qemuProcessStart could fail half way through. */

1571
    if (!(tmp = virSCSIDeviceListFind(mgr->activeSCSIHostdevs, scsi))) {
1572
        VIR_WARN("Unable to find device %s:%u:%u:%llu "
1573 1574 1575 1576 1577 1578 1579
                 "in list of active SCSI devices",
                 scsihostsrc->adapter, scsihostsrc->bus,
                 scsihostsrc->target, scsihostsrc->unit);
        virSCSIDeviceFree(scsi);
        return;
    }

1580
    VIR_DEBUG("Removing %s:%u:%u:%llu dom=%s from activeSCSIHostdevs",
1581 1582 1583
               scsihostsrc->adapter, scsihostsrc->bus, scsihostsrc->target,
               scsihostsrc->unit, dom_name);

1584
    virSCSIDeviceListDel(mgr->activeSCSIHostdevs, tmp,
1585 1586 1587 1588
                         drv_name, dom_name);
    virSCSIDeviceFree(scsi);
}

1589
void
1590
virHostdevReAttachSCSIDevices(virHostdevManagerPtr mgr,
1591 1592 1593 1594
                              const char *drv_name,
                              const char *dom_name,
                              virDomainHostdevDefPtr *hostdevs,
                              int nhostdevs)
1595 1596 1597
{
    size_t i;

1598 1599 1600
    if (!nhostdevs)
        return;

1601
    virObjectLock(mgr->activeSCSIHostdevs);
1602 1603
    for (i = 0; i < nhostdevs; i++) {
        virDomainHostdevDefPtr hostdev = hostdevs[i];
1604
        virDomainHostdevSubsysSCSIPtr scsisrc = &hostdev->source.subsys.u.scsi;
1605

1606
        if (!virHostdevIsSCSIDevice(hostdev))
1607 1608
            continue;

1609 1610 1611
        if (scsisrc->protocol == VIR_DOMAIN_HOSTDEV_SCSI_PROTOCOL_TYPE_ISCSI)
            continue; /* Not supported for iSCSI */
        else
1612
            virHostdevReAttachSCSIHostDevices(mgr, hostdev, scsisrc,
1613
                                              drv_name, dom_name);
1614
    }
1615
    virObjectUnlock(mgr->activeSCSIHostdevs);
1616
}
1617 1618

int
1619
virHostdevPCINodeDeviceDetach(virHostdevManagerPtr mgr,
1620 1621
                              virPCIDevicePtr pci)
{
1622
    struct virHostdevIsPCINodeDeviceUsedData data = { mgr, NULL, false };
1623 1624
    int ret = -1;

1625 1626
    virObjectLock(mgr->activePCIHostdevs);
    virObjectLock(mgr->inactivePCIHostdevs);
1627

1628
    if (virHostdevIsPCINodeDeviceUsed(virPCIDeviceGetAddress(pci), &data))
1629
        goto cleanup;
1630

1631 1632
    if (virPCIDeviceDetach(pci, mgr->activePCIHostdevs,
                           mgr->inactivePCIHostdevs) < 0)
1633
        goto cleanup;
1634 1635

    ret = 0;
1636 1637

 cleanup:
1638 1639
    virObjectUnlock(mgr->inactivePCIHostdevs);
    virObjectUnlock(mgr->activePCIHostdevs);
1640

1641 1642 1643 1644
    return ret;
}

int
1645
virHostdevPCINodeDeviceReAttach(virHostdevManagerPtr mgr,
1646 1647
                                virPCIDevicePtr pci)
{
1648
    struct virHostdevIsPCINodeDeviceUsedData data = { mgr, NULL, false };
1649 1650
    int ret = -1;

1651 1652
    virObjectLock(mgr->activePCIHostdevs);
    virObjectLock(mgr->inactivePCIHostdevs);
1653

1654
    if (virHostdevIsPCINodeDeviceUsed(virPCIDeviceGetAddress(pci), &data))
1655
        goto cleanup;
1656

1657 1658 1659
    virPCIDeviceSetUnbindFromStub(pci, true);
    virPCIDeviceSetRemoveSlot(pci, true);
    virPCIDeviceSetReprobe(pci, true);
1660

1661
    if (virPCIDeviceReattach(pci, mgr->activePCIHostdevs,
1662
                             mgr->inactivePCIHostdevs) < 0)
1663
        goto cleanup;
1664 1665

    ret = 0;
1666 1667

 cleanup:
1668 1669
    virObjectUnlock(mgr->inactivePCIHostdevs);
    virObjectUnlock(mgr->activePCIHostdevs);
1670

1671 1672 1673 1674
    return ret;
}

int
1675
virHostdevPCINodeDeviceReset(virHostdevManagerPtr mgr,
1676 1677 1678 1679
                             virPCIDevicePtr pci)
{
    int ret = -1;

1680 1681 1682 1683
    virObjectLock(mgr->activePCIHostdevs);
    virObjectLock(mgr->inactivePCIHostdevs);
    if (virPCIDeviceReset(pci, mgr->activePCIHostdevs,
                          mgr->inactivePCIHostdevs) < 0)
1684 1685 1686
        goto out;

    ret = 0;
1687
 out:
1688 1689
    virObjectUnlock(mgr->inactivePCIHostdevs);
    virObjectUnlock(mgr->activePCIHostdevs);
1690 1691
    return ret;
}
1692 1693 1694 1695 1696 1697 1698 1699 1700 1701 1702 1703 1704 1705 1706 1707 1708 1709 1710 1711 1712 1713 1714 1715 1716 1717 1718 1719 1720 1721 1722 1723 1724 1725 1726 1727 1728 1729 1730

int
virHostdevPrepareDomainDevices(virHostdevManagerPtr mgr,
                               const char *driver,
                               virDomainDefPtr def,
                               unsigned int flags)
{
    if (!def->nhostdevs)
        return 0;

    if (mgr == NULL)
        return -1;

    if (flags & VIR_HOSTDEV_SP_PCI) {
        if (virHostdevPreparePCIDevices(mgr, driver,
                                        def->name, def->uuid,
                                        def->hostdevs,
                                        def->nhostdevs,
                                        flags) < 0)
            return -1;
    }

    if (flags & VIR_HOSTDEV_SP_USB) {
        if (virHostdevPrepareUSBDevices(mgr, driver, def->name,
                                         def->hostdevs, def->nhostdevs,
                                         flags) < 0)
            return -1;
    }

    if (flags & VIR_HOSTDEV_SP_SCSI) {
        if (virHostdevPrepareSCSIDevices(mgr, driver, def->name,
                                         def->hostdevs, def->nhostdevs) < 0)
        return -1;
    }

    return 0;
}

/* @oldStateDir
1731
 * For upgrade purpose: see virHostdevReAttachPCIHostdevs
1732 1733 1734 1735 1736 1737 1738 1739 1740 1741 1742 1743 1744 1745 1746 1747 1748 1749 1750 1751 1752 1753 1754 1755 1756 1757 1758 1759 1760
 */
void
virHostdevReAttachDomainDevices(virHostdevManagerPtr mgr,
                                const char *driver,
                                virDomainDefPtr def,
                                unsigned int flags,
                                const char *oldStateDir)
{
    if (!def->nhostdevs || !mgr)
        return;

    if (flags & VIR_HOSTDEV_SP_PCI) {
        virHostdevReAttachPCIDevices(mgr, driver, def->name,
                                     def->hostdevs, def->nhostdevs,
                                     oldStateDir);
    }

    if (flags & VIR_HOSTDEV_SP_USB) {
        virHostdevReAttachUSBDevices(mgr, driver, def->name,
                                     def->hostdevs, def->nhostdevs);
    }

    if (flags & VIR_HOSTDEV_SP_SCSI) {
        virHostdevReAttachSCSIDevices(mgr, driver, def->name,
                                      def->hostdevs, def->nhostdevs);
    }
}

int
1761
virHostdevUpdateActiveDomainDevices(virHostdevManagerPtr mgr,
1762 1763 1764 1765 1766 1767 1768 1769 1770 1771 1772 1773 1774 1775 1776 1777 1778 1779 1780 1781 1782 1783 1784 1785 1786 1787 1788 1789 1790 1791 1792 1793 1794
                                    const char *driver,
                                    virDomainDefPtr def,
                                    unsigned int flags)
{
    if (!def->nhostdevs)
        return 0;

    if (flags & VIR_HOSTDEV_SP_PCI) {
        if (virHostdevUpdateActivePCIDevices(mgr,
                                             def->hostdevs,
                                             def->nhostdevs,
                                             driver, def->name) < 0)
            return -1;
    }

    if (flags & VIR_HOSTDEV_SP_USB) {
        if (virHostdevUpdateActiveUSBDevices(mgr,
                                             def->hostdevs,
                                             def->nhostdevs,
                                             driver, def->name) < 0)
            return -1;
    }

    if (flags & VIR_HOSTDEV_SP_SCSI) {
        if (virHostdevUpdateActiveSCSIDevices(mgr,
                                              def->hostdevs,
                                              def->nhostdevs,
                                              driver, def->name) < 0)
            return -1;
    }

    return 0;
}