qemuhotplugtest.c 17.1 KB
Newer Older
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23
/*
 * Copyright (C) 2011-2013 Red Hat, Inc.
 *
 * This library is free software; you can redistribute it and/or
 * modify it under the terms of the GNU Lesser General Public
 * License as published by the Free Software Foundation; either
 * version 2.1 of the License, or (at your option) any later version.
 *
 * This library is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
 * Lesser General Public License for more details.
 *
 * You should have received a copy of the GNU Lesser General Public
 * License along with this library.  If not, see
 * <http://www.gnu.org/licenses/>.
 *
 */

#include <config.h>

#include "qemu/qemu_conf.h"
#include "qemu/qemu_hotplug.h"
24
#include "qemu/qemu_hotplugpriv.h"
25 26 27 28 29 30 31 32 33 34 35 36
#include "qemumonitortestutils.h"
#include "testutils.h"
#include "testutilsqemu.h"
#include "virerror.h"
#include "virstring.h"
#include "virthread.h"
#include "virfile.h"

#define VIR_FROM_THIS VIR_FROM_NONE

static virQEMUDriver driver;

37 38 39 40 41 42
enum {
    ATTACH,
    DETACH,
    UPDATE
};

43 44
#define QEMU_HOTPLUG_TEST_DOMAIN_ID 7

45 46 47 48 49
struct qemuHotplugTestData {
    const char *domain_filename;
    const char *device_filename;
    bool fail;
    const char *const *mon;
50 51 52
    int action;
    bool keep;
    virDomainObjPtr vm;
53
    bool deviceDeletedEvent;
54 55 56 57 58
};

static int
qemuHotplugCreateObjects(virDomainXMLOptionPtr xmlopt,
                         virDomainObjPtr *vm,
59 60
                         const char *domxml,
                         bool event)
61 62
{
    int ret = -1;
63
    qemuDomainObjPrivatePtr priv = NULL;
64 65 66 67

    if (!(*vm = virDomainObjNew(xmlopt)))
        goto cleanup;

68 69 70
    if (!((*vm)->def = virDomainDefParseString(domxml,
                                               driver.caps,
                                               driver.xmlopt,
71
                                               VIR_DOMAIN_DEF_PARSE_INACTIVE)))
72 73
        goto cleanup;

74 75 76 77 78 79
    priv = (*vm)->privateData;

    if (!(priv->qemuCaps = virQEMUCapsNew()))
        goto cleanup;

    /* for attach & detach qemu must support -device */
80
    virQEMUCapsSet(priv->qemuCaps, QEMU_CAPS_DRIVE);
81
    virQEMUCapsSet(priv->qemuCaps, QEMU_CAPS_DEVICE);
82
    virQEMUCapsSet(priv->qemuCaps, QEMU_CAPS_NET_NAME);
83
    virQEMUCapsSet(priv->qemuCaps, QEMU_CAPS_VIRTIO_SCSI);
84
    virQEMUCapsSet(priv->qemuCaps, QEMU_CAPS_DEVICE_USB_STORAGE);
85 86
    if (event)
        virQEMUCapsSet(priv->qemuCaps, QEMU_CAPS_DEVICE_DEL_EVENT);
87

88
    if (qemuDomainAssignAddresses((*vm)->def, priv->qemuCaps, *vm) < 0)
89 90 91 92
        goto cleanup;

    if (qemuAssignDeviceAliases((*vm)->def, priv->qemuCaps) < 0)
        goto cleanup;
93

94 95
    (*vm)->def->id = QEMU_HOTPLUG_TEST_DOMAIN_ID;

96
    ret = 0;
97
 cleanup:
98 99 100
    return ret;
}

101 102 103 104 105 106 107
static int
testQemuHotplugAttach(virDomainObjPtr vm,
                      virDomainDeviceDefPtr dev)
{
    int ret = -1;

    switch (dev->type) {
108 109 110 111 112 113
    case VIR_DOMAIN_DEVICE_DISK:
        /* conn in only used for storage pool and secrets lookup so as long
         * as we don't use any of them, passing NULL should be safe
         */
        ret = qemuDomainAttachDeviceDiskLive(NULL, &driver, vm, dev);
        break;
114 115 116 117 118
    case VIR_DOMAIN_DEVICE_CHR:
        ret = qemuDomainAttachChrDevice(&driver, vm, dev->data.chr);
        break;
    default:
        if (virTestGetVerbose())
119
            fprintf(stderr, "device type '%s' cannot be attached\n",
120 121 122 123 124 125 126 127 128 129 130 131 132 133
                    virDomainDeviceTypeToString(dev->type));
        break;
    }

    return ret;
}

static int
testQemuHotplugDetach(virDomainObjPtr vm,
                      virDomainDeviceDefPtr dev)
{
    int ret = -1;

    switch (dev->type) {
134 135 136
    case VIR_DOMAIN_DEVICE_DISK:
        ret = qemuDomainDetachDeviceDiskLive(&driver, vm, dev);
        break;
137 138 139 140 141
    case VIR_DOMAIN_DEVICE_CHR:
        ret = qemuDomainDetachChrDevice(&driver, vm, dev->data.chr);
        break;
    default:
        if (virTestGetVerbose())
142
            fprintf(stderr, "device type '%s' cannot be detached\n",
143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166
                    virDomainDeviceTypeToString(dev->type));
        break;
    }

    return ret;
}

static int
testQemuHotplugUpdate(virDomainObjPtr vm,
                      virDomainDeviceDefPtr dev)
{
    int ret = -1;

    /* XXX Ideally, we would call qemuDomainUpdateDeviceLive here.  But that
     * would require us to provide virConnectPtr and virDomainPtr (they're used
     * in case of updating a disk device. So for now, we will proceed with
     * breaking the function into pieces. If we ever learn how to fake those
     * required object, we can replace this code then. */
    switch (dev->type) {
    case VIR_DOMAIN_DEVICE_GRAPHICS:
        ret = qemuDomainChangeGraphics(&driver, vm, dev->data.graphics);
        break;
    default:
        if (virTestGetVerbose())
167
            fprintf(stderr, "device type '%s' cannot be updated\n",
168 169 170 171 172 173 174
                    virDomainDeviceTypeToString(dev->type));
        break;
    }

    return ret;
}

175 176 177 178 179 180 181 182
static int
testQemuHotplugCheckResult(virDomainObjPtr vm,
                           const char *expected,
                           bool fail)
{
    char *actual;
    int ret;

183
    vm->def->id = -1;
184
    actual = virDomainDefFormat(vm->def, VIR_DOMAIN_DEF_FORMAT_SECURE);
185 186
    if (!actual)
        return -1;
187
    vm->def->id = QEMU_HOTPLUG_TEST_DOMAIN_ID;
188 189 190 191 192 193 194 195 196 197 198 199 200 201 202

    if (STREQ(expected, actual)) {
        if (fail && virTestGetVerbose())
            fprintf(stderr, "domain XML should not match the expected result\n");
        ret = 0;
    } else {
        if (!fail)
            virtTestDifference(stderr, expected, actual);
        ret = -1;
    }

    VIR_FREE(actual);
    return ret;
}

203 204 205 206 207 208 209
static int
testQemuHotplug(const void *data)
{
    int ret = -1;
    struct qemuHotplugTestData *test = (struct qemuHotplugTestData *) data;
    char *domain_filename = NULL;
    char *device_filename = NULL;
210 211
    char *result_filename = NULL;
    char *domain_xml = NULL;
212
    char *device_xml = NULL;
213
    char *result_xml = NULL;
214 215
    const char *const *tmp;
    bool fail = test->fail;
216
    bool keep = test->keep;
217
    unsigned int device_parse_flags = 0;
218 219 220 221 222 223 224 225 226
    virDomainObjPtr vm = NULL;
    virDomainDeviceDefPtr dev = NULL;
    virCapsPtr caps = NULL;
    qemuMonitorTestPtr test_mon = NULL;
    qemuDomainObjPrivatePtr priv = NULL;

    if (virAsprintf(&domain_filename, "%s/qemuxml2argvdata/qemuxml2argv-%s.xml",
                    abs_srcdir, test->domain_filename) < 0 ||
        virAsprintf(&device_filename, "%s/qemuhotplugtestdata/qemuhotplug-%s.xml",
227 228 229 230 231 232 233 234 235 236 237 238 239
                    abs_srcdir, test->device_filename) < 0 ||
        virAsprintf(&result_filename,
                    "%s/qemuhotplugtestdata/qemuhotplug-%s+%s.xml",
                    abs_srcdir, test->domain_filename,
                    test->device_filename) < 0)
        goto cleanup;

    if (virtTestLoadFile(domain_filename, &domain_xml) < 0 ||
        virtTestLoadFile(device_filename, &device_xml) < 0)
        goto cleanup;

    if (test->action != UPDATE &&
        virtTestLoadFile(result_filename, &result_xml) < 0)
240 241 242 243 244
        goto cleanup;

    if (!(caps = virQEMUDriverGetCapabilities(&driver, false)))
        goto cleanup;

245 246 247
    if (test->vm) {
        vm = test->vm;
    } else {
248 249
        if (qemuHotplugCreateObjects(driver.xmlopt, &vm, domain_xml,
                                     test->deviceDeletedEvent) < 0)
250 251
            goto cleanup;
    }
252

253
    if (test->action == ATTACH)
254
        device_parse_flags = VIR_DOMAIN_DEF_PARSE_INACTIVE;
255

256
    if (!(dev = virDomainDeviceDefParse(device_xml, vm->def,
257 258
                                        caps, driver.xmlopt,
                                        device_parse_flags)))
259 260 261 262
        goto cleanup;

    /* Now is the best time to feed the spoofed monitor with predefined
     * replies. */
263
    if (!(test_mon = qemuMonitorTestNew(true, driver.xmlopt, vm, &driver, NULL)))
264 265 266 267 268 269 270 271 272 273 274 275 276 277
        goto cleanup;

    tmp = test->mon;
    while (tmp && *tmp) {
        const char *command_name;
        const char *response;

        if (!(command_name = *tmp++) ||
            !(response = *tmp++))
            break;
        if (qemuMonitorTestAddItem(test_mon, command_name, response) < 0)
            goto cleanup;
    }

278
    priv = vm->privateData;
279 280 281 282 283 284 285 286
    priv->mon = qemuMonitorTestGetMonitor(test_mon);
    priv->monJSON = true;

    /* XXX We need to unlock the monitor here, as
     * qemuDomainObjEnterMonitorInternal (called from qemuDomainChangeGraphics)
     * tries to lock it again */
    virObjectUnlock(priv->mon);

287 288 289
    switch (test->action) {
    case ATTACH:
        ret = testQemuHotplugAttach(vm, dev);
290 291 292 293 294
        if (ret == 0) {
            /* vm->def stolen dev->data.* so we just need to free the dev
             * envelope */
            VIR_FREE(dev);
        }
295 296
        if (ret == 0 || fail)
            ret = testQemuHotplugCheckResult(vm, result_xml, fail);
297
        break;
298 299 300

    case DETACH:
        ret = testQemuHotplugDetach(vm, dev);
301 302
        if (ret == 0 || fail)
            ret = testQemuHotplugCheckResult(vm, domain_xml, fail);
303
        break;
304 305 306

    case UPDATE:
        ret = testQemuHotplugUpdate(vm, dev);
307 308
    }

309
 cleanup:
310 311
    VIR_FREE(domain_filename);
    VIR_FREE(device_filename);
312 313
    VIR_FREE(result_filename);
    VIR_FREE(domain_xml);
314
    VIR_FREE(device_xml);
315
    VIR_FREE(result_xml);
316 317 318
    /* don't dispose test monitor with VM */
    if (priv)
        priv->mon = NULL;
319 320 321 322 323 324
    if (keep) {
        test->vm = vm;
    } else {
        virObjectUnref(vm);
        test->vm = NULL;
    }
325 326 327 328 329 330 331 332 333 334
    virDomainDeviceDefFree(dev);
    virObjectUnref(caps);
    qemuMonitorTestFree(test_mon);
    return ((ret < 0 && fail) || (!ret && !fail)) ? 0 : -1;
}

static int
mymain(void)
{
    int ret = 0;
335
    struct qemuHotplugTestData data = {0};
336
    virSecurityManagerPtr mgr;
337 338 339 340 341 342 343 344 345 346 347 348 349

#if !WITH_YAJL
    fputs("libvirt not compiled with yajl, skipping this test\n", stderr);
    return EXIT_AM_SKIP;
#endif

    if (virThreadInitialize() < 0 ||
        !(driver.caps = testQemuCapsInit()) ||
        !(driver.xmlopt = virQEMUDriverCreateXMLConf(&driver)))
        return EXIT_FAILURE;

    virEventRegisterDefaultImpl();

350 351
    if (!(driver.config = virQEMUDriverConfigNew(false)))
        return EXIT_FAILURE;
352 353
    VIR_FREE(driver.config->spiceListen);
    VIR_FREE(driver.config->vncListen);
354 355 356
    /* some dummy values from 'config file' */
    if (VIR_STRDUP_QUIET(driver.config->spicePassword, "123456") < 0)
        return EXIT_FAILURE;
357

358
    if (!(driver.domainEventState = virObjectEventStateNew()))
359 360
        return EXIT_FAILURE;

361 362 363 364 365 366 367 368 369
    driver.lockManager = virLockManagerPluginNew("nop", "qemu",
                                                 driver.config->configBaseDir,
                                                 0);
    if (!driver.lockManager)
        return EXIT_FAILURE;

    if (!(mgr = virSecurityManagerNew("none", "qemu", false, false, false)))
        return EXIT_FAILURE;
    if (!(driver.securityManager = virSecurityManagerNewStack(mgr)))
370 371
        return EXIT_FAILURE;

372 373 374 375
    /* wait only 100ms for DEVICE_DELETED event */
    qemuDomainRemoveDeviceWaitTime = 100;

#define DO_TEST(file, ACTION, dev, event, fial, kep, ...)                   \
376
    do {                                                                    \
377
        const char *my_mon[] = { __VA_ARGS__, NULL};                        \
378 379
        const char *name = file " " #ACTION " " dev;                        \
        data.action = ACTION;                                               \
380 381 382 383 384
        data.domain_filename = file;                                        \
        data.device_filename = dev;                                         \
        data.fail = fial;                                                   \
        data.mon = my_mon;                                                  \
        data.keep = kep;                                                    \
385
        data.deviceDeletedEvent = event;                                    \
386
        if (virtTestRun(name, testQemuHotplug, &data) < 0)                  \
387
            ret = -1;                                                       \
388
    } while (0)
389 390

#define DO_TEST_ATTACH(file, dev, fial, kep, ...)                           \
391
    DO_TEST(file, ATTACH, dev, false, fial, kep, __VA_ARGS__)
392 393

#define DO_TEST_DETACH(file, dev, fial, kep, ...)                           \
394 395 396 397 398 399 400
    DO_TEST(file, DETACH, dev, false, fial, kep, __VA_ARGS__)

#define DO_TEST_ATTACH_EVENT(file, dev, fial, kep, ...)                     \
    DO_TEST(file, ATTACH, dev, true, fial, kep, __VA_ARGS__)

#define DO_TEST_DETACH_EVENT(file, dev, fial, kep, ...)                     \
    DO_TEST(file, DETACH, dev, true, fial, kep, __VA_ARGS__)
401 402

#define DO_TEST_UPDATE(file, dev, fial, kep, ...)                           \
403
    DO_TEST(file, UPDATE, dev, false, fial, kep, __VA_ARGS__)
404

405 406

#define QMP_OK      "{\"return\": {}}"
407
#define HMP(msg)    "{\"return\": \"" msg "\"}"
408

409 410 411 412 413 414 415 416 417 418 419 420 421
#define QMP_DEVICE_DELETED(dev) \
    "{"                                                     \
    "    \"timestamp\": {"                                  \
    "        \"seconds\": 1374137171,"                      \
    "        \"microseconds\": 2659"                        \
    "    },"                                                \
    "    \"event\": \"DEVICE_DELETED\","                    \
    "    \"data\": {"                                       \
    "        \"device\": \"" dev "\","                      \
    "        \"path\": \"/machine/peripheral/" dev "\""     \
    "    }"                                                 \
    "}\r\n"

422 423
    DO_TEST_UPDATE("graphics-spice", "graphics-spice-nochange", false, false, NULL);
    DO_TEST_UPDATE("graphics-spice-timeout", "graphics-spice-timeout-nochange", false, false,
424
                   "set_password", QMP_OK, "expire_password", QMP_OK);
425
    DO_TEST_UPDATE("graphics-spice-timeout", "graphics-spice-timeout-password", false, false,
426
                   "set_password", QMP_OK, "expire_password", QMP_OK);
427 428
    DO_TEST_UPDATE("graphics-spice", "graphics-spice-listen", true, false, NULL);
    DO_TEST_UPDATE("graphics-spice-listen-network", "graphics-spice-listen-network", false, false,
429
                   "set_password", QMP_OK, "expire_password", QMP_OK);
430 431 432 433 434
    /* Strange huh? Currently, only graphics can be updated :-P */
    DO_TEST_UPDATE("disk-cdrom", "disk-cdrom-nochange", true, false, NULL);

    DO_TEST_ATTACH("console-compat-2", "console-virtio", false, true,
                   "chardev-add", "{\"return\": {\"pty\": \"/dev/pts/26\"}}",
435
                   "device_add", QMP_OK);
436 437

    DO_TEST_DETACH("console-compat-2", "console-virtio", false, false,
438 439
                   "device_del", QMP_OK,
                   "chardev-remove", QMP_OK);
440

441 442 443 444 445 446 447
    DO_TEST_ATTACH("hotplug-base", "disk-virtio", false, true,
                   "human-monitor-command", HMP("OK\\r\\n"),
                   "device_add", QMP_OK);
    DO_TEST_DETACH("hotplug-base", "disk-virtio", false, false,
                   "device_del", QMP_OK,
                   "human-monitor-command", HMP(""));

448 449 450 451 452 453 454 455 456 457
    DO_TEST_ATTACH_EVENT("hotplug-base", "disk-virtio", false, true,
                         "human-monitor-command", HMP("OK\\r\\n"),
                         "device_add", QMP_OK);
    DO_TEST_DETACH("hotplug-base", "disk-virtio", true, true,
                   "device_del", QMP_OK,
                   "human-monitor-command", HMP(""));
    DO_TEST_DETACH("hotplug-base", "disk-virtio", false, false,
                   "device_del", QMP_DEVICE_DELETED("virtio-disk4") QMP_OK,
                   "human-monitor-command", HMP(""));

458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474
    DO_TEST_ATTACH("hotplug-base", "disk-usb", false, true,
                   "human-monitor-command", HMP("OK\\r\\n"),
                   "device_add", QMP_OK);
    DO_TEST_DETACH("hotplug-base", "disk-usb", false, false,
                   "device_del", QMP_OK,
                   "human-monitor-command", HMP(""));

    DO_TEST_ATTACH_EVENT("hotplug-base", "disk-usb", false, true,
                         "human-monitor-command", HMP("OK\\r\\n"),
                         "device_add", QMP_OK);
    DO_TEST_DETACH("hotplug-base", "disk-usb", true, true,
                   "device_del", QMP_OK,
                   "human-monitor-command", HMP(""));
    DO_TEST_DETACH("hotplug-base", "disk-usb", false, false,
                   "device_del", QMP_DEVICE_DELETED("usb-disk16") QMP_OK,
                   "human-monitor-command", HMP(""));

475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491
    DO_TEST_ATTACH("hotplug-base", "disk-scsi", false, true,
                   "human-monitor-command", HMP("OK\\r\\n"),
                   "device_add", QMP_OK);
    DO_TEST_DETACH("hotplug-base", "disk-scsi", false, false,
                   "device_del", QMP_OK,
                   "human-monitor-command", HMP(""));

    DO_TEST_ATTACH_EVENT("hotplug-base", "disk-scsi", false, true,
                         "human-monitor-command", HMP("OK\\r\\n"),
                         "device_add", QMP_OK);
    DO_TEST_DETACH("hotplug-base", "disk-scsi", true, true,
                   "device_del", QMP_OK,
                   "human-monitor-command", HMP(""));
    DO_TEST_DETACH("hotplug-base", "disk-scsi", false, false,
                   "device_del", QMP_DEVICE_DELETED("scsi0-0-0-5") QMP_OK,
                   "human-monitor-command", HMP(""));

492 493
    virObjectUnref(driver.caps);
    virObjectUnref(driver.xmlopt);
494
    virObjectUnref(driver.config);
495 496 497 498
    return (ret == 0) ? EXIT_SUCCESS : EXIT_FAILURE;
}

VIRT_TEST_MAIN(mymain)