storage_backend_fs.c 41.0 KB
Newer Older
1 2 3
/*
 * storage_backend_fs.c: storage backend for FS and directory handling
 *
4
 * Copyright (C) 2007-2011 Red Hat, Inc.
5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35
 * Copyright (C) 2007-2008 Daniel P. Berrange
 *
 * This library is free software; you can redistribute it and/or
 * modify it under the terms of the GNU Lesser General Public
 * License as published by the Free Software Foundation; either
 * version 2.1 of the License, or (at your option) any later version.
 *
 * This library is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
 * Lesser General Public License for more details.
 *
 * You should have received a copy of the GNU Lesser General Public
 * License along with this library; if not, write to the Free Software
 * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307  USA
 *
 * Author: Daniel P. Berrange <berrange@redhat.com>
 */

#include <config.h>

#include <sys/statvfs.h>
#include <sys/types.h>
#include <sys/stat.h>
#include <stdio.h>
#include <dirent.h>
#include <errno.h>
#include <fcntl.h>
#include <unistd.h>
#include <string.h>

36 37 38 39
#include <libxml/parser.h>
#include <libxml/tree.h>
#include <libxml/xpath.h>

O
Osier Yang 已提交
40 41 42 43
#if HAVE_LIBBLKID
# include <blkid/blkid.h>
#endif

44
#include "virterror_internal.h"
45 46
#include "storage_backend_fs.h"
#include "storage_conf.h"
47
#include "storage_file.h"
48
#include "command.h"
49
#include "memory.h"
50
#include "xml.h"
E
Eric Blake 已提交
51
#include "virfile.h"
O
Osier Yang 已提交
52
#include "logging.h"
53

54
#define VIR_FROM_THIS VIR_FROM_STORAGE
55

56 57 58 59 60
#define VIR_STORAGE_VOL_FS_OPEN_FLAGS       (VIR_STORAGE_VOL_OPEN_DEFAULT   |\
                                             VIR_STORAGE_VOL_OPEN_DIR)
#define VIR_STORAGE_VOL_FS_REFRESH_FLAGS    (VIR_STORAGE_VOL_FS_OPEN_FLAGS  &\
                                             ~VIR_STORAGE_VOL_OPEN_ERROR)

E
Eric Blake 已提交
61
static int ATTRIBUTE_NONNULL(2) ATTRIBUTE_NONNULL(3)
62
virStorageBackendProbeTarget(virStorageVolTargetPtr target,
63
                             char **backingStore,
64
                             int *backingStoreFormat,
65 66 67 68
                             unsigned long long *allocation,
                             unsigned long long *capacity,
                             virStorageEncryptionPtr *encryption)
{
69 70 71 72 73 74 75 76
    int fd = -1;
    int ret = -1;
    virStorageFileMetadata *meta;

    if (VIR_ALLOC(meta) < 0) {
        virReportOOMError();
        return ret;
    }
77

E
Eric Blake 已提交
78 79
    *backingStore = NULL;
    *backingStoreFormat = VIR_STORAGE_FILE_AUTO;
80 81 82
    if (encryption)
        *encryption = NULL;

83
    if ((ret = virStorageBackendVolOpenCheckMode(target->path,
84
                                        VIR_STORAGE_VOL_FS_REFRESH_FLAGS)) < 0)
85
        goto error; /* Take care to propagate ret, it is not always -1 */
86
    fd = ret;
87

88
    if ((ret = virStorageBackendUpdateVolTargetInfoFD(target, fd,
89 90
                                                      allocation,
                                                      capacity)) < 0) {
91
        goto error;
92 93
    }

94
    if ((target->format = virStorageFileProbeFormatFromFD(target->path, fd)) < 0) {
95 96
        ret = -1;
        goto error;
97 98
    }

99 100
    if (virStorageFileGetMetadataFromFD(target->path, fd,
                                        target->format,
101 102 103
                                        meta) < 0) {
        ret = -1;
        goto error;
104
    }
105

106
    VIR_FORCE_CLOSE(fd);
107

108 109 110 111
    if (meta->backingStore) {
        *backingStore = meta->backingStore;
        meta->backingStore = NULL;
        if (meta->backingStoreFormat == VIR_STORAGE_FILE_AUTO) {
112 113 114 115 116 117 118 119 120 121 122
            if ((ret = virStorageFileProbeFormat(*backingStore)) < 0) {
                /* If the backing file is currently unavailable, only log an error,
                 * but continue. Returning -1 here would disable the whole storage
                 * pool, making it unavailable for even maintenance. */
                virStorageReportError(VIR_ERR_INTERNAL_ERROR,
                                      _("cannot probe backing volume format: %s"),
                                      *backingStore);
                ret = -3;
            } else {
                *backingStoreFormat = ret;
                ret = 0;
123 124
            }
        } else {
125
            *backingStoreFormat = meta->backingStoreFormat;
126
            ret = 0;
127
        }
E
Eric Blake 已提交
128
    } else {
129
        ret = 0;
130 131
    }

132 133
    if (capacity && meta->capacity)
        *capacity = meta->capacity;
134

135
    if (encryption != NULL && meta->encrypted) {
136
        if (VIR_ALLOC(*encryption) < 0) {
137
            virReportOOMError();
138
            goto cleanup;
139 140 141 142 143 144 145 146 147 148 149 150
        }

        switch (target->format) {
        case VIR_STORAGE_FILE_QCOW:
        case VIR_STORAGE_FILE_QCOW2:
            (*encryption)->format = VIR_STORAGE_ENCRYPTION_FORMAT_QCOW;
            break;
        default:
            break;
        }

        /* XXX ideally we'd fill in secret UUID here
E
Eric Blake 已提交
151
         * but we cannot guarantee 'conn' is non-NULL
152 153 154 155 156
         * at this point in time :-(  So we only fill
         * in secrets when someone first queries a vol
         */
    }

157 158
    virStorageFileFreeMetadata(meta);

159
    return ret;
160

161 162 163
error:
    VIR_FORCE_CLOSE(fd);

164
cleanup:
165 166 167
    virStorageFileFreeMetadata(meta);
    return ret;

168 169 170
}

#if WITH_STORAGE_FS
171

172
# include <mntent.h>
173

174 175
struct _virNetfsDiscoverState {
    const char *host;
176
    virStoragePoolSourceList list;
177 178 179 180 181
};

typedef struct _virNetfsDiscoverState virNetfsDiscoverState;

static int
182
virStorageBackendFileSystemNetFindPoolSourcesFunc(virStoragePoolObjPtr pool ATTRIBUTE_UNUSED,
183 184 185 186 187
                                                  char **const groups,
                                                  void *data)
{
    virNetfsDiscoverState *state = data;
    const char *name, *path;
188 189
    virStoragePoolSource *src = NULL;
    int ret = -1;
190 191 192

    path = groups[0];

193
    if (!(name = strrchr(path, '/'))) {
194
        virStorageReportError(VIR_ERR_INTERNAL_ERROR,
195
                              _("invalid netfs path (no /): %s"), path);
196
        goto cleanup;
197 198 199
    }
    name += 1;
    if (*name == '\0') {
200
        virStorageReportError(VIR_ERR_INTERNAL_ERROR,
201
                              _("invalid netfs path (ends in /): %s"), path);
202
        goto cleanup;
203 204
    }

205
    if (!(src = virStoragePoolSourceListNewSource(&state->list)))
206
        goto cleanup;
207

208 209
    if (VIR_ALLOC_N(src->hosts, 1) < 0) {
        virReportOOMError();
210 211
        goto cleanup;
    }
212
    src->nhost = 1;
213 214

    if (!(src->hosts[0].name = strdup(state->host)) ||
215
        !(src->dir = strdup(path))) {
216
        virReportOOMError();
217 218
        goto cleanup;
    }
219
    src->format = VIR_STORAGE_POOL_NETFS_NFS;
220

221 222 223
    ret = 0;
cleanup:
    return ret;
224 225
}

226

227
static char *
228
virStorageBackendFileSystemNetFindPoolSources(virConnectPtr conn ATTRIBUTE_UNUSED,
229
                                              const char *srcSpec,
E
Eric Blake 已提交
230
                                              unsigned int flags)
231 232 233 234 235 236 237 238 239 240 241 242 243 244 245
{
    /*
     *  # showmount --no-headers -e HOSTNAME
     *  /tmp   *
     *  /A dir demo1.foo.bar,demo2.foo.bar
     *
     * Extract directory name (including possible interior spaces ...).
     */

    const char *regexes[] = {
        "^(/.*\\S) +\\S+$"
    };
    int vars[] = {
        1
    };
246 247 248 249 250 251 252 253
    virNetfsDiscoverState state = {
        .host = NULL,
        .list = {
            .type = VIR_STORAGE_POOL_NETFS,
            .nsources = 0,
            .sources = NULL
        }
    };
254
    const char *prog[] = { SHOWMOUNT, "--no-headers", "--exports", NULL, NULL };
255
    virStoragePoolSourcePtr source = NULL;
256
    char *retval = NULL;
257
    unsigned int i;
258

E
Eric Blake 已提交
259 260
    virCheckFlags(0, NULL);

261
    source = virStoragePoolDefParseSourceString(srcSpec,
262 263
                                                VIR_STORAGE_POOL_NETFS);
    if (!source)
264 265
        goto cleanup;

266 267 268 269 270 271 272 273
    if (source->nhost != 1) {
        virStorageReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
                              _("Expected exactly 1 host for the storage pool"));
        goto cleanup;
    }

    state.host = source->hosts[0].name;
    prog[3] = source->hosts[0].name;
274

275
    if (virStorageBackendRunProgRegex(NULL, prog, 1, regexes, vars,
276
                            virStorageBackendFileSystemNetFindPoolSourcesFunc,
277
                            &state, NULL) < 0)
278 279
        goto cleanup;

280
    retval = virStoragePoolSourceListFormat(&state.list);
281
    if (retval == NULL) {
282
        virReportOOMError();
283 284 285 286
        goto cleanup;
    }

 cleanup:
287
    for (i = 0; i < state.list.nsources; i++)
288 289
        virStoragePoolSourceClear(&state.list.sources[i]);
    VIR_FREE(state.list.sources);
290

291
    virStoragePoolSourceFree(source);
292 293 294 295 296

    return retval;
}


297 298 299 300 301 302 303 304 305
/**
 * @conn connection to report errors against
 * @pool storage pool to check for status
 *
 * Determine if a storage pool is already mounted
 *
 * Return 0 if not mounted, 1 if mounted, -1 on error
 */
static int
306
virStorageBackendFileSystemIsMounted(virStoragePoolObjPtr pool) {
307
    FILE *mtab;
308 309
    struct mntent ent;
    char buf[1024];
310 311

    if ((mtab = fopen(_PATH_MOUNTED, "r")) == NULL) {
312
        virReportSystemError(errno,
313 314
                             _("cannot read mount list '%s'"),
                             _PATH_MOUNTED);
315 316 317
        return -1;
    }

318 319
    while ((getmntent_r(mtab, &ent, buf, sizeof(buf))) != NULL) {
        if (STREQ(ent.mnt_dir, pool->def->target.path)) {
320
            VIR_FORCE_FCLOSE(mtab);
321 322 323 324
            return 1;
        }
    }

325
    VIR_FORCE_FCLOSE(mtab);
326 327 328 329 330 331 332 333 334 335 336 337 338
    return 0;
}

/**
 * @conn connection to report errors against
 * @pool storage pool to mount
 *
 * Ensure that a FS storage pool is mounted on its target location.
 * If already mounted, this is a no-op
 *
 * Returns 0 if successfully mounted, -1 on error
 */
static int
339
virStorageBackendFileSystemMount(virStoragePoolObjPtr pool) {
340
    char *src;
341 342 343 344 345 346 347
    const char **mntargv;

    /* 'mount -t auto' doesn't seem to auto determine nfs (or cifs),
     *  while plain 'mount' does. We have to craft separate argvs to
     *  accommodate this */
    int netauto = (pool->def->type == VIR_STORAGE_POOL_NETFS &&
                   pool->def->source.format == VIR_STORAGE_POOL_NETFS_AUTO);
348 349 350
    int glusterfs = (pool->def->type == VIR_STORAGE_POOL_NETFS &&
                 pool->def->source.format == VIR_STORAGE_POOL_NETFS_GLUSTERFS);

351 352 353 354 355 356 357 358 359 360
    int source_index;

    const char *netfs_auto_argv[] = {
        MOUNT,
        NULL, /* source path */
        pool->def->target.path,
        NULL,
    };

    const char *fs_argv[] =  {
361 362 363
        MOUNT,
        "-t",
        pool->def->type == VIR_STORAGE_POOL_FS ?
364 365
        virStoragePoolFormatFileSystemTypeToString(pool->def->source.format) :
        virStoragePoolFormatFileSystemNetTypeToString(pool->def->source.format),
366 367
        NULL, /* Fill in shortly - careful not to add extra fields
                 before this */
368 369 370
        pool->def->target.path,
        NULL,
    };
371

372 373 374 375 376 377 378 379
    const char *glusterfs_argv[] = {
        MOUNT,
        "-t",
        pool->def->type == VIR_STORAGE_POOL_FS ?
        virStoragePoolFormatFileSystemTypeToString(pool->def->source.format) :
        virStoragePoolFormatFileSystemNetTypeToString(pool->def->source.format),
        NULL,
        "-o",
E
Eric Blake 已提交
380
        "direct-io-mode=1",
381 382 383 384
        pool->def->target.path,
        NULL,
    };

385 386 387
    if (netauto) {
        mntargv = netfs_auto_argv;
        source_index = 1;
388 389 390
    } else if (glusterfs) {
        mntargv = glusterfs_argv;
        source_index = 3;
391 392 393 394 395
    } else {
        mntargv = fs_argv;
        source_index = 3;
    }

396 397 398
    int ret;

    if (pool->def->type == VIR_STORAGE_POOL_NETFS) {
399 400 401 402 403 404
        if (pool->def->source.nhost != 1) {
            virStorageReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
                                  _("Expected exactly 1 host for the storage pool"));
            return -1;
        }
        if (pool->def->source.hosts[0].name == NULL) {
405
            virStorageReportError(VIR_ERR_INTERNAL_ERROR,
J
Jim Meyering 已提交
406
                                  "%s", _("missing source host"));
407 408 409
            return -1;
        }
        if (pool->def->source.dir == NULL) {
410
            virStorageReportError(VIR_ERR_INTERNAL_ERROR,
J
Jim Meyering 已提交
411
                                  "%s", _("missing source path"));
412 413 414 415
            return -1;
        }
    } else {
        if (pool->def->source.ndevice != 1) {
416
            virStorageReportError(VIR_ERR_INTERNAL_ERROR,
J
Jim Meyering 已提交
417
                                  "%s", _("missing source device"));
418 419 420 421
            return -1;
        }
    }

J
Jim Meyering 已提交
422
    /* Short-circuit if already mounted */
423
    if ((ret = virStorageBackendFileSystemIsMounted(pool)) != 0) {
424 425 426 427
        virStorageReportError(VIR_ERR_OPERATION_INVALID,
                              _("Target '%s' is already mounted"),
                              pool->def->target.path);
        return -1;
428 429 430
    }

    if (pool->def->type == VIR_STORAGE_POOL_NETFS) {
431
        if (virAsprintf(&src, "%s:%s",
432
                        pool->def->source.hosts[0].name,
433
                        pool->def->source.dir) == -1) {
434
            virReportOOMError();
435 436
            return -1;
        }
437

438
    } else {
439
        if ((src = strdup(pool->def->source.devices[0].path)) == NULL) {
440
            virReportOOMError();
441 442
            return -1;
        }
443
    }
444
    mntargv[source_index] = src;
445

446
    if (virRun(mntargv, NULL) < 0) {
447
        VIR_FREE(src);
448 449
        return -1;
    }
450
    VIR_FREE(src);
451 452 453 454 455 456 457 458 459 460 461 462 463
    return 0;
}

/**
 * @conn connection to report errors against
 * @pool storage pool to unmount
 *
 * Ensure that a FS storage pool is not mounted on its target location.
 * If already unmounted, this is a no-op
 *
 * Returns 0 if successfully unmounted, -1 on error
 */
static int
464
virStorageBackendFileSystemUnmount(virStoragePoolObjPtr pool) {
465 466 467 468
    const char *mntargv[3];
    int ret;

    if (pool->def->type == VIR_STORAGE_POOL_NETFS) {
469 470 471 472 473 474
        if (pool->def->source.nhost != 1) {
            virStorageReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
                                  _("Expected exactly 1 host for the storage pool"));
            return -1;
        }
        if (pool->def->source.hosts[0].name == NULL) {
475
            virStorageReportError(VIR_ERR_INTERNAL_ERROR,
J
Jim Meyering 已提交
476
                                  "%s", _("missing source host"));
477 478 479
            return -1;
        }
        if (pool->def->source.dir == NULL) {
480
            virStorageReportError(VIR_ERR_INTERNAL_ERROR,
J
Jim Meyering 已提交
481
                                  "%s", _("missing source dir"));
482 483 484 485
            return -1;
        }
    } else {
        if (pool->def->source.ndevice != 1) {
486
            virStorageReportError(VIR_ERR_INTERNAL_ERROR,
J
Jim Meyering 已提交
487
                                  "%s", _("missing source device"));
488 489 490 491 492
            return -1;
        }
    }

    /* Short-circuit if already unmounted */
493
    if ((ret = virStorageBackendFileSystemIsMounted(pool)) != 1) {
494 495 496 497 498 499 500 501 502 503
        if (ret < 0)
            return -1;
        else
            return 0;
    }

    mntargv[0] = UMOUNT;
    mntargv[1] = pool->def->target.path;
    mntargv[2] = NULL;

504
    if (virRun(mntargv, NULL) < 0) {
505 506 507 508 509 510 511
        return -1;
    }
    return 0;
}
#endif /* WITH_STORAGE_FS */


512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535
static int
virStorageBackendFileSystemCheck(virConnectPtr conn ATTRIBUTE_UNUSED,
                                 virStoragePoolObjPtr pool,
                                 bool *isActive)
{
    *isActive = false;
    if (pool->def->type == VIR_STORAGE_POOL_DIR) {
        if (access(pool->def->target.path, F_OK) == 0)
            *isActive = true;
#if WITH_STORAGE_FS
    } else {
        int ret;
        if ((ret = virStorageBackendFileSystemIsMounted(pool)) != 0) {
            if (ret < 0)
                return -1;
            *isActive = true;
        }
#endif /* WITH_STORAGE_FS */
    }

    return 0;
}

#if WITH_STORAGE_FS
536 537 538 539 540 541 542 543 544 545 546
/**
 * @conn connection to report errors against
 * @pool storage pool to start
 *
 * Starts a directory or FS based storage pool.
 *
 *  - If it is a FS based pool, mounts the unlying source device on the pool
 *
 * Returns 0 on success, -1 on error
 */
static int
547
virStorageBackendFileSystemStart(virConnectPtr conn ATTRIBUTE_UNUSED,
548 549 550
                                 virStoragePoolObjPtr pool)
{
    if (pool->def->type != VIR_STORAGE_POOL_DIR &&
551
        virStorageBackendFileSystemMount(pool) < 0)
552 553 554 555 556 557
        return -1;

    return 0;
}
#endif /* WITH_STORAGE_FS */

O
Osier Yang 已提交
558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643
#if HAVE_LIBBLKID
static virStoragePoolProbeResult
virStorageBackendFileSystemProbe(const char *device,
                                 const char *format) {

    virStoragePoolProbeResult ret = FILESYSTEM_PROBE_ERROR;
    blkid_probe probe = NULL;
    const char *fstype = NULL;
    char *names[2], *libblkid_format = NULL;

    VIR_DEBUG("Probing for existing filesystem of type %s on device %s",
              format, device);

    if (blkid_known_fstype(format) == 0) {
        virStorageReportError(VIR_ERR_STORAGE_PROBE_FAILED,
                              _("Not capable of probing for "
                                "filesystem of type %s"),
                              format);
        goto error;
    }

    probe = blkid_new_probe_from_filename(device);
    if (probe == NULL) {
        virStorageReportError(VIR_ERR_STORAGE_PROBE_FAILED,
                                  _("Failed to create filesystem probe "
                                  "for device %s"),
                                  device);
        goto error;
    }

    if ((libblkid_format = strdup(format)) == NULL) {
        virReportOOMError();
        goto error;
    }

    names[0] = libblkid_format;
    names[1] = NULL;

    blkid_probe_filter_superblocks_type(probe,
                                        BLKID_FLTR_ONLYIN,
                                        names);

    if (blkid_do_probe(probe) != 0) {
        VIR_INFO("No filesystem of type '%s' found on device '%s'",
                 format, device);
        ret = FILESYSTEM_PROBE_NOT_FOUND;
    } else if (blkid_probe_lookup_value(probe, "TYPE", &fstype, NULL) == 0) {
        virStorageReportError(VIR_ERR_STORAGE_POOL_BUILT,
                              _("Existing filesystem of type '%s' found on "
                                "device '%s'"),
                              fstype, device);
        ret = FILESYSTEM_PROBE_FOUND;
    }

    if (blkid_do_probe(probe) != 1) {
        virStorageReportError(VIR_ERR_STORAGE_PROBE_FAILED,
                                  _("Found additional probes to run, "
                                    "filesystem probing may be incorrect"));
        ret = FILESYSTEM_PROBE_ERROR;
    }

error:
    VIR_FREE(libblkid_format);

    if (probe != NULL) {
        blkid_free_probe(probe);
    }

    return ret;
}

#else /* #if HAVE_LIBBLKID */

static virStoragePoolProbeResult
virStorageBackendFileSystemProbe(const char *device ATTRIBUTE_UNUSED,
                                 const char *format ATTRIBUTE_UNUSED)
{
    virStorageReportError(VIR_ERR_OPERATION_INVALID,
                          _("probing for filesystems is unsupported "
                            "by this build"));

    return FILESYSTEM_PROBE_ERROR;
}

#endif /* #if HAVE_LIBBLKID */

644 645
/* some platforms don't support mkfs */
#ifdef MKFS
O
Osier Yang 已提交
646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667
static int
virStorageBackendExecuteMKFS(const char *device,
                             const char *format)
{
    int ret = 0;
    virCommandPtr cmd = NULL;

    cmd = virCommandNewArgList(MKFS,
                               "-t",
                               format,
                               device,
                               NULL);

    if (virCommandRun(cmd, NULL) < 0) {
        virReportSystemError(errno,
                             _("Failed to make filesystem of "
                               "type '%s' on device '%s'"),
                             format, device);
        ret = -1;
    }
    return ret;
}
668 669 670 671 672 673 674 675 676 677 678 679 680
#else /* #ifdef MKFS */
static int
virStorageBackendExecuteMKFS(const char *device ATTRIBUTE_UNUSED,
                             const char *format ATTRIBUTE_UNUSED)
{
    virStorageReportError(VIR_ERR_INTERNAL_ERROR,
                              _("mkfs is not supported on this platform: "
                                "Failed to make filesystem of "
                               "type '%s' on device '%s'"),
                             format, device);
    return -1;
}
#endif /* #ifdef MKFS */
O
Osier Yang 已提交
681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723

static int
virStorageBackendMakeFileSystem(virStoragePoolObjPtr pool,
                                unsigned int flags)
{
    const char *device = NULL, *format = NULL;
    bool ok_to_mkfs = false;
    int ret = -1;

    if (pool->def->source.devices == NULL) {
        virStorageReportError(VIR_ERR_OPERATION_INVALID,
                              _("No source device specified when formatting pool '%s'"),
                              pool->def->name);
        goto error;
    }

    device = pool->def->source.devices[0].path;
    format = virStoragePoolFormatFileSystemTypeToString(pool->def->source.format);
    VIR_DEBUG("source device: '%s' format: '%s'", device, format);

    if (!virFileExists(device)) {
        virStorageReportError(VIR_ERR_OPERATION_INVALID,
                              _("Source device does not exist when formatting pool '%s'"),
                              pool->def->name);
        goto error;
    }

    if (flags & VIR_STORAGE_POOL_BUILD_OVERWRITE) {
        ok_to_mkfs = true;
    } else if (flags & VIR_STORAGE_POOL_BUILD_NO_OVERWRITE &&
               virStorageBackendFileSystemProbe(device, format) ==
               FILESYSTEM_PROBE_NOT_FOUND) {
        ok_to_mkfs = true;
    }

    if (ok_to_mkfs) {
        ret = virStorageBackendExecuteMKFS(device, format);
    }

error:
    return ret;
}

724 725 726 727

/**
 * @conn connection to report errors against
 * @pool storage pool to build
E
Eric Blake 已提交
728
 * @flags controls the pool formatting behaviour
729 730 731
 *
 * Build a directory or FS based storage pool.
 *
O
Osier Yang 已提交
732 733 734 735 736 737 738
 * If no flag is set, it only makes the directory; If
 * VIR_STORAGE_POOL_BUILD_NO_OVERWRITE set, it probes to determine if
 * filesystem already exists on the target device, renurning an error
 * if exists, or using mkfs to format the target device if not; If
 * VIR_STORAGE_POOL_BUILD_OVERWRITE is set, mkfs is always executed,
 * any existed data on the target device is overwritten unconditionally.
 *
739 740 741 742 743
 *  - If it is a FS based pool, mounts the unlying source device on the pool
 *
 * Returns 0 on success, -1 on error
 */
static int
744
virStorageBackendFileSystemBuild(virConnectPtr conn ATTRIBUTE_UNUSED,
745
                                 virStoragePoolObjPtr pool,
E
Eric Blake 已提交
746
                                 unsigned int flags)
747
{
748
    int err, ret = -1;
O
Osier Yang 已提交
749 750
    char *parent = NULL;
    char *p = NULL;
751

O
Osier Yang 已提交
752 753 754 755 756 757 758 759 760 761 762
    virCheckFlags(VIR_STORAGE_POOL_BUILD_OVERWRITE |
                  VIR_STORAGE_POOL_BUILD_NO_OVERWRITE, ret);

    if (flags == (VIR_STORAGE_POOL_BUILD_OVERWRITE |
                  VIR_STORAGE_POOL_BUILD_NO_OVERWRITE)) {

        virStorageReportError(VIR_ERR_OPERATION_INVALID,
                              _("Overwrite and no overwrite flags"
                                " are mutually exclusive"));
        goto error;
    }
E
Eric Blake 已提交
763

764
    if ((parent = strdup(pool->def->target.path)) == NULL) {
765
        virReportOOMError();
766 767 768
        goto error;
    }
    if (!(p = strrchr(parent, '/'))) {
769
        virStorageReportError(VIR_ERR_INVALID_ARG,
770 771 772
                              _("path '%s' is not absolute"),
                              pool->def->target.path);
        goto error;
773 774
    }

775 776 777 778
    if (p != parent) {
        /* assure all directories in the path prior to the final dir
         * exist, with default uid/gid/mode. */
        *p = '\0';
779 780
        if (virFileMakePath(parent) < 0) {
            virReportSystemError(errno, _("cannot create path '%s'"),
781 782 783 784 785 786 787 788
                                 parent);
            goto error;
        }
    }

    /* Now create the final dir in the path with the uid/gid/mode
     * requested in the config. If the dir already exists, just set
     * the perms. */
789 790
    if ((err = virDirCreate(pool->def->target.path,
                            pool->def->target.perms.mode,
791 792
                            pool->def->target.perms.uid,
                            pool->def->target.perms.gid,
793 794 795 796 797 798 799
                            VIR_DIR_CREATE_FORCE_PERMS |
                            VIR_DIR_CREATE_ALLOW_EXIST |
                            (pool->def->type == VIR_STORAGE_POOL_NETFS
                            ? VIR_DIR_CREATE_AS_UID : 0)) < 0)) {
        virReportSystemError(-err, _("cannot create path '%s'"),
                             pool->def->target.path);
        goto error;
800
    }
O
Osier Yang 已提交
801

802 803
    /* Reflect the actual uid and gid to the config. */
    if (pool->def->target.perms.uid == (uid_t) -1)
804
        pool->def->target.perms.uid = getuid();
805
    if (pool->def->target.perms.gid == (gid_t) -1)
806
        pool->def->target.perms.gid = getgid();
807

O
Osier Yang 已提交
808 809 810 811 812 813
    if (flags != 0) {
        ret = virStorageBackendMakeFileSystem(pool, flags);
    } else {
        ret = 0;
    }

814 815 816
error:
    VIR_FREE(parent);
    return ret;
817 818 819 820 821 822 823 824
}


/**
 * Iterate over the pool's directory and enumerate all disk images
 * within it. This is non-recursive.
 */
static int
825
virStorageBackendFileSystemRefresh(virConnectPtr conn ATTRIBUTE_UNUSED,
826 827 828 829 830
                                   virStoragePoolObjPtr pool)
{
    DIR *dir;
    struct dirent *ent;
    struct statvfs sb;
831
    virStorageVolDefPtr vol = NULL;
832 833

    if (!(dir = opendir(pool->def->target.path))) {
834
        virReportSystemError(errno,
835 836
                             _("cannot open path '%s'"),
                             pool->def->target.path);
837 838 839 840 841
        goto cleanup;
    }

    while ((ent = readdir(dir)) != NULL) {
        int ret;
842
        char *backingStore;
843
        int backingStoreFormat;
844

845 846
        if (VIR_ALLOC(vol) < 0)
            goto no_memory;
847

848 849
        if ((vol->name = strdup(ent->d_name)) == NULL)
            goto no_memory;
850

851
        vol->type = VIR_STORAGE_VOL_FILE;
852
        vol->target.format = VIR_STORAGE_FILE_RAW; /* Real value is filled in during probe */
853 854 855
        if (virAsprintf(&vol->target.path, "%s/%s",
                        pool->def->target.path,
                        vol->name) == -1)
856 857 858 859
            goto no_memory;

        if ((vol->key = strdup(vol->target.path)) == NULL)
            goto no_memory;
860

861
        if ((ret = virStorageBackendProbeTarget(&vol->target,
862
                                                &backingStore,
863
                                                &backingStoreFormat,
864
                                                &vol->allocation,
865
                                                &vol->capacity,
866
                                                &vol->target.encryption)) < 0) {
867
            if (ret == -2) {
868
                /* Silently ignore non-regular files,
869
                 * eg '.' '..', 'lost+found', dangling symbolic link */
870 871
                virStorageVolDefFree(vol);
                vol = NULL;
872
                continue;
873 874 875 876 877 878 879 880 881
            } else if (ret == -3) {
                /* The backing file is currently unavailable, its format is not
                 * explicitly specified, the probe to auto detect the format
                 * failed: continue with faked RAW format, since AUTO will
                 * break virStorageVolTargetDefFormat() generating the line
                 * <format type='...'/>. */
                backingStoreFormat = VIR_STORAGE_FILE_RAW;
            } else
                goto cleanup;
882 883
        }

884 885 886 887
        /* directory based volume */
        if (vol->target.format == VIR_STORAGE_FILE_DIR)
            vol->type = VIR_STORAGE_VOL_DIR;

888
        if (backingStore != NULL) {
889 890 891 892
            vol->backingStore.path = backingStore;
            vol->backingStore.format = backingStoreFormat;

            if (virStorageBackendUpdateVolTargetInfo(&vol->backingStore,
893 894
                                        NULL, NULL,
                                        VIR_STORAGE_VOL_OPEN_DEFAULT) < 0) {
895 896
                /* The backing file is currently unavailable, the capacity,
                 * allocation, owner, group and mode are unknown. Just log the
E
Eric Blake 已提交
897
                 * error and continue.
898 899 900 901 902 903
                 * Unfortunately virStorageBackendProbeTarget() might already
                 * have logged a similar message for the same problem, but only
                 * if AUTO format detection was used. */
                virStorageReportError(VIR_ERR_INTERNAL_ERROR,
                                      _("cannot probe backing volume info: %s"),
                                      vol->backingStore.path);
904 905 906 907
            }
        }


908 909 910 911 912
        if (VIR_REALLOC_N(pool->volumes.objs,
                          pool->volumes.count+1) < 0)
            goto no_memory;
        pool->volumes.objs[pool->volumes.count++] = vol;
        vol = NULL;
913 914 915 916 917
    }
    closedir(dir);


    if (statvfs(pool->def->target.path, &sb) < 0) {
918
        virReportSystemError(errno,
919 920
                             _("cannot statvfs path '%s'"),
                             pool->def->target.path);
921 922 923 924 925 926 927 928 929 930
        return -1;
    }
    pool->def->capacity = ((unsigned long long)sb.f_frsize *
                           (unsigned long long)sb.f_blocks);
    pool->def->available = ((unsigned long long)sb.f_bfree *
                            (unsigned long long)sb.f_bsize);
    pool->def->allocation = pool->def->capacity - pool->def->available;

    return 0;

931
no_memory:
932
    virReportOOMError();
933 934
    /* fallthrough */

935
 cleanup:
936 937
    if (dir)
        closedir(dir);
938
    virStorageVolDefFree(vol);
939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954
    virStoragePoolObjClearVols(pool);
    return -1;
}


/**
 * @conn connection to report errors against
 * @pool storage pool to start
 *
 * Stops a directory or FS based storage pool.
 *
 *  - If it is a FS based pool, unmounts the unlying source device on the pool
 *  - Releases all cached data about volumes
 */
#if WITH_STORAGE_FS
static int
955
virStorageBackendFileSystemStop(virConnectPtr conn ATTRIBUTE_UNUSED,
956 957 958
                                virStoragePoolObjPtr pool)
{
    if (pool->def->type != VIR_STORAGE_POOL_DIR &&
959
        virStorageBackendFileSystemUnmount(pool) < 0)
960 961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977
        return -1;

    return 0;
}
#endif /* WITH_STORAGE_FS */


/**
 * @conn connection to report errors against
 * @pool storage pool to build
 *
 * Build a directory or FS based storage pool.
 *
 *  - If it is a FS based pool, mounts the unlying source device on the pool
 *
 * Returns 0 on success, -1 on error
 */
static int
978
virStorageBackendFileSystemDelete(virConnectPtr conn ATTRIBUTE_UNUSED,
979
                                  virStoragePoolObjPtr pool,
E
Eric Blake 已提交
980
                                  unsigned int flags)
981
{
E
Eric Blake 已提交
982 983
    virCheckFlags(0, -1);

984 985
    /* XXX delete all vols first ? */

986
    if (rmdir(pool->def->target.path) < 0) {
987
        virReportSystemError(errno,
988
                             _("failed to remove pool '%s'"),
989
                             pool->def->target.path);
990 991 992 993 994 995 996 997
        return -1;
    }

    return 0;
}


/**
998 999 1000 1001
 * Set up a volume definition to be added to a pool's volume list, but
 * don't do any file creation or allocation. By separating the two processes,
 * we allow allocation progress reporting (by polling the volume's 'info'
 * function), and can drop the parent pool lock during the (slow) allocation.
1002 1003
 */
static int
1004
virStorageBackendFileSystemVolCreate(virConnectPtr conn ATTRIBUTE_UNUSED,
1005 1006 1007 1008
                                     virStoragePoolObjPtr pool,
                                     virStorageVolDefPtr vol)
{

1009 1010
    vol->type = VIR_STORAGE_VOL_FILE;

R
Ryota Ozaki 已提交
1011
    VIR_FREE(vol->target.path);
1012 1013 1014
    if (virAsprintf(&vol->target.path, "%s/%s",
                    pool->def->target.path,
                    vol->name) == -1) {
1015
        virReportOOMError();
1016 1017
        return -1;
    }
1018

R
Ryota Ozaki 已提交
1019
    VIR_FREE(vol->key);
1020 1021
    vol->key = strdup(vol->target.path);
    if (vol->key == NULL) {
1022
        virReportOOMError();
1023 1024 1025
        return -1;
    }

1026 1027 1028
    return 0;
}

1029
static int createFileDir(virConnectPtr conn ATTRIBUTE_UNUSED,
1030
                         virStoragePoolObjPtr pool,
1031
                         virStorageVolDefPtr vol,
1032
                         virStorageVolDefPtr inputvol,
E
Eric Blake 已提交
1033 1034
                         unsigned int flags)
{
1035 1036
    int err;

E
Eric Blake 已提交
1037 1038
    virCheckFlags(0, -1);

1039
    if (inputvol) {
1040
        virStorageReportError(VIR_ERR_INTERNAL_ERROR,
1041 1042 1043 1044 1045
                              "%s",
                              _("cannot copy from volume to a directory volume"));
        return -1;
    }

1046
    if ((err = virDirCreate(vol->target.path, vol->target.perms.mode,
1047 1048
                            vol->target.perms.uid,
                            vol->target.perms.gid,
1049
                            VIR_DIR_CREATE_FORCE_PERMS |
1050
                            (pool->def->type == VIR_STORAGE_POOL_NETFS
1051 1052
                             ? VIR_DIR_CREATE_AS_UID : 0))) < 0) {
        virReportSystemError(-err, _("cannot create path '%s'"),
1053 1054 1055
                             vol->target.path);
        return -1;
    }
1056

1057 1058
    return 0;
}
1059

1060
static int
1061
_virStorageBackendFileSystemVolBuild(virConnectPtr conn,
1062
                                     virStoragePoolObjPtr pool,
1063 1064
                                     virStorageVolDefPtr vol,
                                     virStorageVolDefPtr inputvol)
1065
{
1066
    virStorageBackendBuildVolFrom create_func;
1067
    int tool_type;
1068

1069
    if (inputvol) {
1070
        if (vol->target.encryption != NULL) {
O
Osier Yang 已提交
1071
            virStorageReportError(VIR_ERR_CONFIG_UNSUPPORTED,
1072 1073 1074 1075 1076
                                  "%s", _("storage pool does not support "
                                          "building encrypted volumes from "
                                          "other volumes"));
            return -1;
        }
1077
        create_func = virStorageBackendGetBuildVolFromFunction(vol,
1078
                                                               inputvol);
1079 1080
        if (!create_func)
            return -1;
1081
    } else if (vol->target.format == VIR_STORAGE_FILE_RAW) {
1082
        create_func = virStorageBackendCreateRaw;
1083
    } else if (vol->target.format == VIR_STORAGE_FILE_DIR) {
1084
        create_func = createFileDir;
1085
    } else if ((tool_type = virStorageBackendFindFSImageTool(NULL)) != -1) {
1086
        create_func = virStorageBackendFSImageToolTypeToFunc(tool_type);
1087 1088

        if (!create_func)
1089
            return -1;
1090
    } else {
1091
        virStorageReportError(VIR_ERR_INTERNAL_ERROR,
J
Jim Meyering 已提交
1092 1093
                              "%s", _("creation of non-raw images "
                                      "is not supported without qemu-img"));
1094 1095 1096
        return -1;
    }

1097
    if (create_func(conn, pool, vol, inputvol, 0) < 0)
1098
        return -1;
1099 1100 1101
    return 0;
}

1102 1103 1104 1105 1106 1107 1108
/**
 * Allocate a new file as a volume. This is either done directly
 * for raw/sparse files, or by calling qemu-img/qcow-create for
 * special kinds of files
 */
static int
virStorageBackendFileSystemVolBuild(virConnectPtr conn,
1109
                                    virStoragePoolObjPtr pool,
1110
                                    virStorageVolDefPtr vol) {
1111
    return _virStorageBackendFileSystemVolBuild(conn, pool, vol, NULL);
1112 1113 1114 1115 1116 1117 1118
}

/*
 * Create a storage vol using 'inputvol' as input
 */
static int
virStorageBackendFileSystemVolBuildFrom(virConnectPtr conn,
1119
                                        virStoragePoolObjPtr pool,
1120 1121
                                        virStorageVolDefPtr vol,
                                        virStorageVolDefPtr inputvol,
E
Eric Blake 已提交
1122 1123 1124 1125
                                        unsigned int flags)
{
    virCheckFlags(0, -1);

1126
    return _virStorageBackendFileSystemVolBuild(conn, pool, vol, inputvol);
1127
}
1128 1129

/**
1130
 * Remove a volume - no support for BLOCK and NETWORK yet
1131 1132
 */
static int
1133
virStorageBackendFileSystemVolDelete(virConnectPtr conn ATTRIBUTE_UNUSED,
1134 1135
                                     virStoragePoolObjPtr pool ATTRIBUTE_UNUSED,
                                     virStorageVolDefPtr vol,
E
Eric Blake 已提交
1136
                                     unsigned int flags)
1137
{
E
Eric Blake 已提交
1138 1139
    virCheckFlags(0, -1);

1140 1141 1142 1143 1144 1145 1146 1147 1148 1149 1150 1151 1152 1153
    switch (vol->type) {
    case VIR_STORAGE_VOL_FILE:
        if (unlink(vol->target.path) < 0) {
            /* Silently ignore failures where the vol has already gone away */
            if (errno != ENOENT) {
                virReportSystemError(errno,
                                     _("cannot unlink file '%s'"),
                                     vol->target.path);
                return -1;
            }
        }
        break;
    case VIR_STORAGE_VOL_DIR:
        if (rmdir(vol->target.path) < 0) {
1154
            virReportSystemError(errno,
1155
                                 _("cannot remove directory '%s'"),
1156
                                 vol->target.path);
1157 1158
            return -1;
        }
1159 1160 1161 1162 1163 1164 1165 1166
        break;
    case VIR_STORAGE_VOL_BLOCK:
    case VIR_STORAGE_VOL_NETWORK:
    default:
        virStorageReportError(VIR_ERR_NO_SUPPORT,
                              _("removing block or network volumes is not supported: %s"),
                              vol->target.path);
        return -1;
1167 1168 1169 1170 1171 1172 1173 1174 1175 1176 1177 1178 1179
    }
    return 0;
}


/**
 * Update info about a volume's capacity/allocation
 */
static int
virStorageBackendFileSystemVolRefresh(virConnectPtr conn,
                                      virStoragePoolObjPtr pool ATTRIBUTE_UNUSED,
                                      virStorageVolDefPtr vol)
{
1180 1181
    int ret;

1182
    /* Refresh allocation / permissions info in case its changed */
1183 1184
    ret = virStorageBackendUpdateVolInfoFlags(vol, 0,
                                              VIR_STORAGE_VOL_FS_OPEN_FLAGS);
1185 1186 1187 1188 1189 1190 1191 1192 1193 1194 1195 1196 1197 1198 1199 1200 1201
    if (ret < 0)
        return ret;

    /* Load any secrets if posible */
    if (vol->target.encryption &&
        vol->target.encryption->format == VIR_STORAGE_ENCRYPTION_FORMAT_QCOW &&
        vol->target.encryption->nsecrets == 0) {
        virSecretPtr sec;
        virStorageEncryptionSecretPtr encsec = NULL;

        sec = virSecretLookupByUsage(conn,
                                     VIR_SECRET_USAGE_TYPE_VOLUME,
                                     vol->target.path);
        if (sec) {
            if (VIR_ALLOC_N(vol->target.encryption->secrets, 1) < 0 ||
                VIR_ALLOC(encsec) < 0) {
                VIR_FREE(vol->target.encryption->secrets);
1202
                virReportOOMError();
1203 1204 1205 1206 1207 1208 1209 1210 1211 1212 1213 1214 1215 1216
                virSecretFree(sec);
                return -1;
            }

            vol->target.encryption->nsecrets = 1;
            vol->target.encryption->secrets[0] = encsec;

            encsec->type = VIR_STORAGE_ENCRYPTION_SECRET_TYPE_PASSPHRASE;
            virSecretGetUUID(sec, encsec->uuid);
            virSecretFree(sec);
        }
    }

    return 0;
1217 1218
}

1219 1220 1221 1222 1223 1224 1225 1226 1227 1228 1229 1230 1231 1232 1233 1234 1235 1236 1237 1238 1239 1240 1241 1242 1243 1244 1245 1246 1247 1248 1249 1250 1251 1252 1253 1254 1255 1256 1257 1258 1259 1260 1261 1262 1263 1264 1265 1266 1267 1268
static int
virStorageBackendFilesystemResizeQemuImg(const char *path,
                                         unsigned long long capacity)
{
    int ret = -1;
    char *img_tool;
    virCommandPtr cmd = NULL;

    /* KVM is usually ahead of qemu on features, so try that first */
    img_tool = virFindFileInPath("kvm-img");
    if (!img_tool)
        img_tool = virFindFileInPath("qemu-img");

    if (!img_tool) {
        virStorageReportError(VIR_ERR_INTERNAL_ERROR,
                              "%s", _("unable to find kvm-img or qemu-img"));
        return -1;
    }

    cmd = virCommandNew(img_tool);
    virCommandAddArgList(cmd, "resize", path, NULL);
    virCommandAddArgFormat(cmd, "%llu", capacity);

    ret = virCommandRun(cmd, NULL);

    VIR_FREE(img_tool);
    virCommandFree(cmd);

    return ret;
}

/**
 * Resize a volume
 */
static int
virStorageBackendFileSystemVolResize(virConnectPtr conn ATTRIBUTE_UNUSED,
                                     virStoragePoolObjPtr pool ATTRIBUTE_UNUSED,
                                     virStorageVolDefPtr vol,
                                     unsigned long long capacity,
                                     unsigned int flags)
{
    virCheckFlags(0, -1);

    if (vol->target.format == VIR_STORAGE_FILE_RAW)
        return virStorageFileResize(vol->target.path, capacity);
    else
        return virStorageBackendFilesystemResizeQemuImg(vol->target.path,
                                                        capacity);
}

1269 1270 1271 1272
virStorageBackend virStorageBackendDirectory = {
    .type = VIR_STORAGE_POOL_DIR,

    .buildPool = virStorageBackendFileSystemBuild,
1273
    .checkPool = virStorageBackendFileSystemCheck,
1274 1275
    .refreshPool = virStorageBackendFileSystemRefresh,
    .deletePool = virStorageBackendFileSystemDelete,
1276
    .buildVol = virStorageBackendFileSystemVolBuild,
1277
    .buildVolFrom = virStorageBackendFileSystemVolBuildFrom,
1278 1279 1280
    .createVol = virStorageBackendFileSystemVolCreate,
    .refreshVol = virStorageBackendFileSystemVolRefresh,
    .deleteVol = virStorageBackendFileSystemVolDelete,
1281
    .resizeVol = virStorageBackendFileSystemVolResize,
1282 1283 1284 1285 1286 1287 1288
};

#if WITH_STORAGE_FS
virStorageBackend virStorageBackendFileSystem = {
    .type = VIR_STORAGE_POOL_FS,

    .buildPool = virStorageBackendFileSystemBuild,
1289
    .checkPool = virStorageBackendFileSystemCheck,
1290 1291 1292 1293
    .startPool = virStorageBackendFileSystemStart,
    .refreshPool = virStorageBackendFileSystemRefresh,
    .stopPool = virStorageBackendFileSystemStop,
    .deletePool = virStorageBackendFileSystemDelete,
1294
    .buildVol = virStorageBackendFileSystemVolBuild,
1295
    .buildVolFrom = virStorageBackendFileSystemVolBuildFrom,
1296 1297 1298
    .createVol = virStorageBackendFileSystemVolCreate,
    .refreshVol = virStorageBackendFileSystemVolRefresh,
    .deleteVol = virStorageBackendFileSystemVolDelete,
1299
    .resizeVol = virStorageBackendFileSystemVolResize,
1300 1301 1302 1303 1304
};
virStorageBackend virStorageBackendNetFileSystem = {
    .type = VIR_STORAGE_POOL_NETFS,

    .buildPool = virStorageBackendFileSystemBuild,
1305
    .checkPool = virStorageBackendFileSystemCheck,
1306
    .startPool = virStorageBackendFileSystemStart,
1307
    .findPoolSources = virStorageBackendFileSystemNetFindPoolSources,
1308 1309 1310
    .refreshPool = virStorageBackendFileSystemRefresh,
    .stopPool = virStorageBackendFileSystemStop,
    .deletePool = virStorageBackendFileSystemDelete,
1311
    .buildVol = virStorageBackendFileSystemVolBuild,
1312
    .buildVolFrom = virStorageBackendFileSystemVolBuildFrom,
1313 1314 1315
    .createVol = virStorageBackendFileSystemVolCreate,
    .refreshVol = virStorageBackendFileSystemVolRefresh,
    .deleteVol = virStorageBackendFileSystemVolDelete,
1316
    .resizeVol = virStorageBackendFileSystemVolResize,
1317 1318
};
#endif /* WITH_STORAGE_FS */