bridge.c 18.1 KB
Newer Older
1
/*
J
Jim Meyering 已提交
2
 * Copyright (C) 2007, 2009 Red Hat, Inc.
3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23
 *
 * This library is free software; you can redistribute it and/or
 * modify it under the terms of the GNU Lesser General Public
 * License as published by the Free Software Foundation; either
 * version 2.1 of the License, or (at your option) any later version.
 *
 * This library is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
 * Lesser General Public License for more details.
 *
 * You should have received a copy of the GNU Lesser General Public
 * License along with this library; if not, write to the Free Software
 * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307  USA
 *
 * Authors:
 *     Mark McLoughlin <markmc@redhat.com>
 */

#include <config.h>

24
#if defined(WITH_BRIDGE)
25

26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50
# include "bridge.h"

# include <stdlib.h>
# include <stdio.h>
# include <string.h>
# include <unistd.h>
# include <fcntl.h>
# include <errno.h>
# include <arpa/inet.h>
# include <sys/types.h>
# include <sys/socket.h>
# include <sys/ioctl.h>
# include <paths.h>
# include <sys/wait.h>

# include <linux/param.h>     /* HZ                 */
# include <linux/sockios.h>   /* SIOCBRADDBR etc.   */
# include <linux/if_bridge.h> /* SYSFS_BRIDGE_ATTR  */
# include <linux/if_tun.h>    /* IFF_TUN, IFF_NO_PI */
# include <net/if_arp.h>    /* ARPHRD_ETHER */

# include "internal.h"
# include "memory.h"
# include "util.h"
# include "logging.h"
51
# include "network.h"
52 53 54

# define JIFFIES_TO_MS(j) (((j)*1000)/HZ)
# define MS_TO_JIFFIES(ms) (((ms)*HZ)/1000)
55 56 57 58 59

struct _brControl {
    int fd;
};

60 61 62 63 64 65 66 67 68
/**
 * brInit:
 * @ctlp: pointer to bridge control return value
 *
 * Initialize a new bridge layer. In case of success
 * @ctlp will contain a pointer to the new bridge structure.
 *
 * Returns 0 in case of success, an error code otherwise.
 */
69 70 71 72
int
brInit(brControl **ctlp)
{
    int fd;
73
    int flags;
74 75 76 77 78 79 80 81

    if (!ctlp || *ctlp)
        return EINVAL;

    fd = socket(AF_INET, SOCK_STREAM, 0);
    if (fd < 0)
        return errno;

82 83 84 85 86 87 88
    if ((flags = fcntl(fd, F_GETFD)) < 0 ||
        fcntl(fd, F_SETFD, flags | FD_CLOEXEC) < 0) {
        int err = errno;
        close(fd);
        return err;
    }

89
    if (VIR_ALLOC(*ctlp) < 0) {
90
        close(fd);
91
        return ENOMEM;
92
    }
93 94 95 96 97 98

    (*ctlp)->fd = fd;

    return 0;
}

99 100 101 102 103 104
/**
 * brShutdown:
 * @ctl: pointer to a bridge control
 *
 * Shutdown the bridge layer and deallocate the associated structures
 */
105 106 107 108 109 110 111 112 113
void
brShutdown(brControl *ctl)
{
    if (!ctl)
        return;

    close(ctl->fd);
    ctl->fd = 0;

114
    VIR_FREE(ctl);
115 116
}

117 118 119
/**
 * brAddBridge:
 * @ctl: bridge control pointer
120
 * @name: the bridge name
121
 *
122
 * This function register a new bridge
123 124 125
 *
 * Returns 0 in case of success or an errno code in case of failure.
 */
126
# ifdef SIOCBRADDBR
127 128
int
brAddBridge(brControl *ctl,
129
            const char *name)
130
{
131
    if (!ctl || !ctl->fd || !name)
132 133
        return EINVAL;

134 135
    if (ioctl(ctl->fd, SIOCBRADDBR, name) == 0)
        return 0;
136 137 138

    return errno;
}
139
# else
140
int brAddBridge (brControl *ctl ATTRIBUTE_UNUSED,
141
                 const char *name ATTRIBUTE_UNUSED)
142 143 144
{
    return EINVAL;
}
145
# endif
146

147
# ifdef SIOCBRDELBR
148 149 150 151 152 153 154 155 156 157 158
int
brHasBridge(brControl *ctl,
            const char *name)
{
    struct ifreq ifr;

    if (!ctl || !name) {
        errno = EINVAL;
        return -1;
    }

C
Chris Lalancette 已提交
159 160 161
    memset(&ifr, 0, sizeof(struct ifreq));

    if (virStrcpyStatic(ifr.ifr_name, name) == NULL) {
162 163 164 165 166 167 168 169 170
        errno = EINVAL;
        return -1;
    }

    if (ioctl(ctl->fd, SIOCGIFFLAGS, &ifr))
        return -1;

    return 0;
}
171
# else
172
int
173 174
brHasBridge(brControl *ctl ATTRIBUTE_UNUSED,
            const char *name ATTRIBUTE_UNUSED)
175 176 177
{
    return EINVAL;
}
178
# endif
179

180 181 182 183 184 185 186 187 188
/**
 * brDeleteBridge:
 * @ctl: bridge control pointer
 * @name: the bridge name
 *
 * Remove a bridge from the layer.
 *
 * Returns 0 in case of success or an errno code in case of failure.
 */
189
# ifdef SIOCBRDELBR
190 191 192 193 194 195 196 197 198
int
brDeleteBridge(brControl *ctl,
               const char *name)
{
    if (!ctl || !ctl->fd || !name)
        return EINVAL;

    return ioctl(ctl->fd, SIOCBRDELBR, name) == 0 ? 0 : errno;
}
199
# else
200 201 202 203 204 205
int
brDeleteBridge(brControl *ctl ATTRIBUTE_UNUSED,
               const char *name ATTRIBUTE_UNUSED)
{
    return EINVAL;
}
206
# endif
207

208
# if defined(SIOCBRADDIF) && defined(SIOCBRDELIF)
209 210 211 212 213 214 215 216 217 218 219 220 221
static int
brAddDelInterface(brControl *ctl,
                  int cmd,
                  const char *bridge,
                  const char *iface)
{
    struct ifreq ifr;

    if (!ctl || !ctl->fd || !bridge || !iface)
        return EINVAL;

    memset(&ifr, 0, sizeof(struct ifreq));

C
Chris Lalancette 已提交
222 223
    if (virStrcpyStatic(ifr.ifr_name, bridge) == NULL)
        return EINVAL;
224 225 226 227 228 229

    if (!(ifr.ifr_ifindex = if_nametoindex(iface)))
        return ENODEV;

    return ioctl(ctl->fd, cmd, &ifr) == 0 ? 0 : errno;
}
230
# endif
231

232 233 234 235 236
/**
 * brAddInterface:
 * @ctl: bridge control pointer
 * @bridge: the bridge name
 * @iface: the network interface name
237
 *
238 239 240 241
 * Adds an interface to a bridge
 *
 * Returns 0 in case of success or an errno code in case of failure.
 */
242
# ifdef SIOCBRADDIF
243 244 245 246 247 248 249
int
brAddInterface(brControl *ctl,
               const char *bridge,
               const char *iface)
{
    return brAddDelInterface(ctl, SIOCBRADDIF, bridge, iface);
}
250
# else
251 252 253 254 255 256 257
int
brAddInterface(brControl *ctl ATTRIBUTE_UNUSED,
               const char *bridge ATTRIBUTE_UNUSED,
               const char *iface ATTRIBUTE_UNUSED)
{
    return EINVAL;
}
258
# endif
259

260 261 262 263 264
/**
 * brDeleteInterface:
 * @ctl: bridge control pointer
 * @bridge: the bridge name
 * @iface: the network interface name
265
 *
266 267 268 269
 * Removes an interface from a bridge
 *
 * Returns 0 in case of success or an errno code in case of failure.
 */
270
# ifdef SIOCBRDELIF
271 272 273 274 275 276 277
int
brDeleteInterface(brControl *ctl,
                  const char *bridge,
                  const char *iface)
{
    return brAddDelInterface(ctl, SIOCBRDELIF, bridge, iface);
}
278
# else
279 280 281 282 283 284 285
int
brDeleteInterface(brControl *ctl ATTRIBUTE_UNUSED,
                  const char *bridge ATTRIBUTE_UNUSED,
                  const char *iface ATTRIBUTE_UNUSED)
{
    return EINVAL;
}
286
# endif
287

288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319
/**
 * ifSetInterfaceMac:
 * @ctl: bridge control pointer
 * @ifname: interface name to set MTU for
 * @macaddr: MAC address (VIR_MAC_BUFLEN in size)
 *
 * This function sets the @macaddr for a given interface @ifname. This
 * gets rid of the kernel's automatically assigned random MAC.
 *
 * Returns 0 in case of success or an errno code in case of failure.
 */
static int ifSetInterfaceMac(brControl *ctl, const char *ifname,
                             const unsigned char *macaddr)
{
    struct ifreq ifr;

    if (!ctl || !ifname)
        return EINVAL;

    memset(&ifr, 0, sizeof(struct ifreq));
    if (virStrcpyStatic(ifr.ifr_name, ifname) == NULL)
        return EINVAL;

    /* To fill ifr.ifr_hdaddr.sa_family field */
    if (ioctl(ctl->fd, SIOCGIFHWADDR, &ifr) != 0)
        return errno;

    memcpy(ifr.ifr_hwaddr.sa_data, macaddr, VIR_MAC_BUFLEN);

    return ioctl(ctl->fd, SIOCSIFHWADDR, &ifr) == 0 ? 0 : errno;
}

320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338
/**
 * ifGetMtu
 * @ctl: bridge control pointer
 * @ifname: interface name get MTU for
 *
 * This function gets the @mtu value set for a given interface @ifname.
 *
 * Returns the MTU value in case of success.
 * On error, returns -1 and sets errno accordingly
 */
static int ifGetMtu(brControl *ctl, const char *ifname)
{
    struct ifreq ifr;

    if (!ctl || !ifname) {
        errno = EINVAL;
        return -1;
    }

C
Chris Lalancette 已提交
339 340 341
    memset(&ifr, 0, sizeof(struct ifreq));

    if (virStrcpyStatic(ifr.ifr_name, ifname) == NULL) {
342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372
        errno = EINVAL;
        return -1;
    }

    if (ioctl(ctl->fd, SIOCGIFMTU, &ifr))
        return -1;

    return ifr.ifr_mtu;

}

/**
 * ifSetMtu:
 * @ctl: bridge control pointer
 * @ifname: interface name to set MTU for
 * @mtu: MTU value
 *
 * This function sets the @mtu for a given interface @ifname.  Typically
 * used on a tap device to set up for Jumbo Frames.
 *
 * Returns 0 in case of success or an errno code in case of failure.
 */
static int ifSetMtu(brControl *ctl, const char *ifname, int mtu)
{
    struct ifreq ifr;

    if (!ctl || !ifname)
        return EINVAL;

    memset(&ifr, 0, sizeof(struct ifreq));

C
Chris Lalancette 已提交
373 374
    if (virStrcpyStatic(ifr.ifr_name, ifname) == NULL)
        return EINVAL;
375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401
    ifr.ifr_mtu = mtu;

    return ioctl(ctl->fd, SIOCSIFMTU, &ifr) == 0 ? 0 : errno;
}

/**
 * brSetInterfaceMtu
 * @ctl: bridge control pointer
 * @bridge: name of the bridge interface
 * @ifname: name of the interface whose MTU we want to set
 *
 * Sets the interface mtu to the same MTU of the bridge
 *
 * Returns 0 in case of success or an errno code in case of failure.
 */
static int brSetInterfaceMtu(brControl *ctl,
                             const char *bridge,
                             const char *ifname)
{
    int mtu = ifGetMtu(ctl, bridge);

    if (mtu < 0)
        return errno;

    return ifSetMtu(ctl, ifname, mtu);
}

402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420
/**
 * brProbeVnetHdr:
 * @tapfd: a tun/tap file descriptor
 *
 * Check whether it is safe to enable the IFF_VNET_HDR flag on the
 * tap interface.
 *
 * Setting IFF_VNET_HDR enables QEMU's virtio_net driver to allow
 * guests to pass larger (GSO) packets, with partial checksums, to
 * the host. This greatly increases the achievable throughput.
 *
 * It is only useful to enable this when we're setting up a virtio
 * interface. And it is only *safe* to enable it when we know for
 * sure that a) qemu has support for IFF_VNET_HDR and b) the running
 * kernel implements the TUNGETIFF ioctl(), which qemu needs to query
 * the supplied tapfd.
 *
 * Returns 0 in case of success or an errno code in case of failure.
 */
421
# ifdef IFF_VNET_HDR
422 423 424
static int
brProbeVnetHdr(int tapfd)
{
425
#  if defined(IFF_VNET_HDR) && defined(TUNGETFEATURES) && defined(TUNGETIFF)
426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452
    unsigned int features;
    struct ifreq dummy;

    if (ioctl(tapfd, TUNGETFEATURES, &features) != 0) {
        VIR_INFO0(_("Not enabling IFF_VNET_HDR; "
                    "TUNGETFEATURES ioctl() not implemented"));
        return 0;
    }

    if (!(features & IFF_VNET_HDR)) {
        VIR_INFO0(_("Not enabling IFF_VNET_HDR; "
                    "TUNGETFEATURES ioctl() reports no IFF_VNET_HDR"));
        return 0;
    }

    /* The kernel will always return -1 at this point.
     * If TUNGETIFF is not implemented then errno == EBADFD.
     */
    if (ioctl(tapfd, TUNGETIFF, &dummy) != -1 || errno != EBADFD) {
        VIR_INFO0(_("Not enabling IFF_VNET_HDR; "
                    "TUNGETIFF ioctl() not implemented"));
        return 0;
    }

    VIR_INFO0(_("Enabling IFF_VNET_HDR"));

    return 1;
453
#  else
454
    (void) tapfd;
455 456
    VIR_INFO0(_("Not enabling IFF_VNET_HDR; disabled at build time"));
    return 0;
457
#  endif
458
}
459
# endif
460

461 462 463 464 465
/**
 * brAddTap:
 * @ctl: bridge control pointer
 * @bridge: the bridge name
 * @ifname: the interface name (or name template)
466
 * @macaddr: desired MAC address (VIR_MAC_BUFLEN long)
467
 * @vnet_hdr: whether to try enabling IFF_VNET_HDR
468 469
 * @tapfd: file descriptor return value for the new tap device
 *
D
typo  
Daniel Veillard 已提交
470
 * This function creates a new tap device on a bridge. @ifname can be either
471
 * a fixed name or a name template with '%d' for dynamic name allocation.
472 473 474 475 476
 * in either case the final name for the bridge will be stored in @ifname.
 * If the @tapfd parameter is supplied, the open tap device file
 * descriptor will be returned, otherwise the TAP device will be made
 * persistent and closed. The caller must use brDeleteTap to remove
 * a persistent TAP devices when it is no longer needed.
477 478 479
 *
 * Returns 0 in case of success or an errno code in case of failure.
 */
480 481 482
int
brAddTap(brControl *ctl,
         const char *bridge,
483
         char **ifname,
484
         const unsigned char *macaddr,
485
         int vnet_hdr,
486 487
         int *tapfd)
{
C
Chris Lalancette 已提交
488
    int fd;
489
    struct ifreq ifr;
490

491
    if (!ctl || !ctl->fd || !bridge || !ifname)
492 493 494 495 496
        return EINVAL;

    if ((fd = open("/dev/net/tun", O_RDWR)) < 0)
      return errno;

497 498
    memset(&ifr, 0, sizeof(ifr));

499
    ifr.ifr_flags = IFF_TAP|IFF_NO_PI;
500

501
# ifdef IFF_VNET_HDR
502 503
    if (vnet_hdr && brProbeVnetHdr(fd))
        ifr.ifr_flags |= IFF_VNET_HDR;
504
# else
505
    (void) vnet_hdr;
506
# endif
507

C
Chris Lalancette 已提交
508
    if (virStrcpyStatic(ifr.ifr_name, *ifname) == NULL) {
509 510 511
        errno = EINVAL;
        goto error;
    }
512

C
Chris Lalancette 已提交
513 514 515
    if (ioctl(fd, TUNSETIFF, &ifr) < 0)
        goto error;

516 517 518 519 520 521 522 523
    /* We need to set the interface MAC before adding it
     * to the bridge, because the bridge assumes the lowest
     * MAC of all enslaved interfaces & we don't want it
     * seeing the kernel allocate random MAC for the TAP
     * device before we set our static MAC.
     */
    if ((errno = ifSetInterfaceMac(ctl, ifr.ifr_name, macaddr)))
        goto error;
524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541
    /* We need to set the interface MTU before adding it
     * to the bridge, because the bridge will have its
     * MTU adjusted automatically when we add the new interface.
     */
    if ((errno = brSetInterfaceMtu(ctl, bridge, ifr.ifr_name)))
        goto error;
    if ((errno = brAddInterface(ctl, bridge, ifr.ifr_name)))
        goto error;
    if ((errno = brSetInterfaceUp(ctl, ifr.ifr_name, 1)))
        goto error;
    if (!tapfd &&
        (errno = ioctl(fd, TUNSETPERSIST, 1)))
        goto error;
    VIR_FREE(*ifname);
    if (!(*ifname = strdup(ifr.ifr_name)))
        goto error;
    if (tapfd)
        *tapfd = fd;
542 543
    else
        close(fd);
544
    return 0;
545 546 547 548 549 550 551

 error:
    close(fd);

    return errno;
}

552 553 554 555 556 557 558 559 560 561 562 563 564 565 566
int brDeleteTap(brControl *ctl,
                const char *ifname)
{
    struct ifreq try;
    int fd;

    if (!ctl || !ctl->fd || !ifname)
        return EINVAL;

    if ((fd = open("/dev/net/tun", O_RDWR)) < 0)
        return errno;

    memset(&try, 0, sizeof(struct ifreq));
    try.ifr_flags = IFF_TAP|IFF_NO_PI;

C
Chris Lalancette 已提交
567
    if (virStrcpyStatic(try.ifr_name, ifname) == NULL) {
568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583
        errno = EINVAL;
        goto error;
    }

    if (ioctl(fd, TUNSETIFF, &try) == 0) {
        if ((errno = ioctl(fd, TUNSETPERSIST, 0)))
            goto error;
    }

 error:
    close(fd);

    return errno;
}


584 585 586 587 588 589 590 591 592 593
/**
 * brSetInterfaceUp:
 * @ctl: bridge control pointer
 * @ifname: the interface name
 * @up: 1 for up, 0 for down
 *
 * Function to control if an interface is activated (up, 1) or not (down, 0)
 *
 * Returns 0 in case of success or an errno code in case of failure.
 */
594 595 596 597 598 599 600 601 602 603 604 605 606
int
brSetInterfaceUp(brControl *ctl,
                 const char *ifname,
                 int up)
{
    struct ifreq ifr;
    int flags;

    if (!ctl || !ifname)
        return EINVAL;

    memset(&ifr, 0, sizeof(struct ifreq));

C
Chris Lalancette 已提交
607 608
    if (virStrcpyStatic(ifr.ifr_name, ifname) == NULL)
        return EINVAL;
609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624

    if (ioctl(ctl->fd, SIOCGIFFLAGS, &ifr) < 0)
        return errno;

    flags = up ? (ifr.ifr_flags | IFF_UP) : (ifr.ifr_flags & ~IFF_UP);

    if (ifr.ifr_flags != flags) {
        ifr.ifr_flags = flags;

        if (ioctl(ctl->fd, SIOCSIFFLAGS, &ifr) < 0)
            return errno;
    }

    return 0;
}

625 626 627 628 629 630 631 632 633 634
/**
 * brGetInterfaceUp:
 * @ctl: bridge control pointer
 * @ifname: the interface name
 * @up: where to store the status
 *
 * Function to query if an interface is activated (1) or not (0)
 *
 * Returns 0 in case of success or an errno code in case of failure.
 */
635 636 637 638 639 640 641
int
brGetInterfaceUp(brControl *ctl,
                 const char *ifname,
                 int *up)
{
    struct ifreq ifr;

642
    if (!ctl || !ifname || !up)
643 644 645 646
        return EINVAL;

    memset(&ifr, 0, sizeof(struct ifreq));

C
Chris Lalancette 已提交
647 648
    if (virStrcpyStatic(ifr.ifr_name, ifname) == NULL)
        return EINVAL;
649 650 651 652 653 654 655 656 657 658 659 660 661

    if (ioctl(ctl->fd, SIOCGIFFLAGS, &ifr) < 0)
        return errno;

    *up = (ifr.ifr_flags & IFF_UP) ? 1 : 0;

    return 0;
}

static int
brSetInetAddr(brControl *ctl,
              const char *ifname,
              int cmd,
662
              virSocketAddr *addr)
663 664 665 666 667 668 669 670
{
    struct ifreq ifr;

    if (!ctl || !ctl->fd || !ifname || !addr)
        return EINVAL;

    memset(&ifr, 0, sizeof(struct ifreq));

C
Chris Lalancette 已提交
671 672
    if (virStrcpyStatic(ifr.ifr_name, ifname) == NULL)
        return EINVAL;
673

674
    if (!VIR_SOCKET_IS_FAMILY(addr, AF_INET))
675 676
        return EINVAL;

677
    ifr.ifr_addr = addr->data.sa;
678 679 680 681 682 683 684

    if (ioctl(ctl->fd, cmd, &ifr) < 0)
        return errno;

    return 0;
}

685 686 687 688
/**
 * brSetInetAddress:
 * @ctl: bridge control pointer
 * @ifname: the interface name
689
 * @addr: the string representation of the IP address
690 691 692 693 694 695 696 697
 *
 * Function to bind the interface to an IP address, it should handle
 * IPV4 and IPv6. The string for addr would be of the form
 * "ddd.ddd.ddd.ddd" assuming the common IPv4 format.
 *
 * Returns 0 in case of success or an errno code in case of failure.
 */

698 699 700
int
brSetInetAddress(brControl *ctl,
                 const char *ifname,
701
                 virSocketAddr *addr)
702 703 704 705
{
    return brSetInetAddr(ctl, ifname, SIOCSIFADDR, addr);
}

706 707 708 709 710 711 712 713 714 715 716 717 718
/**
 * brSetInetNetmask:
 * @ctl: bridge control pointer
 * @ifname: the interface name
 * @addr: the string representation of the netmask
 *
 * Function to set the netmask of an interface, it should handle
 * IPV4 and IPv6 forms. The string for addr would be of the form
 * "ddd.ddd.ddd.ddd" assuming the common IPv4 format.
 *
 * Returns 0 in case of success or an errno code in case of failure.
 */

719 720 721
int
brSetInetNetmask(brControl *ctl,
                 const char *ifname,
722
                 virSocketAddr *addr)
723 724 725 726
{
    return brSetInetAddr(ctl, ifname, SIOCSIFNETMASK, addr);
}

727 728 729 730 731 732 733 734
/**
 * brSetForwardDelay:
 * @ctl: bridge control pointer
 * @bridge: the bridge name
 * @delay: delay in seconds
 *
 * Set the bridge forward delay
 *
735
 * Returns 0 in case of success or -1 on failure
736
 */
737

738
int
739
brSetForwardDelay(brControl *ctl ATTRIBUTE_UNUSED,
740 741 742
                  const char *bridge,
                  int delay)
{
743
    char delayStr[30];
744 745 746
    const char *const progargv[] = {
        BRCTL, "setfd", bridge, delayStr, NULL
    };
747

748
    snprintf(delayStr, sizeof(delayStr), "%d", delay);
749

750
    if (virRun(progargv, NULL) < 0)
751
        return -1;
752

753
    return 0;
754 755
}

756 757 758 759 760 761 762 763 764
/**
 * brSetEnableSTP:
 * @ctl: bridge control pointer
 * @bridge: the bridge name
 * @enable: 1 to enable, 0 to disable
 *
 * Control whether the bridge participates in the spanning tree protocol,
 * in general don't disable it without good reasons.
 *
765
 * Returns 0 in case of success or -1 on failure
766
 */
767
int
768
brSetEnableSTP(brControl *ctl ATTRIBUTE_UNUSED,
769 770 771
               const char *bridge,
               int enable)
{
772 773 774 775
    const char *setting = enable ? "on" : "off";
    const char *const progargv[] = {
        BRCTL, "stp", bridge, setting, NULL
    };
776

777
    if (virRun(progargv, NULL) < 0)
778
        return -1;
779

780
    return 0;
781 782
}

783
#endif /* WITH_BRIDGE */