gendispatch.pl 75.5 KB
Newer Older
1 2
#!/usr/bin/perl -w
#
3
# Copyright (C) 2010-2014 Red Hat, Inc.
E
Eric Blake 已提交
4 5 6 7 8 9 10 11 12 13 14 15 16 17 18
#
# This library is free software; you can redistribute it and/or
# modify it under the terms of the GNU Lesser General Public
# License as published by the Free Software Foundation; either
# version 2.1 of the License, or (at your option) any later version.
#
# This library is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
# Lesser General Public License for more details.
#
# You should have received a copy of the GNU Lesser General Public
# License along with this library.  If not, see
# <http://www.gnu.org/licenses/>.
#
19 20 21 22 23 24 25 26 27
# This script parses remote_protocol.x or qemu_protocol.x and produces lots of
# boilerplate code for both ends of the remote connection.
#
# The first non-option argument specifies the prefix to be searched for, and
# output to, the boilerplate code.  The second non-option argument is the
# file you want to operate on.  For instance, to generate the dispatch table
# for both remote_protocol.x and qemu_protocol.x, you would run the
# following:
#
28
# gendispatch.pl -t remote ../src/remote/remote_protocol.x
29
# gendispatch.pl -t qemu ../src/remote/qemu_protocol.x
30 31
#
# By Richard Jones <rjones@redhat.com>
32
# Extended by Matthias Bolte <matthias.bolte@googlemail.com>
33 34 35

use strict;

36
use Getopt::Long;
37

38 39 40 41 42
my $mode = "debug";
my $res = GetOptions("mode=s" => \$mode);

die "cannot parse command line options" unless $res;

43
die "unknown mode '$mode', expecting 'client', 'server', " .
44 45
    "'aclheader', 'aclbody', 'aclsym', 'aclapi' or 'debug'"
    unless $mode =~ /^(client|server|aclheader|aclbody|aclsym|aclapi|debug)$/;
46

47 48
my $structprefix = shift or die "missing struct prefix argument";
my $procprefix = shift or die "missing procedure prefix argument";
49 50 51
my $protocol = shift or die "missing protocol argument";
my @autogen;

52 53 54 55 56 57 58 59 60 61 62 63 64 65

sub fixup_name {
    my $name = shift;

    $name =~ s/Nwfilter/NWFilter/;
    $name =~ s/Xml$/XML/;
    $name =~ s/Uri$/URI/;
    $name =~ s/Uuid$/UUID/;
    $name =~ s/Id$/ID/;
    $name =~ s/Mac$/MAC/;
    $name =~ s/Cpu$/CPU/;
    $name =~ s/Os$/OS/;
    $name =~ s/Nmi$/NMI/;
    $name =~ s/Pm/PM/;
66
    $name =~ s/Fstrim$/FSTrim/;
67 68
    $name =~ s/Fsfreeze$/FSFreeze/;
    $name =~ s/Fsthaw$/FSThaw/;
O
Osier Yang 已提交
69 70
    $name =~ s/Scsi/SCSI/;
    $name =~ s/Wwn$/WWN/;
71 72 73

    return $name;
}
74 75 76 77

# Convert name_of_call to NameOfCall.
sub name_to_ProcName {
    my $name = shift;
78 79 80

    my @elems;
    if ($name =~ /_/ || (lc $name) eq "open" || (lc $name) eq "close") {
81 82 83
        @elems = split /_/, $name;
        @elems = map lc, @elems;
        @elems = map ucfirst, @elems;
84
    } else {
85
        @elems = $name;
86 87 88 89 90 91 92 93 94 95
    }
    @elems = map { fixup_name($_) } @elems;
    my $procname = join "", @elems;

    return $procname;
}

sub name_to_TypeName {
    my $name = shift;

96
    my @elems = split /_/, $name;
97
    @elems = map lc, @elems;
98
    @elems = map ucfirst, @elems;
99 100 101
    @elems = map { fixup_name($_) } @elems;
    my $typename = join "", @elems;
    return $typename;
102 103 104 105
}

# Read the input file (usually remote_protocol.x) and form an
# opinion about the name, args and return type of each RPC.
106
my ($name, $ProcName, $id, $flags, %calls, @calls, %opts);
107

108
my $collect_args_members = 0;
109
my $collect_ret_members = 0;
110
my $collect_opts = 0;
111 112
my $last_name;

113 114 115
open PROTOCOL, "<$protocol" or die "cannot open $protocol: $!";

while (<PROTOCOL>) {
116 117 118 119 120 121
    if ($collect_args_members) {
        if (/^};/) {
            $collect_args_members = 0;
        } elsif ($_ =~ m/^\s*(.*\S)\s*$/) {
            push(@{$calls{$name}->{args_members}}, $1);
        }
122 123 124 125 126 127
    } elsif ($collect_ret_members) {
        if (/^};/) {
            $collect_ret_members = 0;
        } elsif ($_ =~ m/^\s*(.*\S)\s*$/) {
            push(@{$calls{$name}->{ret_members}}, $1);
        }
128
    } elsif ($collect_opts) {
129
        if (m,^\s*\*\s*\@(\w+)\s*:\s*((?:\w|:|\!|\|)+)\s*$,) {
130 131 132 133 134 135 136
            if ($1 eq "acl" ||
                $1 eq "aclfilter") {
                $opts{$1} = [] unless exists $opts{$1};
                push @{$opts{$1}}, $2;
            } else {
                $opts{$1} = $2;
            }
137 138 139 140 141 142 143 144 145 146
        } elsif (m,^\s*\*/\s*$,) {
            $collect_opts = 0;
        } elsif (m,^\s*\*\s*$,) {
            # pass
        } else {
            die "cannot parse $_";
        }
    } elsif (m,/\*\*,) {
        %opts = ();
        $collect_opts = 1;
147 148 149 150
    } elsif (/^struct (${structprefix}_(.*)_args)/ ||
             /^struct (${structprefix}(.*)Args)/) {
        my $structname = $1;
        $name = $2;
151
        $ProcName = name_to_ProcName ($name);
152 153 154
        $name = lc $name;
        $name =~ s/_//g;
        die "duplicate definition of $_"
155 156 157 158 159
            if exists $calls{$name};

        $calls{$name} = {
            name => $name,
            ProcName => $ProcName,
160
            args => $structname,
161 162
            args_members => [],
            ret => "void"
163 164
        };

165
        $collect_args_members = 1;
166
        $collect_ret_members = 0;
167
        $last_name = $name;
168 169 170 171 172
    } elsif (/^struct (${structprefix}_(.*)_ret)\s+{(.*)$/ ||
             /^struct (${structprefix}(.*)Ret)\s+{(.*)$/) {
        my $structname = $1;
        $name = $2;
        $flags = $3;
173
        $ProcName = name_to_ProcName ($name);
174 175
        $name = lc $name;
        $name =~ s/_//g;
176 177

        if (exists $calls{$name}) {
178
            $calls{$name}->{ret} = $structname;
179 180 181 182 183
        } else {
            $calls{$name} = {
                name => $name,
                ProcName => $ProcName,
                args => "void",
184
                ret => $structname,
185
                ret_members => []
186 187
            }
        }
188

189
        if ($flags ne "") {
190 191 192 193 194 195 196
            if (!($flags =~ m/^\s*\/\*\s*insert@(\d+)\s*\*\/\s*$/)) {
                die "invalid generator flags for $calls{$name}->{ret}";
            }

            $calls{$name}->{ret_offset} = int($1);
        }

197
        $collect_args_members = 0;
198 199
        $collect_ret_members = 1;
        $last_name = $name;
200 201 202 203
    } elsif (/^struct (${structprefix}_(.*)_msg)/ ||
             /^struct (${structprefix}(.*)Msg)/) {
        my $structname = $1;
        $name = $2;
204
        $ProcName = name_to_ProcName ($name);
205 206
        $name = lc $name;
        $name =~ s/_//g;
207 208 209
        $calls{$name} = {
            name => $name,
            ProcName => $ProcName,
210
            msg => $structname,
211 212 213
        };

        $collect_args_members = 0;
214
        $collect_ret_members = 0;
215
    } elsif (/^\s*(${procprefix}_PROC_(.*?))\s*=\s*(\d+)\s*,?\s*$/) {
216 217 218
        my $constname = $1;
        $name = $2;
        $id = $3;
219
        $ProcName = name_to_ProcName ($name);
220 221
        $name = lc $name;
        $name =~ s/_//g;
222

223 224 225 226 227 228 229 230 231 232 233 234
        if (!exists $calls{$name}) {
            # that the argument and return value cases have not yet added
            # this procedure to the calls hash means that it has no arguments
            # and no return value. add it to the calls hash now because all
            # procedures have to be listed in the calls hash
            $calls{$name} = {
                name => $name,
                ProcName => $ProcName,
                args => "void",
                ret => "void"
            }
        }
235
        $calls{$name}->{constname} = $constname;
236

237 238 239
        if (!exists $opts{generate}) {
            die "'\@generate' annotation missing for $constname";
        }
240

241 242 243
        if ($opts{generate} !~ /^(both|server|client|none)$/) {
            die "'\@generate' annotation value '$opts{generate}' invalid";
        }
244

245 246 247 248 249 250 251
        if ($opts{generate} eq "both") {
            push(@autogen, $ProcName);
        } elsif ($mode eq "server" && ($opts{generate} eq "server")) {
            push(@autogen, $ProcName);
        } elsif ($mode eq "client" && ($opts{generate} eq "client")) {
            push(@autogen, $ProcName);
        }
252

253 254 255 256 257 258 259 260 261
        if (exists $opts{readstream}) {
            $calls{$name}->{streamflag} = "read";
            $calls{$name}->{streamoffset} = int($opts{readstream});
        } elsif (exists $opts{writestream}) {
            $calls{$name}->{streamflag} = "write";
            $calls{$name}->{streamoffset} = int($opts{writestream});
        } else {
            $calls{$name}->{streamflag} = "none";
        }
262

263 264
        $calls{$name}->{acl} = $opts{acl};
        $calls{$name}->{aclfilter} = $opts{aclfilter};
265

266 267 268 269 270 271
        # for now, we distinguish only two levels of priority:
        # low (0) and high (1)
        if (exists $opts{priority}) {
            if ($opts{priority} eq "high") {
                $calls{$name}->{priority} = 1;
            } elsif ($opts{priority} eq "low") {
272
                $calls{$name}->{priority} = 0;
273 274
            } else {
                die "\@priority annotation value '$opts{priority}' invalid for $constname"
275
            }
276 277
        } else {
            $calls{$name}->{priority} = 0;
278 279
        }

280
        $calls[$id] = $calls{$name};
281 282

        $collect_args_members = 0;
283
        $collect_ret_members = 0;
284 285
    } else {
        $collect_args_members = 0;
286
        $collect_ret_members = 0;
287 288 289
    }
}

290 291
close(PROTOCOL);

292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322
# this hash contains the procedures that are allowed to map [unsigned] hyper
# to [unsigned] long for legacy reasons in their signature and return type.
# this list is fixed. new procedures and public APIs have to map [unsigned]
# hyper to [unsigned] long long
my $long_legacy = {
    DomainGetInfo               => { ret => { maxMem => 1, memory => 1 } },
    DomainMigrate               => { arg => { flags => 1, resource => 1 } },
    DomainMigrate2              => { arg => { flags => 1, resource => 1 } },
    DomainMigrateBegin3         => { arg => { flags => 1, resource => 1 } },
    DomainMigrateConfirm3       => { arg => { flags => 1, resource => 1 } },
    DomainMigrateDirect         => { arg => { flags => 1, resource => 1 } },
    DomainMigrateFinish         => { arg => { flags => 1 } },
    DomainMigrateFinish2        => { arg => { flags => 1 } },
    DomainMigrateFinish3        => { arg => { flags => 1 } },
    DomainMigratePeer2Peer      => { arg => { flags => 1, resource => 1 } },
    DomainMigratePerform        => { arg => { flags => 1, resource => 1 } },
    DomainMigratePerform3       => { arg => { flags => 1, resource => 1 } },
    DomainMigratePrepare        => { arg => { flags => 1, resource => 1 } },
    DomainMigratePrepare2       => { arg => { flags => 1, resource => 1 } },
    DomainMigratePrepare3       => { arg => { flags => 1, resource => 1 } },
    DomainMigratePrepareTunnel  => { arg => { flags => 1, resource => 1 } },
    DomainMigratePrepareTunnel3 => { arg => { flags => 1, resource => 1 } },
    DomainMigrateToURI          => { arg => { flags => 1, resource => 1 } },
    DomainMigrateToURI2         => { arg => { flags => 1, resource => 1 } },
    DomainMigrateVersion1       => { arg => { flags => 1, resource => 1 } },
    DomainMigrateVersion2       => { arg => { flags => 1, resource => 1 } },
    DomainMigrateVersion3       => { arg => { flags => 1, resource => 1 } },
    DomainMigrateSetMaxSpeed    => { arg => { bandwidth => 1 } },
    DomainSetMaxMemory          => { arg => { memory => 1 } },
    DomainSetMemory             => { arg => { memory => 1 } },
    DomainSetMemoryFlags        => { arg => { memory => 1 } },
323 324
    ConnectGetLibVersion        => { ret => { lib_ver => 1 } },
    ConnectGetVersion           => { ret => { hv_ver => 1 } },
325
    NodeGetInfo                 => { ret => { memory => 1 } },
326
    DomainBlockCommit           => { arg => { bandwidth => 1 } },
327
    DomainBlockPull             => { arg => { bandwidth => 1 } },
328
    DomainBlockRebase           => { arg => { bandwidth => 1 } },
329
    DomainBlockJobSetSpeed      => { arg => { bandwidth => 1 } },
330
    DomainMigrateGetMaxSpeed    => { ret => { bandwidth => 1 } },
331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347
};

sub hyper_to_long
{
    my $proc_name = shift;
    my $ret_or_arg = shift;
    my $member = shift;

    if ($long_legacy->{$proc_name} and
        $long_legacy->{$proc_name}->{$ret_or_arg} and
        $long_legacy->{$proc_name}->{$ret_or_arg}->{$member}) {
        return 1;
    } else {
        return 0
    }
}

348 349 350
#----------------------------------------------------------------------
# Output

351 352
if ($mode eq "aclsym") {
    print <<__EOF__;
353
# Automatically generated from $protocol by gendispatch.pl.
354 355
# Do not edit this file.  Any changes you make will be lost.
__EOF__
356 357 358
} elsif ($mode eq "aclapi") {
    print <<__EOF__;
<!--
359
  -  Automatically generated from $protocol by gendispatch.pl.
360 361 362
  -  Do not edit this file.  Any changes you make will be lost.
  -->
__EOF__
363 364
} else {
    print <<__EOF__;
365
/* Automatically generated from $protocol by gendispatch.pl.
366 367 368
 * Do not edit this file.  Any changes you make will be lost.
 */
__EOF__
369
}
370 371

# Debugging.
372
if ($mode eq "debug") {
373 374 375 376 377
    my @keys = sort (keys %calls);
    foreach (@keys) {
        print "$_:\n";
        print "        name $calls{$_}->{name} ($calls{$_}->{ProcName})\n";
        print "        $calls{$_}->{args} -> $calls{$_}->{ret}\n";
378
        print "        priority -> $calls{$_}->{priority}\n";
379 380 381
    }
}

382
# Bodies for dispatch functions ("remote_dispatch_bodies.h").
383
elsif ($mode eq "server") {
384
    my %generate = map { $_ => 1 } @autogen;
385 386 387
    my @keys = sort (keys %calls);

    foreach (@keys) {
388 389
        my $call = $calls{$_};

390
        # skip things which are REMOTE_MESSAGE
391
        next if $call->{msg};
392

393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439
        my $name = $structprefix . "Dispatch" . $call->{ProcName};
        my $argtype = $call->{args};
        my $rettype = $call->{ret};

        my $argann = $argtype ne "void" ? "" : " ATTRIBUTE_UNUSED";
        my $retann = $rettype ne "void" ? "" : " ATTRIBUTE_UNUSED";

        # First we print out a function declaration for the
        # real dispatcher body
        print "static int ${name}(\n";
        print "    virNetServerPtr server,\n";
        print "    virNetServerClientPtr client,\n";
        print "    virNetMessagePtr msg,\n";
        print "    virNetMessageErrorPtr rerr";
        if ($argtype ne "void") {
            print ",\n    $argtype *args";
        }
        if ($rettype ne "void") {
            print ",\n    $rettype *ret";
        }
        print ");\n";


        # Next we print out a generic wrapper method which has
        # fixed function signature, for use in the dispatcher
        # table. This simply callers the real dispatcher method
        print "static int ${name}Helper(\n";
        print "    virNetServerPtr server,\n";
        print "    virNetServerClientPtr client,\n";
        print "    virNetMessagePtr msg,\n";
        print "    virNetMessageErrorPtr rerr,\n";
        print "    void *args$argann,\n";
        print "    void *ret$retann)\n";
        print "{\n";
        print "  VIR_DEBUG(\"server=%p client=%p msg=%p rerr=%p args=%p ret=%p\", server, client, msg, rerr, args, ret);\n";
        print "  return $name(server, client, msg, rerr";
        if ($argtype ne "void") {
            print ", args";
        }
        if ($rettype ne "void") {
            print ", ret";
        }
        print ");\n";
        print "}\n";

        # Finally we print out the dispatcher method body impl
        # (if possible)
440 441 442 443 444
        if (!exists($generate{$call->{ProcName}})) {
            print "/* ${structprefix}Dispatch$call->{ProcName} body has " .
                  "to be implemented manually */\n\n\n\n";
            next;
        }
445 446 447

        my $has_node_device = 0;
        my @vars_list = ();
448
        my @optionals_list = ();
449 450
        my @getters_list = ();
        my @args_list = ();
451
        my @prepare_ret_list = ();
452
        my @ret_list = ();
453
        my @free_list = ();
454
        my @free_list_on_error = ("virNetMessageSaveError(rerr);");
455

456
        # handle arguments to the function
457
        if ($argtype ne "void") {
458
            # node device is special, as it's identified by name
459 460
            if ($argtype =~ m/^remote_node_device_/ and
                !($argtype =~ m/^remote_node_device_lookup_by_name_/) and
O
Osier Yang 已提交
461 462
                !($argtype =~ m/^remote_node_device_create_xml_/) and
                !($argtype =~ m/^remote_node_device_lookup_scsi_host_by_wwn_/)) {
463 464 465
                $has_node_device = 1;
                push(@vars_list, "virNodeDevicePtr dev = NULL");
                push(@getters_list,
466
                     "    if (!(dev = virNodeDeviceLookupByName(priv->conn, args->name)))\n" .
467 468 469 470 471 472 473
                     "        goto cleanup;\n");
                push(@args_list, "dev");
                push(@free_list,
                     "    if (dev)\n" .
                     "        virNodeDeviceFree(dev);");
            }

474
            foreach my $args_member (@{$call->{args_members}}) {
475 476 477
                if ($args_member =~ m/^remote_nonnull_string name;/ and $has_node_device) {
                    # ignore the name arg for node devices
                    next
478
                } elsif ($args_member =~ m/^remote_nonnull_(domain|network|storage_pool|storage_vol|interface|secret|nwfilter) (\S+);/) {
479
                    my $type_name = name_to_TypeName($1);
480 481

                    push(@vars_list, "vir${type_name}Ptr $2 = NULL");
482
                    push(@getters_list,
483
                         "    if (!($2 = get_nonnull_$1(priv->conn, args->$2)))\n" .
484
                         "        goto cleanup;\n");
485
                    push(@args_list, "$2");
486
                    push(@free_list,
487 488
                         "    if ($2)\n" .
                         "        vir${type_name}Free($2);");
489 490 491 492
                } elsif ($args_member =~ m/^remote_nonnull_domain_snapshot /) {
                    push(@vars_list, "virDomainPtr dom = NULL");
                    push(@vars_list, "virDomainSnapshotPtr snapshot = NULL");
                    push(@getters_list,
493
                         "    if (!(dom = get_nonnull_domain(priv->conn, args->snap.dom)))\n" .
494 495 496 497 498 499 500 501 502 503
                         "        goto cleanup;\n" .
                         "\n" .
                         "    if (!(snapshot = get_nonnull_domain_snapshot(dom, args->snap)))\n" .
                         "        goto cleanup;\n");
                    push(@args_list, "snapshot");
                    push(@free_list,
                         "    if (snapshot)\n" .
                         "        virDomainSnapshotFree(snapshot);\n" .
                         "    if (dom)\n" .
                         "        virDomainFree(dom);");
504
                } elsif ($args_member =~ m/^(?:remote_string|remote_uuid) (\S+)<\S+>;/) {
505
                    if (! @args_list) {
506
                        push(@args_list, "priv->conn");
507 508
                    }

509 510 511 512
                    push(@args_list, "args->$1.$1_val");
                    push(@args_list, "args->$1.$1_len");
                } elsif ($args_member =~ m/^(?:opaque|remote_nonnull_string) (\S+)<\S+>;(.*)$/) {
                    if (! @args_list) {
513
                        push(@args_list, "priv->conn");
514 515
                    }

516 517 518 519 520 521 522 523 524 525 526 527 528 529
                    my $cast = "";
                    my $arg_name = $1;
                    my $annotation = $2;

                    if ($annotation ne "") {
                        if ($annotation =~ m/\s*\/\*\s*(.*)\s*\*\//) {
                            $cast = $1;
                        } else {
                            die "malformed cast annotation for argument: $args_member";
                        }
                    }

                    push(@args_list, "${cast}args->$arg_name.${arg_name}_val");
                    push(@args_list, "args->$arg_name.${arg_name}_len");
530 531
                } elsif ($args_member =~ m/^(?:unsigned )?int (\S+)<\S+>;/) {
                    if (! @args_list) {
532
                        push(@args_list, "priv->conn");
533 534 535 536
                    }

                    push(@args_list, "args->$1.$1_val");
                    push(@args_list, "args->$1.$1_len");
537 538
                } elsif ($args_member =~ m/^remote_typed_param (\S+)<(\S+)>;/) {
                    push(@vars_list, "virTypedParameterPtr $1 = NULL");
539
                    push(@vars_list, "int n$1 = 0;");
540 541 542
                    if ($call->{ProcName} eq "NodeSetMemoryParameters") {
                        push(@args_list, "priv->conn");
                    }
543 544 545 546 547 548 549
                    push(@args_list, "$1");
                    push(@args_list, "n$1");
                    push(@getters_list, "    if (($1 = remoteDeserializeTypedParameters(args->$1.$1_val,\n" .
                                        "                                                   args->$1.$1_len,\n" .
                                        "                                                   $2,\n" .
                                        "                                                   &n$1)) == NULL)\n" .
                                        "        goto cleanup;\n");
550
                    push(@free_list, "    virTypedParamsFree($1, n$1);");
551 552 553 554
                } elsif ($args_member =~ m/<\S+>;/ or $args_member =~ m/\[\S+\];/) {
                    # just make all other array types fail
                    die "unhandled type for argument value: $args_member";
                } elsif ($args_member =~ m/^remote_uuid (\S+);/) {
555
                    if (! @args_list) {
556
                        push(@args_list, "priv->conn");
557 558
                    }

559 560 561
                    push(@args_list, "(unsigned char *) args->$1");
                } elsif ($args_member =~ m/^remote_string (\S+);/) {
                    if (! @args_list) {
562
                        push(@args_list, "priv->conn");
563
                    }
564 565 566 567 568 569

                    push(@vars_list, "char *$1");
                    push(@optionals_list, "$1");
                    push(@args_list, "$1");
                } elsif ($args_member =~ m/^remote_nonnull_string (\S+);/) {
                    if (! @args_list) {
570
                        push(@args_list, "priv->conn");
571 572 573
                    }

                    push(@args_list, "args->$1");
574
                } elsif ($args_member =~ m/^(unsigned )?int (\S+);/) {
575
                    if (! @args_list) {
576
                        push(@args_list, "priv->conn");
577 578
                    }

579 580 581
                    push(@args_list, "args->$2");
                } elsif ($args_member =~ m/^(unsigned )?hyper (\S+);/) {
                    if (! @args_list) {
582
                        push(@args_list, "priv->conn");
583 584 585 586 587 588 589 590 591 592 593 594 595 596
                    }

                    my $arg_name = $2;

                    if (hyper_to_long($call->{ProcName}, "arg", $arg_name)) {
                        my $type_name = $1; $type_name .= "long";
                        my $sign = ""; $sign = "U" if ($1);

                        push(@vars_list, "$type_name $arg_name");
                        push(@getters_list, "    HYPER_TO_${sign}LONG($arg_name, args->$arg_name);\n");
                        push(@args_list, "$arg_name");
                    } else {
                        push(@args_list, "args->$arg_name");
                    }
597
                } elsif ($args_member =~ m/^(\/)?\*/) {
598 599 600
                    # ignore comments
                } else {
                    die "unhandled type for argument value: $args_member";
601 602 603 604
                }
            }
        }

605
        # handle return values of the function
606 607 608
        my $single_ret_var = "undefined";
        my $single_ret_by_ref = 0;
        my $single_ret_check = " == undefined";
609 610 611 612
        my $single_ret_as_list = 0;
        my $single_ret_list_name = "undefined";
        my $single_ret_list_max_var = "undefined";
        my $single_ret_list_max_define = "undefined";
613 614
        my $multi_ret = 0;

615
        if ($rettype ne "void" and
616
            scalar(@{$call->{ret_members}}) > 1) {
617 618
            $multi_ret = 1;
        }
619

620
        if ($rettype ne "void") {
621
            foreach my $ret_member (@{$call->{ret_members}}) {
622
                if ($multi_ret) {
623
                    if ($ret_member =~ m/^(unsigned )?(char|short|int|hyper) (\S+)\[\S+\];/) {
624 625 626 627
                        if ($2 eq "hyper" and hyper_to_long($call->{ProcName}, "ret", $3)) {
                            die "legacy [u]long hyper arrays aren't supported";
                        }

628
                        push(@ret_list, "memcpy(ret->$3, tmp.$3, sizeof(ret->$3));");
629 630
                    } elsif ($ret_member =~ m/^(unsigned )?(char|short|int|hyper) (\S+);/) {
                        push(@ret_list, "ret->$3 = tmp.$3;");
631 632 633
                    } else {
                        die "unhandled type for multi-return-value: $ret_member";
                    }
634
                } elsif ($ret_member =~ m/^remote_nonnull_string (\S+)<(\S+)>;\s*\/\*\s*insert@(\d+)\s*\*\//) {
635
                    push(@vars_list, "int len");
636
                    splice(@args_list, int($3), 0, ("ret->$1.$1_val"));
637
                    push(@ret_list, "ret->$1.$1_len = len;");
638
                    push(@free_list_on_error, "VIR_FREE(ret->$1.$1_val);");
639 640 641 642 643 644 645
                    $single_ret_var = "len";
                    $single_ret_by_ref = 0;
                    $single_ret_check = " < 0";
                    $single_ret_as_list = 1;
                    $single_ret_list_name = $1;
                    $single_ret_list_max_var = "max$1";
                    $single_ret_list_max_define = $2;
646 647 648
                } elsif ($ret_member =~ m/^remote_nonnull_string (\S+)<\S+>;/) {
                    # error out on unannotated arrays
                    die "remote_nonnull_string array without insert@<offset> annotation: $ret_member";
649
                } elsif ($ret_member =~ m/^remote_nonnull_string (\S+);/) {
650
                    if ($call->{ProcName} eq "ConnectGetType") {
651 652 653
                        # SPECIAL: virConnectGetType returns a constant string that must
                        #          not be freed. Therefore, duplicate the string here.
                        push(@vars_list, "const char *$1");
654
                        push(@ret_list, "/* We have to VIR_STRDUP because remoteDispatchClientRequest will");
655
                        push(@ret_list, " * free this string after it's been serialised. */");
656
                        push(@ret_list, "if (VIR_STRDUP(ret->type, type) < 0)");
657 658 659 660 661 662
                        push(@ret_list, "    goto cleanup;");
                    } else {
                        push(@vars_list, "char *$1");
                        push(@ret_list, "ret->$1 = $1;");
                    }

663 664 665 666 667 668 669 670 671 672
                    $single_ret_var = $1;
                    $single_ret_by_ref = 0;
                    $single_ret_check = " == NULL";
                } elsif ($ret_member =~ m/^remote_string (\S+);/) {
                    push(@vars_list, "char *$1 = NULL");
                    push(@vars_list, "char **$1_p = NULL");
                    push(@ret_list, "ret->$1 = $1_p;");
                    push(@free_list, "    VIR_FREE($1);");
                    push(@free_list_on_error, "VIR_FREE($1_p);");
                    push(@prepare_ret_list,
673
                         "if (VIR_ALLOC($1_p) < 0)\n" .
674 675
                         "        goto cleanup;\n" .
                         "    \n" .
676 677
                         "    if (VIR_STRDUP(*$1_p, $1) < 0)\n".
                         "        goto cleanup;\n");
678

679 680 681
                    $single_ret_var = $1;
                    $single_ret_by_ref = 0;
                    $single_ret_check = " == NULL";
682
                } elsif ($ret_member =~ m/^remote_nonnull_(domain|network|storage_pool|storage_vol|interface|node_device|secret|nwfilter|domain_snapshot) (\S+);/) {
683
                    my $type_name = name_to_TypeName($1);
684

685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700
                    if ($call->{ProcName} eq "DomainCreateWithFlags") {
                        # SPECIAL: virDomainCreateWithFlags updates the given
                        #          domain object instead of returning a new one
                        push(@ret_list, "make_nonnull_$1(&ret->$2, $2);");
                        $single_ret_var = undef;
                        $single_ret_by_ref = 1;
                    } else {
                        push(@vars_list, "vir${type_name}Ptr $2 = NULL");
                        push(@ret_list, "make_nonnull_$1(&ret->$2, $2);");
                        push(@free_list,
                             "    if ($2)\n" .
                             "        vir${type_name}Free($2);");
                        $single_ret_var = $2;
                        $single_ret_by_ref = 0;
                        $single_ret_check = " == NULL";
                    }
701
                } elsif ($ret_member =~ m/^int (\S+)<(\S+)>;\s*\/\*\s*insert@(\d+)\s*\*\//) {
702
                    push(@vars_list, "int len");
703
                    splice(@args_list, int($3), 0, ("ret->$1.$1_val"));
704
                    push(@ret_list, "ret->$1.$1_len = len;");
705
                    push(@free_list_on_error, "VIR_FREE(ret->$1.$1_val);");
706 707 708 709 710 711 712
                    $single_ret_var = "len";
                    $single_ret_by_ref = 0;
                    $single_ret_check = " < 0";
                    $single_ret_as_list = 1;
                    $single_ret_list_name = $1;
                    $single_ret_list_max_var = "max$1";
                    $single_ret_list_max_define = $2;
713 714 715
                } elsif ($ret_member =~ m/^int (\S+)<\S+>;/) {
                    # error out on unannotated arrays
                    die "int array without insert@<offset> annotation: $ret_member";
716
                } elsif ($ret_member =~ m/^int (\S+);/) {
717 718 719 720
                    push(@vars_list, "int $1");
                    push(@ret_list, "ret->$1 = $1;");
                    $single_ret_var = $1;

721
                    if ($call->{ProcName} =~ m/GetAutostart$/) {
722 723 724
                        $single_ret_by_ref = 1;
                    } else {
                        $single_ret_by_ref = 0;
725

726
                        if ($call->{ProcName} eq "CPUCompare") {
727 728 729 730
                            $single_ret_check = " == VIR_CPU_COMPARE_ERROR";
                        } else {
                            $single_ret_check = " < 0";
                        }
731
                    }
732
                } elsif ($ret_member =~ m/^(?:unsigned )?hyper (\S+)<(\S+)>;\s*\/\*\s*insert@(\d+)\s*\*\//) {
733 734 735 736
                    if (hyper_to_long($call->{ProcName}, "ret", $1)) {
                        die "legacy [u]long hyper arrays aren't supported";
                    }

737 738
                    push(@vars_list, "int len");
                    push(@ret_list, "ret->$1.$1_len = len;");
739
                    push(@free_list_on_error, "VIR_FREE(ret->$1.$1_val);");
740 741 742 743
                    $single_ret_var = "len";
                    $single_ret_by_ref = 0;
                    $single_ret_as_list = 1;
                    $single_ret_list_name = $1;
744
                    $single_ret_list_max_var = "max$1";
745 746
                    $single_ret_list_max_define = $2;

747
                    if ($call->{ProcName} eq "NodeGetCellsFreeMemory") {
748
                        $single_ret_check = " <= 0";
749
                        splice(@args_list, int($3), 0, ("(unsigned long long *)ret->$1.$1_val"));
750 751
                    } else {
                        $single_ret_check = " < 0";
752
                        splice(@args_list, int($3), 0, ("ret->$1.$1_val"));
753
                    }
754
                } elsif ($ret_member =~ m/^(?:unsigned )?hyper (\S+)<\S+>;/) {
755 756
                    # error out on unannotated arrays
                    die "hyper array without insert@<offset> annotation: $ret_member";
757
                } elsif ($ret_member =~ m/^(unsigned )?hyper (\S+);(?:\s*\/\*\s*insert@(\d+)\s*\*\/)?/) {
758
                    my $type_name = $1;
759
                    my $ret_name = $2;
760
                    my $ret_assign;
761
                    my $insert = $3;
762

763 764 765 766 767 768 769 770 771
                    if (hyper_to_long($call->{ProcName}, "ret", $ret_name)) {
                        my $sign = ""; $sign = "U" if ($1);

                        $type_name .= "long";
                        $ret_assign = "HYPER_TO_${sign}LONG(ret->$ret_name, $ret_name);";
                    } else {
                        $type_name .= "long long";
                        $ret_assign = "ret->$ret_name = $ret_name;";
                    }
772 773

                    push(@vars_list, "$type_name $ret_name");
774
                    push(@ret_list, $ret_assign);
775 776 777 778 779 780 781

                    if ($insert) {
                        splice(@args_list, int($insert), 0, "&$ret_name");
                        $single_ret_var = undef;
                    } else {
                        $single_ret_var = $ret_name;
                    }
782

783 784
                    if ($call->{ProcName} eq "DomainGetMaxMemory" or
                        $call->{ProcName} eq "NodeGetFreeMemory") {
785 786 787
                        # SPECIAL: virDomainGetMaxMemory and virNodeGetFreeMemory
                        #          return the actual value directly and 0 indicates
                        #          an error
788 789 790 791 792
                        $single_ret_by_ref = 0;
                        $single_ret_check = " == 0";
                    } else {
                        $single_ret_by_ref = 1;
                    }
793 794 795 796 797 798 799 800 801 802 803 804
                } elsif ($ret_member =~ m/^opaque (\S+)<(\S+)>;\s*\/\*\s*insert@(\d+)\s*\*\//) {
                    push(@vars_list, "char *$1 = NULL");
                    push(@vars_list, "int $1_len = 0");
                    splice(@args_list, int($3), 0, ("&$1", "&$1_len"));
                    push(@ret_list, "ret->$1.$1_val = $1;");
                    push(@ret_list, "ret->$1.$1_len = $1_len;");
                    push(@free_list_on_error, "VIR_FREE($1);");
                    $single_ret_var = undef;
                    $single_ret_by_ref = 1;
                } elsif ($ret_member =~ m/^opaque (\S+)<\S+>;/) {
                    # error out on unannotated arrays
                    die "opaque array without insert@<offset> annotation: $ret_member";
805 806
                } elsif ($ret_member =~ m/^(\/)?\*/) {
                    # ignore comments
807 808
                } else {
                    die "unhandled type for return value: $ret_member";
809 810 811 812
                }
            }
        }

813
        # select struct type for multi-return-value functions
814
        if ($multi_ret) {
815 816 817 818
            if (!(defined $call->{ret_offset})) {
                die "multi-return-value without insert@<offset> annotation: $call->{ret}";
            }

819 820
            if (! @args_list) {
                push(@args_list, "priv->conn");
821 822
            }

823
            my $struct_name = $call->{ProcName};
824 825
            $struct_name =~ s/Get//;

826 827 828 829
            splice(@args_list, $call->{ret_offset}, 0, ("&tmp"));

            if ($call->{ProcName} eq "DomainBlockStats" ||
                $call->{ProcName} eq "DomainInterfaceStats") {
830 831 832
                # SPECIAL: virDomainBlockStats and virDomainInterfaceStats
                #          have a 'Struct' suffix on the actual struct name
                #          and take the struct size as additional argument
833
                $struct_name .= "Struct";
834
                splice(@args_list, $call->{ret_offset} + 1, 0, ("sizeof(tmp)"));
835 836 837 838 839
            }

            push(@vars_list, "vir$struct_name tmp");
        }

840
        if ($call->{streamflag} ne "none") {
841
            splice(@args_list, $call->{streamoffset}, 0, ("st"));
842
            push(@free_list_on_error, "if (stream) {");
843 844 845 846
            push(@free_list_on_error, "    virStreamAbort(st);");
            push(@free_list_on_error, "    daemonFreeClientStream(client, stream);");
            push(@free_list_on_error, "} else {");
            push(@free_list_on_error, "    virStreamFree(st);");
847 848 849
            push(@free_list_on_error, "}");
        }

850
        # print functions signature
851 852 853 854 855
        print "static int $name(\n";
        print "    virNetServerPtr server ATTRIBUTE_UNUSED,\n";
        print "    virNetServerClientPtr client,\n";
        print "    virNetMessagePtr msg ATTRIBUTE_UNUSED,\n";
        print "    virNetMessageErrorPtr rerr";
856
        if ($argtype ne "void") {
857 858
            print ",\n    $argtype *args";
        }
859
        if ($rettype ne "void") {
860 861 862
            print ",\n    $rettype *ret";
        }
        print ")\n";
863 864 865 866 867

        # print function body
        print "{\n";
        print "    int rv = -1;\n";

868 869 870
        foreach my $var (@vars_list) {
            print "    $var;\n";
        }
871
        print "    struct daemonClientPrivate *priv =\n";
872
        print "        virNetServerClientGetPrivateData(client);\n";
873

874
        if ($call->{streamflag} ne "none") {
875 876
            print "    virStreamPtr st = NULL;\n";
            print "    daemonClientStreamPtr stream = NULL;\n";
877 878
        }

879
        print "\n";
880
        print "    if (!priv->conn) {\n";
881
        print "        virReportError(VIR_ERR_INTERNAL_ERROR, \"%s\", _(\"connection not open\"));\n";
882 883 884 885
        print "        goto cleanup;\n";
        print "    }\n";
        print "\n";

886 887
        if ($single_ret_as_list) {
            print "    if (args->$single_ret_list_max_var > $single_ret_list_max_define) {\n";
888 889
            print "        virReportError(VIR_ERR_INTERNAL_ERROR,\n";
            print "                       \"%s\", _(\"max$single_ret_list_name > $single_ret_list_max_define\"));\n";
890 891 892 893 894
            print "        goto cleanup;\n";
            print "    }\n";
            print "\n";
        }

895 896
        print join("\n", @getters_list);

897 898 899
        if (@getters_list) {
            print "\n";
        }
900

901 902 903 904 905 906 907 908
        foreach my $optional (@optionals_list) {
            print "    $optional = args->$optional ? *args->$optional : NULL;\n";
        }

        if (@optionals_list) {
            print "\n";
        }

909
        if ($call->{streamflag} ne "none") {
910 911 912
            print "    if (!(st = virStreamNew(priv->conn, VIR_STREAM_NONBLOCK)))\n";
            print "        goto cleanup;\n";
            print "\n";
913
            print "    if (!(stream = daemonCreateClientStream(client, st, remoteProgram, &msg->header)))\n";
914 915 916 917
            print "        goto cleanup;\n";
            print "\n";
        }

918
        if ($rettype eq "void") {
919
            print "    if (vir$call->{ProcName}(";
920 921 922 923
            print join(', ', @args_list);
            print ") < 0)\n";
            print "        goto cleanup;\n";
            print "\n";
924
        } elsif (!$multi_ret) {
925
            my $prefix = "";
926
            my $proc_name = $call->{ProcName};
927 928

            if (! @args_list) {
929
                push(@args_list, "priv->conn");
930 931
            }

932 933 934
            if ($structprefix eq "qemu" &&
                $call->{ProcName} =~ /^(Connect)?Domain/) {
                $proc_name =~ s/^((Connect)?Domain)/${1}Qemu/;
935
            }
936 937 938
            if ($structprefix eq "lxc" && $call->{ProcName} =~ /^Domain/) {
                $proc_name =~ s/^(Domain)/${1}Lxc/;
            }
939

940 941 942
            if ($single_ret_as_list) {
                print "    /* Allocate return buffer. */\n";
                print "    if (VIR_ALLOC_N(ret->$single_ret_list_name.${single_ret_list_name}_val," .
943
                      " args->$single_ret_list_max_var) < 0)\n";
944 945 946 947
                print "        goto cleanup;\n";
                print "\n";
            }

948 949 950
            if ($single_ret_by_ref) {
                print "    if (vir$prefix$proc_name(";
                print join(', ', @args_list);
951 952 953 954 955 956

                if (defined $single_ret_var) {
                    print ", &$single_ret_var";
                }

                print ") < 0)\n";
957 958 959 960 961 962 963 964
            } else {
                print "    if (($single_ret_var = vir$prefix$proc_name(";
                print join(', ', @args_list);
                print "))$single_ret_check)\n";
            }

            print "        goto cleanup;\n";
            print "\n";
965
        } else {
966
            print "    if (vir$call->{ProcName}(";
967 968 969 970
            print join(', ', @args_list);
            print ") < 0)\n";
            print "        goto cleanup;\n";
            print "\n";
971
        }
972

973
        if ($call->{streamflag} ne "none") {
974
            print "    if (daemonAddClientStream(client, stream, ";
975 976

            if ($call->{streamflag} eq "write") {
977
                print "false";
978
            } else {
979
                print "true";
980 981
            }

982 983 984 985 986
            print ") < 0)\n";
            print "        goto cleanup;\n";
            print "\n";
        }

987 988 989 990 991 992
        if (@prepare_ret_list) {
            print "    ";
            print join("\n    ", @prepare_ret_list);
            print "\n";
        }

993 994
        if (@ret_list) {
            print "    ";
995
            print join("\n    ", @ret_list);
996
            print "\n";
997 998 999 1000 1001
        }

        print "    rv = 0;\n";
        print "\n";
        print "cleanup:\n";
1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014
        print "    if (rv < 0)";

        if (scalar(@free_list_on_error) > 1) {
            print " {";
        }

        print "\n        ";
        print join("\n        ", @free_list_on_error);
        print "\n";

        if (scalar(@free_list_on_error) > 1) {
            print "    }\n";
        }
1015 1016 1017

        print join("\n", @free_list);

1018 1019 1020 1021
        if (@free_list) {
            print "\n";
        }

1022
        print "    return rv;\n";
1023
        print "}\n\n\n\n";
1024
    }
1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035


    # Finally we write out the huge dispatch table which lists
    # the dispatch helper method. the XDR proc for processing
    # args and return values, and the size of the args and
    # return value structs. All methods are marked as requiring
    # authentication. Methods are selectively relaxed in the
    # daemon code which registers the program.

    print "virNetServerProgramProc ${structprefix}Procs[] = {\n";
    for ($id = 0 ; $id <= $#calls ; $id++) {
1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057
        my ($comment, $name, $argtype, $arglen, $argfilter, $retlen, $retfilter, $priority);

        if (defined $calls[$id] && !$calls[$id]->{msg}) {
            $comment = "/* Method $calls[$id]->{ProcName} => $id */";
            $name = $structprefix . "Dispatch" . $calls[$id]->{ProcName} . "Helper";
            my $argtype = $calls[$id]->{args};
            my $rettype = $calls[$id]->{ret};
            $arglen = $argtype ne "void" ? "sizeof($argtype)" : "0";
            $retlen = $rettype ne "void" ? "sizeof($rettype)" : "0";
            $argfilter = $argtype ne "void" ? "xdr_$argtype" : "xdr_void";
            $retfilter = $rettype ne "void" ? "xdr_$rettype" : "xdr_void";
        } else {
            if ($calls[$id]->{msg}) {
                $comment = "/* Async event $calls[$id]->{ProcName} => $id */";
            } else {
                $comment = "/* Unused $id */";
            }
            $name = "NULL";
            $arglen = $retlen = 0;
            $argfilter = "xdr_void";
            $retfilter = "xdr_void";
        }
1058

1059 1060
    $priority = defined $calls[$id]->{priority} ? $calls[$id]->{priority} : 0;

1061
        print "{ $comment\n   ${name},\n   $arglen,\n   (xdrproc_t)$argfilter,\n   $retlen,\n   (xdrproc_t)$retfilter,\n   true,\n   $priority\n},\n";
1062 1063 1064
    }
    print "};\n";
    print "size_t ${structprefix}NProcs = ARRAY_CARDINALITY(${structprefix}Procs);\n";
1065
}
1066

1067
# Bodies for client functions ("remote_client_bodies.h").
1068
elsif ($mode eq "client") {
1069
    my %generate = map { $_ => 1 } @autogen;
1070 1071 1072 1073 1074 1075 1076 1077
    my @keys = sort (keys %calls);

    foreach (@keys) {
        my $call = $calls{$_};

        # skip things which are REMOTE_MESSAGE
        next if $call->{msg};

1078 1079
        # skip procedures not on generate list
        next if ! exists($generate{$call->{ProcName}});
1080

1081 1082
        my $argtype = $call->{args};
        my $rettype = $call->{ret};
1083

1084
        # handle arguments to the function
1085 1086
        my @args_list = ();
        my @vars_list = ();
1087
        my @args_check_list = ();
1088
        my @setters_list = ();
1089
        my @setters_list2 = ();
1090
        my @free_list = ();
1091 1092
        my $priv_src = "conn";
        my $priv_name = "privateData";
1093
        my $call_args = "&args";
1094

1095
        if ($argtype eq "void") {
1096
            $call_args = "NULL";
1097
        } else {
1098
            push(@vars_list, "$argtype args");
1099 1100 1101 1102 1103

            my $is_first_arg = 1;
            my $has_node_device = 0;

            # node device is special
1104 1105 1106
            if ($argtype =~ m/^remote_node_/ and
                !($argtype =~ m/^remote_node_device_lookup_by_name_/) and
                !($argtype =~ m/^remote_node_device_create_xml_/)) {
1107
                $has_node_device = 1;
1108
                $priv_name = "nodeDevicePrivateData";
1109 1110 1111 1112 1113 1114 1115 1116 1117
            }

            foreach my $args_member (@{$call->{args_members}}) {
                if ($args_member =~ m/^remote_nonnull_string name;/ and $has_node_device) {
                    $priv_src = "dev->conn";
                    push(@args_list, "virNodeDevicePtr dev");
                    push(@setters_list, "args.name = dev->name;");
                } elsif ($args_member =~ m/^remote_nonnull_(domain|network|storage_pool|storage_vol|interface|secret|nwfilter|domain_snapshot) (\S+);/) {
                    my $name = $1;
1118
                    my $arg_name = $2;
1119
                    my $type_name = name_to_TypeName($name);
1120 1121 1122

                    if ($is_first_arg) {
                        if ($name eq "domain_snapshot") {
1123
                            $priv_src = "$arg_name->domain->conn";
1124
                        } else {
1125
                            $priv_src = "$arg_name->conn";
1126 1127 1128 1129 1130 1131 1132 1133 1134
                        }

                        if ($name =~ m/^storage_/) {
                            $priv_name = "storagePrivateData";
                        } elsif (!($name =~ m/^domain/)) {
                            $priv_name = "${name}PrivateData";
                        }
                    }

1135 1136 1137 1138 1139
                    push(@args_list, "vir${type_name}Ptr $arg_name");
                    push(@setters_list, "make_nonnull_$1(&args.$arg_name, $arg_name);");
                } elsif ($args_member =~ m/^remote_uuid (\S+);/) {
                    push(@args_list, "const unsigned char *$1");
                    push(@setters_list, "memcpy(args.$1, $1, VIR_UUID_BUFLEN);");
1140 1141 1142
                } elsif ($args_member =~ m/^remote_string (\S+);/) {
                    push(@args_list, "const char *$1");
                    push(@setters_list, "args.$1 = $1 ? (char **)&$1 : NULL;");
1143 1144 1145 1146 1147 1148 1149 1150 1151 1152 1153 1154 1155 1156 1157 1158 1159 1160 1161
                } elsif ($args_member =~ m/^remote_nonnull_string (\S+)<(\S+)>;(.*)$/) {
                    my $type_name = "const char **";
                    my $arg_name = $1;
                    my $limit = $2;
                    my $annotation = $3;

                    if ($annotation ne "") {
                        if ($annotation =~ m/\s*\/\*\s*\((.*)\)\s*\*\//) {
                            $type_name = $1;
                        } else {
                            die "malformed cast annotation for argument: $args_member";
                        }
                    }

                    push(@args_list, "$type_name$arg_name");
                    push(@args_list, "unsigned int ${arg_name}len");
                    push(@setters_list, "args.$arg_name.${arg_name}_val = (char **)$arg_name;");
                    push(@setters_list, "args.$arg_name.${arg_name}_len = ${arg_name}len;");
                    push(@args_check_list, { name => "\"$arg_name\"", arg => "${arg_name}len", limit => $2 });
1162 1163 1164
                } elsif ($args_member =~ m/^remote_nonnull_string (\S+);/) {
                    push(@args_list, "const char *$1");
                    push(@setters_list, "args.$1 = (char *)$1;");
1165 1166 1167 1168 1169 1170 1171 1172 1173 1174 1175 1176 1177 1178 1179
                } elsif ($args_member =~ m/^opaque (\S+)<(\S+)>;(.*)$/) {
                    my $type_name = "const char *";
                    my $arg_name = $1;
                    my $limit = $2;
                    my $annotation = $3;

                    if ($annotation ne "") {
                        if ($annotation =~ m/\s*\/\*\s*\((.*)\)\s*\*\//) {
                            $type_name = $1;
                        } else {
                            die "malformed cast annotation for argument: $args_member";
                        }
                    }

                    push(@args_list, "$type_name$arg_name");
1180

1181
                    if ($call->{ProcName} eq "SecretSetValue") {
1182
                        # SPECIAL: virSecretSetValue uses size_t instead of int
1183
                        push(@args_list, "size_t ${arg_name}len");
1184
                    } else {
1185
                        push(@args_list, "int ${arg_name}len");
1186 1187
                    }

1188 1189 1190 1191 1192 1193 1194 1195 1196
                    push(@setters_list, "args.$arg_name.${arg_name}_val = (char *)$arg_name;");
                    push(@setters_list, "args.$arg_name.${arg_name}_len = ${arg_name}len;");
                    push(@args_check_list, { name => "\"$arg_name\"", arg => "${arg_name}len", limit => $limit });
                } elsif ($args_member =~ m/^remote_string (\S+)<(\S+)>;/) {
                    my $arg_name = $1;
                    my $limit = $2;

                    push(@args_list, "const char *$arg_name");
                    push(@args_list, "int ${arg_name}len");
1197 1198 1199
                    push(@setters_list, "args.$arg_name.${arg_name}_val = (char *)$arg_name;");
                    push(@setters_list, "args.$arg_name.${arg_name}_len = ${arg_name}len;");
                    push(@args_check_list, { name => "\"$arg_name\"", arg => "${arg_name}len", limit => $limit });
1200 1201 1202 1203 1204 1205
                } elsif ($args_member =~ m/^((?:unsigned )?int) (\S+)<(\S+)>;/) {
                    my $type_name = $1;
                    my $arg_name = $2;
                    my $limit = $3;

                    push(@args_list, "${type_name} *$arg_name");
1206
                    push(@args_list, "int ${arg_name}len");
1207 1208 1209
                    push(@setters_list, "args.$arg_name.${arg_name}_val = $arg_name;");
                    push(@setters_list, "args.$arg_name.${arg_name}_len = ${arg_name}len;");
                    push(@args_check_list, { name => "\"$arg_name\"", arg => "${arg_name}len", limit => $limit });
1210 1211 1212 1213 1214 1215 1216
                } elsif ($args_member =~ m/^remote_typed_param (\S+)<(\S+)>;/) {
                    push(@args_list, "virTypedParameterPtr $1");
                    push(@args_list, "int n$1");
                    push(@setters_list2, "if (remoteSerializeTypedParameters($1, n$1, &args.$1.$1_val, &args.$1.$1_len) < 0) {\n" .
                                         "        xdr_free((xdrproc_t)xdr_$call->{args}, (char *)&args);\n" .
                                         "        goto done;\n" .
                                         "    }");
1217
                    push(@free_list, "    remoteFreeTypedParameters(args.params.params_val, args.params.params_len);\n");
1218 1219
                } elsif ($args_member =~ m/^((?:unsigned )?int) (\S+);\s*\/\*\s*call-by-reference\s*\*\//) {
                    my $type_name = "$1 *";
1220 1221 1222 1223
                    my $arg_name = $2;

                    push(@args_list, "$type_name $arg_name");
                    push(@setters_list, "args.$arg_name = *$arg_name;");
1224 1225
                } elsif ($args_member =~ m/^((?:unsigned )?int) (\S+);/) {
                    my $type_name = $1;
1226 1227 1228 1229 1230 1231 1232 1233 1234 1235 1236 1237
                    my $arg_name = $2;

                    push(@args_list, "$type_name $arg_name");
                    push(@setters_list, "args.$arg_name = $arg_name;");
                } elsif ($args_member =~ m/^(unsigned )?hyper (\S+);/) {
                    my $type_name = $1;
                    my $arg_name = $2;

                    if (hyper_to_long($call->{ProcName}, "arg", $arg_name)) {
                        $type_name .= "long";
                    } else {
                        $type_name .= "long long";
1238 1239 1240 1241
                    }

                    push(@args_list, "$type_name $arg_name");
                    push(@setters_list, "args.$arg_name = $arg_name;");
1242
                } elsif ($args_member =~ m/^(\/)?\*/) {
1243 1244 1245 1246 1247 1248 1249 1250 1251 1252 1253 1254 1255
                    # ignore comments
                } else {
                    die "unhandled type for argument value: $args_member";
                }

                if ($is_first_arg and $priv_src eq "conn") {
                    unshift(@args_list, "virConnectPtr conn");
                }

                $is_first_arg = 0;
            }
        }

1256 1257 1258 1259
        if (! @args_list) {
            push(@args_list, "virConnectPtr conn");
        }

1260 1261
        # fix priv_name for the NumOf* functions
        if ($priv_name eq "privateData" and
1262 1263 1264
            !($call->{ProcName} =~ m/(Domains|DomainSnapshot)/) and
            ($call->{ProcName} =~ m/NumOf(Defined|Domain)*(\S+)s/ or
             $call->{ProcName} =~ m/List(Defined|Domain)*(\S+)s/)) {
1265 1266 1267 1268 1269
            my $prefix = lc $2;
            $prefix =~ s/(pool|vol)$//;
            $priv_name = "${prefix}PrivateData";
        }

1270 1271
        # handle return values of the function
        my @ret_list = ();
1272
        my @ret_list2 = ();
1273 1274 1275
        my $call_ret = "&ret";
        my $single_ret_var = "int rv = -1";
        my $single_ret_type = "int";
1276 1277 1278 1279 1280
        my $single_ret_as_list = 0;
        my $single_ret_list_error_msg_type = "undefined";
        my $single_ret_list_name = "undefined";
        my $single_ret_list_max_var = "undefined";
        my $single_ret_list_max_define = "undefined";
1281
        my $single_ret_cleanup = 0;
1282 1283
        my $multi_ret = 0;

1284
        if ($rettype ne "void" and
1285 1286 1287 1288
            scalar(@{$call->{ret_members}}) > 1) {
            $multi_ret = 1;
        }

1289
        if ($rettype eq "void") {
1290
            $call_ret = "NULL";
1291
        } else {
1292
            push(@vars_list, "$rettype ret");
1293 1294

            foreach my $ret_member (@{$call->{ret_members}}) {
1295
                if ($multi_ret) {
1296
                    if ($ret_member =~ m/^(unsigned )?(char|short|int|hyper) (\S+)\[\S+\];/) {
1297 1298 1299 1300
                        if ($2 eq "hyper" and hyper_to_long($call->{ProcName}, "ret", $3)) {
                            die "legacy [u]long hyper arrays aren't supported";
                        }

1301
                        push(@ret_list, "memcpy(result->$3, ret.$3, sizeof(result->$3));");
1302 1303
                    } elsif ($ret_member =~ m/<\S+>;/ or $ret_member =~ m/\[\S+\];/) {
                        # just make all other array types fail
1304 1305
                        die "unhandled type for multi-return-value for " .
                            "procedure $call->{name}: $ret_member";
1306
                    } elsif ($ret_member =~ m/^(unsigned )?(char|short|int|hyper) (\S+);/) {
1307 1308 1309 1310 1311 1312 1313
                        if ($2 eq "hyper" and hyper_to_long($call->{ProcName}, "ret", $3)) {
                            my $sign = ""; $sign = "U" if ($1);

                            push(@ret_list, "HYPER_TO_${sign}LONG(result->$3, ret.$3);");
                        } else {
                            push(@ret_list, "result->$3 = ret.$3;");
                        }
1314
                    } else {
1315 1316
                        die "unhandled type for multi-return-value for " .
                            "procedure $call->{name}: $ret_member";
1317
                    }
1318 1319 1320 1321 1322
                } elsif ($ret_member =~ m/^remote_nonnull_string (\S+)<(\S+)>;\s*\/\*\s*insert@(\d+)\s*\*\//) {
                    splice(@args_list, int($3), 0, ("char **const $1"));
                    push(@ret_list, "rv = ret.$1.$1_len;");
                    $single_ret_var = "int rv = -1";
                    $single_ret_type = "int";
1323 1324 1325 1326
                    $single_ret_as_list = 1;
                    $single_ret_list_name = $1;
                    $single_ret_list_max_var = "max$1";
                    $single_ret_list_max_define = $2;
1327 1328 1329
                } elsif ($ret_member =~ m/^remote_nonnull_string (\S+)<\S+>;/) {
                    # error out on unannotated arrays
                    die "remote_nonnull_string array without insert@<offset> annotation: $ret_member";
1330
                } elsif ($ret_member =~ m/^remote_nonnull_string (\S+);/) {
1331 1332 1333
                    push(@ret_list, "rv = ret.$1;");
                    $single_ret_var = "char *rv = NULL";
                    $single_ret_type = "char *";
1334 1335 1336 1337 1338
                } elsif ($ret_member =~ m/^remote_string (\S+);/) {
                    push(@ret_list, "rv = ret.$1 ? *ret.$1 : NULL;");
                    push(@ret_list, "VIR_FREE(ret.$1);");
                    $single_ret_var = "char *rv = NULL";
                    $single_ret_type = "char *";
1339
                } elsif ($ret_member =~ m/^remote_nonnull_(domain|network|storage_pool|storage_vol|node_device|interface|secret|nwfilter|domain_snapshot) (\S+);/) {
1340 1341
                    my $name = $1;
                    my $arg_name = $2;
1342
                    my $type_name = name_to_TypeName($name);
1343 1344

                    if ($name eq "node_device") {
1345
                        $priv_name = "nodeDevicePrivateData";
1346 1347 1348 1349 1350 1351
                    } elsif ($name =~ m/^storage_/) {
                        $priv_name = "storagePrivateData";
                    } elsif (!($name =~ m/^domain/)) {
                        $priv_name = "${name}PrivateData";
                    }

1352 1353 1354 1355 1356 1357 1358 1359
                    if ($call->{ProcName} eq "DomainCreateWithFlags") {
                        # SPECIAL: virDomainCreateWithFlags updates the given
                        #          domain object instead of returning a new one
                        push(@ret_list, "dom->id = ret.dom.id;");
                        push(@ret_list, "xdr_free((xdrproc_t)xdr_$call->{ret}, (char *)&ret);");
                        push(@ret_list, "rv = 0;");
                        $single_ret_var = "int rv = -1";
                        $single_ret_type = "int";
1360
                    } else {
1361
                        if ($name eq "domain_snapshot") {
1362 1363 1364
                            my $dom = "$priv_src";
                            $dom =~ s/->conn//;
                            push(@ret_list, "rv = get_nonnull_$name($dom, ret.$arg_name);");
1365 1366 1367
                        } else {
                            push(@ret_list, "rv = get_nonnull_$name($priv_src, ret.$arg_name);");
                        }
1368

1369
                        push(@ret_list, "xdr_free((xdrproc_t)xdr_$rettype, (char *)&ret);");
1370 1371 1372
                        $single_ret_var = "vir${type_name}Ptr rv = NULL";
                        $single_ret_type = "vir${type_name}Ptr";
                    }
1373 1374 1375 1376 1377
                } elsif ($ret_member =~ m/^remote_typed_param (\S+)<(\S+)>;\s*\/\*\s*insert@(\d+)\s*\*\//) {
                    splice(@args_list, int($3), 0, ("virTypedParameterPtr $1"));
                    push(@ret_list2, "if (remoteDeserializeTypedParameters(ret.$1.$1_val,\n" .
                                     "                                         ret.$1.$1_len,\n" .
                                     "                                         $2,\n" .
1378
                                     "                                         &$1,\n" .
1379 1380 1381 1382 1383 1384
                                     "                                         n$1) < 0)\n" .
                                     "        goto cleanup;\n");
                    $single_ret_cleanup = 1;
                } elsif ($ret_member =~ m/^remote_typed_param (\S+)<\S+>;/) {
                    # error out on unannotated arrays
                    die "remote_typed_param array without insert@<offset> annotation: $ret_member";
1385
                } elsif ($ret_member =~ m/^int (\S+);/) {
1386 1387 1388 1389 1390 1391 1392 1393 1394 1395
                    my $arg_name = $1;

                    if ($call->{ProcName} =~ m/GetAutostart$/) {
                        push(@args_list, "int *$arg_name");
                        push(@ret_list, "if ($arg_name) *$arg_name = ret.$arg_name;");
                        push(@ret_list, "rv = 0;");
                    } else {
                        push(@ret_list, "rv = ret.$arg_name;");
                    }

1396 1397 1398 1399 1400 1401 1402 1403 1404 1405 1406 1407 1408 1409 1410 1411 1412 1413
                    $single_ret_var = "int rv = -1";
                    $single_ret_type = "int";
                } elsif ($ret_member =~ m/^(unsigned )?hyper (\S+);\s*\/\*\s*insert@(\d+)\s*\*\//) {
                    my $type_name = $1;
                    my $sign = ""; $sign = "U" if ($1);
                    my $ret_name = $2;
                    my $insert = $3;

                    if (hyper_to_long($call->{ProcName}, "ret", $ret_name)) {
                        $type_name .= "long";
                        push(@ret_list, "if ($ret_name) HYPER_TO_${sign}LONG(*$ret_name, ret.$ret_name);");
                    } else {
                        $type_name .= "long long";
                        push(@ret_list, "if ($ret_name) *$ret_name = ret.$ret_name;");
                    }

                    splice(@args_list, int($insert), 0, ("$type_name *$ret_name"));
                    push(@ret_list, "rv = 0;");
1414 1415
                    $single_ret_var = "int rv = -1";
                    $single_ret_type = "int";
1416
                } elsif ($ret_member =~ m/^unsigned hyper (\S+);/) {
1417
                    my $ret_name = $1;
1418

1419
                    if ($call->{ProcName} =~ m/Get(Lib)?Version/) {
1420 1421
                        push(@args_list, "unsigned long *$ret_name");
                        push(@ret_list, "if ($ret_name) HYPER_TO_ULONG(*$ret_name, ret.$ret_name);");
1422 1423 1424
                        push(@ret_list, "rv = 0;");
                        $single_ret_var = "int rv = -1";
                        $single_ret_type = "int";
1425 1426
                    } elsif (hyper_to_long($call->{ProcName}, "ret", $ret_name)) {
                        push(@ret_list, "HYPER_TO_ULONG(rv, ret.$ret_name);");
1427 1428
                        $single_ret_var = "unsigned long rv = 0";
                        $single_ret_type = "unsigned long";
1429 1430 1431 1432
                    } else {
                        push(@ret_list, "rv = ret.$ret_name;");
                        $single_ret_var = "unsigned long long rv = 0";
                        $single_ret_type = "unsigned long long";
1433
                    }
1434 1435
                } elsif ($ret_member =~ m/^(\/)?\*/) {
                    # ignore comments
1436
                } else {
1437 1438
                    die "unhandled type for return value for procedure " .
                        "$call->{name}: $ret_member";
1439 1440 1441 1442
                }
            }
        }

1443 1444
        # select struct type for multi-return-value functions
        if ($multi_ret) {
1445 1446
            if (!(defined $call->{ret_offset})) {
                die "multi-return-value without insert@<offset> annotation: $call->{ret}";
1447 1448
            }

1449 1450
            my $struct_name = $call->{ProcName};
            $struct_name =~ s/Get//;
1451

1452
            splice(@args_list, $call->{ret_offset}, 0, ("vir${struct_name}Ptr result"));
1453 1454
        }

1455 1456 1457 1458
        if ($call->{streamflag} ne "none") {
            splice(@args_list, $call->{streamoffset}, 0, ("virStreamPtr st"));
        }

1459 1460
        # print function
        print "\n";
1461
        print "static $single_ret_type\n";
1462 1463 1464 1465 1466 1467 1468 1469 1470
        if ($structprefix eq "remote") {
            print "$structprefix$call->{ProcName}(";
        } else {
            my $proc = $call->{ProcName};
            my $extra = $structprefix;
            $extra =~ s/^(\w)/uc $1/e;
            $proc =~ s/^(Domain)(.*)/$1 . $extra . $2/e;
            print "remote$proc(";
        }
1471 1472 1473 1474 1475

        print join(", ", @args_list);

        print ")\n";
        print "{\n";
1476
        print "    $single_ret_var;\n";
1477 1478 1479 1480 1481 1482
        print "    struct private_data *priv = $priv_src->$priv_name;\n";

        foreach my $var (@vars_list) {
            print "    $var;\n";
        }

1483
        if ($single_ret_as_list) {
1484
            print "    size_t i;\n";
1485 1486
        }

1487
        if ($call->{streamflag} ne "none") {
1488
            print "    virNetClientStreamPtr netst = NULL;\n";
1489 1490
        }

1491 1492 1493
        print "\n";
        print "    remoteDriverLock(priv);\n";

1494 1495
        if ($call->{streamflag} ne "none") {
            print "\n";
1496
            print "    if (!(netst = virNetClientStreamNew(priv->remoteProgram, $call->{constname}, priv->counter)))\n";
1497
            print "        goto done;\n";
1498
            print "\n";
1499
            print "    if (virNetClientAddStream(priv->client, netst) < 0) {\n";
1500
            print "        virObjectUnref(netst);\n";
1501
            print "        goto done;\n";
1502 1503
            print "    }";
            print "\n";
1504
            print "    st->driver = &remoteStreamDrv;\n";
1505
            print "    st->privateData = netst;\n";
1506 1507
        }

1508 1509 1510 1511 1512 1513 1514 1515 1516
        if ($call->{ProcName} eq "SupportsFeature") {
            # SPECIAL: VIR_DRV_FEATURE_REMOTE feature is handled directly
            print "\n";
            print "    if (feature == VIR_DRV_FEATURE_REMOTE) {\n";
            print "        rv = 1;\n";
            print "        goto done;\n";
            print "    }\n";
        }

1517 1518 1519
        foreach my $args_check (@args_check_list) {
            print "\n";
            print "    if ($args_check->{arg} > $args_check->{limit}) {\n";
1520 1521 1522
            print "        virReportError(VIR_ERR_RPC,\n";
            print "                       _(\"%s length greater than maximum: %d > %d\"),\n";
            print "                       $args_check->{name}, (int)$args_check->{arg}, $args_check->{limit});\n";
1523 1524 1525 1526
            print "        goto done;\n";
            print "    }\n";
        }

1527 1528 1529
        if ($single_ret_as_list) {
            print "\n";
            print "    if ($single_ret_list_max_var > $single_ret_list_max_define) {\n";
1530 1531 1532
            print "        virReportError(VIR_ERR_RPC,\n";
            print "                       _(\"too many remote ${single_ret_list_error_msg_type}s: %d > %d\"),\n";
            print "                       $single_ret_list_max_var, $single_ret_list_max_define);\n";
1533 1534 1535 1536
            print "        goto done;\n";
            print "    }\n";
        }

1537
        if (@setters_list) {
1538
            print "\n";
1539 1540 1541 1542 1543 1544 1545 1546 1547
            print "    ";
        }

        print join("\n    ", @setters_list);

        if (@setters_list) {
            print "\n";
        }

1548 1549 1550 1551 1552 1553 1554 1555 1556 1557 1558
        if (@setters_list2) {
            print "\n";
            print "    ";
        }

        print join("\n    ", @setters_list2);

        if (@setters_list2) {
            print "\n";
        }

1559
        if ($rettype ne "void") {
1560
            print "\n";
1561
            print "    memset(&ret, 0, sizeof(ret));\n";
1562 1563
        }

1564 1565 1566 1567
        my $callflags = "0";
        if ($structprefix eq "qemu") {
            $callflags = "REMOTE_CALL_QEMU";
        }
1568 1569 1570
        if ($structprefix eq "lxc") {
            $callflags = "REMOTE_CALL_LXC";
        }
1571

1572
        print "\n";
1573
        print "    if (call($priv_src, priv, $callflags, $call->{constname},\n";
1574 1575
        print "             (xdrproc_t)xdr_$argtype, (char *)$call_args,\n";
        print "             (xdrproc_t)xdr_$rettype, (char *)$call_ret) == -1) {\n";
1576 1577

        if ($call->{streamflag} ne "none") {
1578
            print "        virNetClientRemoveStream(priv->client, netst);\n";
1579
            print "        virObjectUnref(netst);\n";
1580 1581
            print "        st->driver = NULL;\n";
            print "        st->privateData = NULL;\n";
1582 1583
        }

1584
        print "        goto done;\n";
1585
        print "    }\n";
1586
        print "\n";
1587

1588 1589
        if ($single_ret_as_list) {
            print "    if (ret.$single_ret_list_name.${single_ret_list_name}_len > $single_ret_list_max_var) {\n";
1590 1591 1592
            print "        virReportError(VIR_ERR_RPC,\n";
            print "                       _(\"too many remote ${single_ret_list_error_msg_type}s: %d > %d\"),\n";
            print "                       ret.$single_ret_list_name.${single_ret_list_name}_len, $single_ret_list_max_var);\n";
1593 1594 1595 1596 1597
            print "        goto cleanup;\n";
            print "    }\n";
            print "\n";
            print "    /* This call is caller-frees (although that isn't clear from\n";
            print "     * the documentation).  However xdr_free will free up both the\n";
1598
            print "     * names and the list of pointers, so we have to VIR_STRDUP the\n";
1599 1600
            print "     * names here. */\n";
            print "    for (i = 0; i < ret.$single_ret_list_name.${single_ret_list_name}_len; ++i) {\n";
1601 1602
            print "        if (VIR_STRDUP(${single_ret_list_name}[i],\n";
            print "                       ret.$single_ret_list_name.${single_ret_list_name}_val[i]) < 0) {\n";
1603 1604 1605
            print "            size_t j;\n";
            print "            for (j = 0; j < i; j++)\n";
            print "                VIR_FREE(${single_ret_list_name}[j]);\n";
1606 1607 1608 1609 1610 1611 1612
            print "\n";
            print "            goto cleanup;\n";
            print "        }\n";
            print "    }\n";
            print "\n";
        }

1613 1614 1615 1616 1617 1618
        if (@ret_list2) {
            print "    ";
            print join("\n    ", @ret_list2);
            print "\n";
        }

1619 1620 1621 1622
        if (@ret_list) {
            print "    ";
            print join("\n    ", @ret_list);
            print "\n";
1623 1624
        }

1625
        if ($call->{ProcName} eq "DomainDestroy" ||
1626 1627
            $call->{ProcName} eq "DomainSave" ||
            $call->{ProcName} eq "DomainManagedSave") {
1628
            # SPECIAL: virDomain{Destroy|Save|ManagedSave} need to reset
1629
            # the domain id explicitly on success
1630 1631 1632
            print "    dom->id = -1;\n";
        }

1633
        if ($multi_ret or !@ret_list) {
1634 1635 1636
            print "    rv = 0;\n";
        }

1637
        if ($single_ret_as_list or $single_ret_cleanup) {
1638 1639
            print "\n";
            print "cleanup:\n";
1640
            print "    xdr_free((xdrproc_t)xdr_$call->{ret}, (char *)&ret);\n";
1641 1642
        }

1643 1644
        print "\n";
        print "done:\n";
1645 1646 1647

        print join("\n", @free_list);

1648 1649 1650 1651
        print "    remoteDriverUnlock(priv);\n";
        print "    return rv;\n";
        print "}\n";
    }
1652 1653
} elsif ($mode eq "aclheader" ||
         $mode eq "aclbody" ||
1654 1655
         $mode eq "aclsym" ||
         $mode eq "aclapi") {
1656 1657 1658 1659 1660 1661 1662 1663 1664 1665 1666 1667 1668 1669 1670 1671 1672 1673 1674 1675 1676 1677 1678 1679 1680
    my %generate = map { $_ => 1 } @autogen;
    my @keys = keys %calls;

    if ($mode eq "aclsym") {
        @keys = sort { my $c = $a . "ensureacl";
                       my $d = $b . "ensureacl";
                       $c cmp $d } @keys;
    } else {
        @keys = sort { $a cmp $b } @keys;
    }

    if ($mode eq "aclheader") {
        my @headers = (
            "internal.h",
            "domain_conf.h",
            "network_conf.h",
            "secret_conf.h",
            "storage_conf.h",
            "nwfilter_conf.h",
            "node_device_conf.h",
            "interface_conf.h"
            );
        foreach my $hdr (@headers) {
            print "#include \"$hdr\"\n";
        }
1681
        print "\n";
1682 1683 1684 1685 1686 1687 1688 1689 1690
    } elsif ($mode eq "aclbody") {
        my $header = shift;
        print "#include <config.h>\n";
        print "#include \"$header\"\n";
        print "#include \"access/viraccessmanager.h\"\n";
        print "#include \"datatypes.h\"\n";
        print "#include \"virerror.h\"\n";
        print "\n";
        print "#define VIR_FROM_THIS VIR_FROM_ACCESS\n";
1691 1692 1693 1694 1695
        print "\n";
    } elsif ($mode eq "aclapi") {
        print "<aclinfo>\n";
    } else {
        print "\n";
1696 1697 1698 1699 1700 1701 1702 1703 1704 1705 1706 1707 1708 1709
    }

    foreach (@keys) {
        my $call = $calls{$_};

        die "missing 'acl' option for $call->{ProcName}"
            unless exists $call->{acl} &&
            $#{$call->{acl}} != -1;

        next if $call->{acl}->[0] eq "none";

        if ($mode eq "aclsym") {
            my $apiname = "vir" . $call->{ProcName};
            if ($structprefix eq "qemu") {
1710
                $apiname =~ s/(vir(Connect)?Domain)/${1}Qemu/;
1711 1712 1713 1714 1715 1716 1717
            } elsif ($structprefix eq "lxc") {
                $apiname =~ s/virDomain/virDomainLxc/;
            }
            if (defined $call->{aclfilter}) {
                print $apiname . "CheckACL;\n";
            }
            print $apiname . "EnsureACL;\n";
1718 1719
        } elsif ($mode eq "aclapi") {
            &generate_aclapi($call);
1720 1721 1722 1723 1724 1725 1726 1727 1728 1729 1730 1731 1732 1733 1734 1735 1736 1737 1738 1739 1740 1741 1742 1743 1744 1745 1746 1747 1748 1749
        } else {
            &generate_acl($call, $call->{acl}, "Ensure");
            if (defined $call->{aclfilter}) {
                &generate_acl($call, $call->{aclfilter}, "Check");
            }
        }

        sub generate_acl {
            my $call = shift;
            my $acl = shift;
            my $action = shift;

            my @acl;
            foreach (@{$acl}) {
                my @bits = split /:/;
                push @acl, { object => $bits[0], perm => $bits[1], flags => $bits[2] }
            }

            my $checkflags = 0;
            for (my $i = 1 ; $i <= $#acl ; $i++) {
                if ($acl[$i]->{object} ne $acl[0]->{object}) {
                    die "acl for '$call->{ProcName}' cannot check different objects";
                }
                if (defined $acl[$i]->{flags}) {
                    $checkflags = 1;
                }
            }

            my $apiname = "vir" . $call->{ProcName};
            if ($structprefix eq "qemu") {
1750
                $apiname =~ s/(vir(Connect)?Domain)/${1}Qemu/;
1751 1752 1753 1754 1755 1756 1757 1758 1759 1760 1761 1762 1763 1764 1765 1766 1767 1768 1769 1770 1771 1772 1773 1774 1775 1776 1777 1778 1779
            } elsif ($structprefix eq "lxc") {
                $apiname =~ s/virDomain/virDomainLxc/;
            }

            my $object = $acl[0]->{object};
            my $arg = $acl[0]->{object};
            $arg =~ s/^.*_(\w+)$/$1/;
            $object =~ s/^(\w)/uc $1/e;
            $object =~ s/_(\w)/uc $1/e;
            $object =~ s/Nwfilter/NWFilter/;
            my $objecttype = "vir" . $object . "DefPtr";
            $apiname .= $action . "ACL";

            if ($arg eq "interface") {
                $arg = "iface";
            }

            my @argdecls;
            push @argdecls, "virConnectPtr conn";
            if ($object ne "Connect") {
                if ($object eq "StorageVol") {
                    push @argdecls, "virStoragePoolDefPtr pool";
                }
                push @argdecls, "$objecttype $arg";
            }
            if ($checkflags) {
                push @argdecls, "unsigned int flags";
            }

1780 1781 1782 1783 1784 1785 1786 1787 1788 1789 1790 1791 1792
            my $ret;
            my $pass;
            my $fail;
            if ($action eq "Check") {
                $ret = "bool";
                $pass = "true";
                $fail = "false";
            } else {
                $ret = "int";
                $pass = "0";
                $fail = "-1";
            }

1793
            if ($mode eq "aclheader") {
1794
                print "extern $ret $apiname(" . join(", ", @argdecls) . ");\n";
1795 1796 1797 1798 1799 1800 1801 1802 1803 1804 1805
            } else {
                my @argvars;
                push @argvars, "mgr";
                push @argvars, "conn->driver->name";
                if ($object ne "Connect") {
                    if ($object eq "StorageVol") {
                        push @argvars, "pool";
                    }
                    push @argvars, $arg;
                }

1806 1807
                print "/* Returns: $fail on error/denied, $pass on allowed */\n";
                print "$ret $apiname(" . join(", ", @argdecls) . ")\n";
1808 1809 1810 1811
                print "{\n";
                print "    virAccessManagerPtr mgr;\n";
                print "    int rv;\n";
                print "\n";
1812 1813 1814 1815 1816 1817
                print "    if (!(mgr = virAccessManagerGetDefault())) {\n";
                if ($action eq "Check") {
                    print "        virResetLastError();\n";
                }
                print "        return $fail;\n";
                print "    }\n";
1818 1819 1820 1821 1822 1823 1824 1825 1826 1827 1828 1829 1830 1831 1832 1833 1834 1835 1836 1837 1838 1839 1840 1841
                print "\n";

                foreach my $acl (@acl) {
                    my $perm = "vir_access_perm_" . $acl->{object} . "_" . $acl->{perm};
                    $perm =~ tr/a-z/A-Z/;

                    my $method = "virAccessManagerCheck" . $object;
                    my $space = ' ' x length($method);
                    print "    if (";
                    if (defined $acl->{flags}) {
                        my $flags = $acl->{flags};
                        if ($flags =~ /^\!/) {
                            $flags = substr $flags, 1;
                            print "((flags & ($flags)) == 0) &&\n";
                        } else {
                            print "((flags & ($flags)) == ($flags)) &&\n";
                        }
                        print "        ";
                    }
                    print "(rv = $method(" . join(", ", @argvars, $perm) . ")) <= 0) {\n";
                    print "        virObjectUnref(mgr);\n";
                    if ($action eq "Ensure") {
                        print "        if (rv == 0)\n";
                        print "            virReportError(VIR_ERR_ACCESS_DENIED, NULL);\n";
1842
                        print "        return $fail;\n";
1843
                    } else {
1844 1845
                        print "        virResetLastError();\n";
                        print "        return $fail;\n";
1846 1847 1848 1849 1850 1851
                    }
                    print "    }";
                    print "\n";
                }

                print "    virObjectUnref(mgr);\n";
1852
                print "    return $pass;\n";
1853 1854 1855
                print "}\n\n";
            }
        }
1856 1857 1858 1859 1860 1861

        sub generate_aclapi {
            my $call = shift;

            my $apiname = "vir" . $call->{ProcName};
            if ($structprefix eq "qemu") {
1862
                $apiname =~ s/(vir(Connect)?Domain)/${1}Qemu/;
1863 1864 1865 1866 1867 1868 1869 1870 1871 1872 1873 1874 1875 1876 1877 1878 1879 1880 1881 1882 1883 1884 1885 1886 1887 1888 1889 1890 1891
            } elsif ($structprefix eq "lxc") {
                $apiname =~ s/virDomain/virDomainLxc/;
            }

            print "  <api name='$apiname'>\n";

            my $acl = $call->{acl};
            foreach (@{$acl}) {
                my @bits = split /:/;
                print "    <check object='$bits[0]' perm='$bits[1]'";
                if (defined $bits[2]) {
                    print " flags='$bits[2]'";
                }
                print "/>\n";
            }

            my $aclfilter = $call->{aclfilter};
            foreach (@{$aclfilter}) {
                my @bits = split /:/;
                print "    <filter object='$bits[0]' perm='$bits[1]'/>\n";
            }

            print "  </api>\n";
        }

    }

    if ($mode eq "aclapi") {
        print "</aclinfo>\n";
1892
    }
1893
}