This patch removes several unnecessary comments, changes some comments
so that the use as much of the allowable 80 characters as possible, adds
the proper whitespace, removes some structure members from the kernel
docs that are no longer present, and improves the existing kernel doc
information for some existing structure members.
Signed-off-by: NBrian Masney <masneyb@onstation.org>
Signed-off-by: NJonathan Cameron <Jonathan.Cameron@huawei.com>

This patch changes the defaults of the als_time, prox_time and
wait_time to match the defaults according to the TSL2772 datasheet.
Signed-off-by: NBrian Masney <masneyb@onstation.org>
Signed-off-by: NJonathan Cameron <Jonathan.Cameron@huawei.com>

The driver mostly uses the 'prox' naming convention for most of the
proximity settings, however prx_time and tsl2x7x_prx_gain was present.
This patch renames these to prox_time and tsl2x7x_prox_gain for
consistency with everything else in the driver.

The kernel documentation for prx_gain is corrected to prox_gain so that
it matches what is actually in the structure.
Signed-off-by: NBrian Masney <masneyb@onstation.org>
Signed-off-by: NJonathan Cameron <Jonathan.Cameron@huawei.com>

The power and diode defines are needed for the platform data so this
patch moves the defines out of the .c file and into the header file. A
comment for the diode is also cleaned up while this code is touched.
Signed-off-by: NBrian Masney <masneyb@onstation.org>
Signed-off-by: NJonathan Cameron <Jonathan.Cameron@huawei.com>

This patch renames tsl2x7x_device_id() to tsl2x7x_device_id_verif(),
removes the unnecessary pointer on the id parameter, and only calls
the verification function once.
Signed-off-by: NBrian Masney <masneyb@onstation.org>
Signed-off-by: NJonathan Cameron <Jonathan.Cameron@huawei.com>

tsl2x7x_write_interrupt_config() has an unnecessary return value check
at the end of the function. This patch changes the function to just
return the value from the call to tsl2x7x_invoke_change().
Signed-off-by: NBrian Masney <masneyb@onstation.org>
Signed-off-by: NJonathan Cameron <Jonathan.Cameron@huawei.com>

tsl2x7x_suspend() and tsl2x7x_resume() both check to see what the
current chip status is. These checks are not necessary so this patch
removes those checks.
Signed-off-by: NBrian Masney <masneyb@onstation.org>
Signed-off-by: NJonathan Cameron <Jonathan.Cameron@huawei.com>

tsl2x7x_clear_interrupts() takes a reg argument but there are only
two callers to this function and both callers pass the same value.
Since this function was introduced, interrupts are now working
properly for this driver, and several unnecessary calls to
tsl2x7x_clear_interrupts() were removed. This patch removes the
tsl2x7x_clear_interrupts() function and replaces the two callers
with the i2c_smbus_write_byte() call instead.
Signed-off-by: NBrian Masney <masneyb@onstation.org>
Signed-off-by: NJonathan Cameron <Jonathan.Cameron@huawei.com>

tsl2x7x_event_handler() could return an error and this could cause the
interrupt to remain masked. We shouldn't return an error in the
interrupt handler so this patch always returns IRQ_HANDLED. An error
will be logged if one occurs.
Signed-off-by: NBrian Masney <masneyb@onstation.org>
Signed-off-by: NJonathan Cameron <Jonathan.Cameron@huawei.com>

The integration_time* attributes are currently associated with the
IIO_LIGHT channel but should be associated with the IIO_INTENSITY
channel. Directory listing of the sysfs attributes for a TSL2772
with this patch applied:

dev
events
in_illuminance0_calibrate
in_illuminance0_calibscale_available
in_illuminance0_input
in_illuminance0_lux_table
in_illuminance0_target_input
in_intensity0_calibbias
in_intensity0_calibscale
in_intensity0_integration_time
in_intensity0_integration_time_available
in_intensity0_raw
in_intensity1_raw
in_proximity0_calibrate
in_proximity0_calibscale
in_proximity0_calibscale_available
in_proximity0_raw
name
of_node
power
subsystem
uevent
Signed-off-by: NBrian Masney <masneyb@onstation.org>
Signed-off-by: NJonathan Cameron <Jonathan.Cameron@huawei.com>

We should get drvdata from struct device directly. Going via
platform_device is an unneeded step back and forth.
Signed-off-by: NWolfram Sang <wsa+renesas@sang-engineering.com>
Signed-off-by: NJonathan Cameron <Jonathan.Cameron@huawei.com>

We should get drvdata from struct device directly. Going via
platform_device is an unneeded step back and forth.
Signed-off-by: NWolfram Sang <wsa+renesas@sang-engineering.com>
Signed-off-by: NJonathan Cameron <Jonathan.Cameron@huawei.com>

We should get drvdata from struct device directly. Going via
platform_device is an unneeded step back and forth.
Signed-off-by: NWolfram Sang <wsa+renesas@sang-engineering.com>
Signed-off-by: NJonathan Cameron <Jonathan.Cameron@huawei.com>

The Lenovo Ideapad Miix 320 uses an st accelerometer with an ACPI id
of SMO8840, add support for this.
Signed-off-by: NHans de Goede <hdegoede@redhat.com>
Signed-off-by: NJonathan Cameron <Jonathan.Cameron@huawei.com>

Document that the hardware supports falling edge, rising edge, level
low, and level high interrupt types, rather than just rising edge.

The language used is the same as that in st_lsm6dsx.txt.
Signed-off-by: NMartin Kelly <mkelly@xevo.com>
Reviewed-by: NRob Herring <robh@kernel.org>
Acked-by: NJean-Baptiste Maneyrol <jmaneyrol@invensense.com>
Signed-off-by: NJonathan Cameron <Jonathan.Cameron@huawei.com>

Currently, we support only rising edge interrupts, and in fact we assume
that the interrupt we're given is rising edge (and things won't work if
it's not). However, the device supports rising edge, falling edge, level
low, and level high interrupts.

Empirically, on my system, switching to level interrupts has fixed a
problem I had with significant (~40%) interrupt loss with edge
interrupts. This issue is likely related to the SoC I'm using (Allwinner
H3), but being able to switch the interrupt type is still a very useful
workaround.

I tested this with each interrupt type and verified correct behavior in
a logic analyzer.

Add support for these interrupt types while also eliminating the error
case of the device tree and driver using different interrupt types.
Signed-off-by: NMartin Kelly <mkelly@xevo.com>
Acked-by: NJean-Baptiste Maneyrol <jmaneyrol@invensense.com>
Signed-off-by: NJonathan Cameron <Jonathan.Cameron@huawei.com>

Set power function is rewritten manually inside i2c mux select.
Better use the already identical existing function.
Signed-off-by: NJean-Baptiste Maneyrol <jmaneyrol@invensense.com>
Signed-off-by: NJonathan Cameron <Jonathan.Cameron@huawei.com>

Rewrite set_power_itg. Failing when turning power off is
no more decreasing the counter now and sleeping only happens
when effectively turning the chip on. Fix also usage in init
function (setting power on one time is sufficient to ensure
chip is effectively on).
Signed-off-by: NJean-Baptiste Maneyrol <jmaneyrol@invensense.com>
Signed-off-by: NJonathan Cameron <Jonathan.Cameron@huawei.com>

Update the example to use the compatible string including the
vendor prefix instead of the ones deprecated in 3a872138.
Signed-off-by: NFabian Mewes <architekt@coding4coffee.org>
Reviewed-by: NRob Herring <robh@kernel.org>
Signed-off-by: NJonathan Cameron <Jonathan.Cameron@huawei.com>

Also remove unnecessary parenthesis
Signed-off-by: NHernán Gonzalez <hernan@vanguardiasur.com.ar>
Signed-off-by: NJonathan Cameron <Jonathan.Cameron@huawei.com>

'sca3000_configure_ring()' can fail, so test its return value and
propagate it if needed.
Signed-off-by: NChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: NJonathan Cameron <Jonathan.Cameron@huawei.com>

Use 'devm_iio_kfifo_allocate()' instead of 'iio_kfifo_allocate()' in order
to simplify code and avoid a memory leak in an error path in
'sca3000_probe()'. A call to 'sca3000_unconfigure_ring()' was missing.

Sent via the next merge window as unimportant bug and there are
other patches dependent on it.
Signed-off-by: NChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: <Stable@vger.kernel.org>
Signed-off-by: NJonathan Cameron <Jonathan.Cameron@huawei.com>

The AD5694/AD5694R/AD5695R/AD5696/AD5696R are a family of 4 channel DACs
with 12-bit, 14-bit and 16-bit precision respectively. The devices have
either no built-in reference, or built-in 2.5V reference.

The AD5671R/AD5675R are similar, except that they have 8 instead of 4
channels.

These devices are similar to AD5672R/AD5676/AD5676R and
AD5684/AD5684R/AD5684/AD5685R/AD5686/AD5686R, except that they use i2c
instead of spi.

Datasheets:
http://www.analog.com/media/en/technical-documentation/data-sheets/AD5671R_5675R.pdf
http://www.analog.com/media/en/technical-documentation/data-sheets/AD5696R_5695R_5694R.pdfSigned-off-by: NStefan Popa <stefan.popa@analog.com>
Signed-off-by: NJonathan Cameron <Jonathan.Cameron@huawei.com>

In this patch restructures the existing ad5686 driver by adding a module
for SPI and a header file, while the baseline module deals with the
chip-logic.

This is a necessary step, as this driver should support in the future
similar devices which differ only in the type of interface used (I2C
instead of SPI).
Signed-off-by: NStefan Popa <stefan.popa@analog.com>
Signed-off-by: NJonathan Cameron <Jonathan.Cameron@huawei.com>

The AD5684R/AD5686R are a family of 4 channel DACs with 12-bit, 14-bit and
16-bit precision respectively. The devices come either with a built-in
reference or no built-in reference.

The AD5672R/AD5676/AD5676R are similar, except that they have 8 channels
instead of 4.

Datasheets:
http://www.analog.com/media/en/technical-documentation/data-sheets/AD5672R_5676R.pdf
http://www.analog.com/media/en/technical-documentation/data-sheets/AD5686R_5685R_5684R.pdfSigned-off-by: NStefan Popa <stefan.popa@analog.com>
Signed-off-by: NJonathan Cameron <Jonathan.Cameron@huawei.com>

This driver acctually supports the AD5685R device and NOT the AD5685, which
does not exist.  Maintain old id entry in case we have devicetrees
out there which are using the wrong name.

More information can be found in the datasheet:
http://www.analog.com/media/en/technical-documentation/data-sheets/AD5686_5684.pdfSigned-off-by: NStefan Popa <stefan.popa@analog.com>
Signed-off-by: NJonathan Cameron <Jonathan.Cameron@huawei.com>

This patch adds a new num_channels attribute as part of the
ad5686_chip_info struct which replaces the AD5686_DAC_CHANNELS define. This
is a necessary step, since this driver should support similar devices which
differ only in the number of channels.
Signed-off-by: NStefan Popa <stefan.popa@analog.com>
Signed-off-by: NJonathan Cameron <Jonathan.Cameron@huawei.com>

Add GPLv2+ SPDX identifier and remove license notice to keep the whole
purpose of using an SPDx id.
Signed-off-by: NStefan Popa <stefan.popa@analog.com>
Signed-off-by: NJonathan Cameron <Jonathan.Cameron@huawei.com>

This patch fixes some indentation issues and does not modify the
functionality of the driver.
Signed-off-by: NStefan Popa <stefan.popa@analog.com>
Signed-off-by: NJonathan Cameron <Jonathan.Cameron@huawei.com>

Added support for the mpu9255 IMU to the mpu6050 driver. The
register map is the same as the other chips; the only driver
difference is the compatible string and the WHOAMI register
value.
Signed-off-by: NDouglas Fischer <fischerdouglasc@gmail.com>
Signed-off-by: NJonathan Cameron <Jonathan.Cameron@huawei.com>

usleep_range() uses hrtimers and provides no advantage over msleep()
for larger delays.

Cc: Nicholas Mc Guire <hofrat@osadl.org>
Link: http://lkml.org/lkml/2017/1/11/377Signed-off-by: NMatt Ranostay <matt.ranostay@konsulko.com>
Reviewed-by: NNicholas Mc Guire <hofrat@osadl.org>
Signed-off-by: NJonathan Cameron <Jonathan.Cameron@huawei.com>

Use the new probe style for i2c drivers.
Signed-off-by: NPeter Rosin <peda@axentia.se>
Signed-off-by: NJonathan Cameron <Jonathan.Cameron@huawei.com>

Use the new probe style for i2c drivers.
Signed-off-by: NPeter Rosin <peda@axentia.se>
Signed-off-by: NJonathan Cameron <Jonathan.Cameron@huawei.com>

There is no need to flush fifo and loose all data when the iio
buffer is full. Just drop the data by ignoring the error as
commonly done in other drivers.
Signed-off-by: NJean-Baptiste Maneyrol <jmaneyrol@invensense.com>
Reviewed-by: NMartin Kelly <martin@martingkelly.com>
Signed-off-by: NJonathan Cameron <Jonathan.Cameron@huawei.com>

Reorder some variable declarations in an inverse-pyramid scheme.
Signed-off-by: NHernán Gonzalez <hernan@vanguardiasur.com.ar>
Signed-off-by: NJonathan Cameron <Jonathan.Cameron@huawei.com>

Signed-off-by: NHernán Gonzalez <hernan@vanguardiasur.com.ar>
Signed-off-by: NJonathan Cameron <Jonathan.Cameron@huawei.com>

Clear checkpatch.pl WARNING about multiple line derefence but creates a
new one of line over 80 characters. In my opinion, it improves
readability.
Signed-off-by: NHernán Gonzalez <hernan@vanguardiasur.com.ar>
Signed-off-by: NJonathan Cameron <Jonathan.Cameron@huawei.com>

Clear a couple more checkpatch.pl CHECKS.
Signed-off-by: NHernán Gonzalez <hernan@vanguardiasur.com.ar>
Signed-off-by: NJonathan Cameron <Jonathan.Cameron@huawei.com>

Data to read or write was being handled with the swab16() macro instead
of using i2c_smbus_{read,write}_swapped.
Signed-off-by: NHernán Gonzalez <hernan@vanguardiasur.com.ar>
Signed-off-by: NJonathan Cameron <Jonathan.Cameron@huawei.com>

Signed-off-by: NLorenzo Bianconi <lorenzo.bianconi@redhat.com>
Signed-off-by: NJonathan Cameron <Jonathan.Cameron@huawei.com>