1. 04 2月, 2020 1 次提交
    • P
      drm/i915/display: Make WARN* drm specific where drm_device ptr is available · f4224a4c
      Pankaj Bharadiya 提交于
      drm specific WARN* calls include device information in the
      backtrace, so we know what device the warnings originate from.
      
      Covert all the calls of WARN* with device specific drm_WARN*
      variants in functions where drm_device or drm_i915_private struct
      pointer is readily available.
      
      The conversion was done automatically with below coccinelle semantic
      patch. checkpatch errors/warnings are fixed manually.
      
      @rule1@
      identifier func, T;
      @@
      func(...) {
      ...
      struct drm_device *T = ...;
      <...
      (
      -WARN(
      +drm_WARN(T,
      ...)
      |
      -WARN_ON(
      +drm_WARN_ON(T,
      ...)
      |
      -WARN_ONCE(
      +drm_WARN_ONCE(T,
      ...)
      |
      -WARN_ON_ONCE(
      +drm_WARN_ON_ONCE(T,
      ...)
      )
      ...>
      }
      
      @rule2@
      identifier func, T;
      @@
      func(struct drm_device *T,...) {
      <...
      (
      -WARN(
      +drm_WARN(T,
      ...)
      |
      -WARN_ON(
      +drm_WARN_ON(T,
      ...)
      |
      -WARN_ONCE(
      +drm_WARN_ONCE(T,
      ...)
      |
      -WARN_ON_ONCE(
      +drm_WARN_ON_ONCE(T,
      ...)
      )
      ...>
      }
      
      @rule3@
      identifier func, T;
      @@
      func(...) {
      ...
      struct drm_i915_private *T = ...;
      <+...
      (
      -WARN(
      +drm_WARN(&T->drm,
      ...)
      |
      -WARN_ON(
      +drm_WARN_ON(&T->drm,
      ...)
      |
      -WARN_ONCE(
      +drm_WARN_ONCE(&T->drm,
      ...)
      |
      -WARN_ON_ONCE(
      +drm_WARN_ON_ONCE(&T->drm,
      ...)
      )
      ...+>
      }
      
      @rule4@
      identifier func, T;
      @@
      func(struct drm_i915_private *T,...) {
      <+...
      (
      -WARN(
      +drm_WARN(&T->drm,
      ...)
      |
      -WARN_ON(
      +drm_WARN_ON(&T->drm,
      ...)
      |
      -WARN_ONCE(
      +drm_WARN_ONCE(&T->drm,
      ...)
      |
      -WARN_ON_ONCE(
      +drm_WARN_ON_ONCE(&T->drm,
      ...)
      )
      ...+>
      }
      Signed-off-by: NPankaj Bharadiya <pankaj.laxminarayan.bharadiya@intel.com>
      Signed-off-by: NJani Nikula <jani.nikula@intel.com>
      Link: https://patchwork.freedesktop.org/patch/msgid/20200128181603.27767-20-pankaj.laxminarayan.bharadiya@intel.com
      f4224a4c
  2. 27 1月, 2020 1 次提交
  3. 23 1月, 2020 1 次提交
    • W
      drm/i915/bios: convert to struct drm_device logging macros. · e92cbf38
      Wambui Karuga 提交于
      This replaces the printk based logging macros with the struct drm_device
      based logging macros.
      This conversion was achieved using the following coccinelle script that
      transforms based on the existence of a struct drm_i915_private device:
      @rule1@
      identifier fn, T;
      @@
      
      fn(struct drm_i915_private *T,...) {
      <+...
      (
      -DRM_INFO(
      +drm_info(&T->drm,
      ...)
      |
      -DRM_ERROR(
      +drm_err(&T->drm,
      ...)
      |
      -DRM_WARN(
      +drm_warn(&T->drm,
      ...)
      |
      -DRM_DEBUG(
      +drm_dbg(&T->drm,
      ...)
      |
      -DRM_DEBUG_DRIVER(
      +drm_dbg(&T->drm,
      ...)
      |
      -DRM_DEBUG_KMS(
      +drm_dbg_kms(&T->drm,
      ...)
      )
      ...+>
      }
      
      @rule2@
      identifier fn, T;
      @@
      
      fn(...) {
      ...
      struct drm_i915_private *T = ...;
      <+...
      (
      -DRM_INFO(
      +drm_info(&T->drm,
      ...)
      |
      -DRM_ERROR(
      +drm_err(&T->drm,
      ...)
      |
      -DRM_WARN(
      +drm_warn(&T->drm,
      ...)
      |
      -DRM_DEBUG(
      +drm_dbg(&T->drm,
      ...)
      |
      -DRM_DEBUG_KMS(
      +drm_dbg_kms(&T->drm,
      ...)
      |
      -DRM_DEBUG_DRIVER(
      +drm_dbg(&T->drm,
      ...)
      )
      ...+>
      }
      
      Formatting warnings by checkpatch are addressed manually.
      Signed-off-by: NWambui Karuga <wambui.karugax@gmail.com>
      Signed-off-by: NJani Nikula <jani.nikula@intel.com>
      Link: https://patchwork.freedesktop.org/patch/msgid/20200121134559.17355-3-wambui.karugax@gmail.com
      e92cbf38
  4. 21 1月, 2020 8 次提交
  5. 15 1月, 2020 1 次提交
  6. 14 12月, 2019 1 次提交
  7. 13 12月, 2019 1 次提交
  8. 11 12月, 2019 3 次提交
  9. 03 12月, 2019 4 次提交
  10. 19 11月, 2019 2 次提交
  11. 14 11月, 2019 3 次提交
  12. 12 11月, 2019 2 次提交
  13. 04 11月, 2019 1 次提交
  14. 17 10月, 2019 2 次提交
  15. 14 10月, 2019 1 次提交
  16. 08 10月, 2019 1 次提交
  17. 16 9月, 2019 1 次提交
  18. 19 8月, 2019 1 次提交
    • M
      drm/i915/gen11: Allow usage of all GPIO pins · 5a6b7ef6
      Matt Roper 提交于
      Our pin mapping tables for ICP and MCC currently only list the standard
      GPIO pins used for various output ports.  Even through ICP's standard
      pin usage only utilizes pins 1, 2, and 9-12, and MCC's standard pin
      usage only uses pins 1, 2, and 9, these platforms do still have GPIO
      registers to address pins in the range 1-3 and 9-14.  OEM's may remap
      GPIO usage in non-standard ways (and provide the actual mapping via VBT
      settings), so we shouldn't exclude pins on these platforms just because
      they aren't part of the standard mappings.
      
      TGP's standard pin tables contains all the possible pins, so let's
      rename them to "icp" and use them for all PCH >= PCH_ICP.  This will
      prevent intel_gmbus_is_valid_pin from rejecting non-standard pin usage
      that an OEM specifies via the VBT.
      
      Note that this will cause pin 9 to be labeled as "tc1" instead of "dpc"
      in debug messages on platforms with the MCC PCH, but that may actually
      help avoid confusion since the text strings will now be the same on all
      gen11+ platforms instead of being different on just EHL.
      
      v2: Drop now-unused MCC_DDC_BUS_DDI_* names.
      
      v3: We want to compare against INTEL_PCH_TYPE, not INTEL_PCH_ID.
      
      Bspec: 8417
      Cc: José Roberto de Souza <jose.souza@intel.com>
      Cc: Lucas De Marchi <lucas.demarchi@intel.com>
      Cc: Vivek Kasireddy <vivek.kasireddy@intel.com>
      Cc: Jani Nikula <jani.nikula@intel.com>
      Signed-off-by: NMatt Roper <matthew.d.roper@intel.com>
      Reviewed-by: NJosé Roberto de Souza <jose.souza@intel.com>
      Link: https://patchwork.freedesktop.org/patch/msgid/20190817005041.20651-1-matthew.d.roper@intel.com
      5a6b7ef6
  19. 29 7月, 2019 1 次提交
  20. 19 7月, 2019 1 次提交
  21. 12 7月, 2019 2 次提交
  22. 11 7月, 2019 1 次提交