The zynqmp_pm_set_suspend_mode() and zynqmp_pm_get_trustzone_version()
functions pass values as api_id into zynqmp_pm_invoke_fn
that are beyond PM_API_MAX, resulting in an out-of-bounds access:

drivers/firmware/xilinx/zynqmp.c: In function 'zynqmp_pm_set_suspend_mode':
drivers/firmware/xilinx/zynqmp.c:150:24: warning: array subscript 2562 is above array bounds of 'u32[64]' {aka 'unsigned int[64]'} [-Warray-bounds]
  150 |  if (zynqmp_pm_features[api_id] != PM_FEATURE_UNCHECKED)
      |      ~~~~~~~~~~~~~~~~~~^~~~~~~~
drivers/firmware/xilinx/zynqmp.c:28:12: note: while referencing 'zynqmp_pm_features'
   28 | static u32 zynqmp_pm_features[PM_API_MAX];
      |            ^~~~~~~~~~~~~~~~~~

Replace the resulting undefined behavior with an error return.
This may break some things that happen to work at the moment
but seems better than randomly overwriting kernel data.

I assume we need additional fixes for the two functions that now
return an error.

Fixes: 76582671 ("firmware: xilinx: Add Zynqmp firmware driver")
Fixes: e178df31 ("firmware: xilinx: Implement ZynqMP power management APIs")
Signed-off-by: NArnd Bergmann <arnd@arndb.de>
Link: https://lore.kernel.org/r/20201026155449.3703142-1-arnd@kernel.org
Cc: stable <stable@vger.kernel.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

If 'mfd_add_devices()' fails, we must undo 'zynqmp_pm_api_debugfs_init()'
otherwise some debugfs directory and files will be left.

Just move the call to 'zynqmp_pm_api_debugfs_init()' a few lines below to
fix the issue.

Fixes: e23d9c6d ("drivers: soc: xilinx: Add ZynqMP power domain driver")
Signed-off-by: NChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: NJolly Shah <jolly.shah@xilinx.com>
Link: https://lore.kernel.org/r/20200510130357.233364-1-christophe.jaillet@wanadoo.frSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

When building arm64 allmodconfig:

ERROR: modpost: "zynqmp_pm_fpga_load" [drivers/fpga/zynqmp-fpga.ko] undefined!
ERROR: modpost: "zynqmp_pm_fpga_get_status" [drivers/fpga/zynqmp-fpga.ko] undefined!

These functions were added to drivers/fpga/zynqmp-fpga.c but not
exported so the module build breaks. Export them so that they can be
used in modules properly.

Fixes: 4db8180f ("firmware: xilinx: Remove eemi ops for fpga related APIs")
Signed-off-by: NNathan Chancellor <natechancellor@gmail.com>
Reported-by: N"kernelci.org bot" <bot@kernelci.org>
Reported-by: NStephen Rothwell <sfr@canb.auug.org.au>
Link: https://lore.kernel.org/r/20200502025958.2714249-1-natechancellor@gmail.comSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Add sysfs interface to set boot health status from user space.
Add API used by this interface to communicate with firmware.

If PMUFW is compiled with CHECK_HEALTHY_BOOT, it will check the
healthy bit on FPD WDT expiration. If healthy bit is set by a user
application running in Linux, PMUFW will do APU only restart. If
healthy bit is not set during FPD WDT expiration, PMUFW will do
system restart.
Signed-off-by: NRajan Vaja <rajan.vaja@xilinx.com>
Signed-off-by: NMichal Simek <michal.simek@xilinx.com>
Signed-off-by: NTejas Patel <tejas.patel@xilinx.com>
Signed-off-by: NJolly Shah <jolly.shah@xilinx.com>
Link: https://lore.kernel.org/r/1587761887-4279-26-git-send-email-jolly.shah@xilinx.comSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

The Linux shutdown functionality implemented via PSCI system_off does
not include an option to set a scope, i.e. which parts of the system to
shut down.

This patch creates sysfs that allows to set the shutdown scope for the
next shutdown request. When the next shutdown is performed, the platform
specific portion of PSCI-system_off can use the chosen shutdown scope.
Signed-off-by: NRajan Vaja <rajan.vaja@xilinx.com>
Signed-off-by: NStefan Krsmanovic <stefan.krsmanovic@aggios.com>
Signed-off-by: NMichal Simek <michal.simek@xilinx.com>
Signed-off-by: NTejas Patel <tejas.patel@xilinx.com>
Signed-off-by: NJolly Shah <jolly.shah@xilinx.com>
Link: https://lore.kernel.org/r/1587761887-4279-25-git-send-email-jolly.shah@xilinx.comSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Add system shutdown API interface which asks firmware to
perform system shutdown/restart.
Signed-off-by: NRajan Vaja <rajan.vaja@xilinx.com>
Signed-off-by: NMichal Simek <michal.simek@xilinx.com>
Signed-off-by: NJolly Shah <jolly.shah@xilinx.com>
Link: https://lore.kernel.org/r/1587761887-4279-24-git-send-email-jolly.shah@xilinx.comSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Add firmware-ggs sysfs interface which provides read/write
interface to global storage registers.
Signed-off-by: NRajan Vaja <rajan.vaja@xilinx.com>
Signed-off-by: NMichal Simek <michal.simek@xilinx.com>
Signed-off-by: NTejas Patel <tejas.patel@xilinx.com>
Signed-off-by: NJolly Shah <jolly.shah@xilinx.com>
Link: https://lore.kernel.org/r/1587761887-4279-23-git-send-email-jolly.shah@xilinx.comSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Add APIs to read/write PGGS and GGS registers.
Signed-off-by: NRajan Vaja <rajan.vaja@xilinx.com>
Signed-off-by: NJolly Shah <jolly.shah@xilinx.com>
Link: https://lore.kernel.org/r/1587761887-4279-22-git-send-email-jolly.shah@xilinx.comSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Use direct function call instead of using eemi ops for fpga related
APIs. Also remove eemi ops structure.
Signed-off-by: NRajan Vaja <rajan.vaja@xilinx.com>
Signed-off-by: NJolly Shah <jolly.shah@xilinx.com>
Link: https://lore.kernel.org/r/1587761887-4279-21-git-send-email-jolly.shah@xilinx.comSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Use direct function call for aes engine instead of using eemi ops.
Signed-off-by: NRajan Vaja <rajan.vaja@xilinx.com>
Signed-off-by: NJolly Shah <jolly.shah@xilinx.com>
Link: https://lore.kernel.org/r/1587761887-4279-20-git-send-email-jolly.shah@xilinx.comSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Use direct function call instead of using eemi ops for
set_requirement.
Signed-off-by: NRajan Vaja <rajan.vaja@xilinx.com>
Signed-off-by: NJolly Shah <jolly.shah@xilinx.com>
Link: https://lore.kernel.org/r/1587761887-4279-19-git-send-email-jolly.shah@xilinx.comSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Use direct function call instead of using eemi ops for release_node.
Signed-off-by: NRajan Vaja <rajan.vaja@xilinx.com>
Signed-off-by: NJolly Shah <jolly.shah@xilinx.com>
Link: https://lore.kernel.org/r/1587761887-4279-18-git-send-email-jolly.shah@xilinx.comSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Use direct function call instead of using eemi ops for request_node.
Signed-off-by: NRajan Vaja <rajan.vaja@xilinx.com>
Signed-off-by: NJolly Shah <jolly.shah@xilinx.com>
Link: https://lore.kernel.org/r/1587761887-4279-17-git-send-email-jolly.shah@xilinx.comSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Use direct function call instead of eemi ops for set_suspend_mode.
Signed-off-by: NRajan Vaja <rajan.vaja@xilinx.com>
Signed-off-by: NJolly Shah <jolly.shah@xilinx.com>
Link: https://lore.kernel.org/r/1587761887-4279-16-git-send-email-jolly.shah@xilinx.comSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Use direct function call instead of eemi ops for init_finalize.
Signed-off-by: NRajan Vaja <rajan.vaja@xilinx.com>
Signed-off-by: NJolly Shah <jolly.shah@xilinx.com>
Link: https://lore.kernel.org/r/1587761887-4279-15-git-send-email-jolly.shah@xilinx.comSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Use direct function call instead of using eemi ops for
reset_get_status.
Signed-off-by: NRajan Vaja <rajan.vaja@xilinx.com>
Signed-off-by: NJolly Shah <jolly.shah@xilinx.com>
Link: https://lore.kernel.org/r/1587761887-4279-14-git-send-email-jolly.shah@xilinx.comSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Use direct function call instead of using eemi ops for
reset_assert.
Signed-off-by: NRajan Vaja <rajan.vaja@xilinx.com>
Signed-off-by: NJolly Shah <jolly.shah@xilinx.com>
Link: https://lore.kernel.org/r/1587761887-4279-13-git-send-email-jolly.shah@xilinx.comSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Remove IOCTL API and use individual APIs for better readability.
Signed-off-by: NRajan Vaja <rajan.vaja@xilinx.com>
Signed-off-by: NJolly Shah <jolly.shah@xilinx.com>
Link: https://lore.kernel.org/r/1587761887-4279-12-git-send-email-jolly.shah@xilinx.comSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Use direct function call instead of eemi ops for clock set/get parent.
Signed-off-by: NRajan Vaja <rajan.vaja@xilinx.com>
Signed-off-by: NJolly Shah <jolly.shah@xilinx.com>
Link: https://lore.kernel.org/r/1587761887-4279-11-git-send-email-jolly.shah@xilinx.comSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Use direct function call instead of eemi ops for clock set/get rate.
Signed-off-by: NRajan Vaja <rajan.vaja@xilinx.com>
Signed-off-by: NJolly Shah <jolly.shah@xilinx.com>
Link: https://lore.kernel.org/r/1587761887-4279-10-git-send-email-jolly.shah@xilinx.comSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Use direct function call instead of using eemi ops for
clock_getdivider.
Signed-off-by: NRajan Vaja <rajan.vaja@xilinx.com>
Signed-off-by: NJolly Shah <jolly.shah@xilinx.com>
Link: https://lore.kernel.org/r/1587761887-4279-9-git-send-email-jolly.shah@xilinx.comSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Use direct function call instead of using eemi ops for
clock_setdivider.
Signed-off-by: NRajan Vaja <rajan.vaja@xilinx.com>
Signed-off-by: NJolly Shah <jolly.shah@xilinx.com>
Link: https://lore.kernel.org/r/1587761887-4279-8-git-send-email-jolly.shah@xilinx.comSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Use direct function call instead of eemi ops for clock_getstate.
Signed-off-by: NRajan Vaja <rajan.vaja@xilinx.com>
Signed-off-by: NJolly Shah <jolly.shah@xilinx.com>
Link: https://lore.kernel.org/r/1587761887-4279-7-git-send-email-jolly.shah@xilinx.comSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Use direct function call for clock_disable instead using of eemi ops.
Signed-off-by: NRajan Vaja <rajan.vaja@xilinx.com>
Signed-off-by: NJolly Shah <jolly.shah@xilinx.com>
Link: https://lore.kernel.org/r/1587761887-4279-6-git-send-email-jolly.shah@xilinx.comSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Use direct function call for clock_enable instead of eemi ops.
Signed-off-by: NRajan Vaja <rajan.vaja@xilinx.com>
Signed-off-by: NJolly Shah <jolly.shah@xilinx.com>
Link: https://lore.kernel.org/r/1587761887-4279-5-git-send-email-jolly.shah@xilinx.comSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Use direct function call for query_data instead of using eemi ops.
Signed-off-by: NRajan Vaja <rajan.vaja@xilinx.com>
Signed-off-by: NJolly Shah <jolly.shah@xilinx.com>
Link: https://lore.kernel.org/r/1587761887-4279-4-git-send-email-jolly.shah@xilinx.comSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Use direct function call instead of eemi ops for get_chipid.
Signed-off-by: NRajan Vaja <rajan.vaja@xilinx.com>
Signed-off-by: NJolly Shah <jolly.shah@xilinx.com>
Link: https://lore.kernel.org/r/1587761887-4279-3-git-send-email-jolly.shah@xilinx.comSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Use direct function calls instead of using eemi ops. So remove
eemi ops for get_api_version and use direct function call.
Signed-off-by: NRajan Vaja <rajan.vaja@xilinx.com>
Signed-off-by: NJolly Shah <jolly.shah@xilinx.com>
Link: https://lore.kernel.org/r/1587761887-4279-2-git-send-email-jolly.shah@xilinx.comSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

SD DLL resets are required for some of the operations on ZynqMP platform.
Add DLL reset support in ZynqMP firmware driver for SD DLL reset.
Signed-off-by: NManish Narani <manish.narani@xilinx.com>
Acked-by: NMichal Simek <michal.simek@xilinx.com>
Link: https://lore.kernel.org/r/1579602095-30060-3-git-send-email-manish.narani@xilinx.comSigned-off-by: NUlf Hansson <ulf.hansson@linaro.org>

The Tap Delay setup ioctl was not added to valid list due to which it
may fail to set Tap Delays for SD. This patch fixes the same.
Signed-off-by: NManish Narani <manish.narani@xilinx.com>
Acked-by: NMichal Simek <michal.simek@xilinx.com>
Link: https://lore.kernel.org/r/1579602095-30060-2-git-send-email-manish.narani@xilinx.comSigned-off-by: NUlf Hansson <ulf.hansson@linaro.org>

Add ZynqMP firmware AES API to perform encryption/decryption of given data.
Signed-off-by: NKalyani Akula <kalyani.akula@xilinx.com>
Acked-by: NMichal Simek <michal.simek@xilinx.com>
Signed-off-by: NHerbert Xu <herbert@gondor.apana.org.au>

Warn user if clock is used by more than allowed devices.
This check is done by firmware and returns respective
error code. Upon receiving error code for excessive user,
warn user for the same.

This change is done to restrict VPLL use count. It is
assumed that VPLL is used by one user only.
Signed-off-by: NMichal Simek <michal.simek@xilinx.com>
Signed-off-by: NRajan Vaja <rajan.vaja@xilinx.com>
Link: https://lkml.kernel.org/r/1575527759-26452-4-git-send-email-rajan.vaja@xilinx.comAcked-by: NMichal Simek <michal.simek@xilinx.com>
Signed-off-by: NStephen Boyd <sboyd@kernel.org>

Query for corresponding feature before calling EEMI API
from the driver.
Signed-off-by: NRavi Patel <ravi.patel@xilinx.com>
Signed-off-by: NMichal Simek <michal.simek@xilinx.com>
Signed-off-by: NRajan Vaja <rajan.vaja@xilinx.com>

Versal is xilinx's next generation soc. This patch adds
driver support required to be compatible with versal device.
Signed-off-by: NJolly Shah <jolly.shah@xilinx.com>
Signed-off-by: NMichal Simek <michal.simek@xilinx.com>

This Patch Adds fpga API's to support the Bitstream loading
by using firmware interface.
Signed-off-by: NNava kishore Manne <nava.manne@xilinx.com>
Reviewed-by: NMoritz Fischer <mdf@kernel.org>
Signed-off-by: NMichal Simek <michal.simek@xilinx.com>

Driver needs ZynqMP firmware interface to call EEMI
APIs. In case firmware is not ready, dependent drivers
should wait until the firmware is ready.
Signed-off-by: NRajan Vaja <rajan.vaja@xilinx.com>
Signed-off-by: NJolly Shah <jollys@xilinx.com>
Signed-off-by: NMichal Simek <michal.simek@xilinx.com>

The zynqmp-genpd driver communicates the usage requirements
for logical power domains / devices to the platform FW.
FW is responsible for choosing appropriate power states,
taking Linux' usage information into account.
Signed-off-by: NRajan Vaja <rajan.vaja@xilinx.com>
Signed-off-by: NJolly Shah <jolly.shah@xilinx.com>
Signed-off-by: NMichal Simek <michal.simek@xilinx.com>

Add Xilinx ZynqMP firmware APIs to control node status
and power. These APIs allows turning on/off power domain
and setting capabilities of devices present in power domain.
Signed-off-by: NRajan Vaja <rajan.vaja@xilinx.com>
Signed-off-by: NJolly Shah <jolly.shah@xilinx.com>
Signed-off-by: NMichal Simek <michal.simek@xilinx.com>

Add Xilinx ZynqMP firmware APIs to set suspend mode
and inform firmware that master has initialized its
own power management.
Signed-off-by: NRajan Vaja <rajan.vaja@xilinx.com>
Signed-off-by: NJolly Shah <jolly.shah@xilinx.com>
Signed-off-by: NMichal Simek <michal.simek@xilinx.com>

This patch adds a new API to provide access to the
hardware related data like soc revision, IDCODE... etc.
Signed-off-by: NNava kishore Manne <nava.manne@xilinx.com>
Signed-off-by: NMichal Simek <michal.simek@xilinx.com>