Currently we are relying on the exact match of the regulator name to
find MICVDD, we should add an explicit supply mapping to allow this to
be found more reliably.
Signed-off-by: NCharles Keepax <ckeepax@opensource.cirrus.com>
Signed-off-by: NLee Jones <lee.jones@linaro.org>

regmap_read won't set val to anything if an ACKed bus fails.
Signed-off-by: NStuart Henderson <stuarth@opensource.cirrus.com>
Signed-off-by: NCharles Keepax <ckeepax@opensource.cirrus.com>
Signed-off-by: NLee Jones <lee.jones@linaro.org>

The pinctrl.txt file was converted into reStructuredText and moved into
driver-api folder. This patch updates the broken reference.

Fixes: 5a9b7383 ("pinctrl.txt: move it to the driver-api book")
Signed-off-by: NOtto Sabart <ottosabart@seberm.com>
Signed-off-by: NCharles Keepax <ckeepax@opensource.cirrus.com>
Reviewed-by: NMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Signed-off-by: NLee Jones <lee.jones@linaro.org>

When the driver is used with a subdevice that is disabled in the
kernel configuration, clang gets a little confused about the
control flow and fails to notice that n_subdevs is only
uninitialized when subdevs is NULL, and we check for that,
leading to a false-positive warning:

drivers/mfd/arizona-core.c:1423:19: error: variable 'n_subdevs' is uninitialized when used here
      [-Werror,-Wuninitialized]
                              subdevs, n_subdevs, NULL, 0, NULL);
                                       ^~~~~~~~~
drivers/mfd/arizona-core.c:999:15: note: initialize the variable 'n_subdevs' to silence this warning
        int n_subdevs, ret, i;
                     ^
                      = 0

Ideally, we would rearrange the code to avoid all those early
initializations and have an explicit exit in each disabled case,
but it's much easier to chicken out and add one more initialization
here to shut up the warning.
Signed-off-by: NArnd Bergmann <arnd@arndb.de>
Reviewed-by: NNathan Chancellor <natechancellor@gmail.com>
Signed-off-by: NCharles Keepax <ckeepax@opensource.cirrus.com>
Signed-off-by: NLee Jones <lee.jones@linaro.org>

The logic for setting the of_node on devices created by mfd did not set
the fwnode pointer to match, which caused fwnode-based APIs to
malfunction on these devices since the fwnode pointer was null. Fix
this.
Signed-off-by: NRobert Hancock <hancock@sedsystems.ca>
Signed-off-by: NLee Jones <lee.jones@linaro.org>

Easier to find and maintain if the device tables sorted by ID.
Do it here for intel-lpss MFD driver.
Signed-off-by: NAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: NLee Jones <lee.jones@linaro.org>

The RTC core already has error messages in case of failure, there is no
need to have another message in the driver.
Signed-off-by: NAlexandre Belloni <alexandre.belloni@bootlin.com>
Signed-off-by: NLee Jones <lee.jones@linaro.org>

Allow overwriting the values in BD718XX_REG_PWRONCONFIG0 and
BD718XX_REG_PWRONCONFIG1 via devicetree. Read values in milliseconds and
attempt to round them to something supported by the hardware.

Keep existing values (from bootloader or OTP) if property is not
present.
Signed-off-by: NLeonard Crestez <leonard.crestez@nxp.com>
Reviewed-By: NMatti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
[Lee: Fixed-up merge/API conflict]
Signed-off-by: NLee Jones <lee.jones@linaro.org>

These values can be overwritten at probe time.
Signed-off-by: NLeonard Crestez <leonard.crestez@nxp.com>
Acked-By: NMatti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
Signed-off-by: NLee Jones <lee.jones@linaro.org>

The reset button on imx8mm-evk is tied to PWRON_B pin of bd71847 and the
long press duration is set to zero from OTP. The linux driver overrides
those values and breaks reset from button.

Overwriting OTP or bootloader configuration with some hardcoded defaults
is not desirable, keep already programmed values instead.
Signed-off-by: NLeonard Crestez <leonard.crestez@nxp.com>
Acked-By: NMatti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
Signed-off-by: NLee Jones <lee.jones@linaro.org>

Register driver when EC indicates has precise lid angle calculation code
running.
Fix incorrect extra resource allocation in cros_ec_sensors_register().
Signed-off-by: NGwendal Grignou <gwendal@chromium.org>
Signed-off-by: NLee Jones <lee.jones@linaro.org>

MODULE_DEVICE_TABLE(of, <of_match_table>) should be called to complete DT
OF mathing mechanism and register it.

Before this patch:
modinfo ./drivers/mfd/madera.ko | grep alias

After this patch:
modinfo ./drivers/mfd/madera.ko | grep alias
alias:          of:N*T*Ccirrus,wm1840C*
alias:          of:N*T*Ccirrus,wm1840
alias:          of:N*T*Ccirrus,cs47l91C*
alias:          of:N*T*Ccirrus,cs47l91
alias:          of:N*T*Ccirrus,cs47l90C*
alias:          of:N*T*Ccirrus,cs47l90
alias:          of:N*T*Ccirrus,cs47l85C*
alias:          of:N*T*Ccirrus,cs47l85
alias:          of:N*T*Ccirrus,cs47l35C*
alias:          of:N*T*Ccirrus,cs47l35
Reported-by: NJavier Martinez Canillas <javier@dowhile0.org>
Signed-off-by: NDaniel Gomez <dagmcr@gmail.com>
Signed-off-by: NLee Jones <lee.jones@linaro.org>

Merge branches 'ib-mfd-clk-gpio-power-regulator-rtc-5.3', 'ib-mfd-clk-regulator-rtc-5.3', 'ib-mfd-cros-5.3' and 'ib-mfd-regulator-5.3' into ibs-for-mfd-merged

Currently the LP87565_DEVICE_TYPE_LP87561_Q1 case does not have a
break statement, causing it to fall through to a dev_err message.
Fix this by adding in the missing break statement.

Addresses-Coverity: ("Missing break in switch")
Fixes: 7ee63bd7 ("regulator: lp87565: Add 4-phase lp87561 regulator support")
Signed-off-by: NColin Ian King <colin.king@canonical.com>
Reviewed-by: NKeerthy <j-keerthy@ti.com>
Signed-off-by: NLee Jones <lee.jones@linaro.org>

RK809 and RK817 are power management IC chips for multimedia products.
most of their functions and registers are same, including the clkout
funciton.
Signed-off-by: NTony Xie <tony.xie@rock-chips.com>
Acked-by: NStephen Boyd <sboyd@kernel.org>
Signed-off-by: NLee Jones <lee.jones@linaro.org>

RK809 and RK817 are power management IC chips for multimedia products.
Most of their functions and registers are same, including the rtc.
Signed-off-by: NTony Xie <tony.xie@rock-chips.com>
Acked-by: NAlexandre Belloni <alexandre.belloni@bootlin.com>
Signed-off-by: NLee Jones <lee.jones@linaro.org>

Add device tree bindings documentation for Rockchip's RK809 & RK817 PMIC.
Signed-off-by: NTony Xie <tony.xie@rock-chips.com>
Reviewed-by: NRob Herring <robh@kernel.org>
Signed-off-by: NLee Jones <lee.jones@linaro.org>

    Add support for the rk809 and rk817 regulator driver.
    Their specifications are as follows：
    1. The RK809 and RK809 consist of 5 DCDCs, 9 LDOs
       and have the same registers for these components except dcdc5.
    2. The dcdc5 is a boost dcdc for RK817 and is a buck for RK809.
    3. The RK817 has one switch but The Rk809 has two.

    The output voltages are configurable and are meant to supply power
    to the main processor and other components.
Signed-off-by: NTony Xie <tony.xie@rock-chips.com>
Acked-by: NMark Brown <broonie@kernel.org>
[rebased on top of 5.2-rc1]
Signed-off-by: NHeiko Stuebner <heiko@sntech.de>
Signed-off-by: NLee Jones <lee.jones@linaro.org>

The RK809 and RK817 are a Power Management IC (PMIC) for multimedia
and handheld devices. They contains the following components:
  - Regulators
  - RTC
  - Clocking

Both RK809 and RK817 chips are using a similar register map,
so we can reuse the RTC and Clocking functionality.
Most of regulators have a some implementation also.
Signed-off-by: NTony Xie <tony.xie@rock-chips.com>
Acked-by: NStephen Boyd <sboyd@kernel.org>
Signed-off-by: NLee Jones <lee.jones@linaro.org>

ROHM BD70528 PMIC includes battery charger block. Support charger
staus queries and doing few basic settings like input current limit
and charging current.
Signed-off-by: NMatti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
Acked-by: NSebastian Reichel <sebastian.reichel@collabora.com>
Signed-off-by: NLee Jones <lee.jones@linaro.org>

Support RTC block in ROHM bd70528 power management IC. Support
getting and setting the time and date as well as arming an alarm
which can also be used to wake the PMIC from standby state.

HW supports wake interrupt only for the next 24 hours (sec, minute
and hour information only) so we limit also the alarm interrupt to
this 24 hours for the sake of consistency.
Signed-off-by: NMatti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
Acked-by: NAlexandre Belloni <alexandre.belloni@bootlin.com>
Signed-off-by: NLee Jones <lee.jones@linaro.org>

ROHM BD70528 PMIC has 4 GPIO pins. Allow them to be
controlled by GPIO framework.

IRQs are handled by regmap-irq and GPIO driver is not
aware of the irq usage.
Signed-off-by: NMatti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
Reviewed-by: NLinus Walleij <linus.walleij@linaro.org>
Signed-off-by: NLee Jones <lee.jones@linaro.org>

Document bindings for regulators (3 bucks, 3 LDOs and 2 LED
drivers) and 4 GPIO pins which can be configured for I/O or
as interrupt sources withe configurable trigger levels.
Signed-off-by: NMatti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
Reviewed-by: NRob Herring <robh@kernel.org>
Acked-by: NLinus Walleij <linus.walleij@linaro.org>
Signed-off-by: NLee Jones <lee.jones@linaro.org>

ROHM BD70528 is an ultra low power PMIC with similar 32K clk as
bd718x7. Only difference (from clk perspective) is register address.
Add support for controlling BD70528 clk using bd718x7 driver.
Signed-off-by: NMatti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
Acked-by: NStephen Boyd <sboyd@kernel.org>
Signed-off-by: NLee Jones <lee.jones@linaro.org>

ROHM BD70528MWV is an ultra-low quiescent current general
purpose single-chip power management IC for battery-powered
portable devices.

Add MFD core which enables chip access for following subdevices:
	- regulators/LED drivers
	- battery-charger
	- gpios
	- 32.768kHz clk
	- RTC
	- watchdog
Signed-off-by: NMatti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
Signed-off-by: NLee Jones <lee.jones@linaro.org>

Split the bd718x7.h to ROHM common and bd718x7 specific parts
so that we do not need to add same things in every new ROHM
PMIC header. Please note that this change requires changes also
in bd718x7 sub-device drivers for regulators and clk.
Signed-off-by: NMatti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
Acked-by: NMark Brown <broonie@kernel.org>
Acked-by: NStephen Boyd <sboyd@kernel.org>
Signed-off-by: NLee Jones <lee.jones@linaro.org>

The LP8756x family has a single output 4-phase regulator
configuration. Add support for the same. The control
lies in the master buck which is buck0 for 4-phase
configuration. Enable/disable/voltage set happen via
buck0 registers.

Data Sheet: https://www.ti.com/lit/ds/symlink/lp87561-q1.pdfSigned-off-by: NKeerthy <j-keerthy@ti.com>
Acked-by: NMark Brown <broonie@kernel.org>
Signed-off-by: NLee Jones <lee.jones@linaro.org>

Add support for 4-phase LP87561 combination.

Data Sheet: https://www.ti.com/lit/ds/symlink/lp87561-q1.pdfSigned-off-by: NKeerthy <j-keerthy@ti.com>
Signed-off-by: NLee Jones <lee.jones@linaro.org>

lp87561 is a single output 4-phase regulator configuration.
Add support for the same.

Data Sheet: https://www.ti.com/lit/ds/symlink/lp87561-q1.pdfSigned-off-by: NKeerthy <j-keerthy@ti.com>
Signed-off-by: NLee Jones <lee.jones@linaro.org>

Improve I2S API.
Rename ec_response_codec_gain into ec_codec_i2s_gain,
update caller accordlingly.
Signed-off-by: NGwendal Grignou <gwendal@chromium.org>
Acked-by: NEnric Balletbo i Serra <enric.balletbo@collabora.com>
Acked-by: NBenson Leung <bleung@chromium.org>
Reviewed-by: NFabien Lahoudere <fabien.lahoudere@collabora.com>
Signed-off-by: NLee Jones <lee.jones@linaro.org>

Add commands for test and management.
Add command space for future development.
Signed-off-by: NGwendal Grignou <gwendal@chromium.org>
Acked-by: NEnric Balletbo i Serra <enric.balletbo@collabora.com>
Acked-by: NBenson Leung <bleung@chromium.org>
Reviewed-by: NFabien Lahoudere <fabien.lahoudere@collabora.com>
Signed-off-by: NLee Jones <lee.jones@linaro.org>

Add API to store SKU, Cros board information in EC flash memory.
Add API to store security data in EC.
Signed-off-by: NGwendal Grignou <gwendal@chromium.org>
Acked-by: NEnric Balletbo i Serra <enric.balletbo@collabora.com>
Acked-by: NBenson Leung <bleung@chromium.org>
Reviewed-by: NFabien Lahoudere <fabien.lahoudere@collabora.com>
Signed-off-by: NLee Jones <lee.jones@linaro.org>

Add command to retrieve signature of image stored in the RW memory
slot(s).
Signed-off-by: NGwendal Grignou <gwendal@chromium.org>
Acked-by: NEnric Balletbo i Serra <enric.balletbo@collabora.com>
Acked-by: NBenson Leung <bleung@chromium.org>
Reviewed-by: NFabien Lahoudere <fabien.lahoudere@collabora.com>
Signed-off-by: NLee Jones <lee.jones@linaro.org>

Add API for fingerprint sensor presented by embedded controller.
Signed-off-by: NGwendal Grignou <gwendal@chromium.org>
Acked-by: NEnric Balletbo i Serra <enric.balletbo@collabora.com>
Acked-by: NBenson Leung <bleung@chromium.org>
Reviewed-by: NFabien Lahoudere <fabien.lahoudere@collabora.com>
Signed-off-by: NLee Jones <lee.jones@linaro.org>

Add API to control touchpad presented by Embedded Controller.
Signed-off-by: NGwendal Grignou <gwendal@chromium.org>
Acked-by: NEnric Balletbo i Serra <enric.balletbo@collabora.com>
Acked-by: NBenson Leung <bleung@chromium.org>
Reviewed-by: NFabien Lahoudere <fabien.lahoudere@collabora.com>
Signed-off-by: NLee Jones <lee.jones@linaro.org>

Allow EC to talk to other ECs that are not presented to the host.
Neeed when EC are present in detachable keyboard.
Signed-off-by: NGwendal Grignou <gwendal@chromium.org>
Acked-by: NEnric Balletbo i Serra <enric.balletbo@collabora.com>
Acked-by: NBenson Leung <bleung@chromium.org>
Reviewed-by: NFabien Lahoudere <fabien.lahoudere@collabora.com>
Signed-off-by: NLee Jones <lee.jones@linaro.org>

Prevent direct i2c access to device behind EC when not in development mode.
Signed-off-by: NGwendal Grignou <gwendal@chromium.org>
Acked-by: NEnric Balletbo i Serra <enric.balletbo@collabora.com>
Acked-by: NBenson Leung <bleung@chromium.org>
Reviewed-by: NFabien Lahoudere <fabien.lahoudere@collabora.com>
Signed-off-by: NLee Jones <lee.jones@linaro.org>

Add API to update battery firmware.
Signed-off-by: NGwendal Grignou <gwendal@chromium.org>
Acked-by: NEnric Balletbo i Serra <enric.balletbo@collabora.com>
Acked-by: NBenson Leung <bleung@chromium.org>
Reviewed-by: NFabien Lahoudere <fabien.lahoudere@collabora.com>
Signed-off-by: NLee Jones <lee.jones@linaro.org>

Add support for controlling hibernation of the Embedded Controller.
Signed-off-by: NGwendal Grignou <gwendal@chromium.org>
Acked-by: NEnric Balletbo i Serra <enric.balletbo@collabora.com>
Acked-by: NBenson Leung <bleung@chromium.org>
Reviewed-by: NFabien Lahoudere <fabien.lahoudere@collabora.com>
Signed-off-by: NLee Jones <lee.jones@linaro.org>

Add command to allow keyboard testing in factory.
Signed-off-by: NGwendal Grignou <gwendal@chromium.org>
Acked-by: NEnric Balletbo i Serra <enric.balletbo@collabora.com>
Acked-by: NBenson Leung <bleung@chromium.org>
Reviewed-by: NFabien Lahoudere <fabien.lahoudere@collabora.com>
Signed-off-by: NLee Jones <lee.jones@linaro.org>