1. 25 9月, 2018 3 次提交
  2. 24 8月, 2018 2 次提交
    • M
      iommu/rockchip: Move irq request past pm_runtime_enable · 1aa55ca9
      Marc Zyngier 提交于
      Enabling the interrupt early, before power has been applied to the
      device, can result in an interrupt being delivered too early if:
      
      - the IOMMU shares an interrupt with a VOP
      - the VOP has a pending interrupt (after a kexec, for example)
      
      In these conditions, we end-up taking the interrupt without
      the IOMMU being ready to handle the interrupt (not powered on).
      
      Moving the interrupt request past the pm_runtime_enable() call
      makes sure we can at least access the IOMMU registers. Note that
      this is only a partial fix, and that the VOP interrupt will still
      be screaming until the VOP driver kicks in, which advocates for
      a more synchronized interrupt enabling/disabling approach.
      
      Fixes: 0f181d3c ("iommu/rockchip: Add runtime PM support")
      Reviewed-by: NHeiko Stuebner <heiko@sntech.de>
      Signed-off-by: NMarc Zyngier <marc.zyngier@arm.com>
      Signed-off-by: NOlof Johansson <olof@lixom.net>
      1aa55ca9
    • M
      iommu/rockchip: Handle errors returned from PM framework · 3fc7c5c0
      Marc Zyngier 提交于
      pm_runtime_get_if_in_use can fail: either PM has been disabled
      altogether (-EINVAL), or the device hasn't been enabled yet (0).
      Sadly, the Rockchip IOMMU driver tends to conflate the two things
      by considering a non-zero return value as successful.
      
      This has the consequence of hiding other bugs, so let's handle this
      case throughout the driver, with a WARN_ON_ONCE so that we can try
      and work out what happened.
      
      Fixes: 0f181d3c ("iommu/rockchip: Add runtime PM support")
      Reviewed-by: NHeiko Stuebner <heiko@sntech.de>
      Signed-off-by: NMarc Zyngier <marc.zyngier@arm.com>
      Signed-off-by: NOlof Johansson <olof@lixom.net>
      3fc7c5c0
  3. 18 8月, 2018 2 次提交
  4. 08 8月, 2018 2 次提交
  5. 28 7月, 2018 1 次提交
  6. 27 7月, 2018 7 次提交
  7. 26 7月, 2018 4 次提交
  8. 20 7月, 2018 12 次提交
  9. 10 7月, 2018 2 次提交
  10. 06 7月, 2018 5 次提交