1. 20 9月, 2018 1 次提交
  2. 14 9月, 2018 1 次提交
  3. 13 9月, 2018 1 次提交
  4. 11 9月, 2018 1 次提交
  5. 10 9月, 2018 1 次提交
  6. 04 9月, 2018 7 次提交
  7. 03 9月, 2018 1 次提交
    • T
      ALSA: rawmidi: Initialize allocated buffers · 5a7b44a8
      Takashi Iwai 提交于
      syzbot reported the uninitialized value exposure in certain situations
      using virmidi loop.  It's likely a very small race at writing and
      reading, and the influence is almost negligible.  But it's safer to
      paper over this just by replacing the existing kvmalloc() with
      kvzalloc().
      
      Reported-by: syzbot+194dffdb8b22fc5d207a@syzkaller.appspotmail.com
      Signed-off-by: NTakashi Iwai <tiwai@suse.de>
      5a7b44a8
  8. 30 8月, 2018 3 次提交
    • P
      ALSA: hda: move hda_codec.h to include/sound · be57bfff
      Pierre-Louis Bossart 提交于
      As suggested by Takashi, move this header file to make it easier
      to include from e.g. the Intel Skylake driver in follow-up patches
      Signed-off-by: NPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
      Signed-off-by: NMark Brown <broonie@kernel.org>
      be57bfff
    • T
      ALSA: hda - Fix cancel_work_sync() stall from jackpoll work · 16037643
      Takashi Iwai 提交于
      On AMD/ATI controllers, the HD-audio controller driver allows a bus
      reset upon the error recovery, and its procedure includes the
      cancellation of pending jack polling work as found in
      snd_hda_bus_codec_reset().  This works usually fine, but it becomes a
      problem when the reset happens from the jack poll work itself; then
      calling cancel_work_sync() from the work being processed tries to wait
      the finish endlessly.
      
      As a workaround, this patch adds the check of current_work() and
      applies the cancel_work_sync() only when it's not from the
      jackpoll_work.
      
      This doesn't fix the root cause of the reported error below, but at
      least, it eases the unexpected stall of the whole system.
      
      Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=200937
      Cc: <stable@vger.kernel.org>
      Cc: Lukas Wunner <lukas@wunner.de>
      Signed-off-by: NTakashi Iwai <tiwai@suse.de>
      16037643
    • T
      ALSA: hda - Clean up jackpoll_ms option handling · 3a182c84
      Takashi Iwai 提交于
      Currently the jackpoll_ms option value is passed indirectly by
      referring to an array in chip->jackpoll_ms although each card needs to
      see only the assigned value.  Also, the sanity check is done at each
      time in get_jackpoll_interval() although basically jackpoll_ms option
      is a read-only, hence we need to evaluate only once at probe time.
      
      This patch is the code simplification about the above points: the jack
      polling interval is directly set to chip->jackpoll_interval so that it
      can be simply copied to each codec.
      
      No functional change but only code reduction.
      Signed-off-by: NTakashi Iwai <tiwai@suse.de>
      3a182c84
  9. 28 8月, 2018 10 次提交
  10. 27 8月, 2018 3 次提交
  11. 24 8月, 2018 1 次提交
  12. 21 8月, 2018 1 次提交
  13. 20 8月, 2018 3 次提交
  14. 16 8月, 2018 1 次提交
    • L
      ALSA: update dell-wmi mic-mute registration to new world order · 70b20dd7
      Linus Torvalds 提交于
      Commit c647f806 ("ALSA: hda - Allow multiple ADCs for mic mute LED
      controls") changed the return value of the snd_hda_gen_add_micmute_led()
      without actually updating the callers.
      
      Admittedly, almost no callers actually cared about the return value.
      But one call site very much did: the Dell wmi code.  It would see the
      registration return zero, which _used_ to mean "failed" but now means
      "success", and clear the dell_micmute_led_set_func pointer.
      
      End result: the successful registration would end up calling the Dell
      code that thought it had all failed, and call through a NULL pointer.
      
      To make matters worse, it ends up being a tail-call, and with the
      retpoline sequence you don't even see the caller (dell_micmute_update())
      in the stack trace, so the error ended up way less obvious than it
      should have been.
      
      Fixes: c647f806 "ALSA: hda - Allow multiple ADCs for mic mute LED controls"
      Cc: Takashi Iwai <tiwai@suse.de>
      Signed-off-by: NLinus Torvalds <torvalds@linux-foundation.org>
      70b20dd7
  15. 15 8月, 2018 1 次提交
    • T
      ALSA: seq: virmidi: Fix discarding the unsubscribed output · 82fd4b05
      Takashi Iwai 提交于
      The recent change to move the virmidi output processing to a work
      slightly modified the code to discard the unsubscribed outputs so that
      it works without a temporary buffer.  However, this is actually buggy,
      and may spew a kernel warning due to the unexpected call of
      snd_rawmidi_transmit_ack(), as triggered by syzbot.
      
      This patch takes back to the original code in that part, use a
      temporary buffer and simply repeat snd_rawmidi_transmit(), in order to
      address the regression.
      
      Fixes: f7debfe5 ("ALSA: seq: virmidi: Offload the output event processing")
      Reported-by: syzbot+ec5f605c91812d200367@syzkaller.appspotmail.com
      Signed-off-by: NTakashi Iwai <tiwai@suse.de>
      82fd4b05
  16. 09 8月, 2018 4 次提交