Fix lines over 80 characters by wrapping arguments in function calls,
improving the format for a better code readability.
Issue found by checkpatch.
Signed-off-by: NJavier F. Arias <jarias.linux@gmail.com>
Link: https://lore.kernel.org/r/6a12577f3b95a77e060a2fb60ff17ce94774c076.1571284318.git.jarias.linux@gmail.comSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Replace the hardcoded function names with the corresponding
predefined identifiers.
Issue found by checkpatch.
Signed-off-by: NJavier F. Arias <jarias.linux@gmail.com>
Link: https://lore.kernel.org/r/b2ff6a52a7140480c9fdb6486a6ac6b4eb51203b.1571284318.git.jarias.linux@gmail.comSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Add a L: tag so get_maintainers.pl output includes the linux-fsdevel list
Signed-off-by: NValdis Kletnieks <Valdis.Kletnieks@vt.edu>
Link: https://lore.kernel.org/r/20191023055353.695275-1-Valdis.Kletnieks@vt.eduSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

During concurrent mode(AP/STA + P2P), pass the mgmt frames received from
firmware to appropriate interface. Iterate the complete interface list
to pass frames on the interface which has registered to receive mgmt
frame. Added extra time for 'remain_on_ch' timer to ensure that timeout
for uncanceled remain_on_channel is not triggered & 'p2p_listen_state'
is not cleared before passing the mgmt frames to p2p interface.
Signed-off-by: NAjay Singh <ajay.kathat@microchip.com>
Link: https://lore.kernel.org/r/20191018124511.22751-1-ajay.kathat@microchip.comSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

The "rates_len" value needs to be capped so that the memcpy() doesn't
copy beyond the end of the array.

Fixes: c5c77ba1 ("staging: wilc1000: Add SDIO/SPI 802.11 driver")
Signed-off-by: NDan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: NAdham Abozaeid <adham.abozaeid@microchip.com>
Link: https://lore.kernel.org/r/20191017091832.GB31278@mwandaSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

In a fast disconnect/connect sequence, cfg80211_connect_result() can
fail to find the bss object which the driver is connecting to. Detailed
sequence of events:
* Driver is connected in STA mode
* Disconnect request arrives from user space. Driver disconnects and
  calls cfg80211_disconnected() which adds new event to the
  cfg80211_wq worker thread
* Connect request arrives from user space. cfg80211_connect() stores
  ssid/ssid_len and calls rdev_connect()
* __cfg80211_disconnected() runs in worker thread and zero
  wdev->ssid_len
* Connect succeeds. Driver calls cfg80211_connect_result() which fails
  to find the bss because wdev->ssid_len is zero

To overcome this, upon connect request, store the bss object in the
driver and upon connect completion pass it to kernel using
cfg80211_connect_bss().

Ref: bcdd49b0 ("store bss object and use cfg80211_connect_bss()")
Signed-off-by: NAdham Abozaeid <adham.abozaeid@microchip.com>
Link: https://lore.kernel.org/r/20191017165105.27429-1-adham.abozaeid@microchip.comSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Remove code valid only for 5 GHz, according to the TODO.

- find and remove remaining code valid only for 5 GHz. Most of the obvious
  ones have been removed, but things like channel > 14 still exist.
Signed-off-by: NMichael Straube <straube.linux@gmail.com>
Link: https://lore.kernel.org/r/20191024155918.13399-1-straube.linux@gmail.comSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Fix duplicated arguments to bitwise & operator.
Issue detected by coccinelle.
Signed-off-by: NJamal Shareef <jamal.k.shareef@gmail.com>
Link: https://lore.kernel.org/r/20191023215105.18049-1-jamal.k.shareef@gmail.comSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Fix lines ending with a '('. Issue found by checkpatch.
Signed-off-by: NCristianeNaves <cristianenavescardoso09@gmail.com>
Link: https://lore.kernel.org/r/20191024134623.GA4506@cristiane-Inspiron-5420Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Cleans up checks of "Alignment should match open parenthesis"
in file sm750_cursor.h
Signed-off-by: NGabriela Bittencourt <gabrielabittencourt00@gmail.com>
Link: https://lore.kernel.org/r/20191024163822.7157-4-gabrielabittencourt00@gmail.comSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Cleans up checks of "Alignment should match open parenthesis"
in file sm750_accel.h
Signed-off-by: NGabriela Bittencourt <gabrielabittencourt00@gmail.com>
Link: https://lore.kernel.org/r/20191024163822.7157-3-gabrielabittencourt00@gmail.comSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Cleans up checks of "Alignment should match open parenthesis"
in file ddk750_sii164.c
Signed-off-by: NGabriela Bittencourt <gabrielabittencourt00@gmail.com>
Link: https://lore.kernel.org/r/20191024163822.7157-2-gabrielabittencourt00@gmail.comSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Formatting comments in file drivers/staging/sm750fb/sm750_accel.h.
Signed-off-by: NGabriela Bittencourt <gabrielabittencourt00@gmail.com>

Link: https://lore.kernel.org/r/20191023163016.30217-3-gabrielabittencourt00@gmail.comSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Formatting comments in file drivers/staging/sm750fb/sm750_accel.c.
Signed-off-by: NGabriela Bittencourt <gabrielabittencourt00@gmail.com>

Link: https://lore.kernel.org/r/20191023163016.30217-2-gabrielabittencourt00@gmail.comSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Fix warnings of Block comments use * on subsequent lines.
Issue detected by checkpatch tool.
Signed-off-by: NJules Irenge <jbi.octave@gmail.com>
Link: https://lore.kernel.org/r/20191017173837.27336-1-jbi.octave@gmail.comSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Fix warnings of space required between operator and variables.
Issue detected by checkpatch tool
Signed-off-by: NJules Irenge <jbi.octave@gmail.com>
Link: https://lore.kernel.org/r/20191017163126.23992-1-jbi.octave@gmail.comSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Fix warnings of line over 80 characters.
Issue detected by checkepatch tool.
Signed-off-by: NJules Irenge <jbi.octave@gmail.com>
Link: https://lore.kernel.org/r/20191017150044.17746-1-jbi.octave@gmail.comSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Change "standred" on line 3 to "standard"
Signed-off-by: NEvan Chime <chime.evan.dri.devel@gmail.com>
Link: https://lore.kernel.org/r/20191018175759.GA8294@ik-ubuntuSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Change "in to" in "Changing comments in to linux standred format" on
line 3 to "into"
Signed-off-by: NEvan Chime <chime.evan.dri.devel@gmail.com>
Link: https://lore.kernel.org/r/20191018175725.GA8274@ik-ubuntuSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Fix warnings of comparision to bool.
Issue detected by coccinelle tool.
Signed-off-by: NJules Irenge <jbi.octave@gmail.com>
Acked-by: NJulia Lawall <julia.lawall@lip6.fr>
Link: https://lore.kernel.org/r/20191022185328.9387-1-jbi.octave@gmail.comSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

 Bool initializations should use true and false.  Bool tests don't need
 comparisons.  Based on contributions from Joe Perches, Rusty Russell
 and Bruce W Allan.

 The semantic patch that makes this report is available
 in scripts/coccinelle/misc/boolinit.cocci.

 More information about semantic patching is available at
 http://coccinelle.lip6.fr/Signed-off-by: NJamal Shareef <jamal.k.shareef@gmail.com>
Link: https://lore.kernel.org/r/20191024223937.2800-1-jamal.k.shareef@gmail.comSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

drivers/staging/comedi/drivers/ni_routes.c:52:21: warning:
 route_table_size defined but not used [-Wunused-const-variable=]

It is never used since introduction.
Signed-off-by: NYueHaibing <yuehaibing@huawei.com>
Reviewed-by: NIan Abbott <abbotti@mev.co.uk>
Link: https://lore.kernel.org/r/20191023075206.33088-1-yuehaibing@huawei.comSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Convert FFS_MEMORYERR to -ENOMEM
Signed-off-by: NValdis Kletnieks <Valdis.Kletnieks@vt.edu>
Link: https://lore.kernel.org/r/20191024155327.1095907-9-Valdis.Kletnieks@vt.eduSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Convert FFS_INVALIDPATH to -EINVAL
Signed-off-by: NValdis Kletnieks <Valdis.Kletnieks@vt.edu>
Link: https://lore.kernel.org/r/20191024155327.1095907-8-Valdis.Kletnieks@vt.eduSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Convert FFS_FILEEXIST to -EEXIST
Signed-off-by: NValdis Kletnieks <Valdis.Kletnieks@vt.edu>
Link: https://lore.kernel.org/r/20191024155327.1095907-7-Valdis.Kletnieks@vt.eduSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Convert FFS_NOTNAMETOOLONG to -ENAMETOOLONG
Signed-off-by: NValdis Kletnieks <Valdis.Kletnieks@vt.edu>
Link: https://lore.kernel.org/r/20191024155327.1095907-6-Valdis.Kletnieks@vt.eduSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Convert FFS_PERMISSIONERR to -EPERM
Signed-off-by: NValdis Kletnieks <Valdis.Kletnieks@vt.edu>
Link: https://lore.kernel.org/r/20191024155327.1095907-5-Valdis.Kletnieks@vt.eduSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Convert FFS_DIRBUSY to -EBUSY
Signed-off-by: NValdis Kletnieks <Valdis.Kletnieks@vt.edu>
Link: https://lore.kernel.org/r/20191024155327.1095907-4-Valdis.Kletnieks@vt.eduSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Convert FFS_NOTFOUND to -ENOENT
Signed-off-by: NValdis Kletnieks <Valdis.Kletnieks@vt.edu>
Link: https://lore.kernel.org/r/20191024155327.1095907-3-Valdis.Kletnieks@vt.eduSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Start cleaning up the odd scheme of return codes, starting with FFS_FULL
Signed-off-by: NValdis Kletnieks <Valdis.Kletnieks@vt.edu>
Link: https://lore.kernel.org/r/20191024155327.1095907-2-Valdis.Kletnieks@vt.eduSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

The build of xtensa allmodconfig gives warning of:
In function 'cfg80211_rtw_scan':
warning: the frame size of 1040 bytes is larger than 1024 bytes

Allocate memory for ssid dynamically to reduce the stack usage, as an
added benifit we can remove the memset by using kzalloc while allocating
memory.
Signed-off-by: NSudip Mukherjee <sudipm.mukherjee@gmail.com>
Link: https://lore.kernel.org/r/20191018101854.31876-1-sudipm.mukherjee@gmail.comSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

The build of xtensa allmodconfig gives warning of:
In function 'rtw_cfg80211_unlink_bss':
warning: the frame size of 1136 bytes is larger than 1024 bytes

Instead of having 'select_network' structure as a variable use it as a
pointer.
Signed-off-by: NSudip Mukherjee <sudipm.mukherjee@gmail.com>
Reviewed-by: NDan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/20191018104837.23246-1-sudipm.mukherjee@gmail.comSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

There is use of if..elseif..else condition which has same logic
in all three blocks.
Removed if..else block and placed log message instead that.
Signed-off-by: NAliasgar Surti <aliasgar.surti500@gmail.com>
Reviewed-by: NDan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/1571321906-15074-1-git-send-email-aliasgar.surti500@gmail.comSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

The `rtl8188eu` driver is built as a kmod in order to avoid symbol
conflicts (at link-time) with other Realtek drivers.

Internally, we use this driver as builtin [vs kmod], and we've identified
the `efuse_power_switch()` symbol to be conflicting at link-time with the
one from the `rtlwifi` driver.

An alternative solution would have been to rename the function, but it
doesn't look like it's being used outside of this driver, so just make it
static.
Signed-off-by: NAlexandru Ardelean <alexandru.ardelean@analog.com>
Link: https://lore.kernel.org/r/20191016065834.12186-1-alexandru.ardelean@analog.comSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Use devm_platform_ioremap_resource() to simplify the code a bit.
This is detected by coccinelle.
Signed-off-by: NYueHaibing <yuehaibing@huawei.com>
Link: https://lore.kernel.org/r/20191016085833.26376-1-yuehaibing@huawei.comSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Use devm_platform_ioremap_resource() to simplify the code a bit.
This is detected by coccinelle.
Signed-off-by: NYueHaibing <yuehaibing@huawei.com>
Link: https://lore.kernel.org/r/20191016090136.20620-1-yuehaibing@huawei.comSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Use devm_platform_ioremap_resource() to simplify the code a bit.
This is detected by coccinelle.
Signed-off-by: NYueHaibing <yuehaibing@huawei.com>
Link: https://lore.kernel.org/r/20191016090305.23392-1-yuehaibing@huawei.comSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Fix lines over 80 character warnings. Issue found
by checkpatch.
Signed-off-by: NJamal Shareef <jamal.k.shareef@gmail.com>
Link: https://lore.kernel.org/r/1f635b0469f93d8460d513f5fabd877dc5054a33.1571108943.git.jamal.k.shareef@gmail.comSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Remove blank lines to reduce whitespace and improve readability.
Signed-off-by: NMichael Straube <straube.linux@gmail.com>
Link: https://lore.kernel.org/r/20191015154535.27979-3-straube.linux@gmail.comSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Convert the local variables max_ampdu_len and min_mpdu_spacing from
unsigned char to u8 and remove unnecessary castings to u8 pointer.
Signed-off-by: NMichael Straube <straube.linux@gmail.com>
Link: https://lore.kernel.org/r/20191015154535.27979-2-straube.linux@gmail.comSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>