Signed-off-by: NBoris Barbulovski <bbarbulovski@gmail.com>
Signed-off-by: NThiago Macieira <thiago.macieira@intel.com>
Signed-off-by: NMichal Marek <mmarek@suse.com>

Signed-off-by: NBoris Barbulovski <bbarbulovski@gmail.com>
Signed-off-by: NThiago Macieira <thiago.macieira@intel.com>
Signed-off-by: NMichal Marek <mmarek@suse.com>

Signed-off-by: NBoris Barbulovski <bbarbulovski@gmail.com>
Signed-off-by: NThiago Macieira <thiago.macieira@intel.com>
Signed-off-by: NMichal Marek <mmarek@suse.com>

Signed-off-by: NBoris Barbulovski <bbarbulovski@gmail.com>
Signed-off-by: NThiago Macieira <thiago.macieira@intel.com>
Signed-off-by: NMichal Marek <mmarek@suse.com>

Signed-off-by: NBoris Barbulovski <bbarbulovski@gmail.com>
Signed-off-by: NThiago Macieira <thiago.macieira@intel.com>
Signed-off-by: NMichal Marek <mmarek@suse.com>

Signed-off-by: NBoris Barbulovski <bbarbulovski@gmail.com>
Signed-off-by: NThiago Macieira <thiago.macieira@intel.com>
Signed-off-by: NMichal Marek <mmarek@suse.com>

Signed-off-by: NBoris Barbulovski <bbarbulovski@gmail.com>
Signed-off-by: NThiago Macieira <thiago.macieira@intel.com>
Signed-off-by: NMichal Marek <mmarek@suse.com>

Signed-off-by: NBoris Barbulovski <bbarbulovski@gmail.com>
Signed-off-by: NThiago Macieira <thiago.macieira@intel.com>
Signed-off-by: NMichal Marek <mmarek@suse.com>

Signed-off-by: NBoris Barbulovski <bbarbulovski@gmail.com>
Signed-off-by: NThiago Macieira <thiago.macieira@intel.com>
Signed-off-by: NMichal Marek <mmarek@suse.com>

Signed-off-by: NBoris Barbulovski <bbarbulovski@gmail.com>
Signed-off-by: NThiago Macieira <thiago.macieira@intel.com>
Signed-off-by: NMichal Marek <mmarek@suse.com>

Signed-off-by: NBoris Barbulovski <bbarbulovski@gmail.com>
Signed-off-by: NThiago Macieira <thiago.macieira@intel.com>
Signed-off-by: NMichal Marek <mmarek@suse.com>

Signed-off-by: NBoris Barbulovski <bbarbulovski@gmail.com>
Signed-off-by: NThiago Macieira <thiago.macieira@intel.com>
Signed-off-by: NMichal Marek <mmarek@suse.com>

Signed-off-by: NBoris Barbulovski <bbarbulovski@gmail.com>
Signed-off-by: NThiago Macieira <thiago.macieira@intel.com>
Signed-off-by: NMichal Marek <mmarek@suse.com>

Signed-off-by: NBoris Barbulovski <bbarbulovski@gmail.com>
Signed-off-by: NThiago Macieira <thiago.macieira@intel.com>
Signed-off-by: NMichal Marek <mmarek@suse.com>

Signed-off-by: NBoris Barbulovski <bbarbulovski@gmail.com>
Signed-off-by: NThiago Macieira <thiago.macieira@intel.com>
Signed-off-by: NMichal Marek <mmarek@suse.com>

Signed-off-by: NBoris Barbulovski <bbarbulovski@gmail.com>
Signed-off-by: NThiago Macieira <thiago.macieira@intel.com>
Signed-off-by: NMichal Marek <mmarek@suse.com>

Signed-off-by: NBoris Barbulovski <bbarbulovski@gmail.com>
Signed-off-by: NThiago Macieira <thiago.macieira@intel.com>
Signed-off-by: NMichal Marek <mmarek@suse.com>

Signed-off-by: NBoris Barbulovski <bbarbulovski@gmail.com>
Signed-off-by: NThiago Macieira <thiago.macieira@intel.com>
Signed-off-by: NMichal Marek <mmarek@suse.com>

Signed-off-by: NBoris Barbulovski <bbarbulovski@gmail.com>
Signed-off-by: NThiago Macieira <thiago.macieira@intel.com>
Signed-off-by: NMichal Marek <mmarek@suse.com>

Signed-off-by: NBoris Barbulovski <bbarbulovski@gmail.com>
Signed-off-by: NThiago Macieira <thiago.macieira@intel.com>
Signed-off-by: NMichal Marek <mmarek@suse.com>

Signed-off-by: NBoris Barbulovski <bbarbulovski@gmail.com>
Signed-off-by: NThiago Macieira <thiago.macieira@intel.com>
Signed-off-by: NMichal Marek <mmarek@suse.com>

Signed-off-by: NBoris Barbulovski <bbarbulovski@gmail.com>
Signed-off-by: NThiago Macieira <thiago.macieira@intel.com>
Signed-off-by: NMichal Marek <mmarek@suse.com>

Signed-off-by: NBoris Barbulovski <bbarbulovski@gmail.com>
Signed-off-by: NThiago Macieira <thiago.macieira@intel.com>
Signed-off-by: NMichal Marek <mmarek@suse.com>

Recursive dependency issues with kconfig are unavoidable due to
some limitations with kconfig, since these issues are recurring
provide a hint to the user how they can resolve these dependency
issues and also document why such limitation exists.

While at it also document a bit of future prospects of ways to
enhance Kconfig, including providing formal semantics and evaluation
of use of a SAT solver. If you're interested in this work or prospects
of it check out the kconfig-sat project wiki [0] and mailing list [1].

[0] http://kernelnewbies.org/KernelProjects/kconfig-sat
[1] https://groups.google.com/d/forum/kconfig-sat

Cc: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: James Bottomley <jbottomley@odin.com>
Cc: Josh Triplett <josh@joshtriplett.org>
Cc: Paul Bolle <pebolle@tiscali.nl>
Cc: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Takashi Iwai <tiwai@suse.de>
Cc: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Jonathan Corbet <corbet@lwn.net>
Cc: Mate Soos <soos.mate@gmail.com>
Signed-off-by: NLuis R. Rodriguez <mcgrof@suse.com>
Signed-off-by: NMichal Marek <mmarek@suse.com>

Fix the following warning when compiling extract-cert:

  scripts/extract-cert.c: In function `write_cert':
  scripts/extract-cert.c:89:2: warning: format not a string literal and no format arguments [-Wformat-security]
    ERR(!i2d_X509_bio(wb, x509), cert_dst);
    ^

whereby the ERR() macro is taking cert_dst as the format string.  "%s"
should be used as the format string as the path could contain special
characters.
Signed-off-by: NDavid Howells <dhowells@redhat.com>
Reported-by: NJim Davis <jim.epost@gmail.com>
Acked-by : David Woodhouse <david.woodhouse@intel.com>
Cc: James Morris <jmorris@namei.org>
Signed-off-by: NAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: NLinus Torvalds <torvalds@linux-foundation.org>

"CONST <comparison> variable" checks like:

        if (NULL != foo)
and
        while (0 < bar(...))

where a constant (or what appears to be a constant like an upper case
identifier) is on the left of a comparison are generally preferred to be
written using the constant on the right side like:

        if (foo != NULL)
and
        while (bar(...) > 0)

Add a test for this.

Add a --fix option too, but only do it when the code is immediately
surrounded by parentheses to avoid misfixing things like "(0 < bar() +
constant)"
Signed-off-by: NJoe Perches <joe@perches.com>
Cc: Nicolas Morey Chaisemartin <nmorey@kalray.eu>
Cc: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: NAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: NLinus Torvalds <torvalds@linux-foundation.org>

commit 61031952 ("arch, x86: pmem api for ensuring durability of
persistent memory updates") added a new __pmem annotation for sparse
verification.  Add __pmem to the $Sparse variable so checkpatch can
appropriately ignore uses of this attribute too.
Signed-off-by: NJoe Perches <joe@perches.com>
Reviewed-by: NRoss Zwisler <ross.zwisler@linux.intel.com>
Acked-by: NAndy Whitcroft <apw@canonical.com>
Signed-off-by: NAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: NLinus Torvalds <torvalds@linux-foundation.org>

Using checkpatch.pl with Perl 5.22.0 generates the following warning:

    Unescaped left brace in regex is deprecated, passed through in regex;

This patch fixes the warnings by escaping occurrences of the left brace
inside the regular expression.
Signed-off-by: NEddie Kovsky <ewk@edkovsky.org>
Cc: Joe Perches <joe@perches.com>
Signed-off-by: NAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: NLinus Torvalds <torvalds@linux-foundation.org>

Fixes: and Link: lines may exceed 75 chars in the commit log.

So too can stack dump and dmesg lines and lines that seem
like filenames.

And Fixes: lines don't need to have a "commit" prefix before the
commit id.

Add exceptions for these types of lines.
Signed-off-by: NJoe Perches <joe@perches.com>
Reported-by: NPaul Bolle <pebolle@tiscali.nl>
Signed-off-by: NAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: NLinus Torvalds <torvalds@linux-foundation.org>

Using 0x%d is wrong.  Emit a message when it happens.

Miscellanea:

Improve the %Lu warning to match formats like %16Lu.
Signed-off-by: NJoe Perches <joe@perches.com>
Signed-off-by: NAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: NLinus Torvalds <torvalds@linux-foundation.org>

Making --strict the default for staging may help some people submit
patches without obvious defects.
Signed-off-by: NJoe Perches <joe@perches.com>
Cc: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: NAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: NLinus Torvalds <torvalds@linux-foundation.org>

Some of the block comment tests that are used only for networking are
appropriate for all patches.

For example, these styles are not encouraged:

	/*
	 block comment without introductory *
	*/
and
	/*
	 * block comment with line terminating */

Remove the networking specific test and add comments.

There are some infrequent false positives where code is lazily
commented out using /* and */ rather than using #if 0/#endif blocks
like:
	/* case foo:
	case bar: */
	case baz:
Signed-off-by: NJoe Perches <joe@perches.com>
Signed-off-by: NAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: NLinus Torvalds <torvalds@linux-foundation.org>

commit 34d8815f ("checkpatch: add --showfile to allow input via pipe
to show filenames") broke the --emacs with --file option.

Fix it.
Signed-off-by: NJoe Perches <joe@perches.com>
Signed-off-by: NAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: NLinus Torvalds <torvalds@linux-foundation.org>

Sergey Senozhatsky has modified several destroy functions that can
now be called with NULL values.

 - kmem_cache_destroy()
 - mempool_destroy()
 - dma_pool_destroy()

Update checkpatch to warn when those functions are preceded by an if.

Update checkpatch to --fix all the calls too only when the code style
form is using leading tabs.

from:
	if (foo)
		<func>(foo);
to:
	<func>(foo);
Signed-off-by: NJoe Perches <joe@perches.com>
Tested-by: NSergey Senozhatsky <sergey.senozhatsky@gmail.com>
Cc: David Rientjes <rientjes@google.com>
Cc: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: NAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: NLinus Torvalds <torvalds@linux-foundation.org>

Some really long declaration macros exist.

For instance;
  	DEFINE_DMA_BUF_EXPORT_INFO(exp_info);
and
	DECLARE_DM_KCOPYD_THROTTLE_WITH_MODULE_PARM(name, description)

Increase the limit from 2 words to 6 after DECLARE/DEFINE uses.
Signed-off-by: NJoe Perches <joe@perches.com>
Signed-off-by: NAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: NLinus Torvalds <torvalds@linux-foundation.org>

Many lines exist like

	if (foo)
			bar;

where the tabbed indentation of the branch is not one more than the "if"
line above it.

checkpatch should emit a warning on those lines.

Miscellenea:

o Remove comments from branch blocks
o Skip blank lines in block
Signed-off-by: NJoe Perches <joe@perches.com>
Signed-off-by: NAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: NLinus Torvalds <torvalds@linux-foundation.org>

Using BUG/BUG_ON crashes the kernel and is just unfriendly.

Enable code that emits a warning on BUG/BUG_ON use.

Make the code emit the message at WARNING level when scanning a patch and
at CHECK level when scanning files so that script users don't feel an
obligation to fix code that might be above their pay grade.
Signed-off-by: NJoe Perches <joe@perches.com>
Reported-by: NGeert Uytterhoeven <geert@linux-m68k.org>
Tested-by: NGeert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: NAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: NLinus Torvalds <torvalds@linux-foundation.org>

Commit IDs should have commit descriptions too.  Warn when a 12 to 40 byte
SHA-1 is used in commit logs.
Signed-off-by: NJoe Perches <joe@perches.com>
Signed-off-by: NAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: NLinus Torvalds <torvalds@linux-foundation.org>

add [pci|dma]_pool_zalloc coccinelle check.
replaces instances of [pci|dma]_pool_alloc() followed by memset(0)
with [pci|dma]_pool_zalloc().
Signed-off-by: NSean O. Stalley <sean.stalley@intel.com>
Acked-by: NJulia Lawall <julia.lawall@lip6.fr>
Cc: Vinod Koul <vinod.koul@intel.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>
Cc: Gilles Muller <Gilles.Muller@lip6.fr>
Cc: Nicolas Palix <nicolas.palix@imag.fr>
Cc: Michal Marek <mmarek@suse.cz>
Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Jonathan Corbet <corbet@lwn.net>
Signed-off-by: NAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: NLinus Torvalds <torvalds@linux-foundation.org>

I wrote a small script to show word-pair from all linux spelling-typo
commits, and get following result by sort | uniq -c:

    181 occured -> occurred
     78 transfered -> transferred
     67 recieved -> received
     65 dependant -> dependent
     58 wether -> whether
     56 accomodate -> accommodate
     54 occured -> occurred
     51 recieve -> receive
     47 cant -> can't
     40 sucessfully -> successfully
     ...

Some of them are not in spelling.txt, this patch adds the most common
word-pairs into spelling.txt.
Signed-off-by: NZhao Lei <zhaolei@cn.fujitsu.com>
Signed-off-by: NAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: NLinus Torvalds <torvalds@linux-foundation.org>