Remove support for v5 firmware images as all known firmware images are v6.
Signed-off-by: NOndrej Zary <linux@rainbow-software.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

PSEUDOSZ seems to define struct pseudo_hdr size.
Remove it and use sizeof(struct pseudo_hdr) directly.
Signed-off-by: NOndrej Zary <linux@rainbow-software.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Major CodingStyle fixes in ft1000.h
Signed-off-by: NOndrej Zary <linux@rainbow-software.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Remove useless ft1000_release() function.
Signed-off-by: NOndrej Zary <linux@rainbow-software.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Remove unused includes from ft1000_cs.c
Signed-off-by: NOndrej Zary <linux@rainbow-software.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Minor coding style fixes in ft1000_cs.c
Signed-off-by: NOndrej Zary <linux@rainbow-software.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Functions ft1000_asic_read() and ft1000_asic_write() are unused. Remove them.
Signed-off-by: NOndrej Zary <linux@rainbow-software.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Remove misleading, useless and template comments from ft1000_cs.c
Signed-off-by: NOndrej Zary <linux@rainbow-software.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Remove useless debugging from ft1000_cs.c
Signed-off-by: NOndrej Zary <linux@rainbow-software.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Remove unused defines from ft1000_cs.c
Signed-off-by: NOndrej Zary <linux@rainbow-software.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Remove custom defines for standard types (u8, u16, u32...)
Signed-off-by: NOndrej Zary <linux@rainbow-software.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Remove 13 unused fields from struct ft1000_info.
Signed-off-by: NOndrej Zary <linux@rainbow-software.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Remove firmware download typedefs:
DFP_FILE_HDR, DSP_FILE_HDR_5, DSP_IMAGE_INFO, DSP_IMAGE_INFO_V6
Signed-off-by: NOndrej Zary <linux@rainbow-software.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Delete local_info_t typedef along with the struct as its "link" member was
not used. Use link->priv to store net_device directly.
Signed-off-by: NOndrej Zary <linux@rainbow-software.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Delete unused DPRAM_BLK typedefs.
Signed-off-by: NOndrej Zary <linux@rainbow-software.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Remove FT1000_INFO typedefs.
Signed-off-by: NOndrej Zary <linux@rainbow-software.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Remove PROV_RECORD typedefs.
Signed-off-by: NOndrej Zary <linux@rainbow-software.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Delete unused APP_INFO_BLOCK typedefs and associated variables.
Signed-off-by: NOndrej Zary <linux@rainbow-software.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Delete unused DSPHIBERNATE typedefs.
Signed-off-by: NOndrej Zary <linux@rainbow-software.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Remove DSPINITMSG typedefs.
Signed-off-by: NOndrej Zary <linux@rainbow-software.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Delete unused TIMEMSG typedefs.
Signed-off-by: NOndrej Zary <linux@rainbow-software.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Remove MEDIAMSG typedefs.
Signed-off-by: NOndrej Zary <linux@rainbow-software.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Remove DRVMSG typedefs.
Signed-off-by: NOndrej Zary <linux@rainbow-software.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Remove PSEUDO_HDR typedefs.
Signed-off-by: NOndrej Zary <linux@rainbow-software.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Shorten ft1000_read_reg() to single line and move it to ft1000.h along with
ft1000_write_reg() and delete ft1000_dev.h
Signed-off-by: NOndrej Zary <linux@rainbow-software.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Remove useless ft1000.conf file.
Signed-off-by: NOndrej Zary <linux@rainbow-software.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Delete DEBUG statement that prevents compilation with FT_DEBUG enabled.
Signed-off-by: NOndrej Zary <linux@rainbow-software.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Don't crash with NULL pointer dereference on load because of empty .name.
Signed-off-by: NOndrej Zary <linux@rainbow-software.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

As described above fillin_formats()

"""
    /*
     *  THE 16-BIT easycap_format.mask HAS MEANING:
     *    (least significant) BIT  0:     0 => PAL, 25 FPS;   1 => NTSC, 30 FPS
     *                        BITS 2-4:   RESERVED FOR DIFFERENTIATING STANDARDS
     *                        BITS 5-7:   NUMBER OF BYTES PER PIXEL
     *                        BIT  8:     0 => NATIVE BYTE ORDER;  1 => SWAPPED
     *                        BITS 9-10:  RESERVED FOR OTHER BYTE PERMUTATIONS
     *                        BIT 11:     0 => UNDECIMATED;    1 => DECIMATED
     *                        BIT 12:     0 => OFFER FRAMES;   1 => OFFER FIELDS
     *                        BIT 13:     0 => FULL FRAMERATE; 1 => REDUCED
     *     (most significant) BITS 14-15: RESERVED FOR OTHER FIELD/FRAME OPTIONS
     *  IT FOLLOWS THAT:
     *     bytesperpixel IS         ((0x00E0 & easycap_format.mask) >> 5)
     *     byteswaporder IS true IF (0 != (0x0100 & easycap_format.mask))
     *
     *     decimatepixel IS true IF (0 != (0x0800 & easycap_format.mask))
     *
     *       offerfields IS true IF (0 != (0x1000 & easycap_format.mask))
     */
"""

bytes-per-pixel is stored in bits 5-7 of calculated mask.

But when calculating bytes-per-line we were extracting wrong value
instead of bytes-per-pixel, which was usually 2 times bigger -- e.g. for
PAL YUV 422 I was getting ((mask3 & 0x00F0) >> 4) = 4 bytes instead of 2.

The error here is that even in comments there is a line saying

     *     bytesperpixel IS         ((0x00E0 & easycap_format.mask) >> 5)

but we were using
                                    ((0x00F0 & easycap_format.mask) >> 4)

With 2 times bigger bytesperpixel and automatically bytesperline, the
video was shown halfheight'ed, which is understandable if we look at
video-memory layout:

    <------- bytesperline -------->
    <- real bpl ->

    x0----------y0  x1-----------y1
    x2----------y2  x3-----------y3

    xn----------yn  xn-----------yn
    <garbage>

for each line, we should display width pixels, then move to next line
with bytesperline, and oops, if bytesperline = 2*real-bytesperlin, we'll
skip one line and move to next-next line, and so only half lines will be
shown.

Initially I've debugged the problem with my video application[1], but
I've checked that after this patch both rawv (mine app) and tvtime work
correctly.

[1] http://repo.or.cz/w/rawv.git

P.S. why at all we use those mask/shifts? Why not use bitfields?

Cc: Mike Thomas <rmthomas@sciolus.org>
Signed-off-by: NKirill Smelkov <kirr@mns.spb.ru>
Acked-by: NTomas Winkler <tomas.winkler@intel.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

I'm not 100% sure, only 99.99% that PAGE_SIZE is always defined in
Linux. So there is no need to check for it.

Cc: Mike Thomas <rmthomas@sciolus.org>
Signed-off-by: NKirill Smelkov <kirr@mns.spb.ru>
Acked-by: NTomas Winkler <tomas.winkler@intel.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Because V4L1 was completly removed from the kernel in 2.6.38. See e.g.

08af245d ([media] V4L: remove V4L1 compatibility mode).

Cc: Mike Thomas <rmthomas@sciolus.org>
Signed-off-by: NKirill Smelkov <kirr@mns.spb.ru>
Acked-by: NTomas Winkler <tomas.winkler@intel.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Both bars=0 and bars=1 were described as meaning to display bars on
signal lost. Actually bars=1 means "display bars", but bars=0 means
display raw source as is (usually black screen).

Instead of changing bars=0 to "_no_ testcard bars ..." as suggested by
Dan Carpenter reword the whole bars description for clarity.

Cc: Mike Thomas <rmthomas@sciolus.org>
Cc: Dan Carpenter <error27@gmail.com>
Signed-off-by: NKirill Smelkov <kirr@mns.spb.ru>
Acked-by: NTomas Winkler <tomas.winkler@intel.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

The following options were removed from in-tree driver, but were left
in README:

- EASYCAP_IS_VIDEODEV_CLIENT was removed in cb81fa07 (staging/easycap:
  kill EASYCAP_IS_VIDEODEV_CLIENT compilation conditional);

- EASYCAP_NEEDS_V4L2_DEVICE_H/EASYCAP_NEEDS_V4L2_FOPS were removed in
  30516058 (staging/easycap: kill EASYCAP_NEEDS_V4L2_DEVICE_H and
  EASYCAP_NEEDS_V4L2_FOPS);

- EASYCAP_NEEDS_UNLOCKED_IOCTL was removed in f2b3c685 (staging/easycap:
  kill EASYCAP_NEEDS_UNLOCKED_IOCTL).

Remove them.

Cc: Mike Thomas <rmthomas@sciolus.org>
Signed-off-by: NKirill Smelkov <kirr@mns.spb.ru>
Acked-by: NTomas Winkler <tomas.winkler@intel.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Fixes scripts/checkpatch.pl warning.
Signed-off-by: NMichael Fiedler <michael.fiedler@informatik.stud.uni-erlangen.de>
Acked-by: NLarry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Fixes warning from scripts/checkpatch.pl.
Signed-off-by: NMichael Fiedler <michael.fiedler@informatik.stud.uni-erlangen.de>
Acked-by: NLarry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

According to scripts/checkpatch.pl, the __packed macro
from linux/compiler.h should be used.
Signed-off-by: NMichael Fiedler <michael.fiedler@informatik.stud.uni-erlangen.de>
Acked-by: NLarry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

There is already a macro defined in linux/compiler.h.
Signed-off-by: NMichael Fiedler <michael.fiedler@informatik.stud.uni-erlangen.de>
Acked-by: NLarry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

The JOM() macro dereferences peasycap, so I moved the free down some
lines.
Signed-off-by: NDan Carpenter <error27@gmail.com>
Acked-by: NTomas Winkler <tomas.winkler@intel.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

This fixes out-of-tree builds ($builddir != $srcdir). In such cases,
libusbip.la cannot be found because it is generated in the build
directory and not the source directory.
Signed-off-by: NTobias Klauser <tklauser@distanz.ch>
Acked-by: Nmatt mooney <mfm@muteddisk.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Fixed a brace coding style warning.
Signed-off-by: NZac Storer <zac.3.14159@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>