1. 02 3月, 2017 2 次提交
  2. 28 2月, 2017 1 次提交
  3. 22 2月, 2017 16 次提交
  4. 21 2月, 2017 1 次提交
  5. 18 2月, 2017 5 次提交
  6. 17 2月, 2017 3 次提交
    • G
      pci/hotplug/pnv-php: Disable MSI and PCI device properly · 49f4b08e
      Gavin Shan 提交于
      pnv_php_disable_irq() can be called in two paths: Bailing path in
      pnv_php_enable_irq() or releasing slot. The MSI (or MSIx) interrupts
      is disabled unconditionally in pnv_php_disable_irq(). It's wrong
      because that might be enabled by drivers other than pnv-php.
      
      This disables MSI (or MSIx) interrupts and the PCI device only if
      it was enabled by pnv-php. In the error path of pnv_php_enable_irq(),
      we rely on the newly added parameter @disable_device. In the path
      of releasing slot, @pnv_php->irq is checked.
      
      Cc: <stable@vger.kernel.org> # v4.9+
      Fixes: 360aebd8 ("drivers/pci/hotplug: Support surprise hotplug in powernv driver")
      Signed-off-by: NGavin Shan <gwshan@linux.vnet.ibm.com>
      Reviewed-by: NAndrew Donnellan <andrew.donnellan@au1.ibm.com>
      Signed-off-by: NMichael Ellerman <mpe@ellerman.id.au>
      49f4b08e
    • G
      pci/hotplug/pnv-php: Disable surprise hotplug capability on conflicts · 303529d6
      Gavin Shan 提交于
      The root port or PCIe switch downstream port might have been associated
      with driver other than pnv-php. The MSI or MSIx might also have been
      enabled by that driver (e.g. pcieport_drv). Attempt to enable MSI incurs
      below backtrace:
      
       PowerPC PowerNV PCI Hotplug Driver version: 0.1
       ------------[ cut here ]------------
       WARNING: CPU: 19 PID: 1004 at drivers/pci/msi.c:1071 \
                                    __pci_enable_msi_range+0x84/0x4e0
       NIP [c000000000665c34] __pci_enable_msi_range+0x84/0x4e0
       LR [c000000000665c24] __pci_enable_msi_range+0x74/0x4e0
       Call Trace:
       [c000000384d67600] [c000000000665c24] __pci_enable_msi_range+0x74/0x4e0
       [c000000384d676e0] [d00000000aa31b04] pnv_php_register+0x564/0x5a0 [pnv_php]
       [c000000384d677c0] [d00000000aa31658] pnv_php_register+0xb8/0x5a0 [pnv_php]
       [c000000384d678a0] [d00000000aa31658] pnv_php_register+0xb8/0x5a0 [pnv_php]
       [c000000384d67980] [d00000000aa31dfc] pnv_php_init+0x60/0x98 [pnv_php]
       [c000000384d679f0] [c00000000000cfdc] do_one_initcall+0x6c/0x1d0
       [c000000384d67ab0] [c000000000b92354] do_init_module+0x94/0x254
       [c000000384d67b40] [c00000000019719c] load_module+0x258c/0x2c60
       [c000000384d67d30] [c000000000197bb0] SyS_finit_module+0xf0/0x170
       [c000000384d67e30] [c00000000000b184] system_call+0x38/0xe0
      
      This fixes the issue by skipping enabling the surprise hotplug
      capability if the MSI or MSIx on the PCI slot's upstream port has
      been enabled by other driver.
      
      Cc: <stable@vger.kernel.org> # v4.9+
      Fixes: 360aebd8 ("drivers/pci/hotplug: Support surprise hotplug in powernv driver")
      Signed-off-by: NGavin Shan <gwshan@linux.vnet.ibm.com>
      Reviewed-by: NAndrew Donnellan <andrew.donnellan@au1.ibm.com>
      Tested-by: NVaibhav Jain <vaibhav@linux.vnet.ibm.com>
      Signed-off-by: NMichael Ellerman <mpe@ellerman.id.au>
      303529d6
    • G
      pci/hotplug/pnv-php: Remove WARN_ON() in pnv_php_put_slot() · 36c7c9da
      Gavin Shan 提交于
      The WARN_ON() causes unnecessary backtrace when putting the parent
      slot, which is likely to be NULL.
      
       WARNING: CPU: 2 PID: 1071 at drivers/pci/hotplug/pnv_php.c:85 \
                                    pnv_php_release+0xcc/0x150 [pnv_php]
          :
       Call Trace:
       [c0000003bc007c10] [d00000000ad613c4] pnv_php_release+0x144/0x150 [pnv_php]
       [c0000003bc007c40] [c0000000006641d8] pci_hp_deregister+0x238/0x330
       [c0000003bc007cd0] [d00000000ad61440] pnv_php_unregister_one+0x70/0xa0 [pnv_php]
       [c0000003bc007d10] [d00000000ad614c0] pnv_php_unregister+0x50/0x80 [pnv_php]
       [c0000003bc007d40] [d00000000ad61e84] pnv_php_exit+0x50/0xcb4 [pnv_php]
       [c0000003bc007d70] [c00000000019499c] SyS_delete_module+0x1fc/0x2a0
       [c0000003bc007e30] [c00000000000b184] system_call+0x38/0xe0
      
      Cc: <stable@vger.kernel.org> # v4.8+
      Fixes: 66725152 ("PCI/hotplug: PowerPC PowerNV PCI hotplug driver")
      Signed-off-by: NGavin Shan <gwshan@linux.vnet.ibm.com>
      Reviewed-by: NAndrew Donnellan <andrew.donnellan@au1.ibm.com>
      Tested-by: NVaibhav Jain <vaibhav@linux.vnet.ibm.com>
      Signed-off-by: NMichael Ellerman <mpe@ellerman.id.au>
      36c7c9da
  7. 16 2月, 2017 1 次提交
  8. 15 2月, 2017 9 次提交
  9. 11 2月, 2017 2 次提交