1. 25 4月, 2013 2 次提交
  2. 24 4月, 2013 1 次提交
  3. 23 4月, 2013 4 次提交
    • D
      net: sctp: minor: remove dead code from sctp_packet · 3e3251b3
      Daniel Borkmann 提交于
      struct sctp_packet is currently embedded into sctp_transport or
      sits on the stack as 'singleton' in sctp_outq_flush(). Therefore,
      its member 'malloced' is always 0, thus a kfree() is never called.
      Because of that, we can just remove this code.
      Signed-off-by: NDaniel Borkmann <dborkman@redhat.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      3e3251b3
    • E
      net: remove a stale comment for dl_next · 3fb62c5d
      Eric Dumazet 提交于
      dl_next member in struct request_sock doesn't need to be first.
      
      We expect to insert a "struct common_sock" or a subset of it,
      so this claim had to be verified.
      Signed-off-by: NEric Dumazet <edumazet@google.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      3fb62c5d
    • W
      xen-netback: coalesce slots in TX path and fix regressions · 2810e5b9
      Wei Liu 提交于
      This patch tries to coalesce tx requests when constructing grant copy
      structures. It enables netback to deal with situation when frontend's
      MAX_SKB_FRAGS is larger than backend's MAX_SKB_FRAGS.
      
      With the help of coalescing, this patch tries to address two regressions
      avoid reopening the security hole in XSA-39.
      
      Regression 1. The reduction of the number of supported ring entries (slots)
      per packet (from 18 to 17). This regression has been around for some time but
      remains unnoticed until XSA-39 security fix. This is fixed by coalescing
      slots.
      
      Regression 2. The XSA-39 security fix turning "too many frags" errors from
      just dropping the packet to a fatal error and disabling the VIF. This is fixed
      by coalescing slots (handling 18 slots when backend's MAX_SKB_FRAGS is 17)
      which rules out false positive (using 18 slots is legit) and dropping packets
      using 19 to `max_skb_slots` slots.
      
      To avoid reopening security hole in XSA-39, frontend sending packet using more
      than max_skb_slots is considered malicious.
      
      The behavior of netback for packet is thus:
      
          1-18            slots: valid
         19-max_skb_slots slots: drop and respond with an error
         max_skb_slots+   slots: fatal error
      
      max_skb_slots is configurable by admin, default value is 20.
      
      Also change variable name from "frags" to "slots" in netbk_count_requests.
      
      Please note that RX path still has dependency on MAX_SKB_FRAGS. This will be
      fixed with separate patch.
      Signed-off-by: NWei Liu <wei.liu2@citrix.com>
      Acked-by: NIan Campbell <ian.campbell@citrix.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      2810e5b9
    • W
      xen-netfront: reduce gso_max_size to account for max TCP header · 9ecd1a75
      Wei Liu 提交于
      The maximum packet including header that can be handled by netfront / netback
      wire format is 65535. Reduce gso_max_size accordingly.
      
      Drop skb and print warning when skb->len > 65535. This can 1) save the effort
      to send malformed packet to netback, 2) help spotting misconfiguration of
      netfront in the future.
      Signed-off-by: NWei Liu <wei.liu2@citrix.com>
      Acked-by: NIan Campbell <ian.campbell@citrix.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      9ecd1a75
  4. 22 4月, 2013 4 次提交
  5. 21 4月, 2013 1 次提交
  6. 20 4月, 2013 15 次提交
  7. 19 4月, 2013 2 次提交
    • E
      tcp: introduce TCPSpuriousRtxHostQueues SNMP counter · 0e280af0
      Eric Dumazet 提交于
      Host queues (Qdisc + NIC) can hold packets so long that TCP can
      eventually retransmit a packet before the first transmit even left
      the host.
      
      Its not clear right now if we could avoid this in the first place :
      
      - We could arm RTO timer not at the time we enqueue packets, but
        at the time we TX complete them (tcp_wfree())
      
      - Cancel the sending of the new copy of the packet if prior one
        is still in queue.
      
      This patch adds instrumentation so that we can at least see how
      often this problem happens.
      
      TCPSpuriousRtxHostQueues SNMP counter is incremented every time
      we detect the fast clone is not yet freed in tcp_transmit_skb()
      Signed-off-by: NEric Dumazet <edumazet@google.com>
      Cc: Yuchung Cheng <ycheng@google.com>
      Cc: Neal Cardwell <ncardwell@google.com>
      Cc: Tom Herbert <therbert@google.com>
      Cc: Willem de Bruijn <willemb@google.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      0e280af0
    • L
      Revert "block: add missing block_bio_complete() tracepoint" · 0a82a8d1
      Linus Torvalds 提交于
      This reverts commit 3a366e61.
      
      Wanlong Gao reports that it causes a kernel panic on his machine several
      minutes after boot. Reverting it removes the panic.
      
      Jens says:
       "It's not quite clear why that is yet, so I think we should just revert
        the commit for 3.9 final (which I'm assuming is pretty close).
      
        The wifi is crap at the LSF hotel, so sending this email instead of
        queueing up a revert and pull request."
      Reported-by: NWanlong Gao <gaowanlong@cn.fujitsu.com>
      Requested-by: NJens Axboe <axboe@kernel.dk>
      Cc: Tejun Heo <tj@kernel.org>
      Cc: Steven Rostedt <rostedt@goodmis.org>
      Signed-off-by: NLinus Torvalds <torvalds@linux-foundation.org>
      0a82a8d1
  8. 18 4月, 2013 11 次提交