We now have a binding which adds two parameters to the matrix keypad DT
node. This is separate from the GPIO-driven matrix keypad binding, and
unfortunately incompatible, since that uses row-gpios/col-gpios for the
row and column counts.

So the easiest option here is to provide a function for non-GPIO drivers
to use to decode the binding.

Note: We could in fact create an entirely separate structure to hold
these two fields, but it does not seem worth it, yet. If we have more
parameters then we can add this, and then refactor each driver to hold
such a structure.
Signed-off-by: NSimon Glass <sjg@chromium.org>
Acked-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>
Tested-by: Sourav Poddar <sourav.poddar@ti.com> (v2)
Signed-off-by: NSamuel Ortiz <sameo@linux.intel.com>

CONFIG_HOTPLUG is going away as an option.  As a result, the __dev*
markings need to be removed.

This change removes the use of __devinit, __devexit_p, __devinitdata,
__devinitconst, and __devexit from these drivers.

Based on patches originally written by Bill Pemberton, but redone by me
in order to handle some of the coding style issues better, by hand.

Cc: Bill Pemberton <wfp5p@virginia.edu>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Let's switch to using devm_*() interfaces to manage our resources,
thus will simplify error unwinding a bit.
Reviewed-by: NAlban Bedel <alban.bedel@avionic-design.de>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Failures to build a keymap, request an IRQ, or register input device are
fatal for the driver, therefore the messages should have "error" severity
instead of "debug".
Reviewed-by: NAlban Bedel <alban.bedel@avionic-design.de>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

This matches structure of most other input drivers.
Reviewed-by: NAlban Bedel <alban.bedel@avionic-design.de>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

We need to use proper accessor functions instead of directly poking into
various structures.
Reviewed-by: NAlban Bedel <alban.bedel@avionic-design.de>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Use a temporary variable for our parent device (coming from I2C client
structure); we'll be also using it during conversion to managed resources.
Reviewed-by: NAlban Bedel <alban.bedel@avionic-design.de>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Signed-off-by: NAlban Bedel <alban.bedel@avionic-design.de>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Signed-off-by: NAlban Bedel <alban.bedel@avionic-design.de>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

CONFIG_HOTPLUG is going away as an option so __devexit is no
longer needed.
Signed-off-by: NBill Pemberton <wfp5p@virginia.edu>
Acked-by: NMark Brown <broonie@opensource.wolfsonmicro.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

CONFIG_HOTPLUG is going away as an option so __devinit is no longer
needed.
Signed-off-by: NBill Pemberton <wfp5p@virginia.edu>
Acked-by: NMark Brown <broonie@opensource.wolfsonmicro.com>
Acked-by: NJavier Martinez Canillas <javier@dowhile0.org>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

CONFIG_HOTPLUG is going away as an option so __devexit_p is no longer
needed.
Signed-off-by: NBill Pemberton <wfp5p@virginia.edu>
Acked-by: NRussell King <rmk+kernel@arm.linux.org.uk>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Since commit 1c6c6952 ("genirq: Reject bogus threaded irq requests")
threaded IRQs without a primary handler need to be requested with
IRQF_ONESHOT, otherwise the request will fail. This patch adds the
IRQF_ONESHOT to input drivers where it is missing. Not modified by
this patch are those drivers where the requested IRQ will always be a
nested IRQ (e.g. because it's part of an MFD), since for this special
case IRQF_ONESHOT is not required to be specified when requesting the
IRQ.
Signed-off-by: NLars-Peter Clausen <lars@metafoo.de>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Change matrix-keymap helper to be out-of-line, like sparse keymap,
allow the helper perform basic keymap validation and return errors,
and prepare for device tree support.
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>

This driver has been tested with hardware and works as expected.  To use
it add the platform data as appropriate and register it with the
corresponding I2C bus.
Signed-off-by: NKyle Manna <kyle.manna@fuel7.com>
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>