Signed-off-by: NJoe Perches <joe@perches.com>
Acked-by: NArend van Spriel <arend@broadcom.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Add an #include of <linux/if_ether.h> to include/proto/ethernet.h
Convert ETHER_ADDR_LEN, remove the #define for ETHER_ADDR_LEN.
Signed-off-by: NJoe Perches <joe@perches.com>
Acked-by: NArend van Spriel <arend@broadcom.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Use the normal kernel calls and remove the #defines
for ETHER_IS_BCAST and ETHER_IS_NULLADDR.

Add #include for etherdevice.h where necessary.
Signed-off-by: NJoe Perches <joe@perches.com>
Acked-by: NArend van Spriel <arend@broadcom.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

These are unused, just remove them.
Signed-off-by: NJoe Perches <joe@perches.com>
Acked-by: NArend van Spriel <arend@broadcom.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Use the standard kernel function.
Change callers to add .octet to addressing to avoid warnings.
Add #include <linux/etherdevice.h> where necessary.
Signed-off-by: NJoe Perches <joe@perches.com>
Acked-by: NArend van Spriel <arend@broadcom.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Signed-off-by: NJoe Perches <joe@perches.com>
Acked-by: NArend van Spriel <arend@broadcom.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

This patch fixes the following issues in s526.c:

WARNING: printk() should include KERN_ facility level
WARNING: line over 80 characters
ERROR: do not use C99 // comments
WARNING: space prohibited between function name and open parenthesis '('
WARNING: braces {} are not necessary for any arm of this statement
WARNING: suspect code indent for conditional statements (16, 16)
Signed-off-by: NXenofon Foukas <foukas.xenofon@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

This patch fixes the following issues in file ii_pci20kc.c:

WARNING: please, no space before tabs
WARNING: unnecessary whitespace before a quoted newline
WARNING: line over 80 characters
Signed-off-by: NXenofon Foukas <foukas.xenofon@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

During ioctl testing was observed kernel panic beuase
file->private_data pointer was not correctly set when
debugfs file was created. Add correct pointer setup.
Signed-off-by: NMarek Belisko <marek.belisko@open-nandra.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Signed-off-by: NMarek Belisko <marek.belisko@open-nandra.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Name of old file was misleading because it is currently
updated to debugfs so change also file name.
Signed-off-by: NMarek Belisko <marek.belisko@open-nandra.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Signed-off-by: NMarek Belisko <marek.belisko@open-nandra.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Cleaner implementation. Avoids the need of the double parenthesis to call the
macro.
Signed-off-by: NL. Alberto Giménez <agimenez@sysvalve.es>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Fix checkpatch complains.
Signed-off-by: NL. Alberto Giménez <agimenez@sysvalve.es>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Signed-off-by: NHaiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: NHank Janssen <hjanssen@microsoft.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Signed-off-by: NHaiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: NHank Janssen <hjanssen@microsoft.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Signed-off-by: NHaiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: NHank Janssen <hjanssen@microsoft.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Signed-off-by: NHaiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: NHank Janssen <hjanssen@microsoft.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Signed-off-by: NHaiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: NHank Janssen <hjanssen@microsoft.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Signed-off-by: NHaiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: NHank Janssen <hjanssen@microsoft.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Signed-off-by: NHaiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: NHank Janssen <hjanssen@microsoft.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

rt28xx_close and rt28xx_open are already declared in a file included in
rt_config.h, so there is no need to declare them again.
Signed-off-by: NL. Alberto Giménez <agimenez@sysvalve.es>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Fix checkpatch complains
Signed-off-by: NL. Alberto Giménez <agimenez@sysvalve.es>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

add DEVICE_ID to table
Signed-off-by: NRuben Smits <ruben.smits@mech.kuleuven.be>
Cc: stable <stable@kernel.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

This patch fixes the following issues in ni_tiocmd.c:

WARNING: braces {} are not necessary for any arm of this statement
WARNING: braces {} are not necessary for single statement blocks
WARNING: printk() should include KERN_ facility level
WARNING: line over 80 characters
__func__ should be used instead of gcc specific __FUNCTION__
ERROR: that open brace { should be on the previous line
WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
Signed-off-by: NXenofon Foukas <foukas.xenofon@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Using gCardIndex as global variable was not correctly used because
for every plugged device was set to 0 in init_ft1000_netdev.

Remove global definition. Use it locally and for every plugged
device extract number from net device name.
Signed-off-by: NMarek Belisko <marek.belisko@open-nandra.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

You should not be able to write to sysfs files from any user.

Cc: Graf Yang <graf.yang@analog.com>
Cc: Michael Hennerich <michael.hennerich@analog.com>
Cc: Jonathan Cameron <jic23@cam.ac.uk>
Cc: Mike Frysinger <vapier@gentoo.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

You should not be able to write to a debugfs file from any user.

Cc: Marek Belisko <marek.belisko@open-nandra.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

The driver should not have such a generic global variable name.
Reported-by: NZimny Lech <napohybelskurwysynom2010@gmail.com>
Cc: Bob Beers <bob.beers@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Original comments were inaccurate
Signed-off-by: NMark Allyn <mark.a.allyn@intel.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

The if condition was ignored in the original code and we just used the
default channel.
Signed-off-by: NDan Carpenter <error27@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

This patch fixes line over 80 characters warning issues found
in file drivers.c
Signed-off-by: NXenofon Foukas <foukas.xenofon@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Signed-off-by: NMark Allyn <mark.a.allyn@intel.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Signed-off-by: NMark Allyn <mark.a.allyn@intel.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Signed-off-by: NMark Allyn <mark.a.allyn@intel.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Signed-off-by: NMark Allyn <mark.a.allyn@intel.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Signed-off-by: NMark Allyn <mark.a.allyn@intel.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

The Moorestown (older device) will be added to driver
later.
Signed-off-by: NMark Allyn <mark.a.allyn@intel.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Signed-off-by: NMark Allyn <mark.a.allyn@intel.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Add pci_disable
Signed-off-by: NMark Allyn <mark.a.allyn@intel.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>