1. 17 3月, 2007 1 次提交
    • R
      [IPV4]: Do not disable preemption in trie_leaf_remove(). · d5cc4a73
      Robert Olsson 提交于
      Hello, Just discussed this Patrick...
      
      We have two users of trie_leaf_remove, fn_trie_flush and fn_trie_delete
      both are holding RTNL. So there shouldn't be need for this preempt stuff.
      This is assumed to a leftover from an older RCU-take.
      
      > Mhh .. I think I just remembered something - me incorrectly suggesting
      > to add it there while we were talking about this at OLS :) IIRC the
      > idea was to make sure tnode_free (which at that time didn't use
      > call_rcu) wouldn't free memory while still in use in a rcu read-side
      > critical section. It should have been synchronize_rcu of course,
      > but with tnode_free using call_rcu it seems to be completely
      > unnecessary. So I guess we can simply remove it.
      Signed-off-by: NRobert Olsson <robert.olsson@its.uu.se>
      Signed-off-by: NPatrick McHardy <kaber@trash.net>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      d5cc4a73
  2. 16 3月, 2007 5 次提交
  3. 15 3月, 2007 34 次提交