Brought to you with the help of sed and manual clean-up after.

  $ sed -i -e 's|printk("\\n|dev_warn(dev->hw_dev,\n\t"|' \
    addi-data/hwdrv_apci1500.c

Since all of these printk()s were for invalid API inputs and most of
them returned -EINVAL, I fixed the rest of them to return -EINVAL as
well.
Signed-off-by: NConrad Meyer <cse.cem@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This check is unnecessary because range_table will always be
initialized to range_unknown by comedi_device_postconfig() for
drivers that do not initialize range_table or range_table_list
Signed-off-by: NFred Akers <knivey@botops.net>
Reviewed-by: NH Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: NIan Abbott <abbotti@mev.co.uk>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Refactor this function to remove an extra indent level
Signed-off-by: NFred Akers <knivey@botops.net>
Reviewed-by: NH Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: NIan Abbott <abbotti@mev.co.uk>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Rename some very long functions in addi-data/hwdrv_apci1500.c.
Signed-off-by: NConrad Meyer <cse.cem@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch fixes the register map defines for the counter registers such
that they are all the real offsets to each register, rather than a mix of
real offsets and adders to those offsets.
Signed-off-by: NChase Southwood <chase.southwood@yahoo.com>
Reviewed-by: NH Hartley Sweeten <hsweeten@visionengravers.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch for fixes the register map defines for the timer registers such
that they are all the real offsets to each register, rather than a mix of
real offsets and adders to those offsets.
Signed-off-by: NChase Southwood <chase.southwood@yahoo.com>
Reviewed-by: NH Hartley Sweeten <hsweeten@visionengravers.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch for fixes the register map defines for the watchdog registers
such that they are all the real offsets to each register, rather than a
mix of real offsets and adders to those offsets.
Signed-off-by: NChase Southwood <chase.southwood@yahoo.com>
Reviewed-by: NH Hartley Sweeten <hsweeten@visionengravers.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch fixes the register map defines for the digital output registers
such that they are all the real offsets to each register, rather than a
mix of real offsets and adders to those offsets.

Further, some of the old defines were being used incorrectly in the
i_APCI1564_Reset() function.  Upon swapping the old defines out for the
new ones in this function, their use has been corrected.
Signed-off-by: NChase Southwood <chase.southwood@yahoo.com>
Reviewed-by: NH Hartley Sweeten <hsweeten@visionengravers.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch fixes the register map defines for the digital input registers
such that they are all the real offsets to each register, rather than a
mix of real offsets and adders to those offsets.

Further, some of the old defines were being used incorrectly in the
i_APCI1564_Reset() function.  Upon swapping the old defines out for the
new ones in this function, their use has been corrected.
Signed-off-by: NChase Southwood <chase.southwood@yahoo.com>
Reviewed-by: NH Hartley Sweeten <hsweeten@visionengravers.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Since the argument morefrag is being used as a booleon in the function
rtl8180_tx, the type for the argument is changed to booleon in the
function definition and declaration. This ensures that the variable
morefrag is always in the range 0-1 and overflow dooes not cause errors
if it is assigned a value. Also, this improves code readability.
Signed-off-by: NHimangi Saraogi <himangi774@gmail.com>
Acked-by: NPaul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

The Documentation/CodingStyle doesn't recommend the use of typedef, and
The typedef _ThreeWire is not used in the driver. I delete it.
Signed-off-by: NAna Rey <anarey@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

The Documentation/CodingStyle doesn't recommend the use of typedef,
convert this to structure.
Signed-off-by: NAna Rey <anarey@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

The Documentation/CodingStyle doesn't recommend the use of typedef,
convert this to structure.
Signed-off-by: NAna Rey <anarey@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch fixes following sparse warnings:
drivers/staging/rtl8192e/rtllib_tx.c:942:45: warning: invalid assignment: +=
drivers/staging/rtl8192e/rtllib_tx.c:942:45:    left side has type unsigned long
drivers/staging/rtl8192e/rtllib_tx.c:942:45:    right side has type restricted __le16
drivers/staging/rtl8192e/rtllib_tx.c:947:49: warning: invalid assignment: +=
drivers/staging/rtl8192e/rtllib_tx.c:947:49:    left side has type unsigned long
drivers/staging/rtl8192e/rtllib_tx.c:947:49:    right side has type restricted __le16
Signed-off-by: NMonam Agarwal <monamagarwal123@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch fixes whitespaces as the codingStyle of the kernel recommends.

Thus, this patch fixes these errors found by checkpatch.pl in r8180.h

ERROR: space required after that close brace '}'
ERROR: space required after that ',' (ctx:VxV)
ERROR: spaces required around that '==' (ctx:VxV)
ERROR: spaces required around that '=' (ctx:VxV)
ERROR: space required after that ',' (ctx:VxV)
Signed-off-by: NAna Rey <anarey@gmail.com>
Acked-by: NBob Copeland <me@bobcopeland.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Remove brackets from single line branches of if statements.
Break long lines.
Signed-off-by: NRaluca Oncioiu <raluca.oncioiu91@gmail.com>
Acked-by: NPaul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Break up long lines.
Signed-off-by: NRaluca Oncioiu <raluca.oncioiu91@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch fixes the following sparse warnings in ieee80211_rx.c:
drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c:2201:34: warning: cast
to restricted __le32
drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c:2202:34: warning: cast
to restricted __le32
drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c:2203:36: warning: cast
to restricted __le32

by changing the annotation in the structure header file for struct
ieee80211_probe_response for time_stamp and altering the cast
for beacon_interval to le16.
Signed-off-by: NHimangi Saraogi <himangi774@gmail.com>
Reviewed-by: NBob Copeland <me@bobcopeland.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch fixes the following sparse warnings:

drivers/staging/rtl8712/rtl871x_cmd.c:471:30: warning: incorrect type in
assignment (different base types)
drivers/staging/rtl8712/rtl871x_cmd.c:471:30:    expected unsigned int
[unsigned] [usertype] Length
drivers/staging/rtl8712/rtl871x_cmd.c:471:30:    got restricted __le32
[usertype] <noident>
drivers/staging/rtl8712/rtl871x_cmd.c:472:32: warning: incorrect type in
assignment (different base types)
drivers/staging/rtl8712/rtl871x_cmd.c:472:32:    expected unsigned int
[unsigned] [usertype] IELength
drivers/staging/rtl8712/rtl871x_cmd.c:472:32:    got restricted __le32
[usertype] <noident>
drivers/staging/rtl8712/rtl871x_cmd.c:473:39: warning: incorrect type in
assignment (different base types)
drivers/staging/rtl8712/rtl871x_cmd.c:473:39:    expected unsigned int
[unsigned] [usertype] SsidLength
drivers/staging/rtl8712/rtl871x_cmd.c:473:39:    got restricted __le32
[usertype] <noident>
Signed-off-by: NHimangi Saraogi <himangi774@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch fixes the checkpatch.pl warning: line over 80 charcters.
Signed-off-by: NHimangi Saraogi <himangi774@gmail.com>
Reviewed-by: NSarah Sharp <sarah.a.sharp@linux.intel.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Fix checkpatch.pl issues with  __packed is preferred
over __attribute__((packed)) in ft1000_ioctl.h
Signed-off-by: NEbru Akagunduz <ebru.akagunduz@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch fixes following sparse warnings:
drivers/staging/gdm72xx/gdm_wimax.c:543:37: warning: incorrect type in argument 1 (different address spaces)
drivers/staging/gdm72xx/gdm_wimax.c:543:37:    expected void [noderef] <asn:1>*to
drivers/staging/gdm72xx/gdm_wimax.c:543:37:    got void *buf
drivers/staging/gdm72xx/gdm_wimax.c:566:41: warning: incorrect type in argument 2 (different address spaces)
drivers/staging/gdm72xx/gdm_wimax.c:566:41:    expected void const [noderef] <asn:1>*from
drivers/staging/gdm72xx/gdm_wimax.c:566:41:    got void *buf
Signed-off-by: NMonam Agarwal <monamagarwal123@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch fixes the following warning for gdm_wimax.c
WARNING: braces {} are not necessary for any arm of this statement
Signed-off-by: NHimangi Saraogi <himangi774@gmail.com>
Acked-by: NPaul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Fix checkpatch.pl issues with line over 80
characters in wb35rx.c
Signed-off-by: NEbru Akagunduz <ebru.akagunduz@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch moves shared private data kzalloc to managed devm_kzalloc and
cleans now unneccessary kfree in probe and remove functions.
Signed-off-by: NHimangi Saraogi <himangi774@gmail.com>
Acked-by: NPaul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch fixes the following Sparse warnings :

drivers/staging/rtl8187se/ieee80211/ieee80211_softmac.c:27:4: warning:
symbol 'rsn_authen_cipher_suite' was not declared. Should it be static?
drivers/staging/rtl8187se/ieee80211/ieee80211_softmac.c:352:6: warning:
symbol 'ext_ieee80211_send_beacon_wq' was not declared. Should it be
static?
Signed-off-by: NHimangi Saraogi <himangi774@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch fixes sparse warnings like :
(1) drivers/staging/rtl8187se/ieee80211/ieee80211_softmac.c:331:31:
warning:
incorrect type in assignment (different base types)
drivers/staging/rtl8187se/ieee80211/ieee80211_softmac.c:331:31:
expected unsigned short [unsigned] [usertype] frame_ctl
drivers/staging/rtl8187se/ieee80211/ieee80211_softmac.c:331:31:    got
restricted __le16 [usertype] <noident>

(2) drivers/staging/rtl8187se/ieee80211/ieee80211_softmac.c:1091:32:
warning: incorrect type in assignment (different base types)
drivers/staging/rtl8187se/ieee80211/ieee80211_softmac.c:1091:32:
expected restricted __le16 [usertype] duration_id
drivers/staging/rtl8187se/ieee80211/ieee80211_softmac.c:1091:32:    got
int
Signed-off-by: NHimangi Saraogi <himangi774@gmail.com>
Acked-by: NPaul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Unnecessary space between function pointer name.
Signed-off-by: NKeerthimai Janarthanan <keerthimaipb@gmail.com>
Acked-by: NPaul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch fixes the following sparse warning in rts51x.c

drivers/staging/rts5139/rts51x.c:218:5: warning: symbol 'rts51x_pre_reset' was not declared. Should it be static?
drivers/staging/rts5139/rts51x.c:229:5: warning: symbol 'rts51x_post_reset' was not declared. Should it be static?
Signed-off-by: NMonam Agarwal <monamagarwal123@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch fixes the following Sparse warnings :
formatter_inquiry_str should be static
queuecommand_lck should be static
Signed-off-by: NMonam Agarwal <monamagarwal123@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch fixes the quoted string split across
lines in staging/rts5139/ms.c
Signed-off-by: NGeorgiana Rodica Chelu <georgiana.chelu93@gmail.com>
Acked-by: NPaul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Remove unnecessary parentheses from staging/rts5208/rtsx_scsi.c
Signed-off-by: NGeorgiana Rodica Chelu <georgiana.chelu93@gmail.com>
Acked-by: NPaul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch fixes following sparse warning in rts51x_fop.c
Warning: incorrect type in assignment
Signed-off-by: NMonam Agarwal <monamagarwal123@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch fixes the following sparse warning :
drivers/staging/serqt_usb2/serqt_usb2.c:727:40: warning: restricted __le16 degrades to integer
Signed-off-by: NHimangi Saraogi <himangi774@gmail.com>
Cc: stable <stable@vger.kernel.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch moves shared private data kzalloc to managed devm_kzalloc.
There are no kfree statements associated with this data, so using devm
adds the possibility of the data being freed, if the proble function
fails (if that is possible) or if the remove function succeeds.
Signed-off-by: NHimangi Saraogi <himangi774@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Fix checkpatch.pl issues with quoted string split
across lines in nvec.c
Signed-off-by: NEbru Akagunduz <ebru.akagunduz@gmail.com>
Acked-by: NPaul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch fixes following sparse warning in crystalhd_lnx.c
WARNING: incorrect type in argument
Signed-off-by: NMonam Agarwal <monamagarwal123@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch fixes following sparse warning in crystalhd_misc.c
WARNING: incorrect type in argument
Signed-off-by: NMonam Agarwal <monamagarwal123@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Fix checkpatch.pl issues with "foo *  bar" should
be "foo *bar" in dgap.h
Signed-off-by: NEbru Akagunduz <ebru.akagunduz@gmail.com>
Acked-by: NPaul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Fix checkpatch.pl issues with open brace '{'
following struct go on the same line in dgap.h
Signed-off-by: NEbru Akagunduz <ebru.akagunduz@gmail.com>
Acked-by: NPaul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>