snd_kctl_jack_new() tries to assign a unique index number when a name
string that has been already registered is passed.  However, it checks
with the base string without "Jack" suffix, so it never hits.
Fix the call with the properly processed name string instead.

Fixes: b8dd0866 'ALSA: Jack: handle jack embedded kcontrol creating within ctljack')
Signed-off-by: NTakashi Iwai <tiwai@suse.de>

snd_kctl_jack_new() and snd_kctl_jack_report() are internal only now
so make them static.
Signed-off-by: NJie Yang <yang.jie@intel.com>
Signed-off-by: NTakashi Iwai <tiwai@suse.de>

Jack snd_kcontrols can now be created during snd_jack_new()
or by later calling snd_jack_add_new_kctls().

This patch creates the jacks during the initialisation stage
for both phantom and non phantom jacks.
Signed-off-by: NJie Yang <yang.jie@intel.com>
Signed-off-by: NTakashi Iwai <tiwai@suse.de>

This patch adds a static method get_available_index() to
allocate the index of new jack kcontrols and also adds
jack_kctl_name_gen() which is used to ensure compatibility
with jack naming by removing " Jack" from some incorrectly
passed names.
Signed-off-by: NJie Yang <yang.jie@intel.com>
Signed-off-by: NTakashi Iwai <tiwai@suse.de>

This is needed newly since 3.2...
Signed-off-by: NTakashi Iwai <tiwai@suse.de>

Now move the helper function for creating and reporting the jack-detection
to the common place.  The driver that needs this functionality should
select CONFIG_SND_KCTL_JACK kconfig.
Signed-off-by: NTakashi Iwai <tiwai@suse.de>