1. 05 3月, 2011 6 次提交
  2. 31 1月, 2011 1 次提交
  3. 17 12月, 2010 1 次提交
  4. 30 11月, 2010 5 次提交
    • S
      Staging: batman-adv: Use kernel functions to identify broadcasts · 951c44e0
      Sven Eckelmann 提交于
      linux/etherdevice.h already provides functions to classify different
      ethernet addresses. These inlineable functions should be used instead of
      custom functions.
      
      The check for multicast together with multicast can also be replaced
      with a single test for multicast because for every ethernet address x
      following is always true:
      
      is_broadcast_ether_addr(x) => is_multicast_ether_addr(x)
      
      or when looking more at the implementation:
      
      (FF:FF:FF:FF:FF:FF == x) => [(01:00:00:00:00:00 & x) != 00:00:00:00:00:00]
      Reported-by: NTobias Klauser <tklauser@distanz.ch>
      Signed-off-by: NSven Eckelmann <sven.eckelmann@gmx.de>
      Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>
      951c44e0
    • S
      Staging: batman-adv: Limit spin_locks to spin_lock_bh · 7a18deb7
      Sven Eckelmann 提交于
      spin_lock_irqsave disables the IRQs and stores them inside the flags
      provided by the caller. This is needed to protect a bottom half handler
      or a user context critical section from being interrupted by an
      interrupt handler which also tries to acquire the spinlock and locks
      forever.
      
      The linux device drivers will receive the packets inside an interrupt
      handler and the network infrastructure will process them inside bottom
      half. Thus batman-adv will only run in user context and bottom half
      handlers. We can conclude that batman-adv doesn't share its own
      spinlocks with real interrupt handlers.
      
      This makes it possible to exchange the quite complex spin_lock_irqsave
      with spin_lock_bh which only stops bottom halves from running on the
      current cpu, but allows interrupt handlers to take over to keep the
      interrupt latency low.
      Signed-off-by: NSven Eckelmann <sven.eckelmann@gmx.de>
      Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>
      7a18deb7
    • S
      Staging: batman-adv: Rewrite hash using hlist_* · bd204952
      Sven Eckelmann 提交于
      The hash implementation is a complete implementation of a hash using
      buckets as hash entries and overflow buckets attached to them.
      
      The kernel already provides datastructures hlist_head and hlist_node
      which can be used to implement an hash using lists as hash buckets. So
      it is better to implement heavily used functionality on top of those
      instead of providing a full hash implementation.
      
      The rewrite changes the behavior of some functions slightly:
       * hash_add add elements to the front instead of the tail
       * hash_iterate doesn't provide pointer to access bucket->data directly,
         but it can be accessed using hlist_entry
      Reported-by: NDavid S. Miller <davem@davemloft.net>
      Signed-off-by: NSven Eckelmann <sven.eckelmann@gmx.de>
      Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>
      bd204952
    • S
      Staging: batman-adv: Remove hashdata_choose_cb from hash · 6d5e6542
      Sven Eckelmann 提交于
      Function pointers cannot be inlined by a compiler and thus always has
      the overhead of an call. hashdata_choose_cb's are one of the most often
      called function pointers and its overhead must kept relative low.
      
      As first step, every function which uses this function pointer takes it
      as parameter instead of storing it inside the hash abstraction
      structure.
      
      This not generate any performance gain right now. The called functions
      must also be able to be inlined by the calling functions to enable
      inlining of the function pointer.
      Reported-by: NDavid S. Miller <davem@davemloft.net>
      Signed-off-by: NSven Eckelmann <sven.eckelmann@gmx.de>
      Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>
      6d5e6542
    • S
      Staging: batman-adv: Remove hashdata_compare_cb from hash · 51f3d8a2
      Sven Eckelmann 提交于
      Function pointers cannot be inlined by a compiler and thus always has
      the overhead of an call. hashdata_compare_cb's are one of the most often
      called function pointers and its overhead must kept relative low.
      
      As first step, every function which uses this function pointer takes it
      as parameter instead of storing it inside the hash abstraction
      structure.
      
      This not generate any performance gain right now. The called functions
      must also be able to be inlined by the calling functions to enable
      inlining of the function pointer.
      Reported-by: NDavid S. Miller <davem@davemloft.net>
      Signed-off-by: NSven Eckelmann <sven.eckelmann@gmx.de>
      Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>
      51f3d8a2
  5. 11 11月, 2010 1 次提交
  6. 10 11月, 2010 2 次提交
  7. 21 10月, 2010 1 次提交
  8. 21 9月, 2010 1 次提交
  9. 05 9月, 2010 4 次提交
  10. 09 7月, 2010 3 次提交
  11. 23 6月, 2010 3 次提交
  12. 19 6月, 2010 1 次提交
  13. 12 5月, 2010 8 次提交
  14. 04 3月, 2010 3 次提交