Original code doesn't call kfree(chip) on error.
Signed-off-by: NKulikov Vasiliy <segooon@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

If stub_probe() failed then do not increase interf_count. In original
code sdev was leaked as its interf_count never reaches 0.
Signed-off-by: NKulikov Vasiliy <segooon@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

On Fri, Aug 13, 2010 at 03:38:40PM +0200, Dan Carpenter wrote:
> Speak of left over stuff, it's weird that I didn't notice this before
> but gcc complains about an unitialized variable in
> imon_incoming_packet().
>
> drivers/staging/lirc/lirc_imon.c: In function ‘imon_incoming_packet’:
> drivers/staging/lirc/lirc_imon.c:661: warning: ‘chunk_num’ may be used
> 	uninitialized in this function
>
> I don't know how to fix that, but it looks important.

Ew. Yeah, that doesn't look so hot like it is right now. The old lirc_imon
driver had chunk_num = buf[7], and made much more extensive use of
chunk_num. Simply removing chunk_num and using buf[7] should be fine.
Signed-off-by: NJarod Wilson <jarod@redhat.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Driver should call disable_pci_device() if it returns from pci_probe()
with error. Also it must not be called if pci_request_region() fails as
it means that somebody uses device resources and rules the device.
Signed-off-by: NKulikov Vasiliy <segooon@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Driver should call disable_pci_device() if it returns from pci_probe()
with error.
Signed-off-by: NKulikov Vasiliy <segooon@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Driver should call disable_pci_device() if it returns from pci_probe()
with error.
Signed-off-by: NKulikov Vasiliy <segooon@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

acpi_bus_register_driver() returns an int, not acpi_status.  It returns
zero on success and negative error codes on failure, but acpi_status is
unsigned.  We can just use "ret" here.
Signed-off-by: NDan Carpenter <error27@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

In the original source it would write past the end of the array before
returning the error code.
Signed-off-by: NDan Carpenter <error27@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

In the original code there was some extra semicolons after the if
statement:
	if (!channel_map[ieee->current_network.channel]);
						       ^^^
>From the indenting it looked like that should be curly braces instead.

Also I made some white space changes to stop checkpatch.pl from
complaining.
Signed-off-by: NDan Carpenter <error27@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

We never use control_req so I removed it.
Signed-off-by: NDan Carpenter <error27@gmail.com>
Acked-by: NJarod Wilson <jarod@redhat.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Driver should call disable_pci_device() if it returns from pci_probe()
with error.
Signed-off-by: NKulikov Vasiliy <segooon@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Driver should call disable_pci_device() if it returns from pci_probe()
with error.
Signed-off-by: NKulikov Vasiliy <segooon@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Driver should call disable_pci_device() if it returns from pci_probe()
with error.
Signed-off-by: NKulikov Vasiliy <segooon@gmail.com>
Acked-by: NJarod Wilson <jarod@redhat.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Use DEFINE_PCI_DEVICE_TABLE() to make xgifb_pci_table const and marked as __devinitconst
Signed-off-by: NJavier Martinez Canillas <martinez.javier@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

This is the first of a patch series that uses PCI_DEVICE() macro for pci table entries on comedi drivers and thus improving readability.
Signed-off-by: NJavier Martinez Canillas <martinez.javier@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Use PCI_DEVICE() macro for pci table entries on comedi driver and thus improves readability.
Signed-off-by: NJavier Martinez Canillas <martinez.javier@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Use PCI_DEVICE() macro for pci table entries on comedi driver and thus improves readability.
Signed-off-by: NJavier Martinez Canillas <martinez.javier@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Use PCI_DEVICE() macro for pci table entries on comedi driver and thus improves readability.
Signed-off-by: NJavier Martinez Canillas <martinez.javier@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Use PCI_DEVICE() macro for pci table entries on comedi driver and thus improves readability.
Signed-off-by: NJavier Martinez Canillas <martinez.javier@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Use PCI_DEVICE() macro for pci table entries on comedi driver and thus improves readability.
Signed-off-by: NJavier Martinez Canillas <martinez.javier@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Use PCI_DEVICE() macro for pci table entries on comedi driver and thus improves readability.
Signed-off-by: NJavier Martinez Canillas <martinez.javier@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Use PCI_DEVICE() macro for pci table entries on comedi driver and thus improves readability.
Signed-off-by: NJavier Martinez Canillas <martinez.javier@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Use PCI_DEVICE() macro for pci table entries on comedi driver and thus improves readability.
Signed-off-by: NJavier Martinez Canillas <martinez.javier@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Use PCI_DEVICE() macro for pci table entries on comedi driver and thus improves readability.
Signed-off-by: NJavier Martinez Canillas <martinez.javier@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Use PCI_DEVICE() macro for pci table entries on comedi driver and thus improves readability.
Signed-off-by: NJavier Martinez Canillas <martinez.javier@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Use PCI_DEVICE() macro for pci table entries on comedi driver and thus improves readability.
Signed-off-by: NJavier Martinez Canillas <martinez.javier@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Use PCI_DEVICE() macro for pci table entries on comedi driver and thus improves readability.
Signed-off-by: NJavier Martinez Canillas <martinez.javier@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Use PCI_DEVICE() macro for pci table entries on comedi driver and thus improves readability.
Signed-off-by: NJavier Martinez Canillas <martinez.javier@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Fixed the single spacing error in oid.h.
Signed-off-by: NNeil Munro <neilmunro@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Fixed two coding style errors in the form of pointer style issues in eeprom.h.
Signed-off-by: NNeil Munro <neilmunro@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

In today linux-next I got a compile warning in staging/otus driver.
This patch solves the issue and also improves the coding style.
Signed-off-by: NRoberto Rodriguez Alcala <rralcala@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Remove explicit arch dependencies
Signed-off-by: NDenis Kirjanov <dkirjanov@kernel.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

this one completes my last patch set to compile fine for all drivers.
Signed-off-by: NManuel Stahl <manuel.stahl@iis.fraunhofer.de>
Signed-off-by: NJonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: NDatta, Shubhrajyoti <shubhrajyoti@ti.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

g     -> ms/s^2
deg   -> rad
deg/s -> rad/s
some temperatures still broken
Signed-off-by: NManuel Stahl <manuel.stahl@iis.fraunhofer.de>
Signed-off-by: NJonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Signed-off-by: NManuel Stahl <manuel.stahl@iis.fraunhofer.de>
Signed-off-by: NJonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Signed-off-by: NManuel Stahl <manuel.stahl@iis.fraunhofer.de>
Signed-off-by: NJonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

tested with sca3000, adis16400
Signed-off-by: NManuel Stahl <manuel.stahl@iis.fraunhofer.de>
Signed-off-by: NJonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Now fits other driver's structure for easier modification.
Signed-off-by: NManuel Stahl <manuel.stahl@iis.fraunhofer.de>
Signed-off-by: NJonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

bps -> bytes_per_datum
ring_enable -> enable
Signed-off-by: NManuel Stahl <manuel.stahl@iis.fraunhofer.de>
Signed-off-by: NJonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

i2c_smbus_read_byte_data() returns an s32 type.  We need to change
"rate" to signed for the error handling to work.

Also I changed it to propogate the error code instead of just returning
-EINVAL.  Other error codes could be -EAGAIN for example.
Signed-off-by: NDan Carpenter <error27@gmail.com>
Acked-by: NJonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>