Skip to content

K
Kernel

openeuler / Kernel
1 年多 前同步成功

通知 8
Star 0
Fork 0
K
Kernel
切换分支/标签
  1. 18 1月, 2014 1 次提交
  3. 04 1月, 2014 1 次提交
    • S
      sh_eth: coding style fixes · 128296fc
      由 Sergei Shtylyov 提交于 
      Running 'scripts/checkpatch.pl' on the driver files gives numerous warnings:

- block comments using empty /* line;

- unneeded \ at end of lines;

- message string split across lines;

- use of __attribute__((aligned(n))) instead of __aligned(n) macro;

- use of __attribute__((packed)) instead of __packed macro.

Additionally, running 'scripts/checkpatch.pl --strict' gives more complaints:

- including the paragraph about writing to FSF into the heading comment;

- alignment not matching open paren;

- multiple assignments on one line;

- use of CamelCase names;

- missing {} on one of the *if* arms where another has them;

- spinlock definition without a comment.

While fixing these, also do some more style cleanups:

- remove useless () around expressions;

- add {} around multi-line *if* operator's arm;

- remove space before comma;

- add spaces after /* and before */;

- properly align continuation lines of broken up expressions;

- realign comments to the structure fields.
Signed-off-by: NSergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      128296fc
  5. 24 10月, 2013 1 次提交
  7. 21 8月, 2013 2 次提交
  9. 25 7月, 2013 1 次提交
  11. 24 6月, 2013 1 次提交
    • S
      sh_eth: fix unhandled RFE interrupt · ca8c3585
      由 Sergei Shtylyov 提交于 
      EESR.RFE (receive FIFO overflow) interrupt is enabled by the driver on all SoCs
and sh_eth_error() handles it but it's not present in any initializer/assignment
of the 'eesr_err_check' field of 'struct sh_eth_cpu_data'. This leads to that
interrupt not being handled and cleared, and finally to disabling IRQ and the
driver being non-functional.

Modify DEFAULT_EESR_ERR_CHECK macro and all explicit initializers of the above
mentioned field to contain the EESR.RFE bit. Remove useless backslashes from the
initializers, while at it.
Signed-off-by: NSergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      ca8c3585
  13. 20 6月, 2013 5 次提交
  15. 07 6月, 2013 2 次提交
  17. 01 4月, 2013 1 次提交
  19. 30 3月, 2013 1 次提交
  21. 22 3月, 2013 1 次提交
    • S
      sh_eth: use managed device API · d5e07e69
      由 Sergei Shtylyov 提交于 
      Switch the driver to the managed device API by replacing ioremap() calls with
devm_ioremap_resource() (that will also result in calling request_mem_region()
which the driver forgot to do until now) and k[mz]alloc() with devm_kzalloc() --
this permits to simplify driver's probe()/remove() method cleanup. We can now
remove the ioremap() error messages since the error messages are printed by
 devm_ioremap_resource() itself. We can also remove the 'bitbang' field from
'struct sh_eth_private' as we don't need it anymore in order to free the memory
behind it...
Signed-off-by: NSergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      d5e07e69
  23. 21 3月, 2013 1 次提交
  25. 27 6月, 2012 3 次提交
  27. 26 6月, 2012 1 次提交
  29. 05 4月, 2012 1 次提交
  31. 02 4月, 2012 1 次提交
  33. 28 3月, 2012 1 次提交
  35. 17 2月, 2012 2 次提交
  37. 08 2月, 2012 2 次提交
  39. 29 9月, 2011 2 次提交
  41. 13 8月, 2011 1 次提交
  43. 15 3月, 2011 4 次提交
  45. 12 12月, 2010 1 次提交
    • T
      drivers/net: remove unnecessary flush_scheduled_work() calls · 6e07ebd8
      由 Tejun Heo 提交于 
      janz-ican3, sh_eth, skge and vxge don't use workqueue at all and there
is no reason to flush the system_wq.  Drop flush_scheduled_work()
calls and references to workqueue.
Signed-off-by: NTejun Heo <tj@kernel.org>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Wolfgang Grandegger <wg@grandegger.com>
Cc: Stephen Hemminger <shemminger@linux-foundation.org>
Cc: Ramkrishna Vepa <ramkrishna.vepa@exar.com>
Cc: Sivakumar Subramani <sivakumar.subramani@exar.com>
Cc: Sreenivasa Honnur <sreenivasa.honnur@exar.com>
Cc: Jon Mason <jon.mason@exar.com>
Cc: netdev@vger.kernel.org
      6e07ebd8
  47. 13 10月, 2009 1 次提交
  49. 29 8月, 2009 1 次提交
  51. 26 5月, 2009 1 次提交