.probe_new() doesn't get the i2c_device_id * parameter, so determine
that explicitly in the probe function.
Signed-off-by: NUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-for-MFD-by: NLee Jones <lee@kernel.org>
Acked-for-Backlight-by: NLee Jones <lee@kernel.org>
Link: https://lore.kernel.org/r/20221118224540.619276-555-uwe@kleine-koenig.orgSigned-off-by: NMark Brown <broonie@kernel.org>

.probe_new() doesn't get the i2c_device_id * parameter, so determine
that explicitly in the probe function.
Signed-off-by: NUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-for-MFD-by: NLee Jones <lee@kernel.org>
Acked-for-Backlight-by: NLee Jones <lee@kernel.org>
Link: https://lore.kernel.org/r/20221118224540.619276-554-uwe@kleine-koenig.orgSigned-off-by: NMark Brown <broonie@kernel.org>

.probe_new() doesn't get the i2c_device_id * parameter, so determine
that explicitly in the probe function.
Signed-off-by: NUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-for-MFD-by: NLee Jones <lee@kernel.org>
Acked-for-Backlight-by: NLee Jones <lee@kernel.org>
Link: https://lore.kernel.org/r/20221118224540.619276-543-uwe@kleine-koenig.orgSigned-off-by: NMark Brown <broonie@kernel.org>

.probe_new() doesn't get the i2c_device_id * parameter, so determine
that explicitly in the probe function.
Signed-off-by: NUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-for-MFD-by: NLee Jones <lee@kernel.org>
Acked-for-Backlight-by: NLee Jones <lee@kernel.org>
Link: https://lore.kernel.org/r/20221118224540.619276-542-uwe@kleine-koenig.orgSigned-off-by: NMark Brown <broonie@kernel.org>

.probe_new() doesn't get the i2c_device_id * parameter, so determine
that explicitly in the probe function.
Signed-off-by: NUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-for-MFD-by: NLee Jones <lee@kernel.org>
Acked-for-Backlight-by: NLee Jones <lee@kernel.org>
Link: https://lore.kernel.org/r/20221118224540.619276-539-uwe@kleine-koenig.orgSigned-off-by: NMark Brown <broonie@kernel.org>

Add the rpmh regulators found in PM8550 PMIC and its variants,
along with their compatibles and configuration data. They also
contain some FT-SMPS 525, so add their configuration as well.
Signed-off-by: NAbel Vesa <abel.vesa@linaro.org>
Reviewed-by: NKonrad Dybcio <konrad.dybcio@linaro.org>
Link: https://lore.kernel.org/r/20221123153638.721254-3-abel.vesa@linaro.orgSigned-off-by: NMark Brown <broonie@kernel.org>

.probe_new() doesn't get the i2c_device_id * parameter, so determine
that explicitly in the probe function.
Signed-off-by: NUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-for-MFD-by: NLee Jones <lee@kernel.org>
Acked-for-Backlight-by: NLee Jones <lee@kernel.org>
Link: https://lore.kernel.org/r/20221118224540.619276-560-uwe@kleine-koenig.orgSigned-off-by: NMark Brown <broonie@kernel.org>

.probe_new() doesn't get the i2c_device_id * parameter, so determine
that explicitly in the probe function.
Signed-off-by: NUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-for-MFD-by: NLee Jones <lee@kernel.org>
Acked-for-Backlight-by: NLee Jones <lee@kernel.org>
Link: https://lore.kernel.org/r/20221118224540.619276-558-uwe@kleine-koenig.orgSigned-off-by: NMark Brown <broonie@kernel.org>

.probe_new() doesn't get the i2c_device_id * parameter, so determine
that explicitly in the probe function.
Signed-off-by: NUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-for-MFD-by: NLee Jones <lee@kernel.org>
Acked-for-Backlight-by: NLee Jones <lee@kernel.org>
Link: https://lore.kernel.org/r/20221118224540.619276-552-uwe@kleine-koenig.orgSigned-off-by: NMark Brown <broonie@kernel.org>

.probe_new() doesn't get the i2c_device_id * parameter, so determine
that explicitly in the probe function.
Signed-off-by: NUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-for-MFD-by: NLee Jones <lee@kernel.org>
Acked-for-Backlight-by: NLee Jones <lee@kernel.org>
Link: https://lore.kernel.org/r/20221118224540.619276-550-uwe@kleine-koenig.orgSigned-off-by: NMark Brown <broonie@kernel.org>

.probe_new() doesn't get the i2c_device_id * parameter, so determine
that explicitly in the probe function.
Signed-off-by: NUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-for-MFD-by: NLee Jones <lee@kernel.org>
Acked-for-Backlight-by: NLee Jones <lee@kernel.org>
Link: https://lore.kernel.org/r/20221118224540.619276-547-uwe@kleine-koenig.orgSigned-off-by: NMark Brown <broonie@kernel.org>

.probe_new() doesn't get the i2c_device_id * parameter, so determine
that explicitly in the probe function.
Signed-off-by: NUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-for-MFD-by: NLee Jones <lee@kernel.org>
Acked-for-Backlight-by: NLee Jones <lee@kernel.org>
Link: https://lore.kernel.org/r/20221118224540.619276-545-uwe@kleine-koenig.orgSigned-off-by: NMark Brown <broonie@kernel.org>

.probe_new() doesn't get the i2c_device_id * parameter, so determine
that explicitly in the probe function.
Signed-off-by: NUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: NMichael Hennerich <michael.hennerich@analog.com>
Acked-for-MFD-by: NLee Jones <lee@kernel.org>
Acked-for-Backlight-by: NLee Jones <lee@kernel.org>
Link: https://lore.kernel.org/r/20221118224540.619276-540-uwe@kleine-koenig.orgSigned-off-by: NMark Brown <broonie@kernel.org>

Use kfree_const() to free supply_name conditionally in create_regulator()
as supply_name may be allocated from kmalloc() or directly from .rodata
section.

Fixes: 87fe29b6 ("regulator: push allocations in create_regulator() outside of lock")
Signed-off-by: NWang ShaoBo <bobo.shaobowang@huawei.com>
Link: https://lore.kernel.org/r/20221123034616.3609537-1-bobo.shaobowang@huawei.comSigned-off-by: NMark Brown <broonie@kernel.org>

The dev_err_probe() has (at least) following benefits over dev_err()
when printing an error print for a failed function call at a device
driver probe:
        - Omit error level print if error is 'EPRBE_DEFER'
        - Standardized print format for returned error
        - return the error value allowing shortening calls like:

        if (ret) {
                dev_err(...);
                return ret;
        }

        to

        if (ret)
                return dev_err_probe(...);

Convert the ROHM BD718x7 regulator driver to use the dev_err_probe() when
returned error is not hard-coded constant.

NOTE:
This commit also changes the error handling path to return immediately
from a spot where the error is spotted instead of using a single point
of exit.
Signed-off-by: NMatti Vaittinen <mazziesaccount@gmail.com>
Link: https://lore.kernel.org/r/fee54c2d04bb41b51381e31523f9ed31575206d2.1669203610.git.mazziesaccount@gmail.comSigned-off-by: NMark Brown <broonie@kernel.org>

The dev_err_probe() has (at least) following benefits over dev_err()
when printing an error print for a failed function call at a device
driver probe:
        - Omit error level print if error is 'EPRBE_DEFER'
        - Standardized print format for returned error
        - return the error value allowing shortening calls like:

        if (ret) {
                dev_err(...);
                return ret;
        }

        to

        if (ret)
                return dev_err_probe(...);

Convert the ROHM BD71828, ROHM BD71815 and ROHM BD9576 regulator drivers
to use the dev_err_probe() when returned error is not hard-coded constant.
Signed-off-by: NMatti Vaittinen <mazziesaccount@gmail.com>
Link: https://lore.kernel.org/r/0b644da4a8f58558ffe474d2593f85c46de2f965.1669203610.git.mazziesaccount@gmail.comSigned-off-by: NMark Brown <broonie@kernel.org>

A device-tree node name was printed when bd718x7 driver's feedback-loop
feature was developed. This print was accidentally left in driver. The
info-level print just pollutes the log.

Drop unnecessary pr_info()

Fixes: d2ad9811 ("regulator: bd718x7: Support external connection to scale voltages")
Signed-off-by: NMatti Vaittinen <mazziesaccount@gmail.com>
Link: https://lore.kernel.org/r/33fd99abf2451999938fef4ba6cf7b3f19e9b992.1669203610.git.mazziesaccount@gmail.comSigned-off-by: NMark Brown <broonie@kernel.org>

The probe function doesn't make use of the i2c_device_id * parameter so it
can be trivially converted.
Signed-off-by: NUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-for-MFD-by: NLee Jones <lee@kernel.org>
Acked-for-Backlight-by: NLee Jones <lee@kernel.org>
Link: https://lore.kernel.org/r/20221118224540.619276-559-uwe@kleine-koenig.orgSigned-off-by: NMark Brown <broonie@kernel.org>

The probe function doesn't make use of the i2c_device_id * parameter so it
can be trivially converted.
Signed-off-by: NUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-for-MFD-by: NLee Jones <lee@kernel.org>
Acked-for-Backlight-by: NLee Jones <lee@kernel.org>
Link: https://lore.kernel.org/r/20221118224540.619276-557-uwe@kleine-koenig.orgSigned-off-by: NMark Brown <broonie@kernel.org>

The probe function doesn't make use of the i2c_device_id * parameter so it
can be trivially converted.
Signed-off-by: NUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-for-MFD-by: NLee Jones <lee@kernel.org>
Acked-for-Backlight-by: NLee Jones <lee@kernel.org>
Link: https://lore.kernel.org/r/20221118224540.619276-556-uwe@kleine-koenig.orgSigned-off-by: NMark Brown <broonie@kernel.org>

The probe function doesn't make use of the i2c_device_id * parameter so it
can be trivially converted.
Signed-off-by: NUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-for-MFD-by: NLee Jones <lee@kernel.org>
Acked-for-Backlight-by: NLee Jones <lee@kernel.org>
Link: https://lore.kernel.org/r/20221118224540.619276-553-uwe@kleine-koenig.orgSigned-off-by: NMark Brown <broonie@kernel.org>

The probe function doesn't make use of the i2c_device_id * parameter so it
can be trivially converted.
Signed-off-by: NUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-for-MFD-by: NLee Jones <lee@kernel.org>
Acked-for-Backlight-by: NLee Jones <lee@kernel.org>
Link: https://lore.kernel.org/r/20221118224540.619276-551-uwe@kleine-koenig.orgSigned-off-by: NMark Brown <broonie@kernel.org>

The probe function doesn't make use of the i2c_device_id * parameter so it
can be trivially converted.
Signed-off-by: NUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-for-MFD-by: NLee Jones <lee@kernel.org>
Acked-for-Backlight-by: NLee Jones <lee@kernel.org>
Link: https://lore.kernel.org/r/20221118224540.619276-549-uwe@kleine-koenig.orgSigned-off-by: NMark Brown <broonie@kernel.org>

The probe function doesn't make use of the i2c_device_id * parameter so it
can be trivially converted.
Signed-off-by: NUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-for-MFD-by: NLee Jones <lee@kernel.org>
Acked-for-Backlight-by: NLee Jones <lee@kernel.org>
Link: https://lore.kernel.org/r/20221118224540.619276-548-uwe@kleine-koenig.orgSigned-off-by: NMark Brown <broonie@kernel.org>

The probe function doesn't make use of the i2c_device_id * parameter so it
can be trivially converted.
Signed-off-by: NUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-for-MFD-by: NLee Jones <lee@kernel.org>
Acked-for-Backlight-by: NLee Jones <lee@kernel.org>
Link: https://lore.kernel.org/r/20221118224540.619276-546-uwe@kleine-koenig.orgSigned-off-by: NMark Brown <broonie@kernel.org>

The probe function doesn't make use of the i2c_device_id * parameter so it
can be trivially converted.
Signed-off-by: NUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-for-MFD-by: NLee Jones <lee@kernel.org>
Acked-for-Backlight-by: NLee Jones <lee@kernel.org>
Link: https://lore.kernel.org/r/20221118224540.619276-544-uwe@kleine-koenig.orgSigned-off-by: NMark Brown <broonie@kernel.org>

The probe function doesn't make use of the i2c_device_id * parameter so it
can be trivially converted.
Signed-off-by: NUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-for-MFD-by: NLee Jones <lee@kernel.org>
Acked-for-Backlight-by: NLee Jones <lee@kernel.org>
Link: https://lore.kernel.org/r/20221118224540.619276-541-uwe@kleine-koenig.orgSigned-off-by: NMark Brown <broonie@kernel.org>

The regulator_get() function never returns NULL. It returns error pointers.

Fixes: 27b9ecc7 ("regulator: Add of_regulator_bulk_get_all")
Signed-off-by: NPeng Wu <wupeng58@huawei.com>
Link: https://lore.kernel.org/r/20221122082242.82937-1-wupeng58@huawei.comSigned-off-by: NMark Brown <broonie@kernel.org>

The Arizona and Madera codecs all have a datasheet name of "MICVDD"
for the regulator output. But future codecs with a regulator that
can be controlled by this driver have different naming convention
for the output of the regulator.

Move the setting of the supply name from arizona_micsupp_common_init()
to arizona_micsupp_probe() and madera_micsupp_probe().
Signed-off-by: NRichard Fitzgerald <rf@opensource.cirrus.com>
Link: https://lore.kernel.org/r/20221109165331.29332-8-rf@opensource.cirrus.comSigned-off-by: NMark Brown <broonie@kernel.org>

When Madera support was added to this driver the code was left
using ARIZONA_* defines. This wasn't causing any problem because
those defines just happened to have the same value as the
equivalent MADERA_* defines. But it is not ideal to assume this,
and future devices that can share this driver do not have the
same register map.

Fix the code to refer to the register data in struct regulator_desc.
Signed-off-by: NRichard Fitzgerald <rf@opensource.cirrus.com>
Link: https://lore.kernel.org/r/20221109165331.29332-7-rf@opensource.cirrus.comSigned-off-by: NMark Brown <broonie@kernel.org>

It work exactly like regulator_bulk_get() but instead of working on a
provided list of names, it seek all consumers properties matching
xxx-supply.
Signed-off-by: NCorentin Labbe <clabbe@baylibre.com>
Link: https://lore.kernel.org/r/20221115073603.3425396-2-clabbe@baylibre.comSigned-off-by: NMark Brown <broonie@kernel.org>

PMR735a has a wider range than previously defined. Fix it.

Fixes: c4e5aa3d ("regulator: qcom-rpmh: Add PM7325/PMR735A regulator support")
Signed-off-by: NKonrad Dybcio <konrad.dybcio@linaro.org>
Link: https://lore.kernel.org/r/20221110210706.80301-1-konrad.dybcio@linaro.orgSigned-off-by: NMark Brown <broonie@kernel.org>

I got the the following report:

  OF: ERROR: memory leak, expected refcount 1 instead of 2,
  of_node_get()/of_node_put() unbalanced - destroy cset entry:
  attach overlay node /i2c/pmic@62/regulators/exten

In of_get_regulator(), the node is returned from of_parse_phandle()
with refcount incremented, after using it, of_node_put() need be called.

Fixes: 69511a45 ("regulator: map consumer regulator based on device tree")
Signed-off-by: NYang Yingliang <yangyingliang@huawei.com>
Link: https://lore.kernel.org/r/20221115091508.900752-1-yangyingliang@huawei.comSigned-off-by: NMark Brown <broonie@kernel.org>

Introduces new helper function to aid in .probe_new() refactors. In order
to use existing i2c_get_device_id() on the probe callback, the device
match table needs to be accessible in that function, which would require
bigger refactors in some drivers using the deprecated .probe callback.

This issue was discussed in more detail in the IIO mailing list.

Link: https://lore.kernel.org/all/20221023132302.911644-11-u.kleine-koenig@pengutronix.de/Suggested-by: NNuno Sá <noname.nuno@gmail.com>
Suggested-by: NAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Suggested-by: NJonathan Cameron <jic23@kernel.org>
Signed-off-by: NAngel Iglesias <ang.iglesiasg@gmail.com>
Reviewed-by: NAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: NJonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: NWolfram Sang <wsa@kernel.org>

PMR735a has a wider range than previously defined. Fix it.

Fixes: 0cda8c43 ("regulator: qcom_smd: Add PMR735a regulators")
Signed-off-by: NKonrad Dybcio <konrad.dybcio@linaro.org>
Link: https://lore.kernel.org/r/20221110121225.9216-1-konrad.dybcio@linaro.orgSigned-off-by: NMark Brown <broonie@kernel.org>

PMR735a is already supported in the RPMH regulator driver, but
there are cases where it's bundled with SMD RPM SoCs. Port it over
to qcom_smd-regulator to enable usage in such cases.
Signed-off-by: NKonrad Dybcio <konrad.dybcio@linaro.org>
Link: https://lore.kernel.org/r/20221109110846.45789-2-konrad.dybcio@linaro.orgSigned-off-by: NMark Brown <broonie@kernel.org>

In addition to adding some fairly simple OF support code, we make some
slight adjustments to the userspace-consumer driver to properly
support use with regulator-output hardware:

 - We now do an exclusive get of the supply regulators so as to
   prevent regulator_init_complete_work from automatically disabling
   them.

 - Instead of assuming that the supply is initially disabled, we now
   query its state to determine the initial value of drvdata->enabled.
Signed-off-by: NZev Weiss <zev@bewilderbeest.net>
Link: https://lore.kernel.org/r/20221031233704.22575-4-zev@bewilderbeest.netSigned-off-by: NMark Brown <broonie@kernel.org>

We had an exclusive variant of the devm_regulator_get() API, but no
corresponding variant for the bulk API; let's add one now.  We add a
generalized version of the existing regulator_bulk_get() function that
additionally takes a get_type parameter and redefine
regulator_bulk_get() in terms of it, then do similarly with
devm_regulator_bulk_get(), and finally add the new
devm_regulator_bulk_get_exclusive().
Signed-off-by: NZev Weiss <zev@bewilderbeest.net>
Link: https://lore.kernel.org/r/20221031233704.22575-2-zev@bewilderbeest.netSigned-off-by: NMark Brown <broonie@kernel.org>

Add support for Richtek RT6190 4-Switch BuckBoost controller.
Signed-off-by: NChiYuan Huang <cy_huang@richtek.com>
Link: https://lore.kernel.org/r/1667183334-16511-3-git-send-email-u0084500@gmail.comSigned-off-by: NMark Brown <broonie@kernel.org>

Commit 8c193f47 ("pwm: tegra: Optimize period calculation") updated
the period calculation in the Tegra PWM driver and now returns an error
if the period requested is less than minimum period supported. This is
breaking PWM support on various Tegra platforms. For example, on the
Tegra210 Jetson Nano platform this is breaking the PWM fan support and
probing the PWM fan driver now fails ...

 pwm-fan pwm-fan: Failed to configure PWM: -22
 pwm-fan: probe of pwm-fan failed with error -22

The problem is that the default parent clock for the PWM on Tegra210 is
a 32kHz clock and is unable to support the requested PWM period.

Fix PWM support on Tegra20, Tegra30, Tegra114, Tegra124 and Tegra210 by
updating the parent clock for the PWM to be the PLL_P.

Fixes: 8c193f47 ("pwm: tegra: Optimize period calculation")
Signed-off-by: NJon Hunter <jonathanh@nvidia.com>
Tested-by: Robert Eckelmann <longnoserob@gmail.com> # TF101 T20
Tested-by: Antoni Aloy Torrens <aaloytorrens@gmail.com> # TF101 T20
Tested-by: Svyatoslav Ryhel <clamor95@gmail.com> # TF201 T30
Tested-by: Andreas Westman Dorcsak <hedmoo@yahoo.com> # TF700T T3
Link: https://lore.kernel.org/r/20221010100046.6477-1-jonathanh@nvidia.comAcked-by: NUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: NStephen Boyd <sboyd@kernel.org>