提交 · c62d8437aa50cfe996c5a5f8d62387bf9741316f · openeuler / Kernel

04 4月, 2009 40 次提交

Staging: rspiusb: use USB API functions rather than constants · c62d8437

由 Julia Lawall 提交于 12月 29, 2008

This set of patches introduces calls to the following set of functions:

usb_endpoint_dir_in(epd)
usb_endpoint_dir_out(epd)
usb_endpoint_is_bulk_in(epd)
usb_endpoint_is_bulk_out(epd)
usb_endpoint_is_int_in(epd)
usb_endpoint_is_int_out(epd)
usb_endpoint_num(epd)
usb_endpoint_type(epd)
usb_endpoint_xfer_bulk(epd)
usb_endpoint_xfer_control(epd)
usb_endpoint_xfer_int(epd)
usb_endpoint_xfer_isoc(epd)

In some cases, introducing one of these functions is not possible, and it
just replaces an explicit integer value by one of the following constants:

USB_ENDPOINT_XFER_BULK
USB_ENDPOINT_XFER_CONTROL
USB_ENDPOINT_XFER_INT
USB_ENDPOINT_XFER_ISOC

An extract of the semantic patch that makes these changes is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@r1@ struct usb_endpoint_descriptor *epd; @@

- ((epd->bmAttributes & \(USB_ENDPOINT_XFERTYPE_MASK\|3\)) ==
- \(USB_ENDPOINT_XFER_CONTROL\|0\))
+ usb_endpoint_xfer_control(epd)

@r5@ struct usb_endpoint_descriptor *epd; @@

- ((epd->bEndpointAddress & \(USB_ENDPOINT_DIR_MASK\|0x80\)) ==
-  \(USB_DIR_IN\|0x80\))
+ usb_endpoint_dir_in(epd)

@inc@
@@

#include <linux/usb.h>

@depends on !inc && (r1||r5)@
@@

+ #include <linux/usb.h>
  #include <linux/usb/...>
// </smpl>
Signed-off-by: NJulia Lawall <julia@diku.dk>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

c62d8437

Staging: at76_usb: convert to use linux/ieee80211.h · f494b663

由 Kalle Valo 提交于 2月 22, 2009

Jason Andryuk noticed that at76_usb won't compile with current
wireless-testing tree. This is because net/ieee80211.h was missing.

net/ieee80211.h will be removed soon and at76_usb won't compile then that
happens. Preprare for that by using instead linux/ieee80211.h and copying
some structures not available.
Signed-off-by: NKalle Valo <kalle.valo@iki.fi>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

f494b663

Staging: at76_usb: mention mac80211 port in TODO file · 709ff0f6

由 Kalle Valo 提交于 12月 28, 2008

at76_usb has actually been already ported to use mac80211. Update the TODO
file to reflect this.
Signed-off-by: NKalle Valo <kalle.valo@iki.fi>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

709ff0f6

Staging: altpciechdma: checkpatch fixups · c9b8015b

由 Erik Andrén 提交于 3月 19, 2009

Signed-off-by: NErik Andrén <erik.andren@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

c9b8015b

Staging: altpciechdma: Null deref in altpciechdma.c remove() · 2c77cb3e

由 Dan Carpenter 提交于 1月 20, 2009

If dev is NULL it prints an error message.  The error message dereferences
dev.

Compile tested only.
Signed-off-by: NDan Carpenter <error27@gmail.com>
Cc: Leon Woestenberg <leon.woestenberg@axon.tv>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

2c77cb3e

Staging: meilhaus: some checkpatch.pl cleanup · 451084d2

由 Alexander Beregalov 提交于 3月 16, 2009

Cc: David Kiliani <mail@davidkiliani.de>
Signed-off-by: NAlexander Beregalov <a.beregalov@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

451084d2

Staging: meilhaus: remove dependence on kernel version · 483f29cc

由 Alexander Beregalov 提交于 3月 16, 2009

Cc: David Kiliani <mail@davidkiliani.de>
Signed-off-by: NAlexander Beregalov <a.beregalov@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

483f29cc

Staging: meilhaus: unsigned won't get negative after subtraction · a44522b2

由 Roel Kluin 提交于 1月 18, 2009

Since unsigned, it won't get negative after subtraction.
Signed-off-by: NRoel Kluin <roel.kluin@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

a44522b2

Staging: meilhaus: Use DEFINE_SPINLOCK · 3f4577bf

由 Julia Lawall 提交于 12月 25, 2008

SPIN_LOCK_UNLOCKED is deprecated.  The following makes the change suggested
in Documentation/spinlocks.txt

The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@@
declarer name DEFINE_SPINLOCK;
identifier xxx_lock;
@@

- spinlock_t xxx_lock = SPIN_LOCK_UNLOCKED;
+ DEFINE_SPINLOCK(xxx_lock);
// </smpl>
Signed-off-by: NJulia Lawall <julia@diku.dk>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

3f4577bf

Staging: meilhaus: Correct use of ! and & · 530ddf85

由 Julia Lawall 提交于 12月 24, 2008

ME_IO_SINGLE_TYPE_WRITE_NONBLOCKING and ME_IO_STREAM_CONFIG_WRAPAROUND both
hanve 0 as the rightmost bit, and thus eg
!flags & ME_IO_SINGLE_TYPE_WRITE_NONBLOCKING is always 0.
I assume that !(flags & ME_IO_SINGLE_TYPE_WRITE_NONBLOCKING) and
!(flags & ME_IO_STREAM_CONFIG_WRAPAROUND) were intended.

The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@@ expression E; constant C; @@
(
  !E & !C
|
- !E & C
+ !(E & C)
)
// </smpl>
Signed-off-by: NJulia Lawall <julia@diku.dk>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

530ddf85

Staging: go7007: fix build error · c6f5af88

由 Greg Kroah-Hartman 提交于 3月 17, 2009

VID_TYPE_CAPTURE is a v4l1 thing only.
Reported-by: NRandy Dunlap <randy.dunlap@oracle.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

c6f5af88

Staging: go7007: introduce missing kfree · 253d3b13

由 Julia Lawall 提交于 12月 25, 2008

Error handling code following a kmalloc should free the allocated data.

The semantic match that finds the problem is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@r exists@
local idexpression x;
statement S;
expression E;
identifier f,l;
position p1,p2;
expression *ptr != NULL;
@@

(
if ((x@p1 = \(kmalloc\|kzalloc\|kcalloc\)(...)) == NULL) S
|
x@p1 = \(kmalloc\|kzalloc\|kcalloc\)(...);
...
if (x == NULL) S
)
<... when != x
     when != if (...) { <+...x...+> }
x->f = E
...>
(
 return \(0\|<+...x...+>\|ptr\);
|
 return@p2 ...;
)

@script:python@
p1 << r.p1;
p2 << r.p2;
@@

print "* file: %s kmalloc %s return %s" % (p1[0].file,p1[0].line,p2[0].line)
// </smpl>
Signed-off-by: NJulia Lawall <julia@diku.dk>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

253d3b13

Staging: go7007: Move a dereference below a NULL test · 41e84789

由 Julia Lawall 提交于 12月 19, 2008

In each case, if the NULL test is necessary, then the dereference should be
moved below the NULL test.

The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/).  The result has been modified to
move the initialization of usb down closer to where it is used.

// <smpl>
@@
type T;
expression E;
identifier i,fld;
statement S;
@@

- T i = E->fld;
+ T i;
  ... when != E
      when != i
  if (E == NULL) S
+ i = E->fld;
// </smpl>
Signed-off-by: NJulia Lawall <julia@diku.dk>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

41e84789

Staging: agnx: Fixup xmit.c checkpatch warnings · fd1f72b1

由 Erik Andrén 提交于 3月 14, 2009

Signed-off-by: NErik Andrén <erik.andren@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

fd1f72b1

Staging: agnx: Fixup table.c checkpatch warnings · 9e38849e

由 Erik Andrén 提交于 3月 14, 2009

Signed-off-by: NErik Andrén <erik.andren@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

9e38849e

Staging: agnx: Fixup sta.h checkpatch warnings · 7f11b23b

由 Erik Andrén 提交于 3月 14, 2009

Signed-off-by: NErik Andrén <erik.andren@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

7f11b23b

Staging: agnx: Fixup sta.c checkpatch warnings · 715cf2c5

由 Erik Andrén 提交于 3月 14, 2009

Signed-off-by: NErik Andrén <erik.andren@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

715cf2c5

Staging: agnx: Fixup rf.c checkpatch warnings · 20da58cc

由 Erik Andrén 提交于 3月 14, 2009

Signed-off-by: NErik Andrén <erik.andren@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

20da58cc

Staging: agnx: Fixup phy.c checkpatch warnings · 0f31f62d

由 Erik Andrén 提交于 3月 14, 2009

Signed-off-by: NErik Andrén <erik.andren@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

0f31f62d

Staging: agnx: Fixup pci.c checkpatch warnings · f58e12e4

由 Erik Andrén 提交于 3月 14, 2009

Signed-off-by: NErik Andrén <erik.andren@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

f58e12e4

Staging: agnx: Fixup debug.h checkpatch warnings · b6da26e0

由 Erik Andrén 提交于 3月 14, 2009

Signed-off-by: NErik Andrén <erik.andren@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

b6da26e0

Staging: agnx: Fixup agnx.h checkpatch warnings · f9a6b62b

由 Erik Andrén 提交于 3月 14, 2009

Signed-off-by: NErik Andrén <erik.andren@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

f9a6b62b

Staging: agnx: mac80211 hw config change flags · 262d3870

由 Herton Ronaldo Krzesinski 提交于 2月 13, 2009

Adapt agnx after commit "mac80211: introduce hw config change flags",
detected by following build warning:
drivers/staging/agnx/pci.c:426: warning: initialization from incompatible pointer type
Signed-off-by: NHerton Ronaldo Krzesinski <herton@mandriva.com.br>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

262d3870

R
Staging: agnx: i reaches -1, tested 0 · 39b41b23
由 Roel Kluin 提交于 1月 31, 2009
```
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>
```
39b41b23

Staging: agnx: Move a dereference below a NULL test · 6bf67672

由 Julia Lawall 提交于 12月 19, 2008

If the NULL test is necessary, then the dereference should be moved below
the NULL test.

The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@@
type T;
expression E;
identifier i,fld;
statement S;
@@

- T i = E->fld;
+ T i;
  ... when != E
      when != i
  if (E == NULL) S
+ i = E->fld;
// </smpl>
Signed-off-by: NJulia Lawall <julia@diku.dk>
Cc: YanBo <dreamfly281@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

6bf67672

Staging: remove duplicated #include's · 4ed4f41c

由 Huang Weiyi 提交于 1月 11, 2009

Removed duplicated #include's in
  drivers/staging/altpciechdma/altpciechdma.c
  drivers/staging/comedi/comedidev.h
  drivers/staging/rt2860/rt_linux.h
  drivers/staging/rt2870/rt_linux.h
Signed-off-by: NHuang Weiyi <weiyi.huang@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

4ed4f41c

Staging: me4000: make file_operations const · 93be73f9

由 Andre Haupt 提交于 1月 26, 2009

This eliminates checkpatch.pl warnings, that struct file_operations is
usually const.  The structs me4000_ai_fops_array and
me4000_ao_fops_array are not modified and thus also made const.
Signed-off-by: NAndre Haupt <andre@bitwigglers.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

93be73f9

Staging: me4000: use tabs for code indentation · f02d3345

由 Andre Haupt 提交于 1月 26, 2009

Signed-off-by: NAndre Haupt <andre@bitwigglers.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

f02d3345

Staging: me4000: do not use C99 style comments. · 370eb29d

由 Andre Haupt 提交于 1月 26, 2009

Signed-off-by: NAndre Haupt <andre@bitwigglers.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

370eb29d

A
Staging: me4000: fix various checkpatch.pl warnings about bracing · b8341a8d
由 Andre Haupt 提交于 1月 26, 2009
```
Signed-off-by: NAndre Haupt <andre@bitwigglers.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>
```
b8341a8d
A
Staging: me4000: kfree(NULL) is safe, so no extra checks needed. · e8aa1bd0
由 Andre Haupt 提交于 1月 26, 2009
```
Signed-off-by: NAndre Haupt <andre@bitwigglers.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>
```
e8aa1bd0

Staging: me4000: replace some C99 comments · 705d300e

由 Andre Haupt 提交于 1月 26, 2009

checkpatch.pl triggered those as false positives for trailing
statements, but those lines also triggered some other warnings.
Signed-off-by: NAndre Haupt <andre@bitwigglers.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

705d300e

Staging: me4000: inline keyword should sit between storage class and type · 1836842b

由 Andre Haupt 提交于 1月 26, 2009

fixes some checkpatch.pl errors complaining about wrong position of the
inline keyword
Signed-off-by: NAndre Haupt <andre@bitwigglers.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

1836842b

Staging: me4000: return is not a function, no parentheses required · 387ed8f8

由 Andre Haupt 提交于 1月 26, 2009

fixes some checkpatch.pl errors about unneccessary parentheses.
Signed-off-by: NAndre Haupt <andre@bitwigglers.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

387ed8f8

Staging: me4000: use linux/uaccess.h and linux/io.h · 07d2a282

由 Andre Haupt 提交于 1月 26, 2009

This fixes the following checkpatch.pl warnings:

WARNING: Use #include <linux/uaccess.h> instead of <asm/uaccess.h>
WARNING: Use #include <linux/io.h> instead of <asm/io.h>
Signed-off-by: NAndre Haupt <andre@bitwigglers.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

07d2a282

Staging: wlan-ng: block ioctls until card fully initialised · cfde7451

由 Richard Kennedy 提交于 2月 20, 2009

Add a mutex to block ioctls before the card is fully initialised and
only allow one ioctl at a time.
This stops udev trying to load the firmware before to card is fully up.

patch ported from wlan-ng-devel

Karl Relton <karllinuxtest.relton@ntlworld.com> spotted that this was
missing from the staging version,
http://lists.linux-wlan.com/pipermail/linux-wlan-devel/2009-February/003890.htmlSigned-off-by: NRichard Kennedy <richard@rsk.demon.co.uk>
Cc: Karl Relton <karllinuxtest.relton@ntlworld.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

cfde7451

Staging: wlan-ng: Replace local byteorder macros · 18c7f792

由 Moritz Muehlenhoff 提交于 2月 18, 2009

Replace hfa384x2host_16(), hfa384x2host_32(), host2hfa384x_16()
and host2hfa384x_32() with standard byteorder macros.
Signed-off-by: NMoritz Muehlenhoff <jmm@debian.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

18c7f792

M
Staging: wlan-ng: Remove the now empty wlan_compat.h · 465e7417
由 Moritz Muehlenhoff 提交于 2月 09, 2009
```
Signed-off-by: NMoritz Muehlenhoff <jmm@debian.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>
```
465e7417
M
Staging: wlan-ng: Remove dead code from p80211netdev.c · 3897cd0c
由 Moritz Muehlenhoff 提交于 2月 09, 2009
```
Signed-off-by: NMoritz Muehlenhoff <jmm@debian.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>
```
3897cd0c
M
Staging: wlan-ng: Remove unnecessary checks for NULL before calling kfree() · 7c98f718
由 Moritz Muehlenhoff 提交于 2月 09, 2009
```
Signed-off-by: NMoritz Muehlenhoff <jmm@debian.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>
```
7c98f718

openeuler / Kernel 1 年多 前同步成功

openeuler / Kernel
1 年多前同步成功