1. 26 4月, 2018 3 次提交
  2. 17 4月, 2018 1 次提交
    • B
      HID: input: do not increment usages when a duplicate is found · 190d7f02
      Benjamin Tissoires 提交于
      This is something that bothered us from a long time. When hid-input
      doesn't know how to map a usage, it uses *_MISC. But there is something
      else which increments the usage if the evdev code is already used.
      
      This leads to few issues:
      - some devices may have their ABS_X mapped to ABS_Y if they export a bad
        set of usages (see the DragonRise joysticks IIRC -> fixed in a specific
        HID driver)
      - *_MISC + N might (will) conflict with other defined axes (my Logitech
        H800 exports some multitouch axes because of that)
      - this prevents to freely add some new evdev usages, because "hey, my
        headset will now report ABS_COFFEE, and it's not coffee capable".
      
      So let's try to kill this nonsense, and hope we won't break too many
      devices.
      
      I my headset case, the ABS_MISC axes are created because of some
      proprietary usages, so we might not break that many devices.
      
      For backward compatibility, a quirk HID_QUIRK_INCREMENT_USAGE_ON_DUPLICATE
      is created and can be applied to any device that needs this behavior.
      Signed-off-by: NBenjamin Tissoires <benjamin.tissoires@redhat.com>
      Acked-by: NPeter Hutterer <peter.hutterer@who-t.net>
      Acked-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>
      Signed-off-by: NJiri Kosina <jkosina@suse.cz>
      190d7f02
  3. 23 3月, 2018 3 次提交
  4. 06 3月, 2018 1 次提交
  5. 16 2月, 2018 1 次提交
  6. 01 12月, 2017 1 次提交
  7. 21 11月, 2017 3 次提交
    • B
      HID: core: remove the absolute need of hid_have_special_driver[] · e04a0442
      Benjamin Tissoires 提交于
      Most HID devices behave properly when they are used with hid-generic.
      Since kernel v4.12, we do not poll for input reports at plug in, so
      hid-generic should behave properly with all HID devices.
      
      There has been a long standing list of HID devices that have a special
      driver. It used to be just a few, but with time, this list went too big,
      and we can not ask users to know which HID special driver will pick up
      their device.
      
      We can teach hid-generic to be nice with others. If a device is not
      explicitly marked with HID_QUIRK_HAVE_SPECIAL_DRIVER, we can allow
      hid-generic to pick up the device as long as no other loaded HID driver
      will match the device.
      
      When the special driver appears, hid-generic can step back and let
      the special driver handling the device. In case this special driver
      is removed, this good old pal of hid-generic will rebind to the device.
      
      This basically makes the list hid_have_special_driver[] useless. It
      still allows to not see a hid-generic driver bound and removed during
      boot, so we can keep it around.
      
      This will also help other people to have a special HID driver without
      the need of recompiling hid-core.
      Signed-off-by: NBenjamin Tissoires <benjamin.tissoires@redhat.com>
      Signed-off-by: NJiri Kosina <jkosina@suse.cz>
      e04a0442
    • B
      HID: quirks: move the list of special devices into a quirk · 6e65d9d5
      Benjamin Tissoires 提交于
      It is better to centralize the information of special devices in one
      single file. Instead of manually parsing the list of devices that
      have a special driver or those that need to be ignored, introduce
      HID_QUIRK_HAVE_SPECIAL_DRIVER and set the correct quirks while fetching
      those quirks.
      Signed-off-by: NBenjamin Tissoires <benjamin.tissoires@redhat.com>
      Signed-off-by: NJiri Kosina <jkosina@suse.cz>
      6e65d9d5
    • B
      HID: core: move the dynamic quirks handling in core · d5d3e202
      Benjamin Tissoires 提交于
      usbhid has a list of dynamic quirks in addition to a list of static quirks.
      There is not much USB specific in that, so move this part of the module
      in core so we can have one central place for quirks.
      Signed-off-by: NBenjamin Tissoires <benjamin.tissoires@redhat.com>
      Signed-off-by: NJiri Kosina <jkosina@suse.cz>
      d5d3e202
  8. 05 10月, 2017 1 次提交
  9. 02 10月, 2017 1 次提交
  10. 15 8月, 2017 1 次提交
  11. 03 8月, 2017 1 次提交
    • J
      HID: multitouch: Support Asus T304UA media keys · 957b8dff
      João Paulo Rechi Vita 提交于
      The Asus T304UA convertible sports a magnetic detachable keyboard with
      touchpad, which is connected over USB. Most of the keyboard hotkeys are
      exposed through the same USB interface as the touchpad, defined in the
      report descriptor as follows:
      
      0x06, 0x31, 0xFF,  // Usage Page (Vendor Defined 0xFF31)
      0x09, 0x76,        // Usage (0x76)
      0xA1, 0x01,        // Collection (Application)
      0x05, 0xFF,        //   Usage Page (Reserved 0xFF)
      0x85, 0x5A,        //   Report ID (90)
      0x19, 0x00,        //   Usage Minimum (0x00)
      0x2A, 0xFF, 0x00,  //   Usage Maximum (0xFF)
      0x15, 0x00,        //   Logical Minimum (0)
      0x26, 0xFF, 0x00,  //   Logical Maximum (255)
      0x75, 0x08,        //   Report Size (8)
      0x95, 0x0F,        //   Report Count (15)
      0xB1, 0x02,        //   Feature (Data,Var,Abs,No Wrap,Linear,Preferred State,No Null Position,Non-volatile)
      0x05, 0xFF,        //   Usage Page (Reserved 0xFF)
      0x85, 0x5A,        //   Report ID (90)
      0x19, 0x00,        //   Usage Minimum (0x00)
      0x2A, 0xFF, 0x00,  //   Usage Maximum (0xFF)
      0x15, 0x00,        //   Logical Minimum (0)
      0x26, 0xFF, 0x00,  //   Logical Maximum (255)
      0x75, 0x08,        //   Report Size (8)
      0x95, 0x02,        //   Report Count (2)
      0x81, 0x02,        //   Input (Data,Var,Abs,No Wrap,Linear,Preferred State,No Null Position)
      0xC0,              // End Collection
      
      This UsagePage is declared as a variable, but we need to treat it as an
      array to be able to map each Usage we care about to its corresponding
      input key.
      Signed-off-by: NJoão Paulo Rechi Vita <jprvita@endlessm.com>
      Signed-off-by: NJiri Kosina <jkosina@suse.cz>
      957b8dff
  12. 02 8月, 2017 1 次提交
  13. 01 8月, 2017 1 次提交
  14. 27 7月, 2017 1 次提交
    • J
      HID: introduce hid_is_using_ll_driver · fc2237a7
      Jason Gerecke 提交于
      Although HID itself is transport-agnostic, occasionally a driver may
      want to interact with the low-level transport that a device is connected
      through. To do this, we need to know what kind of bus is in use. The
      first guess may be to look at the 'bus' field of the 'struct hid_device',
      but this field may be emulated in some cases (e.g. uhid).
      
      More ideally, we can check which ll_driver a device is using. This
      function introduces a 'hid_is_using_ll_driver' function and makes the
      'struct hid_ll_driver' of the four most common transports accessible
      through hid.h.
      Signed-off-by: NJason Gerecke <jason.gerecke@wacom.com>
      Acked-By: NBenjamin Tissoires <benjamin.tissoires@redhat.com>
      Signed-off-by: NJiri Kosina <jkosina@suse.cz>
      fc2237a7
  15. 08 6月, 2017 2 次提交
  16. 22 5月, 2017 1 次提交
  17. 11 5月, 2017 1 次提交
  18. 30 3月, 2017 1 次提交
  19. 21 3月, 2017 2 次提交
    • J
      HID: hiddev: reallocate hiddev's minor number · 733aca90
      Jaejoong Kim 提交于
      We need to store the minor number each drivers. In case of hidraw, the
      minor number is stored stores in struct hidraw. But hiddev's minor is
      located in struct hid_device.
      
      The hid-core driver announces a kernel message which driver is loaded when
      HID device connected, but hiddev's minor number is always zero. To proper
      display hiddev's minor number, we need to store the minor number asked from
      usb core and do some refactoring work (move from hiddev.c to hiddev.h) to
      access hiddev in hid-core.
      
      [jkosina@suse.cz: rebase on top of newer codebase]
      Reviewed-by: NBenjamin Tissoires <benjamin.tissoires@redhat.com>
      Signed-off-by: NJaejoong Kim <climbbb.kim@gmail.com>
      Signed-off-by: NJiri Kosina <jkosina@suse.cz>
      733aca90
    • B
      HID: remove initial reading of reports at connect · 9143059f
      Benjamin Tissoires 提交于
      It looks like a bunch of devices do not like to be polled
      for their reports at init time. When you look into the details,
      it seems that for those that are requiring the quirk
      HID_QUIRK_NO_INIT_REPORTS, the driver fails to retrieve part
      of the features/inputs while others (more generic) work.
      
      IMO, it should be acceptable to remove the need for the quirk
      in the general case. On the small amount of cases where
      we actually need to read the current values, the driver
      in charge (hid-mt or wacom) already retrieves the features
      manually.
      
      There are 2 cases where we might need to retrieve the reports at
      init:
      1. hiddev devices with specific use-space tool
      2. a device that would require the driver to fetch a specific
         feature/input at plug
      
      For case 2, I have seen this a few time on hid-multitouch. It
      is solved in hid-multitouch directly by fetching the feature.
      I hope it won't be too common and this can be solved on a per-case
      basis (crossing fingers).
      
      For case 1, we moved the implementation of HID_QUIRK_NO_INIT_REPORTS
      in hiddev. When somebody starts calling ioctls that needs an initial
      update, the hiddev device will fetch the initial state of the reports
      to mimic the current behavior. This adds a small amount of time during
      the first HIDIOCGUSAGE(S), but it should be acceptable in
      most cases. To keep the currently known broken devices, we have to
      keep around HID_QUIRK_NO_INIT_REPORTS, but the scope will only be
      for hiddev.
      
      Note that I don't think hidraw would be affected and I checked that
      the FF drivers that need to interact with the report fields are all
      using output reports, which are not initialized by
      usbhid_init_reports().
      
      NO_INIT_INPUT_REPORTS is then replaced by HID_QUIRK_NO_INIT_REPORTS:
      there is no point keeping it for just one device.
      Signed-off-by: NBenjamin Tissoires <benjamin.tissoires@redhat.com>
      Signed-off-by: NJiri Kosina <jkosina@suse.cz>
      9143059f
  20. 28 11月, 2016 1 次提交
    • B
      HID: input: rework HID_QUIRK_MULTI_INPUT · 72d19459
      Benjamin Tissoires 提交于
      The purpose of HID_QUIRK_MULTI_INPUT is to have an input device per
      report id. This is useful when the HID device presents several HID
      collections of different device types.
      
      The current implementation of hid-input creates one input node per id per
      type (input or output). This is problematic for the LEDs of a keyboard as
      they are often set through an output report. The current code creates
      one input node with all the keyboard keys, and one other with only the
      LEDs.
      
      To solve this, we use a two-passes way:
      - first, we initialize all input nodes and associate one per report id
      - then, we register all the input nodes
      Signed-off-by: NBenjamin Tissoires <benjamin.tissoires@redhat.com>
      Signed-off-by: NJiri Kosina <jkosina@suse.cz>
      72d19459
  21. 20 10月, 2016 2 次提交
  22. 29 9月, 2016 1 次提交
  23. 28 12月, 2015 2 次提交
  24. 20 11月, 2015 1 次提交
  25. 06 11月, 2015 1 次提交
  26. 30 9月, 2015 1 次提交
  27. 01 6月, 2015 1 次提交
  28. 14 3月, 2015 1 次提交
    • K
      power_supply: Change ownership from driver to core · 297d716f
      Krzysztof Kozlowski 提交于
      Change the ownership of power_supply structure from each driver
      implementing the class to the power supply core.
      
      The patch changes power_supply_register() function thus all drivers
      implementing power supply class are adjusted.
      
      Each driver provides the implementation of power supply. However it
      should not be the owner of power supply class instance because it is
      exposed by core to other subsystems with power_supply_get_by_name().
      These other subsystems have no knowledge when the driver will unregister
      the power supply. This leads to several issues when driver is unbound -
      mostly because user of power supply accesses freed memory.
      
      Instead let the core own the instance of struct 'power_supply'.  Other
      users of this power supply will still access valid memory because it
      will be freed when device reference count reaches 0. Currently this
      means "it will leak" but power_supply_put() call in next patches will
      solve it.
      
      This solves invalid memory references in following race condition
      scenario:
      
      Thread 1: charger manager
      Thread 2: power supply driver, used by charger manager
      
      THREAD 1 (charger manager)         THREAD 2 (power supply driver)
      ==========================         ==============================
      psy = power_supply_get_by_name()
                                         Driver unbind, .remove
                                           power_supply_unregister()
                                           Device fully removed
      psy->get_property()
      
      The 'get_property' call is executed in invalid context because the driver was
      unbound and struct 'power_supply' memory was freed.
      
      This could be observed easily with charger manager driver (here compiled
      with max17040 fuel gauge):
      
      $ cat /sys/devices/virtual/power_supply/cm-battery/capacity &
      $ echo "1-0036" > /sys/bus/i2c/drivers/max17040/unbind
      [   55.725123] Unable to handle kernel NULL pointer dereference at virtual address 00000000
      [   55.732584] pgd = d98d4000
      [   55.734060] [00000000] *pgd=5afa2831, *pte=00000000, *ppte=00000000
      [   55.740318] Internal error: Oops: 80000007 [#1] PREEMPT SMP ARM
      [   55.746210] Modules linked in:
      [   55.749259] CPU: 1 PID: 2936 Comm: cat Tainted: G        W       3.19.0-rc1-next-20141226-00048-gf79f475f3c44-dirty #1496
      [   55.760190] Hardware name: SAMSUNG EXYNOS (Flattened Device Tree)
      [   55.766270] task: d9b76f00 ti: daf54000 task.ti: daf54000
      [   55.771647] PC is at 0x0
      [   55.774182] LR is at charger_get_property+0x2f4/0x36c
      [   55.779201] pc : [<00000000>]    lr : [<c034b0b4>]    psr: 60000013
      [   55.779201] sp : daf55e90  ip : 00000003  fp : 00000000
      [   55.790657] r10: 00000000  r9 : c06e2878  r8 : d9b26c68
      [   55.795865] r7 : dad81610  r6 : daec7410  r5 : daf55ebc  r4 : 00000000
      [   55.802367] r3 : 00000000  r2 : daf55ebc  r1 : 0000002a  r0 : d9b26c68
      [   55.808879] Flags: nZCv  IRQs on  FIQs on  Mode SVC_32  ISA ARM  Segment user
      [   55.815994] Control: 10c5387d  Table: 598d406a  DAC: 00000015
      [   55.821723] Process cat (pid: 2936, stack limit = 0xdaf54210)
      [   55.827451] Stack: (0xdaf55e90 to 0xdaf56000)
      [   55.831795] 5e80:                                     60000013 c01459c4 0000002a c06f8ef8
      [   55.839956] 5ea0: db651000 c06f8ef8 daebac00 c04cb668 daebac08 c0346864 00000000 c01459c4
      [   55.848115] 5ec0: d99eaa80 c06f8ef8 00000fff 00001000 db651000 c027f25c c027f240 d99eaa80
      [   55.856274] 5ee0: d9a06c00 c0146218 daf55f18 00001000 d99eaa80 db4c18c0 00000001 00000001
      [   55.864468] 5f00: daf55f80 c0144c78 c0144c54 c0107f90 00015000 d99eaab0 00000000 00000000
      [   55.872603] 5f20: 000051c7 00000000 db4c18c0 c04a9370 00015000 00001000 daf55f80 00001000
      [   55.880763] 5f40: daf54000 00015000 00000000 c00e53dc db4c18c0 c00e548c 0000000d 00008124
      [   55.888937] 5f60: 00000001 00000000 00000000 db4c18c0 db4c18c0 00001000 00015000 c00e5550
      [   55.897099] 5f80: 00000000 00000000 00001000 00001000 00015000 00000003 00000003 c000f364
      [   55.905239] 5fa0: 00000000 c000f1a0 00001000 00015000 00000003 00015000 00001000 0001333c
      [   55.913399] 5fc0: 00001000 00015000 00000003 00000003 00000002 00000000 00000000 00000000
      [   55.921560] 5fe0: 7fffe000 be999850 0000a225 b6f3c19c 60000010 00000003 00000000 00000000
      [   55.929744] [<c034b0b4>] (charger_get_property) from [<c0346864>] (power_supply_show_property+0x48/0x20c)
      [   55.939286] [<c0346864>] (power_supply_show_property) from [<c027f25c>] (dev_attr_show+0x1c/0x48)
      [   55.948130] [<c027f25c>] (dev_attr_show) from [<c0146218>] (sysfs_kf_seq_show+0x84/0x104)
      [   55.956298] [<c0146218>] (sysfs_kf_seq_show) from [<c0144c78>] (kernfs_seq_show+0x24/0x28)
      [   55.964536] [<c0144c78>] (kernfs_seq_show) from [<c0107f90>] (seq_read+0x1b0/0x484)
      [   55.972172] [<c0107f90>] (seq_read) from [<c00e53dc>] (__vfs_read+0x18/0x4c)
      [   55.979188] [<c00e53dc>] (__vfs_read) from [<c00e548c>] (vfs_read+0x7c/0x100)
      [   55.986304] [<c00e548c>] (vfs_read) from [<c00e5550>] (SyS_read+0x40/0x8c)
      [   55.993164] [<c00e5550>] (SyS_read) from [<c000f1a0>] (ret_fast_syscall+0x0/0x48)
      [   56.000626] Code: bad PC value
      [   56.011652] ---[ end trace 7b64343fbdae8ef1 ]---
      Signed-off-by: NKrzysztof Kozlowski <k.kozlowski@samsung.com>
      Reviewed-by: NBartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
      
      [for the nvec part]
      Reviewed-by: NMarc Dietrich <marvin24@gmx.de>
      
      [for compal-laptop.c]
      Acked-by: NDarren Hart <dvhart@linux.intel.com>
      
      [for the mfd part]
      Acked-by: NLee Jones <lee.jones@linaro.org>
      
      [for the hid part]
      Acked-by: NJiri Kosina <jkosina@suse.cz>
      
      [for the acpi part]
      Acked-by: NRafael J. Wysocki <rafael.j.wysocki@intel.com>
      Signed-off-by: NSebastian Reichel <sre@kernel.org>
      297d716f
  29. 12 3月, 2015 1 次提交
  30. 05 3月, 2015 1 次提交
    • D
      HID: map telephony usage page · f3dddf24
      Dmitry Torokhov 提交于
      Currently HID code maps usages from telephony page into BTN_0, BTN_1, etc
      keys which get interpreted by mousedev and userspace as left/right/middle
      button clicks, which is not really helpful.
      
      This change adds mappings for usages that have corresponding input event
      definitions, and leaves the rest unmapped. This can be changed when
      there are userspace consumers for more telephony usages.
      Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>
      Signed-off-by: NJiri Kosina <jkosina@suse.cz>
      f3dddf24