Skip to content

K
Kernel

openeuler / Kernel
1 年多 前同步成功

通知 8
Star 0
Fork 0
K
Kernel
切换分支/标签
  1. 16 4月, 2019 4 次提交
  3. 09 4月, 2019 1 次提交
  5. 20 3月, 2019 1 次提交
  7. 07 3月, 2019 1 次提交
    • A
      scsi: qla2xxx: avoid printf format warning · 038d710f
      由 Arnd Bergmann 提交于 
      Depending on the target architecture and configuration, both phys_addr_t
and dma_addr_t may be smaller than 'long long', so we get a warning when
printing either of them using the %llx format string:

drivers/scsi/qla2xxx/qla_iocb.c: In function 'qla24xx_walk_and_build_prot_sglist':
drivers/scsi/qla2xxx/qla_iocb.c:1140:46: error: format '%llx' expects argument of type 'long long unsigned int', but argument 6 has type 'dma_addr_t' {aka 'unsigned int'} [-Werror=format=]
         "%s: page boundary crossing (phys=%llx len=%x)\n",
                                           ~~~^
                                           %x
         __func__, sle_phys, sg->length);
                   ~~~~~~~~
drivers/scsi/qla2xxx/qla_iocb.c:1180:29: error: format '%llx' expects argument of type 'long long unsigned int', but argument 7 has type 'dma_addr_t' {aka 'unsigned int'} [-Werror=format=]
        "%s: sg[%x] (phys=%llx sglen=%x) ldma_sg_len: %x dif_bundl_len: %x ldma_needed: %x\n",
                          ~~~^

There are special %pad and %pap format strings in Linux that we could use
here, but since the driver already does 64-bit arithmetic on the values,
using a plain 'u64' seems more consistent here.

Note: A possible related issue may be that the driver possibly checks the
wrong kind of overflow: when an IOMMU is in use, buffers that cross a
32-bit boundary in physical addresses would still be mapped into dma
addresses within the low 4GB space, so I suspect that we actually want to
check sg_dma_address() instead of sg_phys() here.

Fixes: 50b81275 ("scsi: qla2xxx: Fix DMA error when the DIF sg buffer crosses 4GB boundary")
Signed-off-by: NArnd Bergmann <arnd@arndb.de>
Acked-by: NHimanshu Madhani <hmadhani@marvell.com>
Signed-off-by: NMartin K. Petersen <martin.petersen@oracle.com>
      038d710f
  9. 20 2月, 2019 2 次提交
  11. 06 2月, 2019 1 次提交
  13. 12 1月, 2019 1 次提交
  15. 24 10月, 2018 1 次提交
  17. 17 9月, 2018 1 次提交
  19. 12 9月, 2018 4 次提交
  21. 09 8月, 2018 1 次提交
  23. 03 8月, 2018 4 次提交
  25. 31 7月, 2018 1 次提交
  27. 10 4月, 2018 1 次提交
  29. 23 2月, 2018 1 次提交
  31. 14 2月, 2018 1 次提交
  33. 13 2月, 2018 1 次提交
  35. 23 1月, 2018 1 次提交
  37. 17 1月, 2018 1 次提交
  39. 04 1月, 2018 3 次提交
  41. 08 12月, 2017 2 次提交
  43. 17 10月, 2017 1 次提交
  45. 25 8月, 2017 1 次提交
  47. 02 7月, 2017 1 次提交
  49. 28 6月, 2017 3 次提交