1. 06 10月, 2008 2 次提交
    • H
      atmel-mci: Implement tasklet as a state machine · c06ad258
      Haavard Skinnemoen 提交于
      With the current system of completed/pending events, things may get
      handled in different order depending on which event triggers first. For
      example, if the data transfer is complete before the command, the stop
      command must be sent after the command is complete, not the data. This
      creates a bit of complexity around the stop command.
      
      By having the tasklet go through a sequence of clearly defined states,
      things always happen in a certain order even if the events come at
      different times, so the stop command can simply be sent when we exit the
      "sending data" state because we will never enter that state before the
      command has been sent successfully.
      Signed-off-by: NHaavard Skinnemoen <haavard.skinnemoen@atmel.com>
      c06ad258
    • H
      atmel-mci: Initialize BLKR before sending data transfer command · a252e3e3
      Haavard Skinnemoen 提交于
      The atmel-mci driver sometimes fails data transfers like this:
      
         mmcblk0: error -5 transferring data
         end_request: I/O error, dev mmcblk0, sector 2749769
         end_request: I/O error, dev mmcblk0, sector 2749777
      
      It turns out that this might be caused by the BLKR register (which
      contains the block size and the number of blocks being transfered) being
      initialized too late. This patch moves the initialization of BLKR so
      that it contains the correct value before the block transfer command is
      sent.
      
      This error is difficult to reproduce, but if you insert a long delay
      (mdelay(10) or thereabouts) between the calls to atmci_start_command()
      and atmci_submit_data(), all transfers seem to fail without this patch,
      while I haven't seen any failures with this patch.
      Reported-by: NHein_Tibosch <hein_tibosch@yahoo.es>
      Signed-off-by: NHaavard Skinnemoen <haavard.skinnemoen@atmel.com>
      a252e3e3
  2. 05 10月, 2008 2 次提交
  3. 04 10月, 2008 27 次提交
  4. 03 10月, 2008 9 次提交