Minor changes to nicely line up device entries.
Signed-off-by: NDenis Pithon <denis.pithon@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This fixes "missing a blank line after declaration" warnings from
checkpatch.pl for driver xgifb. The driver has no remaining errors or
warnings from checkpatch.pl
Signed-off-by: NVitor Braga <vitorpybraga@gmail.com>
Reviewed-by: NAaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Signed-off-by: NAntoine Schweitzer-Chaput <antoine@schweitzer-chaput.fr>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

The initial state at boot is assumed to be disconnected, and we hope
to receive an interrupt to update the status.  Let's be more explicit
about the current state - reading the PHY status register tells us
the current level of the hotplug signal, which we can report back in
the _detect() method.
Signed-off-by: NRussell King <rmk+kernel@arm.linux.org.uk>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

The decoder mux id is equal to the port id of the encoder's input port
that is connected to the given crtc, not to the endpoint id (which is
arbitrary and usually zero).
Signed-off-by: NPhilipp Zabel <p.zabel@pengutronix.de>
Tested-by: NShawn Guo <shawn.guo@freescale.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

No need to return a 'fake' return value on platform_get_irq() failure.
Signed-off-by: NFabio Estevam <fabio.estevam@freescale.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Simplify hdmi_phy_wait_i2c_done so the call to hdmi_readb is
only done in one place. Also check for timout before waiting
as suggested by Troy Kisky.
This also fixes a checkpatch warning.
Signed-off-by: NEmil Renner Berthing <kernel@esmil.dk>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Support the LVDS666 format on the IPUv3 parallel display.
This makes the screen work on my Hercules eCAFE Slim HD.
Signed-off-by: NEmil Renner Berthing <kernel@esmil.dk>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Fix checkpatch.pl issues with missing blank line after declarations.
Signed-off-by: NToby Smith <toby@tismith.id.au>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch fixes following smatch warning:
slicoss/slicoss.c:1429 slic_cmdq_addcmdpage() error: we previously assumed 'pslic_handle' could be null
Signed-off-by: NMonam Agarwal <monamagarwal123@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Change the definition of pci_mem_start|end from correct from pci_io(un)map's
point of view.
Signed-off-by: NAnders Darander <anders.darander@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

The driver can already use request_firmware() to load firmware, and
always does so.  There is code in init_firmware() to use the static
firmware images, but it's unreachable!  Remove the data and simplify
init_firmware() accordingly.
Signed-off-by: NBen Hutchings <ben@decadent.org.uk>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Fix spelling typo in comments within rtl8192e.
Signed-off-by: NMasanari Iida <standby24x7@gmail.com>
Reviewed-by: NJames Cameron <quozl@laptop.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

A word in printk is split into two lines.
Change it into one line.
Signed-off-by: NMasanari Iida <standby24x7@gmail.com>
Reviewed-by: NJames Cameron <quozl@laptop.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Signed-off-by: Nnavin patidar <navin.patidar@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Signed-off-by: Nnavin patidar <navin.patidar@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Signed-off-by: Nnavin patidar <navin.patidar@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

struct led_priv contains two variables SwLed0 and SwLed1 but only
SwLed0 is being used by SwLedControlModel1() function.

SwLedControlModel1() function performs led operations.

This patch removes SwLed1 and code which uses SwLed1.
Signed-off-by: Nnavin patidar <navin.patidar@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

 Now driver has only one type of led blinking strategy, so we don't
 need enum LED_STRATEGY_871x variable to store led blinking strategy
 type.
Signed-off-by: Nnavin patidar <navin.patidar@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

driver has code to blink the led in 7 different ways.
struct led_priv contains an enum LED_STRATEGY_871x variable which is
initialized to SW_LED_MODE1 inside rtl8188eu_InitSwLeds() function.
it means driver is hard coded to use only SW_LED_MODE1 blinking strategy.
so we can remove the code related to other blinking strategies
e.g. SW_LED_MODE[0|2|3|4|5|6].
Signed-off-by: Nnavin patidar <navin.patidar@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

_InitHWLed() function does nothing.
Signed-off-by: Nnavin patidar <navin.patidar@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

_ReadLEDSetting() doesn't read led settings this function actually
initialize  member variables of struct led_priv, we should do that
inside rtl8188eu_InitSwLeds().
Signed-off-by: Nnavin patidar <navin.patidar@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

rtw_led_blink_cmd() isn't being used by driver.
Signed-off-by: Nnavin patidar <navin.patidar@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

drv_types_linux.h is empty, so remove the header file and its
reference.
Signed-off-by: Nnavin patidar <navin.patidar@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This commit fixes the following checkpatch errors:

rtl8188eu/core/rtw_recv.c
    - 1874: ERROR: code indent should use tabs where possible
Signed-off-by: NKonrad Zapalowicz <bergo.torino@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This commit fixes the following checkpatch errors:

rtl8188eu/core/rtw_p2p.c
    - 1508: ERROR: code indent should use tabs where possible
    - 1509: ERROR: code indent should use tabs where possible
    - 1510: ERROR: code indent should use tabs where possible
Signed-off-by: NKonrad Zapalowicz <bergo.torino@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Fixes all checkpatch errors reporting that statics shouldn't be initialised
to their defualt values.
Signed-off-by: NMark Einon <mark@einon.net>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Fixes checkpatch error:

ERROR: switch and case should be at the same indent
+               switch (coex_dm->cur_retrylimit_type) {
+                       case 0: /* normal mode */
[...]
+                       case 1: /* retry limit=8 */
[...]
+                       default:
Signed-off-by: NMark Einon <mark@einon.net>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Fix checkpatch issues relating to using leading spaces instead of tabs.
Whitespace changes only.
Signed-off-by: NMark Einon <mark@einon.net>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Whitespace changes only to appease checkpatch warnings.
Signed-off-by: NMark Einon <mark@einon.net>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

We set btrssi to zero and then immediately assign it. Assign it
on declaration instead.
Signed-off-by: NMark Einon <mark@einon.net>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Sparse complains about halbtc8192e2ant_low_penalty_ra() not being used,
and subsequently halbtc8192e2ant_set_sw_penalty_tx_rateadaptive() when
this is removed. remove both functions.
Signed-off-by: NMark Einon <mark@einon.net>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

In halbtc8192e2ant.c, fix all instances of the sparse warning:

warning: symbol 'xxx' was not declared. Should it be static?
Signed-off-by: NMark Einon <mark@einon.net>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Remove functions not being called from anywhere:

halbtc8192e2ant_set_adc_backoff()
halbtc8192e2ant_adc_backoff()
Signed-off-by: NMark Einon <mark@einon.net>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

All code in this file is encapsulated in a useless #if 1
declaration, remove it.
Signed-off-by: NMark Einon <mark@einon.net>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

The two declarations with issues in rtl_wx.h:

  * function: struct iw_statistics *r8192_get_wireless_stats();
  * variable: extern struct iw_handler_def r8192_wx_handlers_def;

The symbol 'r8192_get_wireless_stats' is declared as 'extern'
but it is only used in the local scope. The declaration is deleted
of rtl_wx.h, fixing the conflict with the 'extern' and 'static' scope.

The symbol 'r8192_wx_handlers_def' was fixed of some issues related
to variable declaration marked as 'extern' implicitly,
causing this sparse warning:

drivers/staging/rtl8192e/rtl8192e/rtl_wx.c:1323:24: warning: symbol
'r8192_wx_handlers_def' was not declared. Should it be static?

Resolved incluing the fixed header to rtl_wx.c

Also, isn't declared as constant variable, so it declared as such.
And delete unnecessary cast in rtl_core.c.
Signed-off-by: NJoel Pelaez Jorge <joelpelaez@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

ERROR: spaces required around that '=' (ctx:OxW)
Signed-off-by: NPaul McQuade <paulmcquad@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

The ->SupportedRates[] array has NDIS_802_11_LENGTH_RATES_EX (16)
elements.  Since "ie_len" comes from then network and can go up to 255
then it means we should add a range check to prevent memory corruption.

Fixes: d6846af6 ('staging: r8188eu: Add files for new driver - part 7')
Signed-off-by: NDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Fix coding style problems (incorrect indentation).
Signed-off-by: NLoïc Pellegrino <oort10@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

fix a coding style issue: Missing a blank line after declarations
Signed-off-by: Nhuanqi chi <chihuanqi@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>