1. 26 8月, 2015 1 次提交
  2. 13 8月, 2015 1 次提交
    • A
      gpio: omap: Fix missing raw locks conversion · 627c89b4
      Axel Lin 提交于
      Fix below build warning:
        CC      drivers/gpio/gpio-omap.o
      drivers/gpio/gpio-omap.c: In function 'omap_gpio_irq_type':
      drivers/gpio/gpio-omap.c:504:3: warning: passing argument 1 of 'spin_unlock_irqrestore' from incompatible pointer type [enabled by default]
      include/linux/spinlock.h:360:29: note: expected 'struct spinlock_t *' but argument is of type 'struct raw_spinlock_t *'
      
      Fixes: commit 4dbada2b ("gpio: omap: use raw locks for locking")
      Signed-off-by: NAxel Lin <axel.lin@ingics.com>
      Signed-off-by: NLinus Walleij <linus.walleij@linaro.org>
      627c89b4
  3. 27 7月, 2015 1 次提交
    • S
      gpio: omap: use raw locks for locking · 4dbada2b
      Sebastian Andrzej Siewior 提交于
      This patch converts gpio_bank.lock from a spin_lock into a
      raw_spin_lock. The call path is to access this lock is always under a
      raw_spin_lock, for instance
      - __setup_irq() holds &desc->lock with irq off
        + __irq_set_trigger()
         + omap_gpio_irq_type()
      
      - handle_level_irq() (runs with irqs off therefore raw locks)
        + mask_ack_irq()
         + omap_gpio_mask_irq()
      
      This fixes the obvious backtrace on -RT. However the locking vs context
      is not and this is not limited to -RT:
      - omap_gpio_irq_type() is called with IRQ off and has an conditional
        call to pm_runtime_get_sync() which may sleep. Either it may happen or
        it may not happen but pm_runtime_get_sync() should not be called with
        irqs off.
      
      - omap_gpio_debounce() is holding the lock with IRQs off.
        + omap2_set_gpio_debounce()
         + clk_prepare_enable()
          + clk_prepare() this one might sleep.
        The number of users of gpiod_set_debounce() / gpio_set_debounce()
        looks low but still this is not good.
      Acked-by: NJavier Martinez Canillas <javier@dowhile0.org>
      Acked-by: NSantosh Shilimkar <ssantosh@kernel.org>
      Signed-off-by: NSebastian Andrzej Siewior <bigeasy@linutronix.de>
      Signed-off-by: NLinus Walleij <linus.walleij@linaro.org>
      4dbada2b
  4. 16 7月, 2015 2 次提交
  5. 14 7月, 2015 2 次提交
  6. 01 6月, 2015 5 次提交
  7. 06 5月, 2015 2 次提交
  8. 27 3月, 2015 8 次提交
  9. 10 3月, 2015 1 次提交
  10. 26 1月, 2015 1 次提交
    • T
      gpio: omap: Fix bad device access with setup_irq() · 3d009c8c
      Tony Lindgren 提交于
      Similar to omap_gpio_irq_type() let's make sure that the GPIO
      is usable as an interrupt if the platform init code did not
      call gpio_request(). Otherwise we can get invalid device access
      after setup_irq():
      
      WARNING: CPU: 0 PID: 1 at drivers/bus/omap_l3_noc.c:147 l3_interrupt_handler+0x214/0x340()
      44000000.ocp:L3 Custom Error: MASTER MPU TARGET L4CFG (Idle): Data Access in Supervisor mode during Functional access
      ...
      [<c05f21e4>] (__irq_svc) from [<c05f1974>] (_raw_spin_unlock_irqrestore+0x34/0x44)
      [<c05f1974>] (_raw_spin_unlock_irqrestore) from [<c00914a8>] (__setup_irq+0x244/0x530)
      [<c00914a8>] (__setup_irq) from [<c00917d4>] (setup_irq+0x40/0x8c)
      [<c00917d4>] (setup_irq) from [<c0039c8c>] (omap_system_dma_probe+0x1d4/0x2b4)
      [<c0039c8c>] (omap_system_dma_probe) from [<c03b2200>] (platform_drv_probe+0x44/0xa4)
      ...
      
      We can fix this the same way omap_gpio_irq_type() is handling it.
      
      Note that the long term solution is to change the gpio-omap driver
      to handle the banks as separate driver instances. This will allow
      us to rely on just runtime PM for tracking the bank specific state.
      Reported-by: NRussell King <rmk+kernel@arm.linux.org.uk>
      Cc: Javier Martinez Canillas <javier@dowhile0.org>
      Cc: Kevin Hilman <khilman@kernel.org>
      Cc: Santosh Shilimkar <ssantosh@kernel.org>
      Tested-by: NFelipe Balbi <balbi@ti.com>
      Signed-off-by: NTony Lindgren <tony@atomide.com>
      Signed-off-by: NLinus Walleij <linus.walleij@linaro.org>
      3d009c8c
  11. 04 12月, 2014 1 次提交
  12. 29 10月, 2014 1 次提交
  13. 23 9月, 2014 2 次提交
  14. 09 7月, 2014 3 次提交
  15. 16 5月, 2014 1 次提交
  16. 04 5月, 2014 1 次提交
  17. 29 4月, 2014 4 次提交
  18. 24 2月, 2014 1 次提交
  19. 25 11月, 2013 1 次提交
  20. 16 10月, 2013 1 次提交