Pass up the error code provided by functions.
Signed-off-by: NHartmut Knaack <knaack.h@gmx.de>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

One inclusion of linux/iio/trigger_consumer.h is sufficient.

Fixes: 	ae6d9ce0 ("iio: mma8452: Add support for interrupt driven triggers.")
Signed-off-by: NHartmut Knaack <knaack.h@gmx.de>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

To iterate through the available frequencies of mma8452_hp_filter_cutoff[],
the array size of a row of that table needs to be provided to
_get_int_plus_micros_index().

Fixes: 	1e79841a ("iio: mma8452: Add highpass filter configuration.")
Signed-off-by: NHartmut Knaack <knaack.h@gmx.de>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

Instead of using the I2C or ACPI ID to determine which variant of
the chipset to use, determine that from the chip ID.

Under Windows, the same driver is used for those variants and, despite
incorrect ACPI data, it is able to load and operate the accelerometer.

Fixes the accelerometer failing with:
bmc150_accel i2c-BMA250E:00: Invalid chip f8
on the WinBook TW100
Signed-off-by: NBastien Nocera <hadess@hadess.net>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

Move bmc150_accel_chip_init() so that we can use
bmc150_accel_chip_info_tbl[] in it.
Signed-off-by: NBastien Nocera <hadess@hadess.net>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

Fixing indentation errors in
drivers/staging/iio/iio_simple_dummy_events.c.
Signed-off-by: NLars Svensson <lars1.svensson@sonymobile.com>
Acked-by: NDaniel Baluta <daniel.baluta@intel.com>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

The ADIS16137 is register map compatible to the ADIS16136, but has a
different scale factor for the gyroscope output.
Signed-off-by: NLars-Peter Clausen <lars@metafoo.de>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

The ADIS16445 is similar to the ADIS16448, but without the magnetometer and
pressure channels as well as different scale factors for the gyroscope and
accelerometer outputs.
Signed-off-by: NLars-Peter Clausen <lars@metafoo.de>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

The ADIS16367 is mostly register compatible to the ADIS16360. The only
difference is the scale factor for the gyroscope output.
Signed-off-by: NLars-Peter Clausen <lars@metafoo.de>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

The ADIS16266 is mostly register compatible to the ADIS16260. The
difference is a different gyroscope scale factor as well not having the
relative angular displacement channel.
Signed-off-by: NLars-Peter Clausen <lars@metafoo.de>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

The ADIS16305 is fully register map compatible to the ADIS16300.
Signed-off-by: NLars-Peter Clausen <lars@metafoo.de>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

The ADIS16300 has the product ID and serial number registers, they are just
not documented. Set the appropriate flags so the driver makes use of them.
Signed-off-by: NLars-Peter Clausen <lars@metafoo.de>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

The different devices support by the adis16480 driver have slightly
different scales for the gyroscope and accelerometer channels.
Signed-off-by: NLars-Peter Clausen <lars@metafoo.de>
Cc: <Stable@vger.kernel.org>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

Add inverse unit conversion macro to convert from standard IIO units to
units that might be used by some devices.

Those are useful in combination with scale factors that are specified as
IIO_VAL_FRACTIONAL. Typically the denominator for those specifications will
contain the maximum raw value the sensor will generate and the numerator
the value it maps to in a specific unit. Sometimes datasheets specify those
in different units than the standard IIO units (e.g. degree/s instead of
rad/s) and so we need to do a unit conversion.

From a mathematical point of view it does not make a difference whether we
apply the unit conversion to the numerator or the inverse unit conversion
to the denominator since (x / y) / z = x / (y * z). But as the denominator
is typically a larger value and we are rounding both the numerator and
denominator to integer values using the later method gives us a better
precision (E.g. the relative error is smaller if we round 8000.3 to 8000
rather than rounding 8.3 to 8).

This is where in inverse unit conversion macros will be used.

Marked for stable as used by some upcoming fixes.
Signed-off-by: NLars-Peter Clausen <lars@metafoo.de>
Cc: <Stable@vger.kernel.org>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

Use the correct scale for the adis16448 gyroscope output.
Signed-off-by: NLars-Peter Clausen <lars@metafoo.de>
Cc: <Stable@vger.kernel.org>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

Fix kernel docs warnings by adding the missing description
for each of the existing function parameters.
Signed-off-by: NCristina Opriceana <cristina.opriceana@gmail.com>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

This patch adds an entry in ABI Documentation for the name attribute
issued when a trigger is created.
Signed-off-by: NCristina Opriceana <cristina.opriceana@gmail.com>
Acked-by: NDaniel Baluta <daniel.baluta@intel.com>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

This is intended to help developers faster find their way
inside the Industrial I/O core and reduce time spent on IIO
drivers development.
Signed-off-by: NDaniel Baluta <daniel.baluta@intel.com>
Acked-by: NCrt Mori <cmo@melexis.com>
Reviewed-by: NLars-Peter Clausen <lars@metafoo.de>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

When compile iio related driver the following warning shown:

include/linux/iio/trigger.h:35:34: warning: 'struct iio_trigger'
declared inside parameter list
  int (*set_trigger_state)(struct iio_trigger *trig, bool state);

include/linux/iio/trigger.h:38:18: warning: 'struct iio_dev'
declared inside parameter list
           struct iio_dev *indio_dev);

'struct iio_dev' and 'struct iio_trigger' was used before declaration,
forward declaration for these structs to fix warning.
Signed-off-by: NPengyu Ma <pengyu.ma@windriver.com>
Acked-by: NDaniel Baluta <daniel.baluta@intel.com>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

Drop the local buffer in stk8312_trigger_handler() and use data->buffer
instead for bulk reads.
Signed-off-by: NHartmut Knaack <knaack.h@gmx.de>
Reviewed-by: NTiberiu Breana <tiberiu.a.breana@intel.com>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

Adjust some indentation issues to make checkpatch.pl happy in strict mode.
Signed-off-by: NHartmut Knaack <knaack.h@gmx.de>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

Adapt some variable types to reduce unnecessary casting.
Signed-off-by: NHartmut Knaack <knaack.h@gmx.de>
Reviewed-by: NTiberiu Breana <tiberiu.a.breana@intel.com>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

Make use of BIT to describe register bits, GENMASK for consecutive
bitmasks, rename and sort existing definitions, replace magic value with
an expressive definition, drop an unused definition.
Signed-off-by: NHartmut Knaack <knaack.h@gmx.de>
Reviewed-by: NTiberiu Breana <tiberiu.a.breana@intel.com>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

Improve error handling in the following ways:
  - set return value on error condition to an appropriate error code
  - return error code immediately in case of an error (slightly changes
    code structure)
  - pass up real error code
  - add missing error handling
  - return 0 when error have been caught already
  - put device back in active mode after error occurs
Signed-off-by: NHartmut Knaack <knaack.h@gmx.de>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

Revision 1.2 of the datasheet recommends on page 22 to only write non-zero
values read from OTP register 0x70 into AFECTRL register.
Signed-off-by: NHartmut Knaack <knaack.h@gmx.de>
Reviewed-by: NTiberiu Breana <tiberiu.a.breana@intel.com>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

Add the still missing dependencies for triggered buffer support.

Fixes: 	95c12bba ("iio: accel: Add buffer mode for Sensortek STK8312")
Signed-off-by: NHartmut Knaack <knaack.h@gmx.de>
Reviewed-by: NTiberiu Breana <tiberiu.a.breana@intel.com>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

Drop the otherwise unused definition of the channel-array size and use it
directly in _probe - makes it a bit more obvious.
Signed-off-by: NHartmut Knaack <knaack.h@gmx.de>
Acked-by: NAntoine Tenart <antoine.tenart@free-electrons.com>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

Use augmented assignment to subtract the offset for negative temperature
values.
Specify the amount of private data to be allocated through
devm_iio_device_alloc() with sizeof(*priv), as it is shorter and common
practice in IIO.
Signed-off-by: NHartmut Knaack <knaack.h@gmx.de>
Acked-by: NAntoine Tenart <antoine.tenart@free-electrons.com>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

Mark berlin2_adc_channels array as constant.
Signed-off-by: NHartmut Knaack <knaack.h@gmx.de>
Acked-by: NAntoine Tenart <antoine.tenart@free-electrons.com>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

Pass up the real error code returned by platform_get_irq_byname().
Signed-off-by: NHartmut Knaack <knaack.h@gmx.de>
Acked-by: NAntoine Tenart <antoine.tenart@free-electrons.com>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

Signed-off-by: NJoo Aun Saw <jasaw@dius.com.au>
Acked-by: NDaniel Baluta <daniel.baluta@intel.com>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

Signed-off-by: NJoo Aun Saw <jasaw@dius.com.au>
Acked-by: NDaniel Baluta <daniel.baluta@intel.com>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

Running generic_buffer without enabling any channel of the
sensor will fail without printing any error message.

Add an error message that indicates buffer enable failed.
Signed-off-by: NIrina Tirdea <irina.tirdea@intel.com>
Acked-by: NHartmut Knaack <knaack.h@gmx.de>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

When the the sensor data uses 32 bits out of 32, generic_buffer prints
the value 0 for all data read.

In this case, the mask is shifted 32 bits, which is beyond the size of
an integer. This will lead to the mask always being 0. Before printing,
the mask is applied to the raw value, thus generating a final value of 0.

Fix the mask by shifting a 64 bit value instead of an integer.
Signed-off-by: NIrina Tirdea <irina.tirdea@intel.com>
Acked-by: NHartmut Knaack <knaack.h@gmx.de>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

Fix kernel doc for the iio_dev_attr structure by adding its missing field.
Signed-off-by: NCristina Opriceana <cristina.opriceana@gmail.com>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

Fix buffer name from kernel doc according to the function parameter.
Signed-off-by: NCristina Opriceana <cristina.opriceana@gmail.com>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

Fix kernel docs warnings by adding the missing fields,
each with its associated description.
Signed-off-by: NCristina Opriceana <cristina.opriceana@gmail.com>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

Fix kernel docs for structures and functions in order to
remove some warnings when the documentation gets generated.
Signed-off-by: NCristina Opriceana <cristina.opriceana@gmail.com>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

This patch adds the missing fields in kernel docs to remove
some warnings that appear when the IIO Documentation DocBook
is generated.
Signed-off-by: NCristina Opriceana <cristina.opriceana@gmail.com>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

When setting the trigger state, the device power state is set through
buffer preenable and postdisable hooks. There is no need
to also set it in the trigger set state call.

Remove duplicate set power state from the trigger set
state call.
Signed-off-by: NIrina Tirdea <irina.tirdea@intel.com>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>