1. 23 8月, 2019 5 次提交
  2. 22 8月, 2019 6 次提交
    • Y
      afs: use correct afs_call_type in yfs_fs_store_opaque_acl2 · 7533be85
      YueHaibing 提交于
      It seems that 'yfs_RXYFSStoreOpaqueACL2' should be use in
      yfs_fs_store_opaque_acl2().
      
      Fixes: f5e45463 ("afs: Implement YFS ACL setting")
      Signed-off-by: NYueHaibing <yuehaibing@huawei.com>
      Signed-off-by: NDavid Howells <dhowells@redhat.com>
      7533be85
    • M
      afs: Fix possible oops in afs_lookup trace event · c4c613ff
      Marc Dionne 提交于
      The afs_lookup trace event can cause the following:
      
      [  216.576777] BUG: kernel NULL pointer dereference, address: 000000000000023b
      [  216.576803] #PF: supervisor read access in kernel mode
      [  216.576813] #PF: error_code(0x0000) - not-present page
      ...
      [  216.576913] RIP: 0010:trace_event_raw_event_afs_lookup+0x9e/0x1c0 [kafs]
      
      If the inode from afs_do_lookup() is an error other than ENOENT, or if it
      is ENOENT and afs_try_auto_mntpt() returns an error, the trace event will
      try to dereference the error pointer as a valid pointer.
      
      Use IS_ERR_OR_NULL to only pass a valid pointer for the trace, or NULL.
      
      Ideally the trace would include the error value, but for now just avoid
      the oops.
      
      Fixes: 80548b03 ("afs: Add more tracepoints")
      Signed-off-by: NMarc Dionne <marc.dionne@auristor.com>
      Signed-off-by: NDavid Howells <dhowells@redhat.com>
      c4c613ff
    • D
      afs: Fix leak in afs_lookup_cell_rcu() · a5fb8e6c
      David Howells 提交于
      Fix a leak on the cell refcount in afs_lookup_cell_rcu() due to
      non-clearance of the default error in the case a NULL cell name is passed
      and the workstation default cell is used.
      
      Also put a bit at the end to make sure we don't leak a cell ref if we're
      going to be returning an error.
      
      This leak results in an assertion like the following when the kafs module is
      unloaded:
      
      	AFS: Assertion failed
      	2 == 1 is false
      	0x2 == 0x1 is false
      	------------[ cut here ]------------
      	kernel BUG at fs/afs/cell.c:770!
      	...
      	RIP: 0010:afs_manage_cells+0x220/0x42f [kafs]
      	...
      	 process_one_work+0x4c2/0x82c
      	 ? pool_mayday_timeout+0x1e1/0x1e1
      	 ? do_raw_spin_lock+0x134/0x175
      	 worker_thread+0x336/0x4a6
      	 ? rescuer_thread+0x4af/0x4af
      	 kthread+0x1de/0x1ee
      	 ? kthread_park+0xd4/0xd4
      	 ret_from_fork+0x24/0x30
      
      Fixes: 989782dc ("afs: Overhaul cell database management")
      Signed-off-by: NDavid Howells <dhowells@redhat.com>
      a5fb8e6c
    • L
      Merge tag 'for-linus' of git://git.kernel.org/pub/scm/virt/kvm/kvm · bb7ba806
      Linus Torvalds 提交于
      Pull KVM fixes from Paolo Bonzini:
       "A couple bugfixes, and mostly selftests changes"
      
      * tag 'for-linus' of git://git.kernel.org/pub/scm/virt/kvm/kvm:
        selftests/kvm: make platform_info_test pass on AMD
        Revert "KVM: x86/mmu: Zap only the relevant pages when removing a memslot"
        selftests: kvm: fix state save/load on processors without XSAVE
        selftests: kvm: fix vmx_set_nested_state_test
        selftests: kvm: provide common function to enable eVMCS
        selftests: kvm: do not try running the VM in vmx_set_nested_state_test
        KVM: x86: svm: remove redundant assignment of var new_entry
        MAINTAINERS: add KVM x86 reviewers
        MAINTAINERS: change list for KVM/s390
        kvm: x86: skip populating logical dest map if apic is not sw enabled
      bb7ba806
    • V
      selftests/kvm: make platform_info_test pass on AMD · e4427372
      Vitaly Kuznetsov 提交于
      test_msr_platform_info_disabled() generates EXIT_SHUTDOWN but VMCB state
      is undefined after that so an attempt to launch this guest again from
      test_msr_platform_info_enabled() fails. Reorder the tests to make test
      pass.
      Signed-off-by: NVitaly Kuznetsov <vkuznets@redhat.com>
      Signed-off-by: NPaolo Bonzini <pbonzini@redhat.com>
      e4427372
    • L
      Merge tag 'nfsd-5.3-1' of git://linux-nfs.org/~bfields/linux · 2babd34d
      Linus Torvalds 提交于
      Pull nfsd fixes from Bruce Fields:
       "Fix nfsd bugs: three in the new nfsd/clients/ code, one in the reply
        cache containerization"
      
      * tag 'nfsd-5.3-1' of git://linux-nfs.org/~bfields/linux:
        nfsd4: Fix kernel crash when reading proc file reply_cache_stats
        nfsd: initialize i_private before d_add
        nfsd: use i_wrlock instead of rcu for nfsdfs i_private
        nfsd: fix dentry leak upon mkdir failure.
      2babd34d
  3. 21 8月, 2019 13 次提交
    • P
      Revert "KVM: x86/mmu: Zap only the relevant pages when removing a memslot" · d012a06a
      Paolo Bonzini 提交于
      This reverts commit 4e103134.
      Alex Williamson reported regressions with device assignment with
      this patch.  Even though the bug is probably elsewhere and still
      latent, this is needed to fix the regression.
      
      Fixes: 4e103134 ("KVM: x86/mmu: Zap only the relevant pages when removing a memslot", 2019-02-05)
      Reported-by: NAlex Willamson <alex.williamson@redhat.com>
      Cc: stable@vger.kernel.org
      Cc: Sean Christopherson <sean.j.christopherson@intel.com>
      Signed-off-by: NPaolo Bonzini <pbonzini@redhat.com>
      d012a06a
    • P
      selftests: kvm: fix state save/load on processors without XSAVE · 54577e50
      Paolo Bonzini 提交于
      state_test and smm_test are failing on older processors that do not
      have xcr0.  This is because on those processor KVM does provide
      support for KVM_GET/SET_XSAVE (to avoid having to rely on the older
      KVM_GET/SET_FPU) but not for KVM_GET/SET_XCRS.
      Signed-off-by: NPaolo Bonzini <pbonzini@redhat.com>
      54577e50
    • G
      video: fbdev: acornfb: Mark expected switch fall-through · c3cb6674
      Gustavo A. R. Silva 提交于
      Mark switch cases where we are expecting to fall through.
      
      Fix the following warning (Building: rpc_defconfig arm):
      
      drivers/video/fbdev/acornfb.c: In function ‘acornfb_parse_dram’:
      drivers/video/fbdev/acornfb.c:860:9: warning: this statement may fall through [-Wimplicit-fallthrough=]
          size *= 1024;
          ~~~~~^~~~~~~
      drivers/video/fbdev/acornfb.c:861:3: note: here
         case 'K':
         ^~~~
      Signed-off-by: NGustavo A. R. Silva <gustavo@embeddedor.com>
      c3cb6674
    • G
      scsi: libsas: sas_discover: Mark expected switch fall-through · da1fb290
      Gustavo A. R. Silva 提交于
      Mark switch cases where we are expecting to fall through.
      
      Fix the following warning (Building: mtx1_defconfig mips):
      
      drivers/scsi/libsas/sas_discover.c: In function ‘sas_discover_domain’:
      ./include/linux/printk.h:309:2: warning: this statement may fall through [-Wimplicit-fallthrough=]
        printk(KERN_NOTICE pr_fmt(fmt), ##__VA_ARGS__)
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      drivers/scsi/libsas/sas_discover.c:459:3: note: in expansion of macro ‘pr_notice’
         pr_notice("ATA device seen but CONFIG_SCSI_SAS_ATA=N so cannot attach\n");
         ^~~~~~~~~
      drivers/scsi/libsas/sas_discover.c:462:2: note: here
        default:
        ^~~~~~~
      Signed-off-by: NGustavo A. R. Silva <gustavo@embeddedor.com>
      da1fb290
    • G
      MIPS: Octeon: Mark expected switch fall-through · 93cbcf5d
      Gustavo A. R. Silva 提交于
      Mark switch cases where we are expecting to fall through.
      
      Fix the following warning (Building: cavium_octeon_defconfig mips):
      
      arch/mips/include/asm/octeon/cvmx-sli-defs.h:47:6: warning: this statement
      may fall through [-Wimplicit-fallthrough=]
      Signed-off-by: NGustavo A. R. Silva <gustavo@embeddedor.com>
      93cbcf5d
    • G
      power: supply: ab8500_charger: Mark expected switch fall-through · 5274fdba
      Gustavo A. R. Silva 提交于
      Mark switch cases where we are expecting to fall through.
      
      Fix the following warning (Building: allmodconfig arm):
      
      drivers/power/supply/ab8500_charger.c: In function ‘ab8500_charger_max_usb_curr’:
      drivers/power/supply/ab8500_charger.c:738:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
         if (di->vbus_detected) {
            ^
      drivers/power/supply/ab8500_charger.c:745:2: note: here
        case USB_STAT_HM_IDGND:
        ^~~~
      Signed-off-by: NGustavo A. R. Silva <gustavo@embeddedor.com>
      5274fdba
    • G
      watchdog: wdt285: Mark expected switch fall-through · c9cbbb9f
      Gustavo A. R. Silva 提交于
      Mark switch cases where we are expecting to fall through.
      
      Fix the following warning (Building: footbridge_defconfig arm):
      
      drivers/watchdog/wdt285.c: In function ‘watchdog_ioctl’:
      drivers/watchdog/wdt285.c:170:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
         watchdog_ping();
         ^~~~~~~~~~~~~~~
      drivers/watchdog/wdt285.c:172:2: note: here
        case WDIOC_GETTIMEOUT:
        ^~~~
      Signed-off-by: NGustavo A. R. Silva <gustavo@embeddedor.com>
      c9cbbb9f
    • G
      mtd: sa1100: Mark expected switch fall-through · 3f0289cb
      Gustavo A. R. Silva 提交于
      Mark switch cases where we are expecting to fall through.
      
      Fix the following warning (Building: assabet_defconfig arm):
      
      drivers/mtd/maps/sa1100-flash.c: In function ‘sa1100_probe_subdev’:
      drivers/mtd/maps/sa1100-flash.c:82:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
         printk(KERN_WARNING "SA1100 flash: unknown base address "
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                "0x%08lx, assuming CS0\n", phys);
                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      drivers/mtd/maps/sa1100-flash.c:85:2: note: here
        case SA1100_CS0_PHYS:
        ^~~~
      Signed-off-by: NGustavo A. R. Silva <gustavo@embeddedor.com>
      3f0289cb
    • G
      drm/sun4i: tcon: Mark expected switch fall-through · 5334653d
      Gustavo A. R. Silva 提交于
      Mark switch cases where we are expecting to fall through.
      
      Fix the following warning (Building: sunxi_defconfig arm):
      
      drivers/gpu/drm/sun4i/sun4i_tcon.c: In function ‘sun4i_tcon0_mode_set_dithering’:
      drivers/gpu/drm/sun4i/sun4i_tcon.c:318:7: warning: this statement may fall through [-Wimplicit-fallthrough=]
         val |= SUN4I_TCON0_FRM_CTL_MODE_B;
      drivers/gpu/drm/sun4i/sun4i_tcon.c:319:2: note: here
        case MEDIA_BUS_FMT_RGB666_1X18:
        ^~~~
      Signed-off-by: NGustavo A. R. Silva <gustavo@embeddedor.com>
      5334653d
    • G
      drm/sun4i: sun6i_mipi_dsi: Mark expected switch fall-through · edf6a059
      Gustavo A. R. Silva 提交于
      Mark switch cases where we are expecting to fall through.
      
      Fix the following warning (Building: multi_v7_defconfig arm):
      
      drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c: In function ‘sun6i_dsi_transfer’:
      drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c:993:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
         if (msg->rx_len == 1) {
            ^
      drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c:998:2: note: here
        default:
        ^~~~~~~
      Signed-off-by: NGustavo A. R. Silva <gustavo@embeddedor.com>
      edf6a059
    • G
      ARM: riscpc: Mark expected switch fall-through · 06264adf
      Gustavo A. R. Silva 提交于
      Mark switch cases where we are expecting to fall through.
      
      Fix the following warning (Building: rpc_defconfig arm):
      
      arch/arm/mach-rpc/riscpc.c: In function ‘parse_tag_acorn’:
      arch/arm/mach-rpc/riscpc.c:48:13: warning: this statement may fall through [-Wimplicit-fallthrough=]
         vram_size += PAGE_SIZE * 256;
         ~~~~~~~~~~^~~~~~~~~~~~~~~~~~
      arch/arm/mach-rpc/riscpc.c:49:2: note: here
        case 256:
        ^~~~
      Signed-off-by: NGustavo A. R. Silva <gustavo@embeddedor.com>
      06264adf
    • G
      dmaengine: fsldma: Mark expected switch fall-through · 377ec836
      Gustavo A. R. Silva 提交于
      Mark switch cases where we are expecting to fall through.
      
      Fix the following warnings (Building: powerpc-ppa8548_defconfig powerpc):
      
      drivers/dma/fsldma.c: In function ‘fsl_dma_chan_probe’:
      drivers/dma/fsldma.c:1165:26: warning: this statement may fall through [-Wimplicit-fallthrough=]
         chan->toggle_ext_pause = fsl_chan_toggle_ext_pause;
         ~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~
      drivers/dma/fsldma.c:1166:2: note: here
        case FSL_DMA_IP_83XX:
        ^~~~
      Reported-by: Nkbuild test robot <lkp@intel.com>
      Acked-by: NLi Yang <leoyang.li@nxp.com>
      Signed-off-by: NGustavo A. R. Silva <gustavo@embeddedor.com>
      377ec836
    • L
      Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/hid/hid · 15d90b24
      Linus Torvalds 提交于
      Pull HID fixes from Jiri Kosina:
      
       - a few regression fixes for wacom driver (including fix for my earlier
         mismerge) from Aaron Armstrong Skomra and Jason Gerecke
      
       - revert of a few Logitech device ID additions which turn out to not
         work perfectly with the hidpp driver at the moment; proper support is
         now scheduled for 5.4. Fixes from Benjamin Tissoires
      
       - scheduling-in-atomic fix for cp2112 driver, from Benjamin Tissoires
      
       - new device ID to intel-ish, from Even Xu
      
      * 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/hid/hid:
        HID: wacom: correct misreported EKR ring values
        HID: cp2112: prevent sleeping function called from invalid context
        HID: intel-ish-hid: ipc: add EHL device id
        HID: wacom: Correct distance scale for 2nd-gen Intuos devices
        HID: logitech-hidpp: remove support for the G700 over USB
        Revert "HID: logitech-hidpp: add USB PID for a few more supported mice"
        HID: wacom: add back changes dropped in merge commit
      15d90b24
  4. 20 8月, 2019 5 次提交
    • A
      HID: wacom: correct misreported EKR ring values · fcf887e7
      Aaron Armstrong Skomra 提交于
      The EKR ring claims a range of 0 to 71 but actually reports
      values 1 to 72. The ring is used in relative mode so this
      change should not affect users.
      Signed-off-by: NAaron Armstrong Skomra <aaron.skomra@wacom.com>
      Fixes: 72b236d6 ("HID: wacom: Add support for Express Key Remote.")
      Cc: <stable@vger.kernel.org> # v4.3+
      Reviewed-by: NPing Cheng <ping.cheng@wacom.com>
      Reviewed-by: NJason Gerecke <jason.gerecke@wacom.com>
      Signed-off-by: NJiri Kosina <jkosina@suse.cz>
      fcf887e7
    • L
      Merge tag 'clk-fixes-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/clk/linux · 5f97cbe2
      Linus Torvalds 提交于
      Pull clk fixes from Stephen Boyd:
       "A couple fixes to the core framework logic that finds clk parents, a
        handful of samsung clk driver fixes for audio and display clks, and a
        small fix for the Stratix10 SoC driver that was checking the wrong
        register for validity"
      
      * tag 'clk-fixes-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/clk/linux:
        clk: Fix potential NULL dereference in clk_fetch_parent_index()
        clk: Fix falling back to legacy parent string matching
        clk: socfpga: stratix10: fix rate caclulationg for cnt_clks
        clk: samsung: exynos542x: Move MSCL subsystem clocks to its sub-CMU
        clk: samsung: exynos5800: Move MAU subsystem clocks to MAU sub-CMU
        clk: samsung: Change signature of exynos5_subcmus_init() function
      5f97cbe2
    • L
      Merge branch 'siginfo-linus' of... · 287c55ed
      Linus Torvalds 提交于
      Merge branch 'siginfo-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace
      
      Pull kernel thread signal handling fix from Eric Biederman:
       "I overlooked the fact that kernel threads are created with all signals
        set to SIG_IGN, and accidentally caused a regression in cifs and drbd
        when replacing force_sig with send_sig.
      
        This is my fix for that regression. I add a new function
        allow_kernel_signal which allows kernel threads to receive signals
        sent from the kernel, but continues to ignore all signals sent from
        userspace. This ensures the user space interface for cifs and drbd
        remain the same.
      
        These kernel threads depend on blocking networking calls which block
        until something is received or a signal is pending. Making receiving
        of signals somewhat necessary for these kernel threads.
      
        Perhaps someday we can cleanup those interfaces and remove
        allow_kernel_signal. If not allow_kernel_signal is pretty trivial and
        clearly documents what is going on so I don't think we will mind
        carrying it"
      
      * 'siginfo-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace:
        signal: Allow cifs and drbd to receive their terminating signals
      287c55ed
    • L
      Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net · 06821504
      Linus Torvalds 提交于
      Pull networking fixes from David Miller:
      
        1) Fix jmp to 1st instruction in x64 JIT, from Alexei Starovoitov.
      
        2) Severl kTLS fixes in mlx5 driver, from Tariq Toukan.
      
        3) Fix severe performance regression due to lack of SKB coalescing of
           fragments during local delivery, from Guillaume Nault.
      
        4) Error path memory leak in sch_taprio, from Ivan Khoronzhuk.
      
        5) Fix batched events in skbedit packet action, from Roman Mashak.
      
        6) Propagate VLAN TX offload to hw_enc_features in bond and team
           drivers, from Yue Haibing.
      
        7) RXRPC local endpoint refcounting fix and read after free in
           rxrpc_queue_local(), from David Howells.
      
        8) Fix endian bug in ibmveth multicast list handling, from Thomas
           Falcon.
      
        9) Oops, make nlmsg_parse() wrap around the correct function,
           __nlmsg_parse not __nla_parse(). Fix from David Ahern.
      
       10) Memleak in sctp_scend_reset_streams(), fro Zheng Bin.
      
       11) Fix memory leak in cxgb4, from Wenwen Wang.
      
       12) Yet another race in AF_PACKET, from Eric Dumazet.
      
       13) Fix false detection of retransmit failures in tipc, from Tuong
           Lien.
      
       14) Use after free in ravb_tstamp_skb, from Tho Vu.
      
      * git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net: (101 commits)
        ravb: Fix use-after-free ravb_tstamp_skb
        netfilter: nf_tables: map basechain priority to hardware priority
        net: sched: use major priority number as hardware priority
        wimax/i2400m: fix a memory leak bug
        net: cavium: fix driver name
        ibmvnic: Unmap DMA address of TX descriptor buffers after use
        bnxt_en: Fix to include flow direction in L2 key
        bnxt_en: Use correct src_fid to determine direction of the flow
        bnxt_en: Suppress HWRM errors for HWRM_NVM_GET_VARIABLE command
        bnxt_en: Fix handling FRAG_ERR when NVM_INSTALL_UPDATE cmd fails
        bnxt_en: Improve RX doorbell sequence.
        bnxt_en: Fix VNIC clearing logic for 57500 chips.
        net: kalmia: fix memory leaks
        cx82310_eth: fix a memory leak bug
        bnx2x: Fix VF's VLAN reconfiguration in reload.
        Bluetooth: Add debug setting for changing minimum encryption key size
        tipc: fix false detection of retransmit failures
        lan78xx: Fix memory leaks
        MAINTAINERS: r8169: Update path to the driver
        MAINTAINERS: PHY LIBRARY: Update files in the record
        ...
      06821504
    • D
      keys: Fix description size · 555df336
      David Howells 提交于
      The maximum key description size is 4095.  Commit f771fde8 ("keys:
      Simplify key description management") inadvertantly reduced that to 255
      and made sizes between 256 and 4095 work weirdly, and any size whereby
      size & 255 == 0 would cause an assertion in __key_link_begin() at the
      following line:
      
      	BUG_ON(index_key->desc_len == 0);
      
      This can be fixed by simply increasing the size of desc_len in struct
      keyring_index_key to a u16.
      
      Note the argument length test in keyutils only checked empty
      descriptions and descriptions with a size around the limit (ie.  4095)
      and not for all the values in between, so it missed this.  This has been
      addressed and
      
      	https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/keyutils.git/commit/?id=066bf56807c26cd3045a25f355b34c1d8a20a5aa
      
      now exhaustively tests all possible lengths of type, description and
      payload and then some.
      
      The assertion failure looks something like:
      
       kernel BUG at security/keys/keyring.c:1245!
       ...
       RIP: 0010:__key_link_begin+0x88/0xa0
       ...
       Call Trace:
        key_create_or_update+0x211/0x4b0
        __x64_sys_add_key+0x101/0x200
        do_syscall_64+0x5b/0x1e0
        entry_SYSCALL_64_after_hwframe+0x44/0xa9
      
      It can be triggered by:
      
      	keyctl add user "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa" a @s
      
      Fixes: f771fde8 ("keys: Simplify key description management")
      Reported-by: Nkernel test robot <rong.a.chen@intel.com>
      Signed-off-by: NDavid Howells <dhowells@redhat.com>
      Signed-off-by: NLinus Torvalds <torvalds@linux-foundation.org>
      555df336
  5. 19 8月, 2019 11 次提交