Skip to content

K
Kernel

openeuler / Kernel
接近 2 年 前同步成功

通知 8
Star 0
Fork 0
K
Kernel
切换分支/标签
  1. 07 11月, 2022 1 次提交
  3. 31 10月, 2022 1 次提交
  5. 27 9月, 2022 1 次提交
  7. 03 8月, 2022 1 次提交
  9. 07 4月, 2022 2 次提交
  11. 10 1月, 2022 1 次提交
  13. 18 12月, 2021 1 次提交
  15. 20 10月, 2021 2 次提交
  17. 25 8月, 2021 1 次提交
  19. 05 8月, 2021 1 次提交
  21. 25 6月, 2021 1 次提交
  23. 14 6月, 2021 1 次提交
  25. 06 6月, 2021 1 次提交
  27. 01 6月, 2021 1 次提交
  29. 25 3月, 2021 10 次提交
  31. 24 3月, 2021 1 次提交
  33. 06 10月, 2020 1 次提交
  35. 05 9月, 2020 1 次提交
  37. 13 8月, 2020 1 次提交
  39. 01 7月, 2020 1 次提交
  41. 10 6月, 2020 2 次提交
  43. 04 6月, 2020 1 次提交
  45. 03 6月, 2020 1 次提交
    • L
      gup: document and work around "COW can break either way" issue · 17839856
      由 Linus Torvalds 提交于 
      Doing a "get_user_pages()" on a copy-on-write page for reading can be
ambiguous: the page can be COW'ed at any time afterwards, and the
direction of a COW event isn't defined.

Yes, whoever writes to it will generally do the COW, but if the thread
that did the get_user_pages() unmapped the page before the write (and
that could happen due to memory pressure in addition to any outright
action), the writer could also just take over the old page instead.

End result: the get_user_pages() call might result in a page pointer
that is no longer associated with the original VM, and is associated
with - and controlled by - another VM having taken it over instead.

So when doing a get_user_pages() on a COW mapping, the only really safe
thing to do would be to break the COW when getting the page, even when
only getting it for reading.

At the same time, some users simply don't even care.

For example, the perf code wants to look up the page not because it
cares about the page, but because the code simply wants to look up the
physical address of the access for informational purposes, and doesn't
really care about races when a page might be unmapped and remapped
elsewhere.

This adds logic to force a COW event by setting FOLL_WRITE on any
copy-on-write mapping when FOLL_GET (or FOLL_PIN) is used to get a page
pointer as a result.

The current semantics end up being:

 - __get_user_pages_fast(): no change. If you don't ask for a write,
   you won't break COW. You'd better know what you're doing.

 - get_user_pages_fast(): the fast-case "look it up in the page tables
   without anything getting mmap_sem" now refuses to follow a read-only
   page, since it might need COW breaking.  Which happens in the slow
   path - the fast path doesn't know if the memory might be COW or not.

 - get_user_pages() (including the slow-path fallback for gup_fast()):
   for a COW mapping, turn on FOLL_WRITE for FOLL_GET/FOLL_PIN, with
   very similar semantics to FOLL_FORCE.

If it turns out that we want finer granularity (ie "only break COW when
it might actually matter" - things like the zero page are special and
don't need to be broken) we might need to push these semantics deeper
into the lookup fault path.  So if people care enough, it's possible
that we might end up adding a new internal FOLL_BREAK_COW flag to go
with the internal FOLL_COW flag we already have for tracking "I had a
COW".

Alternatively, if it turns out that different callers might want to
explicitly control the forced COW break behavior, we might even want to
make such a flag visible to the users of get_user_pages() instead of
using the above default semantics.

But for now, this is mostly commentary on the issue (this commit message
being a lot bigger than the patch, and that patch in turn is almost all
comments), with that minimal "enable COW breaking early" logic using the
existing FOLL_WRITE behavior.

[ It might be worth noting that we've always had this ambiguity, and it
  could arguably be seen as a user-space issue.

  You only get private COW mappings that could break either way in
  situations where user space is doing cooperative things (ie fork()
  before an execve() etc), but it _is_ surprising and very subtle, and
  fork() is supposed to give you independent address spaces.

  So let's treat this as a kernel issue and make the semantics of
  get_user_pages() easier to understand. Note that obviously a true
  shared mapping will still get a page that can change under us, so this
  does _not_ mean that get_user_pages() somehow returns any "stable"
  page ]
Reported-by: NJann Horn <jannh@google.com>
Tested-by: NChristoph Hellwig <hch@lst.de>
Acked-by: NOleg Nesterov <oleg@redhat.com>
Acked-by: NKirill Shutemov <kirill@shutemov.name>
Acked-by: NJan Kara <jack@suse.cz>
Cc: Andrea Arcangeli <aarcange@redhat.com>
Cc: Matthew Wilcox <willy@infradead.org>
Signed-off-by: NLinus Torvalds <torvalds@linux-foundation.org>
      17839856
  47. 30 5月, 2020 1 次提交
  49. 25 5月, 2020 1 次提交
  51. 19 5月, 2020 1 次提交
  53. 27 2月, 2020 1 次提交
  55. 08 2月, 2020 1 次提交