1. 30 5月, 2020 1 次提交
    • C
      drm/i915: Check for awaits on still currently executing requests · b55230e5
      Chris Wilson 提交于
      With the advent of preempt-to-busy, a request may still be on the GPU as
      we unwind. And in the case of a unpreemptible [due to HW] request, that
      request will remain indefinitely on the GPU even though we have
      returned it back to our submission queue, and cleared the active bit.
      
      We only run the execution callbacks on transferring the request from our
      submission queue to the execution queue, but if this is a bonded request
      that the HW is waiting for, we will not submit it (as we wait for a
      fresh execution) even though it is still being executed.
      
      As we know that there are always preemption points between requests, we
      know that only the currently executing request may be still active even
      though we have cleared the flag. However, we do not precisely know which
      request is in ELSP[0] due to a delay in processing events, and
      furthermore we only store the last request in a context in our state
      tracker.
      
      Fixes: 22b7a426 ("drm/i915/execlists: Preempt-to-busy")
      Testcase: igt/gem_exec_balancer/bonded-dual
      Signed-off-by: NChris Wilson <chris@chris-wilson.co.uk>
      Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
      Reviewed-by: NTvrtko Ursulin <tvrtko.ursulin@intel.com>
      Link: https://patchwork.freedesktop.org/patch/msgid/20200529143926.3245-1-chris@chris-wilson.co.uk
      b55230e5
  2. 29 5月, 2020 5 次提交
  3. 28 5月, 2020 5 次提交
  4. 27 5月, 2020 3 次提交
  5. 26 5月, 2020 5 次提交
  6. 25 5月, 2020 3 次提交
  7. 23 5月, 2020 1 次提交
    • A
      drm/i915/dsb: Pre allocate and late cleanup of cmd buffer · afeda4f3
      Animesh Manna 提交于
      Pre-allocate command buffer in atomic_commit using intel_dsb_prepare
      function which also includes pinning and map in cpu domain.
      
      No functional change is dsb write/commit functions.
      
      Now dsb get/put function is removed and ref-count mechanism is
      not needed. Below dsb api added to do respective job mentioned
      below.
      
      intel_dsb_prepare - Allocate, pin and map the buffer.
      intel_dsb_cleanup - Unpin and release the gem object.
      
      RFC: Initial patch for design review.
      v2: included _init() part in _prepare(). [Daniel, Ville]
      v3: dsb_cleanup called after cleanup_planes. [Daniel]
      v4: dsb structure is moved to intel_crtc_state from intel_crtc. [Maarten]
      v5: dsb get/put/ref-count mechanism removed. [Maarten]
      v6: Based on review feedback following changes are added,
      - replaced intel_dsb structure by pointer in intel_crtc_state. [Maarten]
      - passing intel_crtc_state to dsp-api to simplify the code. [Maarten]
      - few dsb functions prototype modified to simplify code.
      v7: added few cosmetic changes suggested by Jani and null check for
      crtc_state in dsb_cleanup removed as suggested by Maarten.
      v8: changed the function parameter to intel_crtc_state* of
      ivb_load_lut_ext_max() from intel_crtc. [Maarten]
      v9: error handling improved in _write() and prepare(). [Maarten]
      
      Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
      Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
      Cc: Jani Nikula <jani.nikula@intel.com>
      Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
      Acked-by: NDaniel Vetter <daniel.vetter@ffwll.ch>
      Reviewed-by: NMaarten Lankhorst <maarten.lankhorst@intel.com>
      Signed-off-by: NAnimesh Manna <animesh.manna@intel.com>
      Signed-off-by: NUma Shankar <uma.shankar@intel.com>
      Link: https://patchwork.freedesktop.org/patch/msgid/20200520130737.11240-1-animesh.manna@intel.com
      afeda4f3
  8. 22 5月, 2020 14 次提交
  9. 21 5月, 2020 3 次提交