If two streams are started immediately after one another (such as a
playback and a recording stream), the call to set hw params fails with
EBUSY. This patch makes the call succeed, so playback and recording will
work properly.
Signed-off-by: NDavid Henningsson <launchpad.web@epost.diwic.se>
Signed-off-by: NTakashi Iwai <tiwai@suse.de>

Fix the num_total_dacs setting for Chaintech AV710. The existing comment
that only PSDOUT0 is connected is correct, but since the card is using
packed AC97 mode to send 6 channels to the codec, num_total_dacs should be
set to 6 and not 2. This allows 6-channel surround to work. Also clarify
a comment regarding the additional WM8728 codec on this card (it's connected
to the SPDIF output and always receives the same data).
Signed-off-by: NRobert Hancock <hancockrwd@gmail.com>
Signed-off-by: NTakashi Iwai <tiwai@suse.de>

Increase the default and maximum PCM buffer prellocation size for ice1724's
SPDIF and independent stereo pair outputs to 256K, which is the hardware's
maximum supported size. This allows a reduction in interrupt rate and
potentially power usage when an application is not latency-critical.
Signed-off-by: NRobert Hancock <hancockrwd@gmail.com>
Signed-off-by: NTakashi Iwai <tiwai@suse.de>

* PLEASE NOTE - this change requires the corresponding update of
  envy24control for ice1712 - kind of an ABI change.
* The "Multi Track Peak" control is read-only level meters indicator.
* The control is VERY confusing to most users since it is currently displayed
  in regular mixers. E.g. alsamixer ignores its read-only status
  and allows changing the levels with keys which makes no sense.
Signed-off-by: NPavel Hofman <pavel.hofman@ivitera.com>
Acked-by: NJaroslav Kysela <perex@perex.cz>
Signed-off-by: NTakashi Iwai <tiwai@suse.de>

Now snd_vt1724_chip_reset() is used in the resume callback, thus
it cannot be __devinit.
Signed-off-by: NTakashi Iwai <tiwai@suse.de>

I've built a small HTPC and had to add suspend/resume support in ice1724
driver. There seem to be 3 existing bugs related to that:

https://bugtrack.alsa-project.org/alsa-bug/view.php?id=4413
https://bugtrack.alsa-project.org/alsa-bug/view.php?id=3748
https://bugtrack.alsa-project.org/alsa-bug/view.php?id=2314

Due to hardware (un)availability, I only enabled the fix for Audiotrak
Prodigy HD2 card, which is installed in my HTPC. However, most of my code
should be reusable in the future on other ice1724-based cards as well (as
long as people add card-specific peices of code). The fix is currently based
on ALSA 1.0.20 and works on my MythBuntu 9.04 HTPC (using 2.6.28-11 kernel).

Signed-off-by: Igor Chernyshev <igor.ch75+alsa at gmail.com>
Signed-off-by: NTakashi Iwai <tiwai@suse.de>

Signed-off-by: NJoe Perches <joe@perches.com>
Signed-off-by: NTakashi Iwai <tiwai@suse.de>

Added the support for ESI Maya44 board to ice1724 driver.
Signed-off-by: NTakashi Iwai <tiwai@suse.de>

Added a new flag, own_routing, to allow spec drivers to create own
routing controls.  Also, the basic get/put calls are changed to be
external for later use by maya44 driver.
Signed-off-by: NTakashi Iwai <tiwai@suse.de>

Add the PCI posting to ensure the reset sequence in snd_vt1724_chip_reset().
Signed-off-by: NTakashi Iwai <tiwai@suse.de>

Rename some vt1724_pcm_reg records to more generic and consistent ones.
Signed-off-by: NTakashi Iwai <tiwai@suse.de>

The set_rate might return error but the current code doesn't check it.
This patch adds a proper error check.
Signed-off-by: NTakashi Iwai <tiwai@suse.de>

Replace all DMA_28BIT_MASK macro with DMA_BIT_MASK(28)

Signed-off-by: Yang Hongyang<yanghy@cn.fujitsu.com>
Signed-off-by: NAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: NLinus Torvalds <torvalds@linux-foundation.org>

Signed-off-by: NTakashi Iwai <tiwai@suse.de>

MIDI_TX IRQ seems always pending when any bytes on FIFO is available.
Thus, it's better to enable MPU_TX only when any bytres are really
stored in the substream, and disables immediately when the queue
becomes empty.
Signed-off-by: NTakashi Iwai <tiwai@suse.de>

Convert from snd_card_new() to the new snd_card_create() function
in sound/pci/*.
Signed-off-by: NTakashi Iwai <tiwai@suse.de>

Fix trivial name string typo as reported in bug 2552.
Signed-off-by: NAlan Horstmann <gineera@aspect135.co.uk>
Signed-off-by: NTakashi Iwai <tiwai@suse.de>

The previous IRQ mask initialization was wrong.  It must set the bits
to be masked.
Signed-off-by: NTakashi Iwai <tiwai@suse.de>

The IRQMASK register has to be set to zero expclitily at the initialization
otherwise you'll get no interrupts properly at later operations.

Also, removed the old commented out codes.
Signed-off-by: NTakashi Iwai <tiwai@suse.de>

Neither has any significance currently to the flow
because err is checked for the same condition before
the place of disagreement.
Signed-off-by: NIlpo Järvinen <ilpo.jarvinen@helsinki.fi>
Signed-off-by: NTakashi Iwai <tiwai@suse.de>

MPU TX causes IRQ floods on VT172x devices mysteriously.
Disable TX IRQ if the IRQ flood is detected.
Signed-off-by: NTakashi Iwai <tiwai@suse.de>

before:
total: 113 errors, 169 warnings, 2786 lines checked
total: 26 errors, 24 warnings, 504 lines checked

after:
total: 14 errors, 163 warnings, 2799 lines checked
total: 0 errors, 24 warnings, 504 lines checked

Compile tested only.
Signed-off-by: NAlexander Beregalov <a.beregalov@gmail.com>
Signed-off-by: NTakashi Iwai <tiwai@suse.de>
Signed-off-by: NJaroslav Kysela <perex@perex.cz>

before:
total: 96 errors, 66 warnings, 2612 lines checked

after:
total: 11 errors, 64 warnings, 2624 lines checked

Compile tested only.
Signed-off-by: NAlexander Beregalov <a.beregalov@gmail.com>
Signed-off-by: NTakashi Iwai <tiwai@suse.de>
Signed-off-by: NJaroslav Kysela <perex@perex.cz>

Inspired by Alexander Beregalov's patches for wtm and aureon.c,
I decided to run checkpatch on some more files. After some work
checkpatch.pl-0.23 --no-tree --file --strict <file> reports
0 errors, 0 warnings, 0 checks, n lines checked for:
phase.c
phase.h
juli.c (1 check about unused code, maybe we should comment it)
juli.h (no changes necessary)
In other files I have just fixed // comments and long lines along the
way (but not all of them), more coming up.
Signed-off-by: NVedran Miletic <rivanvx@gmail.com>
Signed-off-by: NTakashi Iwai <tiwai@suse.de>
Signed-off-by: NJaroslav Kysela <perex@perex.cz>

before:
total: 2 errors, 0 warnings, 20 lines checked
total: 49 errors, 2 warnings, 518 lines checked

after:
total: 0 errors, 0 warnings, 20 lines checked
total: 0 errors, 0 warnings, 518 lines checked

Compile tested, size and code are equal.
Signed-off-by: NAlexander Beregalov <a.beregalov@gmail.com>
Signed-off-by: NTakashi Iwai <tiwai@suse.de>
Signed-off-by: NJaroslav Kysela <perex@perex.cz>

before:
total: 304 errors, 137 warnings, 2259 lines checked

after:
total: 0 errors, 121 warnings, 2284 lines checked

Compile tested, size is different because of include was changed,
but without that change md5sum is different because of cmp cx,dx/cmp
dx,cx swap and __LINE__ was changed in printk function.
Signed-off-by: NAlexander Beregalov <a.beregalov@gmail.com>
Signed-off-by: NTakashi Iwai <tiwai@suse.de>
Signed-off-by: NJaroslav Kysela <perex@perex.cz>

Limit the available channels for multi-channel playback device to
the real number of channels.  Until now, always up to 8 channels
are created, which are simply useless without the real outputs.
Signed-off-by: NTakashi Iwai <tiwai@suse.de>
Signed-off-by: NJaroslav Kysela <perex@perex.cz>

Even though MIDI was fixed on ice1724 chips a while ago, it wasn't yet
enabled for some cards as it didn't get enough testing. This was tested
with MIDI keyboard on PHASE 22 and with looping back output to input and
it works stable, so it's safe to enable it.

Besides this, there are some more minor fixes, not exactly user visible:
* added info about PHASE 28 (collected, as I don't have a card)
* added info about TS22PCI and new revisions of PHASE 22
* disable 192k on PHASE 22 as AK4524 I2S doesn't support it
* enable SPDIF reciever on PHASE 22
Signed-off-by: NVedran Miletic <rivanvx@gmail.com>
Signed-off-by: NTakashi Iwai <tiwai@suse.de>
Signed-off-by: NJaroslav Kysela <perex@perex.cz>

This enables MIDI on Terratec Aureon 7.1 Universe cards specifically.
Apparently the other envy24ht-based Aureon cards do not have MIDI ports,
hence I added a Universe specific eeprom array.

The newer cards (Aureon 7.1 PCI / 5.1 PCI/Fun) have MIDI but use a CMI
DSP so this driver does not concern them at all.
Signed-off-by: NMaximilian Rehkopf <otakon@gmx.net>
Signed-off-by: NTakashi Iwai <tiwai@suse.de>
Signed-off-by: NJaroslav Kysela <perex@perex.cz>

It is ALSA bug #1754.
 D6 bit in 02 register is PW4.
Signed-off-by: NAlexander Beregalov <a.beregalov@gmail.com>
Signed-off-by: NTakashi Iwai <tiwai@suse.de>
Signed-off-by: NJaroslav Kysela <perex@perex.cz>

sound/pci: supported cards update
Signed-off-by: NAlexander Beregalov <a.beregalov@gmail.com>
Signed-off-by: NTakashi Iwai <tiwai@suse.de>
Signed-off-by: NJaroslav Kysela <perex@perex.cz>

ice1724/revo: simple clean up
Signed-off-by: NAlexander Beregalov <a.beregalov@gmail.com>
Signed-off-by: NTakashi Iwai <tiwai@suse.de>
Signed-off-by: NJaroslav Kysela <perex@perex.cz>

Kill snd_assert() in sound/pci/*, either removed or replaced with
if () with snd_BUG_ON().
Signed-off-by: NTakashi Iwai <tiwai@suse.de>
Signed-off-by: NJaroslav Kysela <perex@perex.cz>

Added support for Terrasoniq/MUSONIK TS22 PCI card.
Signed-off-by: NMisha Zhilin <misha@epiphan.com>
Signed-off-by: NTakashi Iwai <tiwai@suse.de>
Signed-off-by: NJaroslav Kysela <perex@perex.cz>

The VT1724 MIDI port is not MPU-401 compatible; remove the hacks that
try to make the MPU-401 library work with it, and just use some simple
device-specific code.
Signed-off-by: NClemens Ladisch <clemens@ladisch.de>
Tested-by: NPavel Hofman <pavel.hofman@insite.cz>

Enable watermarks settings (previously commented out) for MPU RX/TX.
Otherwise irqs aren't issued properly.
Tested-by: NPavel Hofman <pavel.hofman@insite.cz>
Signed-off-by: NTakashi Iwai <tiwai@suse.de>

Added MPU401_INFO_NO_ACK bitflag to ignore the ACK check for UART
commands.  VT172x doesn't handle ACK commands, for example.
Tested-by: NPavel Hofman <pavel.hofman@insite.cz>
Signed-off-by: NTakashi Iwai <tiwai@suse.de>

The sound boards with VT1724 and compatible chips may lock up when
MPU401 is accessed together with the PCM streaming.
This patch fixes the problem.
Signed-off-by: NTakashi Iwai <tiwai@suse.de>

Added the support of Terrasonq TS88.
Signed-off-by: NPeter Lienig <lienig@rheinmetall-de.com>
Signed-off-by: NTakashi Iwai <tiwai@suse.de>

free_irq() calls synchronize_irq() for you, so there is no need for
drivers to manually do the same thing (again).  Thus, calls where
sync-irq immediately precedes free-irq can be simplified.

However, during this audit several bugs were noticed, where free-irq is
preceded by a "irq >= 0" check... but the sync-irq call is not covered
by the same check.

So, where sync-irq could not be eliminated completely, the missing check
was added.
Signed-off-by: NJeff Garzik <jgarzik@redhat.com>
Signed-off-by: NTakashi Iwai <tiwai@suse.de>