1. 26 1月, 2019 1 次提交
  2. 14 12月, 2018 1 次提交
  3. 23 11月, 2018 3 次提交
  4. 11 11月, 2018 2 次提交
    • S
      iwlwifi: dbg: avoid passing trigger around · 124e0eba
      Sara Sharon 提交于
      The trigger structure is being passed around, when
      all we care about is whether to dump only monitor
      or not. Pass a bool instead.
      Signed-off-by: NSara Sharon <sara.sharon@intel.com>
      Signed-off-by: NLuca Coelho <luciano.coelho@intel.com>
      124e0eba
    • S
      iwlwifi: trans: Clear persistence bit when starting the FW · 8954e1eb
      Shahar S Matityahu 提交于
      In D3 suspend flow in 9260 gen2 HW, the NIC receives two PERST signals.
      The first PERST is expected and indicates the device on coming resume flow.
      The second PERST causes FW restart FW restart.
      In order to avoid this issue, the FW set the persistence bit on.
      Once this bit is set, the FW ignores reset attempts.
      The problem is when the FW gets assert during D3 and then the persistence
      bit is set and causes the FW to ignore reset.
      To handle this issue, the FW opens the preg bit which allows access
      to the persistence bit, so that the driver clear the persistence bit
      and reset the NIC.
      
      The flow is as follows:
      the driver checks if the persistence bit is set.
      If the bit is set, the driver checks if he can clear the bit.
      If the driver can not clear the bit then there is no point to continue
      configuring the NIC since it will fail.
      
      The fix was added is in start HW flow instead of the resume flow since in
      general, if the persistence bit is set, the driver can not start the FW.
      So it is good to check it when we start configuring the NIC.
      
      The driver does not need to close the preg bit since the FW close it
      during the start flow.
      Signed-off-by: NShahar S Matityahu <shahar.s.matityahu@intel.com>
      Signed-off-by: NLuca Coelho <luciano.coelho@intel.com>
      8954e1eb
  5. 06 10月, 2018 1 次提交
  6. 28 9月, 2018 6 次提交
  7. 31 8月, 2018 7 次提交
  8. 02 8月, 2018 5 次提交
  9. 26 7月, 2018 5 次提交
  10. 29 5月, 2018 1 次提交
  11. 26 4月, 2018 2 次提交
  12. 27 3月, 2018 1 次提交
  13. 21 12月, 2017 2 次提交
  14. 28 11月, 2017 1 次提交
  15. 25 11月, 2017 2 次提交
    • S
      iwlwifi: fix access to prph when transport is stopped · 0232d2cd
      Sara Sharon 提交于
      When getting HW rfkill we get stop_device being called from
      two paths.
      One path is the IRQ calling stop device, and updating op
      mode and stack.
      As a result, cfg80211 is running rfkill sync work that shuts
      down all devices (second path).
      In the second path, we eventually get to iwl_mvm_stop_device
      which calls iwl_fw_dump_conf_clear->iwl_fw_dbg_stop_recording,
      that access periphery registers.
      The device may be stopped at this point from the first path,
      which will result with a failure to access those registers.
      Simply checking for the trans status is insufficient, since
      the race will still exist, only minimized.
      Instead, move the stop from iwl_fw_dump_conf_clear (which is
      getting called only from stop path) to the transport stop
      device function, where the access is always safe.
      This has the added value, of actually stopping dbgc before
      stopping device even when the stop is initiated from the
      transport.
      
      Fixes: 1efc3843 ("iwlwifi: stop dbgc recording before stopping DMA")
      Signed-off-by: NSara Sharon <sara.sharon@intel.com>
      Signed-off-by: NLuca Coelho <luciano.coelho@intel.com>
      0232d2cd
    • S
      iwlwifi: pcie: fix erroneous "Read failed message" · f3402d6d
      Sara Sharon 提交于
      Current pci dumping code code is always falling to the error
      path, resulting with a constant "Read failed" message, also
      for the successful reads.
      
      Fixes: a5c932e41fdd ("iwlwifi: pcie: dump registers when HW becomes inaccessible")
      Signed-off-by: NSara Sharon <sara.sharon@intel.com>
      Signed-off-by: NLuca Coelho <luciano.coelho@intel.com>
      f3402d6d