1. 30 3月, 2010 1 次提交
    • T
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking... · 5a0e3ad6
      Tejun Heo 提交于
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
      
      percpu.h is included by sched.h and module.h and thus ends up being
      included when building most .c files.  percpu.h includes slab.h which
      in turn includes gfp.h making everything defined by the two files
      universally available and complicating inclusion dependencies.
      
      percpu.h -> slab.h dependency is about to be removed.  Prepare for
      this change by updating users of gfp and slab facilities include those
      headers directly instead of assuming availability.  As this conversion
      needs to touch large number of source files, the following script is
      used as the basis of conversion.
      
        http://userweb.kernel.org/~tj/misc/slabh-sweep.py
      
      The script does the followings.
      
      * Scan files for gfp and slab usages and update includes such that
        only the necessary includes are there.  ie. if only gfp is used,
        gfp.h, if slab is used, slab.h.
      
      * When the script inserts a new include, it looks at the include
        blocks and try to put the new include such that its order conforms
        to its surrounding.  It's put in the include block which contains
        core kernel includes, in the same order that the rest are ordered -
        alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
        doesn't seem to be any matching order.
      
      * If the script can't find a place to put a new include (mostly
        because the file doesn't have fitting include block), it prints out
        an error message indicating which .h file needs to be added to the
        file.
      
      The conversion was done in the following steps.
      
      1. The initial automatic conversion of all .c files updated slightly
         over 4000 files, deleting around 700 includes and adding ~480 gfp.h
         and ~3000 slab.h inclusions.  The script emitted errors for ~400
         files.
      
      2. Each error was manually checked.  Some didn't need the inclusion,
         some needed manual addition while adding it to implementation .h or
         embedding .c file was more appropriate for others.  This step added
         inclusions to around 150 files.
      
      3. The script was run again and the output was compared to the edits
         from #2 to make sure no file was left behind.
      
      4. Several build tests were done and a couple of problems were fixed.
         e.g. lib/decompress_*.c used malloc/free() wrappers around slab
         APIs requiring slab.h to be added manually.
      
      5. The script was run on all .h files but without automatically
         editing them as sprinkling gfp.h and slab.h inclusions around .h
         files could easily lead to inclusion dependency hell.  Most gfp.h
         inclusion directives were ignored as stuff from gfp.h was usually
         wildly available and often used in preprocessor macros.  Each
         slab.h inclusion directive was examined and added manually as
         necessary.
      
      6. percpu.h was updated not to include slab.h.
      
      7. Build test were done on the following configurations and failures
         were fixed.  CONFIG_GCOV_KERNEL was turned off for all tests (as my
         distributed build env didn't work with gcov compiles) and a few
         more options had to be turned off depending on archs to make things
         build (like ipr on powerpc/64 which failed due to missing writeq).
      
         * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
         * powerpc and powerpc64 SMP allmodconfig
         * sparc and sparc64 SMP allmodconfig
         * ia64 SMP allmodconfig
         * s390 SMP allmodconfig
         * alpha SMP allmodconfig
         * um on x86_64 SMP allmodconfig
      
      8. percpu.h modifications were reverted so that it could be applied as
         a separate patch and serve as bisection point.
      
      Given the fact that I had only a couple of failures from tests on step
      6, I'm fairly confident about the coverage of this conversion patch.
      If there is a breakage, it's likely to be something in one of the arch
      headers which should be easily discoverable easily on most builds of
      the specific arch.
      Signed-off-by: NTejun Heo <tj@kernel.org>
      Guess-its-ok-by: NChristoph Lameter <cl@linux-foundation.org>
      Cc: Ingo Molnar <mingo@redhat.com>
      Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
      5a0e3ad6
  2. 29 3月, 2010 1 次提交
    • A
      HID: Add NOGET quirk for Quanta Pixart touchscreen · c565c54d
      Anisse Astier 提交于
      Add the NOGET quirk for the Quanta optical touchscreen present on MSI AE2220,
      Otherwise, the hid-quanta driver timeouts at load time:
      
      drivers/hid/usbhid/hid-core.c: usb_submit_urb(ctrl) failed
      quanta-touch 0003:0408:3001.0003: timeout initializing reports
      input: PixArt Imaging Inc. Optical Touch Screen as /class/input/input7
      quanta-touch 0003:0408:3001.0003: input: USB HID v1.10 Device [PixArt Imaging Inc. Optical Touch Screen] on usb-0000:00:06.0-2/input0
      Signed-off-by: NAnisse Astier <anisse@astier.eu>
      Signed-off-by: NJiri Kosina <jkosina@suse.cz>
      c565c54d
  3. 09 3月, 2010 1 次提交
  4. 03 3月, 2010 1 次提交
  5. 17 2月, 2010 1 次提交
  6. 12 2月, 2010 1 次提交
  7. 05 2月, 2010 1 次提交
  8. 03 2月, 2010 4 次提交
  9. 12 1月, 2010 1 次提交
    • M
      HID: make USB device id constant · d67dec5b
      Márton Németh 提交于
      The id_table field of the struct usb_device_id is constant in <linux/usb.h>
      so it is worth to make the initialization data also constant.
      
      The semantic match that finds this kind of pattern is as follows:
      (http://coccinelle.lip6.fr/)
      
      // <smpl>
      @r@
      disable decl_init,const_decl_init;
      identifier I1, I2, x;
      @@
      	struct I1 {
      	  ...
      	  const struct I2 *x;
      	  ...
      	};
      @s@
      identifier r.I1, y;
      identifier r.x, E;
      @@
      	struct I1 y = {
      	  .x = E,
      	};
      @c@
      identifier r.I2;
      identifier s.E;
      @@
      	const struct I2 E[] = ... ;
      @depends on !c@
      identifier r.I2;
      identifier s.E;
      @@
      +	const
      	struct I2 E[] = ...;
      // </smpl>
      Signed-off-by: NMárton Németh <nm127@freemail.hu>
      Cc: Julia Lawall <julia@diku.dk>
      Cc: cocci@diku.dk
      Signed-off-by: NJiri Kosina <jkosina@suse.cz>
      d67dec5b
  10. 12 12月, 2009 1 次提交
  11. 03 12月, 2009 1 次提交
  12. 24 11月, 2009 1 次提交
  13. 06 11月, 2009 1 次提交
  14. 05 11月, 2009 1 次提交
    • J
      HID: fixup quirk for NCR devices · 5b915d9e
      Jiri Kosina 提交于
      NCR devices are terminally broken by design -- they claim themselves to contain
      proper input applications in their HID report descriptor, but behave very badly
      if treated in standard way.
      
      According to NCR developers, the devices get confused when queried for reports
      in a standard way, rendering them unusable.
      
      NCR is shipping application called "RPSL" that can be used to drive these
      devices through hiddev, under the assumption that in-kernel driver doesn't
      perform initial report query.
      If it does, neither in-kernel nor hiddev-based driver can operate with these
      devices any more.
      
      Introduce a quirk that skips the report query for all NCR devices. The previous
      NOGET quirk was wrong and had been introduced because I misunderstood the nature
      of brokenness of these devices.
      Signed-off-by: NJiri Kosina <jkosina@suse.cz>
      5b915d9e
  15. 04 11月, 2009 1 次提交
  16. 20 10月, 2009 1 次提交
  17. 14 10月, 2009 2 次提交
  18. 20 9月, 2009 1 次提交
  19. 17 9月, 2009 1 次提交
  20. 20 8月, 2009 1 次提交
    • J
      HID: support larger reports than 64 bytes in hiddev · affbb8c6
      Jiri Kosina 提交于
      hiddev userspace driver uses a rignbuffer to store the parsed usages
      that should be returned through read(). This buffer is 64 bytes long,
      which is sufficient for queueing single USB 1.0 low-speed report, which
      is of maximum size 48 bytes.
      
      There are however USB HID devices which are full-speed USB devices, and
      therefore they are free to produce reports 64 bytes long. This is correctly
      handled by HID core, but read() on hiddev node gets stuck forever, because
      the ring buffer loops infinitely (as it is exactly 64 bytes long as well),
      never advancing the buffer pointer.
      
      Plus, the core driver is ready to handle highspeed devices, so we should be
      able to handle reports from such devices in the hiddev driver as well, which
      means we need larger ringbuffer.
      Reported-by: NMichael Zeisel <michael.zeisel@philips.com>
      Signed-off-by: NJiri Kosina <jkosina@suse.cz>
      affbb8c6
  21. 18 8月, 2009 1 次提交
  22. 08 8月, 2009 1 次提交
  23. 23 7月, 2009 1 次提交
  24. 13 7月, 2009 1 次提交
  25. 22 6月, 2009 1 次提交
  26. 16 6月, 2009 1 次提交
  27. 12 6月, 2009 1 次提交
    • J
      HID: use debugfs for report dumping descriptor · a635f9dd
      Jiri Kosina 提交于
      It is a little bit inconvenient for people who have some non-standard
      HID hardware (usually violating the HID specification) to have to
      recompile kernel with CONFIG_HID_DEBUG to be able to see kernel's perspective
      of the HID report descriptor and observe the parsed events. Plus the messages
      are then mixed up inconveniently with the rest of the dmesg stuff.
      
      This patch implements /sys/kernel/debug/hid/<device>/rdesc file, which
      represents the kernel's view of report descriptor (both the raw report
      descriptor data and parsed contents).
      
      With all the device-specific debug data being available through debugfs, there
      is no need for keeping CONFIG_HID_DEBUG, as the 'debug' parameter to the
      hid module will now only output only driver-specific debugging options, which has
      absolutely minimal memory footprint, just a few error messages and one global
      flag (hid_debug).
      
      We use the current set of output formatting functions. The ones that need to be
      used both for one-shot rdesc seq_file and also for continuous flow of data
      (individual reports, as being sent by the device) distinguish according to the
      passed seq_file parameter, and if it is NULL, it still output to kernel ringbuffer,
      otherwise the corresponding seq_file is used for output.
      
      The format of the output is preserved.
      Signed-off-by: NJiri Kosina <jkosina@suse.cz>
      a635f9dd
  28. 04 6月, 2009 1 次提交
  29. 11 5月, 2009 2 次提交
  30. 29 4月, 2009 1 次提交
  31. 30 3月, 2009 2 次提交
    • O
      HID: fix race between usb_register_dev() and hiddev_open() · e43bd67d
      Oliver Neukum 提交于
      upon further thought this code is still racy.
      
      	retval = usb_register_dev(usbhid->intf, &hiddev_class);
      
      here you open a window during which open can happen
      
      	if (retval) {
      		err_hid("Not able to get a minor for this device.");
      		hid->hiddev = NULL;
      		kfree(hiddev);
      		return -1;
      	} else {
      		hid->minor = usbhid->intf->minor;
      		hiddev_table[usbhid->intf->minor - HIDDEV_MINOR_BASE] = hiddev;
      
      and will fail because hiddev_table hasn't been updated
      
      The obvious fix of using a mutex to guard hiddev_table doesn't work because
      usb_open() and usb_register_dev() take minor_rwsem and we'd have an AB-BA
      deadlock. We need a lock usb_open() also takes in the right order and that leaves
      only one option, BKL. I don't like it but I see no alternative.
      
      Once the usb_open() implements something better than lock_kernel(), we could also
      do so.
      Signed-off-by: NOliver Neukum <oneukum@suse.de>
      Signed-off-by: NJiri Kosina <jkosina@suse.cz>
      e43bd67d
    • J
      HID: bring back possibility to specify vid/pid ignore on module load · 6f4303fb
      Jiri Kosina 提交于
      When hid quirks were converted to specialized driver, the HID_QUIRK_IGNORE
      has been moved completely, as the hid_ignore_list[] has been moved into the
      generic code.
      
      However userspace already got used to the possibility that modprobing
      usbhid with
      
      	'quirks=vid:pid:0x4'
      
      makes the device ignored by usbhid driver. So keep this quirk flag in place
      for backwards compatibility.
      Signed-off-by: NJiri Kosina <jkosina@suse.cz>
      6f4303fb
  32. 26 3月, 2009 3 次提交
新手
引导
客服 返回
顶部