1. 26 11月, 2012 3 次提交
    • D
      8139cp: set ring address after enabling C+ mode · a9dbe40f
      David Woodhouse 提交于
      This fixes (for me) a regression introduced by commit b01af457 ("8139cp:
      set ring address before enabling receiver"). That commit configured the
      descriptor ring addresses earlier in the initialisation sequence, in
      order to avoid the possibility of triggering stray DMA before the
      correct address had been set up.
      
      Unfortunately, it seems that the hardware will scribble garbage into the
      TxRingAddr registers when we enable "plus mode" Tx in the CpCmd
      register. Observed on a Traverse Geos router board.
      
      To deal with this, while not reintroducing the problem which led to the
      original commit, we augment cp_start_hw() to write to the CpCmd register
      *first*, then set the descriptor ring addresses, and then finally to
      enable Rx and Tx in the original 8139 Cmd register. The datasheet
      actually indicates that we should enable Tx/Rx in the Cmd register
      *before* configuring the descriptor addresses, but that would appear to
      re-introduce the problem that the offending commit b01af457 was trying
      to solve. And this variant appears to work fine on real hardware.
      Signed-off-by: NDavid Woodhouse <David.Woodhouse@intel.com>
      Cc: stable@kernel.org [3.5+]
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      a9dbe40f
    • D
      Revert "8139cp: revert "set ring address before enabling receiver"" · 071e3ef4
      David S. Miller 提交于
      This reverts commit b26623da.
      
      This reverts the revert, in net-next we'll try another scheme
      to fix this bug using patches from David Woodhouse.
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      071e3ef4
    • D
      Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net · 24bc518a
      David S. Miller 提交于
      Conflicts:
      	drivers/net/wireless/iwlwifi/pcie/tx.c
      
      Minor iwlwifi conflict in TX queue disabling between 'net', which
      removed a bogus warning, and 'net-next' which added some status
      register poking code.
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      24bc518a
  2. 25 11月, 2012 1 次提交
  3. 24 11月, 2012 29 次提交
  4. 23 11月, 2012 7 次提交