In resume entry, use dev_get_drvdata() instead of to_platform_device(dev) +
platform_get_drvdata(pdev).
Signed-off-by: NXianglong Du <Xianglong.Du@csr.com>
Signed-off-by: NBarry Song <Baohua.Song@csr.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

This function lost namespace, this patch fixes it.
Signed-off-by: NXianglong Du <Xianglong.Du@csr.com>
Signed-off-by: NBarry Song <Baohua.Song@csr.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Since the IRQ handler always returns IRQ_HANDLED it means this irq is not
a shared IRQ at all. Or at least, the SW is not self-consistent now.
Signed-off-by: NBarry Song <Baohua.Song@csr.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

We can control whetehr device generates interrupts or not so let's
implement open and close methods of input device so that we do not do any
processing until there are users.
Tested-by: NXianglong Du <Xianglong.Du@csr.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Commit 436d42c6 ("ARM: samsung: move platform_data definitions")
moved the files to the current location but forgot to remove the pointer
to its previous location. Clean it up. While at it also change the header
file protection macros appropriately and remove whitespace errors.
Signed-off-by: NSachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

New version of the PCU firmware supports two new commands:
  - IMS_PCU_CMD_OFN_SET_CONFIG which allows to write data to the
  registers of one finger navigation(OFN) chip present on the device
  - IMS_PCU_CMD_OFN_GET_CONFIG which allows to read data form the
  registers of said chip.

This commit adds two helper functions to use those commands and sysfs
attributes to use them. It also exposes some OFN configuration
parameters via sysfs.
Signed-off-by: NAndrey Smirnov <andrew.smirnov@gmail.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

We first create backlight and then input devices so we should destroy them
in opposite order when handling errors.
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

uinput is used in the xorg-integration-tests suite and in the wayland
test suite. These automated tests suites create many virtual input
devices and then hook something to read these newly created devices.

Currently, uinput does not provide the created input device, which means
that we rely on an heuristic to guess which input node was created.
The problem is that is heuristic is subjected to races between different
uinput devices or even with physical devices. Having a way to retrieve
the sysfs path allows us to find without any doubts the event node.
Signed-off-by: NBenjamin Tissoires <benjamin.tissoires@redhat.com>
Reviewed-by: NDavid Herrmann <dh.herrmann@gmail.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

The current implementation prevents us to add variable-length ioctl.
Use a bunch of gotos instead of break to allow us to do so.

No functional changes.
Signed-off-by: NBenjamin Tisssoires <benjamin.tissoires@redhat.com>
Reviewed-by: NDavid Herrmann <dh.herrmann@gmail.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

This makes the zforce driver usable on devicetree-based platforms too.
Signed-off-by: NHeiko Stuebner <heiko.stuebner@bqreaders.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Devicetree support will be creating its own platfprm data structure that
is not attached to the device. Let's use the internal pointer to the
pdata instead of re-fetching it with dev_get_platdata().
Signed-off-by: NHeiko Stuebner <heiko.stuebner@bqreaders.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

A frame is a u8 array with the following structure:
[PAYLOAD_HEADER, PAYLOAD_LENGTH, ...PAYLOAD_BODY...]

PAYLOAD_BODY can be at most 255 bytes long, as it's size is represented
by PAYLOAD_LENGTH. Therefore we can reduce the stack memory allocated to
payload_buffer[] roughly by half, from 512 to 257 bytes.
Signed-off-by: NLuis Ortega <luiorpe1@upv.es>
Acked-by: NHeiko Stuebner <heiko@sntech.de>
Tested-by: Heiko Stuebner <heiko@sntech.de> - bq Cervantes (imx6sl)
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

The function zforce_read_packet() reads 2 values (bytes) of payload
header, validates them and then proceeds to read the payload body.
The function stores all these in a u8 buffer.

The PAYLOAD_LENGTH check seems to be trying to detect an overflow error.
However, since we are just reading a u8 value from the buffer, these
checks are unnecessary and we should simply compare against zero.
Signed-off-by: NLuis Ortega <luiorpe1@upv.es>
Acked-by: NHeiko Stuebner <heiko@sntech.de>
Tested-by: Heiko Stuebner <heiko@sntech.de> - bq Cervantes (imx6sl)
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Fixed lines exceeding 80 characters long wherever possible,
as per the coding style.
Signed-off-by: NLuis Ortega <luiorpe1@upv.es>
Acked-by: NHeiko Stuebner <heiko@sntech.de>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Fixed a few spelling errors.
Signed-off-by: NLuis Ortega <luiorpe1@upv.es>
Acked-by: NHeiko Stuebner <heiko@sntech.de>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

There is usb_get_dev() in gtco_probe(), but there is no usb_put_dev()
anywhere in the driver.

As pointed out by Dmitry Torokhov:
The lifetime of gtco structure is already directly tied to lifetime of
usb_dev: when destroying usb_dev driver core will call remove() function
of currently bound driver (in our case gtco) which will destroy gtco
memory. Taking additional reference is not needed here.

Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: NAlexey Khoroshilov <khoroshilov@ispras.ru>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

This adds Fujitsu-Siemens AMILO Pro 8210 support to wistron_btns driver.

Functions are very similar to already supported AMILO Pro 3505, but 8210
has WIFI led.

Such functionality is needed to enable WiFi under Linux on 8210 when it
cold boots with hardware rfkill enabled, without booting another operating
system or running custom utility that calls appropriate BIOS function.
Signed-off-by: NJakub Bogusz <qboosh@pld-linux.org>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Signed-off-by: NPing Cheng <pingc@wacom.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

features->quirks can have multiple bits set. For dual input, we only
need to check WACOM_QUIRK_MULTI_INPUT.
Reviewed-by: NJason Gerecke <killertofu@gmail.com>
Signed-off-by: NPing Cheng <pingc@wacom.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Simplify the error path and remove() function by using devm_*
functions for requesting gpios and irq and allocating the input
device.
Signed-off-by: NLothar Waßmann <LW@KARO-electronics.de>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Pass through the 0xE1 prefix so atkbd can properly parse the scancode
data.
Signed-off-by: NK. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Signed-off-by: NGeert Uytterhoeven <geert+renesas@linux-m68k.org>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

None of these files are actually using any __init type directives
and hence don't need to include <linux/init.h>.  Most are just a
left over from __devinit and __cpuinit removal, or simply due to
code getting copied from one driver to the next.
Signed-off-by: NPaul Gortmaker <paul.gortmaker@windriver.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Reviewed-by: NJingoo Han <jg1.han@samsung.com>
Tested-by: NSebastian Reichel <sre@debian.org>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Since the driver requires DT now we do not need to check if CONFIG_OF is
defined.
Reviewed-by: NDavid Herrmann <dh.herrmann@gmail.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Add device tree support for twl4030 keypad driver.

Tested on Nokia N900.
Signed-off-by: NSebastian Reichel <sre@debian.org>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

We should drop reference to twl6040_core_node device_node once we are done
using it.
Signed-off-by: NLibo Chen <libo.chen@huawei.com>
Acked-by: NPeter Ujfalusi <peter.ujfalusi@ti.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

We should drop reference to twl6040_core_node device_node once we are done
using it.
Signed-off-by: NLibo Chen <libo.chen@huawei.com>
Acked-by: NPeter Ujfalusi <peter.ujfalusi@ti.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Remove messy dependencies from SERIO_I8042 by having it depend on one
Kconfig symbol (ARCH_MIGHT_HAVE_PC_SERIO) and having architectures
which need it select ARCH_MIGHT_HAVE_PC_SERIO in arch/*/Kconfig.
New architectures are unlikely to need SERIO_I8042, so this avoids
having an ever growing list of architectures to exclude.
Signed-off-by: NMark Salter <msalter@redhat.com>
Acked-by: N"H. Peter Anvin" <hpa@zytor.com>
Acked-by: NRalf Baechle <ralf@linux-mips.org>
Acked-by: NBenjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Architectures which might use an i8042 for serial IO to keyboard,
mouse, etc should select ARCH_MIGHT_HAVE_PC_SERIO.
Signed-off-by: NMark Salter <msalter@redhat.com>
Acked-by: N"H. Peter Anvin" <hpa@zytor.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Architectures which might use an i8042 for serial IO to keyboard,
mouse, etc should select ARCH_MIGHT_HAVE_PC_SERIO.
Signed-off-by: NMark Salter <msalter@redhat.com>
Acked-by: NGuan Xuetao <gxt@mprc.pku.edu.cn>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Architectures which might use an i8042 for serial IO to keyboard,
mouse, etc should select ARCH_MIGHT_HAVE_PC_SERIO.
Signed-off-by: NMark Salter <msalter@redhat.com>
Acked-by: N"David S. Miller" <davem@davemloft.net>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Architectures which might use an i8042 for serial IO to keyboard,
mouse, etc should select ARCH_MIGHT_HAVE_PC_SERIO. Cayman board
is only sh board which needs this.
Signed-off-by: NMark Salter <msalter@redhat.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Architectures which might use an i8042 for serial IO to keyboard,
mouse, etc should select ARCH_MIGHT_HAVE_PC_SERIO.
Signed-off-by: NMark Salter <msalter@redhat.com>
Acked-by: NBenjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Architectures which might use an i8042 for serial IO to keyboard,
mouse, etc should select ARCH_MIGHT_HAVE_PC_SERIO.
Signed-off-by: NMark Salter <msalter@redhat.com>
Acked-by: NRalf Baechle <ralf@linux-mips.org>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Architectures which might use an i8042 for serial IO to keyboard,
mouse, etc should select ARCH_MIGHT_HAVE_PC_SERIO.
Signed-off-by: NMark Salter <msalter@redhat.com>
Acked-by: NTony Luck <tony.luck@intel.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Architectures which might use an i8042 for serial IO to keyboard,
mouse, etc should select ARCH_MIGHT_HAVE_PC_SERIO.
Signed-off-by: NMark Salter <msalter@redhat.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Architectures which might use an i8042 for serial IO to keyboard,
mouse, etc should select ARCH_MIGHT_HAVE_PC_SERIO.
Signed-off-by: NMark Salter <msalter@redhat.com>
Acked-by: NMatt Turner <mattst88@gmail.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

The driver can't deal with two entries its keymap having the same keycode.
When this happens it will get confused about whether the key is down or up
and will cause some screwy behavior.

We need to have two entries for KEY_BACKSLASH to handle US and UK
keyboards. Specifically:
* On the US keyboard the backslash key (above enter) is r3 c11 and is
  supposed to be reported as BACKSLASH.
* On the UK keyboard the # key (left of enter) is r4 c10 and is
  supposed to be reported as BACKSLASH.
* On the UK keyboard the \ key (left of Z) is r2 c7 and is supposed to
  be reported as KEY_102ND.

Note that both keyboards (US and UK) have only one physical backslash
key so the constraint that each physical key should have its own keycode
still stands.
Signed-off-by: NDoug Anderson <dianders@chromium.org>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Commit 2203747c ("ARM: omap: move platform_data definitions")
moved the file to the current location but forgot to remove the pointer
to its previous location. Clean it up. While at it also change the header
file protection macros appropriately.
Signed-off-by: NSachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>