1. 01 12月, 2021 1 次提交
    • L
      drm/i915/dp: Perform 30ms delay after source OUI write · a44f42ba
      Lyude Paul 提交于
      While working on supporting the Intel HDR backlight interface, I noticed
      that there's a couple of laptops that will very rarely manage to boot up
      without detecting Intel HDR backlight support - even though it's supported
      on the system. One example of such a laptop is the Lenovo P17 1st
      generation.
      
      Following some investigation Ville Syrjälä did through the docs they have
      available to them, they discovered that there's actually supposed to be a
      30ms wait after writing the source OUI before we begin setting up the rest
      of the backlight interface.
      
      This seems to be correct, as adding this 30ms delay seems to have
      completely fixed the probing issues I was previously seeing. So - let's
      start performing a 30ms wait after writing the OUI, which we do in a manner
      similar to how we keep track of PPS delays (e.g. record the timestamp of
      the OUI write, and then wait for however many ms are left since that
      timestamp right before we interact with the backlight) in order to avoid
      waiting any longer then we need to. As well, this also avoids us performing
      this delay on systems where we don't end up using the HDR backlight
      interface.
      
      V3:
      * Move last_oui_write into intel_dp
      V2:
      * Move panel delays into intel_pps
      Signed-off-by: NLyude Paul <lyude@redhat.com>
      Reviewed-by: NJani Nikula <jani.nikula@intel.com>
      Fixes: 4a8d7990 ("drm/i915/dp: Enable Intel's HDR backlight interface (only SDR for now)")
      Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
      Cc: <stable@vger.kernel.org> # v5.12+
      Signed-off-by: NJani Nikula <jani.nikula@intel.com>
      Link: https://patchwork.freedesktop.org/patch/msgid/20211130212912.212044-1-lyude@redhat.com
      (cherry picked from commit c7c90b0b)
      Signed-off-by: NRodrigo Vivi <rodrigo.vivi@intel.com>
      a44f42ba
  2. 30 9月, 2021 1 次提交
  3. 24 9月, 2021 1 次提交
  4. 20 9月, 2021 1 次提交
  5. 31 8月, 2021 1 次提交
  6. 24 8月, 2021 2 次提交
  7. 28 4月, 2021 1 次提交
  8. 20 3月, 2021 3 次提交
  9. 02 2月, 2021 1 次提交
  10. 21 1月, 2021 1 次提交
  11. 20 1月, 2021 1 次提交
  12. 19 1月, 2021 1 次提交
  13. 14 1月, 2021 1 次提交
  14. 13 1月, 2021 1 次提交
  15. 22 12月, 2020 3 次提交
  16. 19 11月, 2020 1 次提交
  17. 21 10月, 2020 1 次提交
  18. 12 10月, 2020 2 次提交
    • I
      drm/i915: Switch to LTTPR non-transparent mode link training · b30edfd8
      Imre Deak 提交于
      The DP Standard's recommendation is to use the LTTPR non-transparent
      mode link training if LTTPRs are detected, so let's do this.
      
      Besides power-saving, the advantages of this are that the maximum number
      of LTTPRs can only be used in non-transparent mode (the limit is 5-8 in
      transparent mode), and it provides a way to narrow down the reason for a
      link training failure to a given link segment. Non-transparent mode is
      probably also the mode that was tested the most by the industry.
      
      The changes in this patchset:
      - Pass the DP PHY that is currently link trained to all LT helpers, so
        that these can access the correct LTTPR/DPRX DPCD registers.
      - During LT take into account the LTTPR common lane rate/count and the
        per LTTPR-PHY vswing/pre-emph limits.
      - Switch to LTTPR non-transparent LT mode and train each link segment
        according to the sequence in DP Standard v2.0 (complete CR/EQ for
        each segment before continuing with the next segment).
      
      v2:
      - Switch to non-transparent mode during connector detection, which is
        required before reading the per-PHY LTTPR capabilities.
      - Move the DP_PHY_LTTPR() macro to drm_dp_helper.h (Ville)
      - Use the new drm_dp_dpcd_read_phy_link_status() instead of adding the
        same logic to intel_dp_get_link_status(). (Ville)
      - Make intel_dp_lttpr_phy_caps() return a pointer to the whole array
        instead of a pointer to its first element. (Ville)
      - Add the intel_dp_phy_is_downstream_of_source() helper. (Ville)
      - Add a code comment about the disable->enable quirk of
        non-transparent mode.
      - Add the intel_dp_training_pattern_set_reg() helper.
      - Fix checkpatch/sparse warns.
      
      Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
      Reviewed-by: NVille Syrjälä <ville.syrjala@linux.intel.com>
      Signed-off-by: NImre Deak <imre.deak@intel.com>
      Link: https://patchwork.freedesktop.org/patch/msgid/20201007170917.1764556-7-imre.deak@intel.com
      b30edfd8
    • I
      drm/i915: Simplify the link training functions · 0a5991f5
      Imre Deak 提交于
      Split the prepare, link training, fallback-handling steps into their own
      functions for clarity and as a preparation for the upcoming LTTPR
      changes.
      
      While at it also:
      - Unexport and inline intel_dp_set_idle_link_train(), which is used at a
        single place.
      - Add some documentation to functions that are exported or that can use
        a better description about which part of the LT sequence they
        implement.
      
      v2: (Ville)
      - Unexport/inline intel_dp_set_idle_link_train()
      - Make the documentation of
        intel_dp_prepare_link_train()/intel_dp_stop_link_train() more accurate
        wrt. HW specific details.
      
      Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
      Reviewed-by: NVille Syrjälä <ville.syrjala@linux.intel.com>
      Signed-off-by: NImre Deak <imre.deak@intel.com>
      Link: https://patchwork.freedesktop.org/patch/msgid/20201007170917.1764556-3-imre.deak@intel.com
      0a5991f5
  19. 10 10月, 2020 1 次提交
  20. 06 10月, 2020 2 次提交
  21. 01 10月, 2020 2 次提交
  22. 25 9月, 2020 1 次提交
  23. 17 9月, 2020 1 次提交
  24. 01 9月, 2020 3 次提交
  25. 28 8月, 2020 1 次提交
  26. 03 7月, 2020 1 次提交
  27. 03 6月, 2020 1 次提交
  28. 14 5月, 2020 3 次提交