提交 · a31ec5fac1674c00d388f09c7097e73266721efd · openeuler / Kernel

In MCC_UPDATE_CMD we get from the FW the number of entries in the
channel info array. We used to WARN_ON if this parameter is greater
than we expected. Since this is not really a driver bug, and since it
might happen in some valid cases too, we shouldn't use a warning here.

Fix this by replacing the WARN_ON with a debug print.
Signed-off-by: NMiri Korenblit <miriam.rachel.korenblit@intel.com>
Signed-off-by: NLuca Coelho <luciano.coelho@intel.com>
Link: https://lore.kernel.org/r/iwlwifi.20220130115024.3cb9828df280.I14abe7c71b45bbae3d3cd503e6e13fa2cd372ed4@changeidSigned-off-by: NLuca Coelho <luciano.coelho@intel.com>

853450a6

iwlwifi: read and print OTP minor version · 3ea839c1

由 Luca Coelho 提交于 1月 30, 2022

Sometimes it can be useful to know the OTP minor version, so read it
from the register and print it out.
Signed-off-by: NLuca Coelho <luciano.coelho@intel.com>
Link: https://lore.kernel.org/r/iwlwifi.20220130115024.a90a1363558e.Ifc08db91cdc7d2e8353af55afaf899e10b2ef875@changeidSigned-off-by: NLuca Coelho <luciano.coelho@intel.com>

3ea839c1

iwlwifi: add support for BZ-U and BZ-L HW · b6356d43

由 Mike Golant 提交于 1月 30, 2022

Add support for BZ-U and BZ-L HW
with GF, GF4, MR, FM and FM4 RF modules
Signed-off-by: NMike Golant <michael.golant@intel.com>
Signed-off-by: NLuca Coelho <luciano.coelho@intel.com>
Link: https://lore.kernel.org/r/iwlwifi.20220130115024.da218b81e88d.I5aa958baef1691d443b9f6e42f7b68514e89f0dc@changeidSigned-off-by: NLuca Coelho <luciano.coelho@intel.com>

b6356d43

iwlwifi: mvm: add support for CT-KILL notification version 2 · 5c7fd9dc

由 Miri Korenblit 提交于 1月 29, 2022

A new version was added to the CT-KILL notification API.
Add support for it.

In addition, print the two fields that was added in this version.
Signed-off-by: NMiri Korenblit <miriam.rachel.korenblit@intel.com>
Signed-off-by: NLuca Coelho <luciano.coelho@intel.com>
Link: https://lore.kernel.org/r/iwlwifi.20220129105618.b79be7a134e9.I7f5c67d79dd97bf5170492aab356ec983622d3b2@changeidSigned-off-by: NLuca Coelho <luciano.coelho@intel.com>

5c7fd9dc

iwlwifi: yoyo: remove DBGI_SRAM address reset writing · ce014c98

由 Rotem Saado 提交于 1月 29, 2022

Due to preg protection we cannot write to this register
while FW is running (when FW in Halt it is ok).
since we have some cases that we need to dump this
region while FW is running remove this writing from DRV.
FW will do this writing.
Signed-off-by: NRotem Saado <rotem.saado@intel.com>
Fixes: 89639e06 ("iwlwifi: yoyo: support for new DBGI_SRAM region")
Signed-off-by: NLuca Coelho <luciano.coelho@intel.com>
Link: https://lore.kernel.org/r/iwlwifi.20220129105618.209f3078bc74.I463530bd2f40daedb39f6d9df987bb7cee209033@changeidSigned-off-by: NLuca Coelho <luciano.coelho@intel.com>

ce014c98

iwlwifi: mvm: support v3 of station HE context command · 42506dd2

由 Johannes Berg 提交于 1月 29, 2022

This now includes 320 MHz and some other data for EHT, support
it, but don't fill in the additional EHT data for now.
Signed-off-by: NJohannes Berg <johannes.berg@intel.com>
Signed-off-by: NLuca Coelho <luciano.coelho@intel.com>
Link: https://lore.kernel.org/r/iwlwifi.20220129105618.6054f8028102.I07d7f406c29c9725d8cd9e979c0070332bbfc64b@changeidSigned-off-by: NLuca Coelho <luciano.coelho@intel.com>

42506dd2

iwlwifi: yoyo: add IMR DRAM dump support · c0941ace

由 Mukesh Sisodiya 提交于 1月 29, 2022

Support debug collection of the platform IMR memory region,
where data is copied by FW during d3 state
Signed-off-by: NMukesh Sisodiya <mukesh.sisodiya@intel.com>
Signed-off-by: NLuca Coelho <luciano.coelho@intel.com>
Link: https://lore.kernel.org/r/iwlwifi.20220129105618.715f04ecc635.Ib89a6caa06c1324c1c0dd3f9f4cf7407f2857155@changeidSigned-off-by: NLuca Coelho <luciano.coelho@intel.com>

c0941ace

iwlwifi: yoyo: fix DBGC allocation flow · ab23da48

由 Rotem Saado 提交于 1月 29, 2022

number of DBGCs and number of fragments per DBGC
is hw family dependency and not capability.
Signed-off-by: NRotem Saado <rotem.saado@intel.com>
Signed-off-by: NLuca Coelho <luciano.coelho@intel.com>
Link: https://lore.kernel.org/r/iwlwifi.20220129105618.209c6fe4364a.I5b21769d297d6fcfafc58ddf1db87d88349fe06f@changeidSigned-off-by: NLuca Coelho <luciano.coelho@intel.com>

ab23da48

iwlwifi: pcie: add support for MS devices · ac4790dc

由 Yaara Baruch 提交于 1月 29, 2022

Add MS devices to the driver. For now we are using the same FW image as MR
(since they differ only in rfid), but it should change in the future.
Signed-off-by: NYaara Baruch <yaara.baruch@intel.com>
Signed-off-by: NLuca Coelho <luciano.coelho@intel.com>
Link: https://lore.kernel.org/r/iwlwifi.20220129105618.a82ca9207ace.I38aa0acfb7846b179027b6f87f5f88f8e4177f63@changeidSigned-off-by: NLuca Coelho <luciano.coelho@intel.com>

ac4790dc

iwlwifi: mvm: align locking in D3 test debugfs · 59e1221f

由 Johannes Berg 提交于 1月 29, 2022

Since commit a05829a7 ("cfg80211: avoid holding the RTNL when
calling the driver") we're not only holding the RTNL when going
in and out of suspend, but also the wiphy->mtx. Add that to the
D3 test debugfs in iwlwifi since it's required for various calls
to mac80211.

Fixes: a05829a7 ("cfg80211: avoid holding the RTNL when calling the driver")
Signed-off-by: NJohannes Berg <johannes.berg@intel.com>
Fixes: a05829a7 ("cfg80211: avoid holding the RTNL when calling the driver")
Signed-off-by: NLuca Coelho <luciano.coelho@intel.com>
Link: https://lore.kernel.org/r/iwlwifi.20220129105618.fcec0204e162.Ib73bf787ab4d83581de20eb89b1f8dbfcaaad0e3@changeidSigned-off-by: NLuca Coelho <luciano.coelho@intel.com>

59e1221f

iwlwifi: mvm: don't iterate unadded vifs when handling FW SMPS req · 8a265d1a

由 Luca Coelho 提交于 1月 29, 2022

We may not have all the interfaces added to the driver when we get the
THERMAL_DUAL_CHAIN_REQUEST notification from the FW, so instead of
iterating all vifs to update SMPS, iterate only the ones that are
already assigned. The interfaces that were not assigned yet, will be
updated accordingly when we start using them.
Signed-off-by: NLuca Coelho <luciano.coelho@intel.com>
Fixes: 2a7ce54c ("iwlwifi: mvm: honour firmware SMPS requests")
Signed-off-by: NLuca Coelho <luciano.coelho@intel.com>
Link: https://lore.kernel.org/r/iwlwifi.20220129105618.9416aade2ba0.I0b71142f89e3f158aa058a1dfb2517c8c1fa3726@changeidSigned-off-by: NLuca Coelho <luciano.coelho@intel.com>

8a265d1a

iwlwifi: advertise support for HE - DCM BPSK RX/TX · 0dadd986

由 Mordechay Goodstein 提交于 1月 29, 2022

Our HE capable HW also supports DCM mode, so broadcast this capability
in the HE PHY capabilities.
Signed-off-by: NMordechay Goodstein <mordechay.goodstein@intel.com>
Signed-off-by: NLuca Coelho <luciano.coelho@intel.com>
Link: https://lore.kernel.org/r/iwlwifi.20220129105618.f7f1b31a8c75.Id349f61dfd9d3514c08ad0917b1607d35ab73dfa@changeidSigned-off-by: NLuca Coelho <luciano.coelho@intel.com>

0dadd986

iwlwifi: mvm: only enable HE DCM if we also support TX · b009cf71

由 Mordechay Goodstein 提交于 1月 29, 2022

Currently we enable DCM if the peer supports RX without checking whether
we advertised that we support TX. Fix this by also checking that our TX
side is set.
Signed-off-by: NMordechay Goodstein <mordechay.goodstein@intel.com>
Signed-off-by: NLuca Coelho <luciano.coelho@intel.com>
Link: https://lore.kernel.org/r/iwlwifi.20220129105618.6865266c8a34.If1de7849f25337bb14ba2f27896e9715ae5975df@changeidSigned-off-by: NLuca Coelho <luciano.coelho@intel.com>

b009cf71

iwlwifi: yoyo: fix DBGI_SRAM ini dump header. · 34bc2778

由 Rotem Saado 提交于 1月 29, 2022

DBGI SRAM is new type of monitor, therefore it should be
dump as monitor type with ini dump monitor header.
Signed-off-by: NRotem Saado <rotem.saado@intel.com>
Fixes: 89639e06 ("iwlwifi: yoyo: support for new DBGI_SRAM region")
Signed-off-by: NLuca Coelho <luciano.coelho@intel.com>
Link: https://lore.kernel.org/r/iwlwifi.20220129105618.6c31f6a2dcfc.If311c1d548bc5f7157a449e848ea01f71f5592eb@changeidSigned-off-by: NLuca Coelho <luciano.coelho@intel.com>

34bc2778

iwlwifi: dbg: add infra for tracking free buffer size · f3497dda

由 Mordechay Goodstein 提交于 1月 29, 2022

Until now function just got a pointer to some buffer and used it as if
it's good to use with no boundaries about size left in the buffer.

This infra helps for internal functions ops to make sure buffer usage
is in bound of allocation.

We also add external checks with warnings to verify every internal
function didn't exceed usage of the free buffer size.
Signed-off-by: NMordechay Goodstein <mordechay.goodstein@intel.com>
Signed-off-by: NLuca Coelho <luciano.coelho@intel.com>
Link: https://lore.kernel.org/r/iwlwifi.20220129105618.25c90fb14968.Ic8f05581a745d08011ca29b3f42767402643e8c5@changeidSigned-off-by: NLuca Coelho <luciano.coelho@intel.com>

f3497dda

iwlwifi: mvm: starting from 22000 we have 32 Rx AMPDU sessions · ded5ded3

由 Emmanuel Grumbach 提交于 1月 28, 2022

Those devices have more BAIDs, which is the hardware module
that tracks the BA session.
Signed-off-by: NEmmanuel Grumbach <emmanuel.grumbach@intel.com>
Signed-off-by: NLuca Coelho <luciano.coelho@intel.com>
Link: https://lore.kernel.org/r/iwlwifi.20220128153014.7120a90ed7d2.I9d6d907a2c1b965d1e42ff9f0886b1df627e4761@changeidSigned-off-by: NLuca Coelho <luciano.coelho@intel.com>

ded5ded3

iwlwifi: mvm: support new BAID allocation command · 97f70c56

由 Johannes Berg 提交于 1月 28, 2022

Due to some rearchitecting inside the firmware, a new BAID
allocation command is being introduced. Support it. Note
that with it the firmware no longer returns "no space" but
will crash instead, so check for that before sending the
command to the firmware.
Signed-off-by: NJohannes Berg <johannes.berg@intel.com>
Signed-off-by: NLuca Coelho <luciano.coelho@intel.com>
Link: https://lore.kernel.org/r/iwlwifi.20220128153014.a89fa3bd9d91.Ibe58c5d9e882dad43aa857aa1c8f54f3358c667b@changeidSigned-off-by: NLuca Coelho <luciano.coelho@intel.com>

97f70c56

iwlwifi: mvm: refactor iwl_mvm_sta_rx_agg() · 0f3a4e48

由 Johannes Berg 提交于 1月 28, 2022

Refactor the firmware call in iwl_mvm_sta_rx_agg() out into
its own function to be able to change it more easily in the
next patch.
Signed-off-by: NJohannes Berg <johannes.berg@intel.com>
Signed-off-by: NLuca Coelho <luciano.coelho@intel.com>
Link: https://lore.kernel.org/r/iwlwifi.20220128153014.8ec17e282b24.I37c008a9141a2868ee4560e6de303e8bfbb93502@changeidSigned-off-by: NLuca Coelho <luciano.coelho@intel.com>

0f3a4e48

iwlwifi: cfg: add support for 1K BA queue · d5399f11

由 Mordechay Goodstein 提交于 1月 28, 2022

In order to support 1K aggregations start ba queue with at least double
the size, also allocate based on the connecting type to save memory
usage.
Signed-off-by: NMordechay Goodstein <mordechay.goodstein@intel.com>
Signed-off-by: NLuca Coelho <luciano.coelho@intel.com>
Link: https://lore.kernel.org/r/iwlwifi.20220128153014.16b43fe3e92f.I853c57648feee4b69ccb01ef4c75354377d60be2@changeidSigned-off-by: NLuca Coelho <luciano.coelho@intel.com>

d5399f11

iwlwifi: avoid void pointer arithmetic · 3827cb59

由 Johannes Berg 提交于 1月 28, 2022

Avoid void pointer arithmetic since it's technically
undefined and causes warnings in some places that use
our code.
Signed-off-by: NJohannes Berg <johannes.berg@intel.com>
Signed-off-by: NLuca Coelho <luciano.coelho@intel.com>
Link: https://lore.kernel.org/r/iwlwifi.20220128153014.e349104ecd94.Iadc937f475158b9437becdfefb361a97e7eaa934@changeidSigned-off-by: NLuca Coelho <luciano.coelho@intel.com>

3827cb59

iwlwifi: fix various more -Wcast-qual warnings · 86e8e657

由 Johannes Berg 提交于 1月 28, 2022

When enabling W=3 that gets us -Wcast-qual, fix those warnings
in the code and propagate constness properly, or cast it away
via (uintptr_t) where really needed.
Signed-off-by: NJohannes Berg <johannes.berg@intel.com>
Signed-off-by: NLuca Coelho <luciano.coelho@intel.com>
Link: https://lore.kernel.org/r/iwlwifi.20220128153014.4ac2f19c121e.Ied9469d93f8199206242bfba96e4e8d1949e3a08@changeidSigned-off-by: NLuca Coelho <luciano.coelho@intel.com>

86e8e657

iwlwifi: propagate (const) type qualifier · 73c289ba

由 Bjoern A. Zeeb 提交于 1月 28, 2022

Most of this change is a continuation of commit 403ea939
("iwlwifi: dbg: Mark ucode tlv data as const") propagating the
(const) type qualifier for ucode based tlv data to avoid having
the impression that it is writeable.
The other part of the change preserves the (const) type qualifier
over casts and function calls where it was previously lost.
Both changes are needed to avoid compile time errors on system with
more strict error settings, in this case found with clang on FreeBSD.

Sponsored by:  The FreeBSD Foundation
Signed-off-by: NBjoern A. Zeeb <bz@FreeBSD.ORG>
Signed-off-by: NLuca Coelho <luciano.coelho@intel.com>
[fix double word in commit message]
Signed-off-by: NJohannes Berg <johannes.berg@intel.com>
Signed-off-by: NLuca Coelho <luciano.coelho@intel.com>
Link: https://lore.kernel.org/r/iwlwifi.20220128153014.3230c41312fc.I0032c597984834258d5a79b97052ed83dbe53b80@changeidSigned-off-by: NLuca Coelho <luciano.coelho@intel.com>

73c289ba

iwlwifi: de-const properly where needed · 0301bcd5

由 Bjoern A. Zeeb 提交于 1月 28, 2022

In order to de-const variables simply casting through (void *) is
not enough: "cast from 'const .. *' to 'void *' drops const qualifier".
Cast through (uintptr_t) as well [1] to make this compile on systems
with more strict requirements.
In addition passing const void *data to dma_map_single() also
drops the (const) qualifier.  De-constify on variable on assignment
which may be overwritten later.  In either case the (void *) cast
to dma_map_single() is not needed (anymore) either.

[1] See __DECONST() in sys/sys/cdefs.h in FreeBSD

Sponsored by:  The FreeBSD Foundation
Signed-off-by: NBjoern A. Zeeb <bz@FreeBSD.ORG>
Signed-off-by: NLuca Coelho <luciano.coelho@intel.com>
Link: https://lore.kernel.org/r/iwlwifi.20220128153014.eb696eb56bf6.Ide1dd041f9b908c5154a600286a7453750b0704a@changeidSigned-off-by: NLuca Coelho <luciano.coelho@intel.com>

0301bcd5

iwlwifi: make iwl_fw_lookup_cmd_ver() take a cmd_id · 971cbe50

由 Johannes Berg 提交于 1月 28, 2022

Instead of taking the group/command separately, make the function
take a combined command ID. In many cases, this allows us to pass
an existing command ID (e.g. cmd.id), or introduce a new variable
for it, so that we don't use the command ID twice.

This way, we can also use LONG_GROUP implicitly, so we don't need
to spell that out for many commands.

Apart from mvm.h, fw/img.{c,h} changes and some copyright and
indentation updates, this was done with spatch:

    @@
    identifier cmd;
    expression fw, G, C, def;
    @@
     struct iwl_host_cmd cmd = {
      .id = WIDE_ID(G, C),
    ...
     };
    ...
    -iwl_fw_lookup_cmd_ver(fw, G, C, def)
    +iwl_fw_lookup_cmd_ver(fw, cmd.id, def)

    @@
    identifier cmd;
    expression fw, C, def;
    @@
     struct iwl_host_cmd cmd = {
      .id = C,
    ...
     };
    ...
    -iwl_fw_lookup_cmd_ver(fw, \(IWL_ALWAYS_LONG_GROUP\|LONG_GROUP\), C, def)
    +iwl_fw_lookup_cmd_ver(fw, cmd.id, def)

    @@
    identifier func;
    expression fw, G, C, mvm, flags, cmd, size, def;
    type rettype;
    @@
    rettype func(...)
    {
    +u32 cmd_id = WIDE_ID(G, C);
    ...
    -iwl_fw_lookup_cmd_ver(fw, G, C, def)
    +iwl_fw_lookup_cmd_ver(fw, cmd_id, def)
    ...
    -iwl_mvm_send_cmd_pdu(mvm, WIDE_ID(G, C), flags, cmd, size)
    +iwl_mvm_send_cmd_pdu(mvm, cmd_id, flags, cmd, size)
    ...
    }

    @@
    identifier func;
    expression fw, G, C, mvm, flags, cmd, size, def;
    type rettype;
    @@
    rettype func(...)
    {
    +u32 cmd_id = C;
    ...
    -iwl_fw_lookup_cmd_ver(fw, \(IWL_ALWAYS_LONG_GROUP\|LONG_GROUP\), C, def)
    +iwl_fw_lookup_cmd_ver(fw, cmd_id, def)
    ...
    -iwl_mvm_send_cmd_pdu(mvm, C, flags, cmd, size)
    +iwl_mvm_send_cmd_pdu(mvm, cmd_id, flags, cmd, size)
    ...
    }

    @@
    expression fw, C, def;
    @@
    -iwl_fw_lookup_cmd_ver(fw, \(IWL_ALWAYS_LONG_GROUP\|LONG_GROUP\), C, def)
    +iwl_fw_lookup_cmd_ver(fw, C, def)

    @@
    expression fw, C, G, def;
    @@
    -iwl_fw_lookup_cmd_ver(fw, G, C, def)
    +iwl_fw_lookup_cmd_ver(fw, WIDE_ID(G, C), def)
Signed-off-by: NJohannes Berg <johannes.berg@intel.com>
Signed-off-by: NLuca Coelho <luciano.coelho@intel.com>
Link: https://lore.kernel.org/r/iwlwifi.20220128153014.c4ac213cef5c.I6fd9a4fcbcf16ef3a3ae20a2b08ee54ebe06f96f@changeidSigned-off-by: NLuca Coelho <luciano.coelho@intel.com>

971cbe50

iwlwifi: mvm: fw: clean up hcmd struct creation · c8611331

由 Johannes Berg 提交于 1月 28, 2022

This is valid, but pretty uncommon in the driver, clean up
the code here a bit to use an initializer.
Signed-off-by: NJohannes Berg <johannes.berg@intel.com>
Signed-off-by: NLuca Coelho <luciano.coelho@intel.com>
Link: https://lore.kernel.org/r/iwlwifi.20220128153014.1717817392df.I75add2a50a69d28eaebfd67e5a0524bf43119a81@changeidSigned-off-by: NLuca Coelho <luciano.coelho@intel.com>

c8611331

iwlwifi: prefer WIDE_ID() over iwl_cmd_id() · f0c86427

由 Johannes Berg 提交于 1月 28, 2022

The order of arguments for iwl_cmd_id() is confusing, and the
version is always 0 and thus a useless argument. Prefer the
WIDE_ID() macro (which needs to be a macro due to use in switch
cases etc.) over the iwl_cmd_id() function.

Obviously done with spatch:

  @@
  expression G, C;
  @@
  -iwl_cmd_id(C, G, 0)
  +WIDE_ID(G, C)
Signed-off-by: NJohannes Berg <johannes.berg@intel.com>
Signed-off-by: NLuca Coelho <luciano.coelho@intel.com>
Link: https://lore.kernel.org/r/iwlwifi.20220128153014.cc4f9d1a2e9b.Ieb023cd773ea22e819d1ef1c37ae857ecc1a839d@changeidSigned-off-by: NLuca Coelho <luciano.coelho@intel.com>

f0c86427

iwlwifi: mvm: allow enabling UHB TAS in the USA via ACPI setting · 6da7ba3a

由 Ayala Barazani 提交于 1月 28, 2022

Read a new bit defined in ACPI WTAS that allows OEMs to specify whether
TAS is allowed in UHB (6-7GHz) in the USA. This can be used by OEMs
that got certified to use this feature.
Signed-off-by: NAyala Barazani <ayala.barazani@intel.com>
Signed-off-by: NLuca Coelho <luciano.coelho@intel.com>
Link: https://lore.kernel.org/r/iwlwifi.20220128153014.1d2ae1e6bcdb.I177929ed01ed7bf4614ea0f6db2af9e52de13316@changeidSigned-off-by: NLuca Coelho <luciano.coelho@intel.com>

6da7ba3a

iwlwifi: mvm: offload channel switch timing to FW · ad12b231

由 Nathan Errera 提交于 1月 28, 2022

Since FW is now in charge of timing the channel switch, there is no need
to send the add/modify/remove time event command to fw with every (e)CSA
element.
However, the driver needs to cancel the channel switch if the CS start
notification arrives and it does not know about an ongoing channel switch.
Signed-off-by: NNathan Errera <nathan.errera@intel.com>
Signed-off-by: NLuca Coelho <luciano.coelho@intel.com>
Link: https://lore.kernel.org/r/iwlwifi.20220128153013.ac3af0ff22c7.Ie87c62047b71b93b12aa80b5dc5391b4798dbe97@changeidSigned-off-by: NLuca Coelho <luciano.coelho@intel.com>

ad12b231

iwlwifi: mvm: Don't call iwl_mvm_sta_from_mac80211() with NULL sta · 30d17c12

由 Takashi Iwai 提交于 1月 21, 2022

The recent fix for NULL sta in iwl_mvm_get_tx_rate() still has a call
of iwl_mvm_sta_from_mac80211() that may be called with NULL sta.
Although this practically only points to the address and the actual
access doesn't happen due to the conditional evaluation at a later
point, it looks a bit flaky.

This patch drops the temporary variable above and evaluates
iwm_mvm_sta_from_mac80211() directly for avoiding confusions.

Fixes: d599f714 ("iwlwifi: mvm: don't crash on invalid rate w/o STA")
Signed-off-by: NTakashi Iwai <tiwai@suse.de>
Link: https://lore.kernel.org/r/20220121114024.10454-1-tiwai@suse.deSigned-off-by: NLuca Coelho <luciano.coelho@intel.com>

30d17c12