1. 09 10月, 2012 1 次提交
  2. 08 10月, 2012 1 次提交
    • P
      drivers/net/ethernet/marvell/skge.c: fix error return code · bbcf61fb
      Peter Senna Tschudin 提交于
      The function skge_probe() return 0 for success and negative value
      for most of its internal tests failures. There is one exception
      that is error case going to err_out_led_off:. For this error case, the
      function abort its success execution path, but returns non negative
      value, making it difficult for a caller function to notice the error.
      
      This patch fixes the error case that do not return negative value.
      
      This was found by Coccinelle, but the code change was made by hand.
      This patch is not robot generated.
      
      A simplified version of the semantic match that finds this problem is
      as follows: (http://coccinelle.lip6.fr/)
      
      // <smpl>
      (
      if@p1 (\(ret < 0\|ret != 0\))
       { ... return ret; }
      |
      ret@p1 = 0
      )
      ... when != ret = e1
          when != &ret
      *if(...)
      {
        ... when != ret = e2
            when forall
       return ret;
      }
      // </smpl>
      Signed-off-by: NPeter Senna Tschudin <peter.senna@gmail.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      bbcf61fb
  3. 08 2月, 2012 1 次提交
  4. 01 2月, 2012 1 次提交
  5. 24 1月, 2012 1 次提交
  6. 23 1月, 2012 2 次提交
  7. 04 1月, 2012 1 次提交
  8. 31 12月, 2011 1 次提交
  9. 23 11月, 2011 1 次提交
  10. 09 11月, 2011 1 次提交
  11. 19 10月, 2011 1 次提交
  12. 08 10月, 2011 1 次提交
  13. 07 10月, 2011 1 次提交
  14. 28 9月, 2011 1 次提交
    • S
      skge: handle irq better on single port card · a9e9fd71
      Stephen Hemminger 提交于
      Most boards with SysKonnect/Marvell Ethernet have only a single port.
      For the single port case, use the standard Ethernet driver convention
      of allocating IRQ when device is brought up rather than at probe time.
      
      This patch also adds some additional read after writes to avoid any
      PCI posting problems when setting the IRQ mask.
      
      The error handling of dual port cards is also changed.  If second port
      can not be brought up, then just fail. No point in continuing, since
      the failure is most certainly because of out of memory.
      
      It is worth noting that the dual port skge device has a single irq but two
      seperate status rings and therefore has two NAPI objects, one for
      each port.
      Signed-off-by: NStephen Hemminger <shemminger@vyatta.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      a9e9fd71
  15. 23 9月, 2011 1 次提交
  16. 18 8月, 2011 1 次提交
  17. 12 8月, 2011 1 次提交
  18. 07 7月, 2011 4 次提交
  19. 23 5月, 2011 2 次提交
    • P
      Add appropriate <linux/prefetch.h> include for prefetch users · 70c71606
      Paul Gortmaker 提交于
      After discovering that wide use of prefetch on modern CPUs
      could be a net loss instead of a win, net drivers which were
      relying on the implicit inclusion of prefetch.h via the list
      headers showed up in the resulting cleanup fallout.  Give
      them an explicit include via the following $0.02 script.
      
       =========================================
       #!/bin/bash
       MANUAL=""
       for i in `git grep -l 'prefetch(.*)' .` ; do
       	grep -q '<linux/prefetch.h>' $i
       	if [ $? = 0 ] ; then
       		continue
       	fi
      
       	(	echo '?^#include <linux/?a'
       		echo '#include <linux/prefetch.h>'
       		echo .
       		echo w
       		echo q
       	) | ed -s $i > /dev/null 2>&1
       	if [ $? != 0 ]; then
       		echo $i needs manual fixup
       		MANUAL="$i $MANUAL"
       	fi
       done
       echo ------------------- 8\<----------------------
       echo vi $MANUAL
       =========================================
      Signed-off-by: NPaul <paul.gortmaker@windriver.com>
      [ Fixed up some incorrect #include placements, and added some
        non-network drivers and the fib_trie.c case    - Linus ]
      Signed-off-by: NLinus Torvalds <torvalds@linux-foundation.org>
      70c71606
    • P
      drivers/net: add prefetch header for prefetch users · c0cba59e
      Paul Gortmaker 提交于
      After discovering that wide use of prefetch on modern CPUs
      could be a net loss instead of a win, net drivers which were
      relying on the implicit inclusion of prefetch.h via the list
      headers showed up in the resulting cleanup fallout.  Give
      them an explicit include via the following $0.02 script.
      
       =========================================
       #!/bin/bash
       MANUAL=""
       for i in `git grep -l 'prefetch(.*)' .` ; do
       	grep -q '<linux/prefetch.h>' $i
       	if [ $? = 0 ] ; then
       		continue
       	fi
      
       	(	echo '?^#include <linux/?a'
       		echo '#include <linux/prefetch.h>'
       		echo .
       		echo w
       		echo q
       	) | ed -s $i > /dev/null 2>&1
       	if [ $? != 0 ]; then
       		echo $i needs manual fixup
       		MANUAL="$i $MANUAL"
       	fi
       done
       echo ------------------- 8\<----------------------
       echo vi $MANUAL
       =========================================
      Signed-off-by: NPaul <paul.gortmaker@windriver.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      c0cba59e
  20. 30 4月, 2011 2 次提交
  21. 15 4月, 2011 1 次提交
    • A
      ethtool: allow custom interval for physical identification · fce55922
      Allan, Bruce W 提交于
      When physical identification of an adapter is done by toggling the
      mechanism on and off through software utilizing the set_phys_id operation,
      it is done with a fixed duration for both on and off states.  Some drivers
      may want to set a custom duration for the on/off intervals.  This patch
      changes the API so the return code from the driver's entry point when it
      is called with ETHTOOL_ID_ACTIVE can specify the frequency at which to
      cycle the on/off states, and updates the drivers that have already been
      converted to use the new set_phys_id and use the synchronous method for
      identifying an adapter.
      
      The physical identification frequency set in the updated drivers is based
      on how it was done prior to the introduction of set_phys_id.
      
      Compile tested only.  Also fixes a compiler warning in sfc.
      
      v2: drivers do not return -EINVAL for ETHOOL_ID_ACTIVE
      v3: fold patchset into single patch and cleanup per Ben's feedback
      Signed-off-by: NBruce Allan <bruce.w.allan@intel.com>
      Cc: Ben Hutchings <bhutchings@solarflare.com>
      Cc: Sathya Perla <sathya.perla@emulex.com>
      Cc: Subbu Seetharaman <subbu.seetharaman@emulex.com>
      Cc: Ajit Khaparde <ajit.khaparde@emulex.com>
      Cc: Michael Chan <mchan@broadcom.com>
      Cc: Eilon Greenstein <eilong@broadcom.com>
      Cc: Divy Le Ray <divy@chelsio.com>
      Cc: Don Fry <pcnet32@frontier.com>
      Cc: Jon Mason <jdmason@kudzu.us>
      Cc: Solarflare linux maintainers <linux-net-drivers@solarflare.com>
      Cc: Steve Hodgson <shodgson@solarflare.com>
      Cc: Stephen Hemminger <shemminger@linux-foundation.org>
      Cc: Matt Carlson <mcarlson@broadcom.com>
      Acked-by: NJon Mason <jdmason@kudzu.us>
      Acked-by: NBen Hutchings <bhutchings@solarflare.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      fce55922
  22. 08 4月, 2011 1 次提交
  23. 07 4月, 2011 1 次提交
  24. 25 2月, 2011 1 次提交
  25. 01 1月, 2011 1 次提交
  26. 24 12月, 2010 1 次提交
  27. 21 12月, 2010 1 次提交
  28. 17 12月, 2010 1 次提交
  29. 12 12月, 2010 1 次提交
    • T
      drivers/net: remove unnecessary flush_scheduled_work() calls · 6e07ebd8
      Tejun Heo 提交于
      janz-ican3, sh_eth, skge and vxge don't use workqueue at all and there
      is no reason to flush the system_wq.  Drop flush_scheduled_work()
      calls and references to workqueue.
      Signed-off-by: NTejun Heo <tj@kernel.org>
      Cc: "David S. Miller" <davem@davemloft.net>
      Cc: Wolfgang Grandegger <wg@grandegger.com>
      Cc: Stephen Hemminger <shemminger@linux-foundation.org>
      Cc: Ramkrishna Vepa <ramkrishna.vepa@exar.com>
      Cc: Sivakumar Subramani <sivakumar.subramani@exar.com>
      Cc: Sreenivasa Honnur <sreenivasa.honnur@exar.com>
      Cc: Jon Mason <jon.mason@exar.com>
      Cc: netdev@vger.kernel.org
      6e07ebd8
  30. 09 11月, 2010 1 次提交
  31. 06 10月, 2010 1 次提交
  32. 02 9月, 2010 1 次提交
  33. 16 5月, 2010 1 次提交
  34. 04 4月, 2010 1 次提交
    • J
      net: convert multicast list to list_head · 22bedad3
      Jiri Pirko 提交于
      Converts the list and the core manipulating with it to be the same as uc_list.
      
      +uses two functions for adding/removing mc address (normal and "global"
       variant) instead of a function parameter.
      +removes dev_mcast.c completely.
      +exposes netdev_hw_addr_list_* macros along with __hw_addr_* functions for
       manipulation with lists on a sandbox (used in bonding and 80211 drivers)
      Signed-off-by: NJiri Pirko <jpirko@redhat.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      22bedad3