1. Remove some macros define since it is not used.
2. Remove enum QM_HW_UNKNOWN since it is not used.
3. Remove unused member 'is_frozen' in 'hisi_qm' structure.
Signed-off-by: NWeili Qian <qianweili@huawei.com>
Signed-off-by: NHerbert Xu <herbert@gondor.apana.org.au>

As FIPS may disable algorithms it is useful to show their status
in /proc/crypto.
Signed-off-by: NHerbert Xu <herbert@gondor.apana.org.au>
Acked-by: NArd Biesheuvel <ardb@kernel.org>
Signed-off-by: NHerbert Xu <herbert@gondor.apana.org.au>

In crypto4xx_cipher_done, we should be unmapping the dst page, not
mapping it.

This was flagged by a sparse warning about the unused addr variable.
While we're at it, also fix a sparse warning regarding the unused
ctx variable in crypto4xx_ahash_done (by actually using it).

Fixes: 049359d6 ("crypto: amcc - Add crypt4xx driver")
Signed-off-by: NHerbert Xu <herbert@gondor.apana.org.au>
Tested-by: NChristian Lamparter <chunkeey@gmail.com>
Signed-off-by: NHerbert Xu <herbert@gondor.apana.org.au>

cn10k_cpt.o, otx2_cptlf.o and otx2_cpt_mbox_common.o are linked
into both rvu_cptpf and rvu_cptvf modules:

> scripts/Makefile.build:252: ./drivers/crypto/marvell/octeontx2/Makefile:
> cn10k_cpt.o is added to multiple modules: rvu_cptpf rvu_cptvf
> scripts/Makefile.build:252: ./drivers/crypto/marvell/octeontx2/Makefile:
> otx2_cptlf.o is added to multiple modules: rvu_cptpf rvu_cptvf
> scripts/Makefile.build:252: ./drivers/crypto/marvell/octeontx2/Makefile:
> otx2_cpt_mbox_common.o is added to multiple modules: rvu_cptpf rvu_cptvf

Despite they're build under the same Kconfig option
(CONFIG_CRYPTO_DEV_OCTEONTX2_CPT), it's better do link the common
code into a standalone module and export the shared functions. Under
certain circumstances, this can lead to the same situation as fixed
by commit 637a642f ("zstd: Fixing mixed module-builtin objects").
Plus, those three common object files are relatively big to duplicate
them several times.

Introduce the new module, rvu_cptcommon, to provide the common
functions to both modules.

Fixes: 19d8e8c7 ("crypto: octeontx2 - add virtual function driver support")
Suggested-by: NMasahiro Yamada <masahiroy@kernel.org>
Signed-off-by: NAlexander Lobakin <alobakin@pm.me>
Reviewed-by: NMasahiro Yamada <masahiroy@kernel.org>
Signed-off-by: NHerbert Xu <herbert@gondor.apana.org.au>

This driver generates a large number of sparse warnings due to
two issues.

First of all the structure nx842_devdata is defined inline causing
the __rcu tag to be added to all users of it.  This easily fixed by
splitting up the struct definition.

The second issue is with kdoc markers being incomplete.  The trivial
case of nx842_exec_vas has been fixed, while the other incomplete
documentation has simply been downgraded to normal C comments.
Signed-off-by: NHerbert Xu <herbert@gondor.apana.org.au>

Rewrite the bitwise operations to silence the sparse warnings:

  CHECK   ../crypto/ecc.c
../crypto/ecc.c:1387:39: warning: dubious: !x | y
../crypto/ecc.c:1397:47: warning: dubious: !x | y
Signed-off-by: NHerbert Xu <herbert@gondor.apana.org.au>
Reviewed-by: NVitaly Chikunov <vt@altlinux.org>
Signed-off-by: NHerbert Xu <herbert@gondor.apana.org.au>

The function tls_encrypt_done only uses aead_req to get ahold of
the tls_rec object.  So we could pass that in instead of aead_req
to simplify the code.
Suggested-by: NJakub Kicinski <kuba@kernel.org>
Signed-off-by: NHerbert Xu <herbert@gondor.apana.org.au>
Reviewed-by: NJakub Kicinski <kuba@kernel.org>
Signed-off-by: NHerbert Xu <herbert@gondor.apana.org.au>

This patch removes the temporary scaffolding now that the comletion
function signature has been converted.
Signed-off-by: NHerbert Xu <herbert@gondor.apana.org.au>
Acked-by: NJarkko Sakkinen <jarkko@kernel.org>
Signed-off-by: NHerbert Xu <herbert@gondor.apana.org.au>

This patch removes the temporary scaffolding now that the comletion
function signature has been converted.
Signed-off-by: NHerbert Xu <herbert@gondor.apana.org.au>

This patch removes the temporary scaffolding now that the comletion
function signature has been converted.
Signed-off-by: NHerbert Xu <herbert@gondor.apana.org.au>

This patch removes the temporary scaffolding now that the comletion
function signature has been converted.
Signed-off-by: NHerbert Xu <herbert@gondor.apana.org.au>

This patch removes the temporary scaffolding now that the comletion
function signature has been converted.
Signed-off-by: NHerbert Xu <herbert@gondor.apana.org.au>

This patch removes the temporary scaffolding now that the comletion
function signature has been converted.
Signed-off-by: NHerbert Xu <herbert@gondor.apana.org.au>

This patch removes the temporary scaffolding now that the comletion
function signature has been converted.
Signed-off-by: NHerbert Xu <herbert@gondor.apana.org.au>
Acked-by: NMike Snitzer <snitzer@kernel.org>
Signed-off-by: NHerbert Xu <herbert@gondor.apana.org.au>

This patch does the final flag day conversion of all completion
functions which are now all contained in the Crypto API.
Signed-off-by: NHerbert Xu <herbert@gondor.apana.org.au>

Use the request_complete helpers instead of calling the completion
function directly.
Signed-off-by: NHerbert Xu <herbert@gondor.apana.org.au>

Use the request_complete helpers instead of calling the completion
function directly.
Signed-off-by: NHerbert Xu <herbert@gondor.apana.org.au>

Use the request_complete helpers instead of calling the completion
function directly.
Signed-off-by: NHerbert Xu <herbert@gondor.apana.org.au>

Use the request_complete helpers instead of calling the completion
function directly.
Signed-off-by: NHerbert Xu <herbert@gondor.apana.org.au>

Use the request_complete helpers instead of calling the completion
function directly.
Signed-off-by: NHerbert Xu <herbert@gondor.apana.org.au>
Reviewed-by: NGiovanni Cabiddu <giovanni.cabiddu@intel.com>
Signed-off-by: NHerbert Xu <herbert@gondor.apana.org.au>

Use the request_complete helpers instead of calling the completion
function directly.
Signed-off-by: NHerbert Xu <herbert@gondor.apana.org.au>

Use the request_complete helpers instead of calling the completion
function directly.
Signed-off-by: NHerbert Xu <herbert@gondor.apana.org.au>

Use the request_complete helpers instead of calling the completion
function directly.
Signed-off-by: NHerbert Xu <herbert@gondor.apana.org.au>

Use the request_complete helpers instead of calling the completion
function directly.
Signed-off-by: NHerbert Xu <herbert@gondor.apana.org.au>

Use the request_complete helpers instead of calling the completion
function directly.
Signed-off-by: NHerbert Xu <herbert@gondor.apana.org.au>

Use the request_complete helpers instead of calling the completion
function directly.
Signed-off-by: NHerbert Xu <herbert@gondor.apana.org.au>

Use the request_complete helpers instead of calling the completion
function directly.
Signed-off-by: NHerbert Xu <herbert@gondor.apana.org.au>

Use the request_complete helpers instead of calling the completion
function directly.
Signed-off-by: NHerbert Xu <herbert@gondor.apana.org.au>

Use the request_complete helpers instead of calling the completion
function directly.
Signed-off-by: NHerbert Xu <herbert@gondor.apana.org.au>

Use the request_complete helpers instead of calling the completion
function directly.
Signed-off-by: NHerbert Xu <herbert@gondor.apana.org.au>

Use the request_complete helpers instead of calling the completion
function directly.
Signed-off-by: NHerbert Xu <herbert@gondor.apana.org.au>
Acked-by: NTom Lendacky <thomas.lendacky@amd.com>
Signed-off-by: NHerbert Xu <herbert@gondor.apana.org.au>

Use the request_complete helpers instead of calling the completion
function directly.
Signed-off-by: NHerbert Xu <herbert@gondor.apana.org.au>

Use the request_complete helpers instead of calling the completion
function directly.
Signed-off-by: NHerbert Xu <herbert@gondor.apana.org.au>

Use the request_complete helpers instead of calling the completion
function directly.
Signed-off-by: NHerbert Xu <herbert@gondor.apana.org.au>

Use the request_complete helpers instead of calling the completion
function directly.
Signed-off-by: NHerbert Xu <herbert@gondor.apana.org.au>
Acked-by: NJesper Nilsson <jesper.nilsson@axis.com>
Signed-off-by: NHerbert Xu <herbert@gondor.apana.org.au>

Use the request_complete helpers instead of calling the completion
function directly.
Signed-off-by: NHerbert Xu <herbert@gondor.apana.org.au>

Use the request_complete helpers instead of calling the completion
function directly.
Signed-off-by: NHerbert Xu <herbert@gondor.apana.org.au>

Use the akcipher_request_complete helper instead of calling the
completion function directly.  In fact the previous code was buggy
in that EINPROGRESS was never passed back to the original caller.

Fixes: 3d5b1ecd ("crypto: rsa - RSA padding algorithm")
Signed-off-by: NHerbert Xu <herbert@gondor.apana.org.au>

Use the crypto_request_complete helper instead of calling the
completion function directly.
Signed-off-by: NHerbert Xu <herbert@gondor.apana.org.au>

Use the crypto_request_complete helper instead of calling the
completion function directly.
Signed-off-by: NHerbert Xu <herbert@gondor.apana.org.au>