1. 16 7月, 2010 4 次提交
  2. 13 7月, 2010 1 次提交
    • A
      isdn: autoconvert trivial BKL users to private mutex · 76a64921
      Arnd Bergmann 提交于
      All these files use the big kernel lock in a trivial
      way to serialize their private file operations,
      typically resulting from an earlier semi-automatic
      pushdown from VFS.
      
      None of these drivers appears to want to lock against
      other code, and they all use the BKL as the top-level
      lock in their file operations, meaning that there
      is no lock-order inversion problem.
      
      Consequently, we can remove the BKL completely,
      replacing it with a per-file mutex in every case.
      Using a scripted approach means we can avoid
      typos.
      
      file=$1
      name=$2
      if grep -q lock_kernel ${file} ; then
          if grep -q 'include.*linux.mutex.h' ${file} ; then
                  sed -i '/include.*<linux\/smp_lock.h>/d' ${file}
          else
                  sed -i 's/include.*<linux\/smp_lock.h>.*$/include <linux\/mutex.h>/g' ${file}
          fi
          sed -i ${file} \
              -e "/^#include.*linux.mutex.h/,$ {
                      1,/^\(static\|int\|long\)/ {
                           /^\(static\|int\|long\)/istatic DEFINE_MUTEX(${name}_mutex);
      
      } }"  \
          -e "s/\(un\)*lock_kernel\>[ ]*()/mutex_\1lock(\&${name}_mutex)/g" \
          -e '/[      ]*cycle_kernel_lock();/d'
      else
          sed -i -e '/include.*\<smp_lock.h\>/d' ${file}  \
                      -e '/cycle_kernel_lock()/d'
      fi
      Signed-off-by: NArnd Bergmann <arnd@arndb.de>
      Cc: Karsten Keil <isdn@linux-pingi.de>
      Cc: netdev@vger.kernel.org
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      76a64921
  3. 01 6月, 2010 1 次提交
  4. 29 5月, 2010 1 次提交
  5. 10 5月, 2010 3 次提交
    • T
      pcmcia: update gfp/slab.h includes · 6d59622e
      Tejun Heo 提交于
      Implicit slab.h inclusion via percpu.h is about to go away.  Make sure
      gfp.h or slab.h is included as necessary.
      Signed-off-by: NTejun Heo <tj@kernel.org>
      Cc: Stephen Rothwell <sfr@canb.auug.org.au>
      Signed-off-by: NDominik Brodowski <linux@dominikbrodowski.net>
      6d59622e
    • D
      pcmcia: dev_node removal (drivers with updated printk call) · ded6a1a3
      Dominik Brodowski 提交于
      As a second step, remove any usage of dev_node_t from drivers which
      only wrote to this typedef/struct, except one printk() which can
      easily be replaced by a dev_info()/dev_warn() call.
      
      CC: Harald Welte <laforge@gnumonks.org>
      CC: linux-ide@vger.kernel.org
      CC: linux-wireless@vger.kernel.org
      CC: netdev@vger.kernel.org
      CC: linux-usb@vger.kernel.org
      Acked-by: NKarsten Keil  <isdn@linux-pingi.de>
      Signed-off-by: NDominik Brodowski <linux@dominikbrodowski.net>
      ded6a1a3
    • D
      pcmcia: re-work pcmcia_request_irq() · eb14120f
      Dominik Brodowski 提交于
      Instead of the old pcmcia_request_irq() interface, drivers may now
      choose between:
      
      - calling request_irq/free_irq directly. Use the IRQ from *p_dev->irq.
      
      - use pcmcia_request_irq(p_dev, handler_t); the PCMCIA core will
        clean up automatically on calls to pcmcia_disable_device() or
        device ejection.
      
      - drivers still not capable of IRQF_SHARED (or not telling us so) may
        use the deprecated pcmcia_request_exclusive_irq() for the time
        being; they might receive a shared IRQ nonetheless.
      
      CC: linux-bluetooth@vger.kernel.org
      CC: netdev@vger.kernel.org
      CC: linux-wireless@vger.kernel.org
      CC: linux-serial@vger.kernel.org
      CC: alsa-devel@alsa-project.org
      CC: linux-usb@vger.kernel.org
      CC: linux-ide@vger.kernel.org
      Signed-off-by: NDominik Brodowski <linux@dominikbrodowski.net>
      eb14120f
  6. 30 3月, 2010 1 次提交
    • T
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking... · 5a0e3ad6
      Tejun Heo 提交于
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
      
      percpu.h is included by sched.h and module.h and thus ends up being
      included when building most .c files.  percpu.h includes slab.h which
      in turn includes gfp.h making everything defined by the two files
      universally available and complicating inclusion dependencies.
      
      percpu.h -> slab.h dependency is about to be removed.  Prepare for
      this change by updating users of gfp and slab facilities include those
      headers directly instead of assuming availability.  As this conversion
      needs to touch large number of source files, the following script is
      used as the basis of conversion.
      
        http://userweb.kernel.org/~tj/misc/slabh-sweep.py
      
      The script does the followings.
      
      * Scan files for gfp and slab usages and update includes such that
        only the necessary includes are there.  ie. if only gfp is used,
        gfp.h, if slab is used, slab.h.
      
      * When the script inserts a new include, it looks at the include
        blocks and try to put the new include such that its order conforms
        to its surrounding.  It's put in the include block which contains
        core kernel includes, in the same order that the rest are ordered -
        alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
        doesn't seem to be any matching order.
      
      * If the script can't find a place to put a new include (mostly
        because the file doesn't have fitting include block), it prints out
        an error message indicating which .h file needs to be added to the
        file.
      
      The conversion was done in the following steps.
      
      1. The initial automatic conversion of all .c files updated slightly
         over 4000 files, deleting around 700 includes and adding ~480 gfp.h
         and ~3000 slab.h inclusions.  The script emitted errors for ~400
         files.
      
      2. Each error was manually checked.  Some didn't need the inclusion,
         some needed manual addition while adding it to implementation .h or
         embedding .c file was more appropriate for others.  This step added
         inclusions to around 150 files.
      
      3. The script was run again and the output was compared to the edits
         from #2 to make sure no file was left behind.
      
      4. Several build tests were done and a couple of problems were fixed.
         e.g. lib/decompress_*.c used malloc/free() wrappers around slab
         APIs requiring slab.h to be added manually.
      
      5. The script was run on all .h files but without automatically
         editing them as sprinkling gfp.h and slab.h inclusions around .h
         files could easily lead to inclusion dependency hell.  Most gfp.h
         inclusion directives were ignored as stuff from gfp.h was usually
         wildly available and often used in preprocessor macros.  Each
         slab.h inclusion directive was examined and added manually as
         necessary.
      
      6. percpu.h was updated not to include slab.h.
      
      7. Build test were done on the following configurations and failures
         were fixed.  CONFIG_GCOV_KERNEL was turned off for all tests (as my
         distributed build env didn't work with gcov compiles) and a few
         more options had to be turned off depending on archs to make things
         build (like ipr on powerpc/64 which failed due to missing writeq).
      
         * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
         * powerpc and powerpc64 SMP allmodconfig
         * sparc and sparc64 SMP allmodconfig
         * ia64 SMP allmodconfig
         * s390 SMP allmodconfig
         * alpha SMP allmodconfig
         * um on x86_64 SMP allmodconfig
      
      8. percpu.h modifications were reverted so that it could be applied as
         a separate patch and serve as bisection point.
      
      Given the fact that I had only a couple of failures from tests on step
      6, I'm fairly confident about the coverage of this conversion patch.
      If there is a breakage, it's likely to be something in one of the arch
      headers which should be easily discoverable easily on most builds of
      the specific arch.
      Signed-off-by: NTejun Heo <tj@kernel.org>
      Guess-its-ok-by: NChristoph Lameter <cl@linux-foundation.org>
      Cc: Ingo Molnar <mingo@redhat.com>
      Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
      5a0e3ad6
  7. 29 3月, 2010 1 次提交
  8. 16 3月, 2010 3 次提交
  9. 05 2月, 2010 1 次提交
  10. 04 2月, 2010 3 次提交
  11. 14 1月, 2010 1 次提交
  12. 04 1月, 2010 1 次提交
  13. 08 12月, 2009 1 次提交
  14. 04 12月, 2009 1 次提交
  15. 29 11月, 2009 1 次提交
    • D
      pcmcia: rework the irq_req_t typedef · 5fa9167a
      Dominik Brodowski 提交于
      Most of the irq_req_t typedef'd struct can be re-worked quite
      easily:
      
      (1) IRQInfo2 was unused in any case, so drop it.
      
      (2) IRQInfo1 was used write-only, so drop it.
      
      (3) Instance (private data to be passed to the IRQ handler):
      	Most PCMCIA drivers using pcmcia_request_irq() to actually
      	register an IRQ handler set the "dev_id" to the same pointer
      	as the "priv" pointer in struct pcmcia_device. Modify the two
      	exceptions (ipwireless, ibmtr_cs) to also work this waym and
      	set the IRQ handler's "dev_id" to p_dev->priv unconditionally.
      
      (4) Handler is to be of type irq_handler_t.
      
      (5) Handler != NULL already tells whether an IRQ handler is present.
      	Therefore, we do not need the IRQ_HANDLER_PRESENT flag in
      	irq_req_t.Attributes.
      
      CC: netdev@vger.kernel.org
      CC: linux-bluetooth@vger.kernel.org
      CC: linux-ide@vger.kernel.org
      CC: linux-wireless@vger.kernel.org
      CC: linux-scsi@vger.kernel.org
      CC: alsa-devel@alsa-project.org
      CC: Jaroslav Kysela <perex@perex.cz>
      CC: Jiri Kosina <jkosina@suse.cz>
      CC: Karsten Keil <isdn@linux-pingi.de>
      for the Bluetooth parts: Acked-by: Marcel Holtmann <marcel@holtmann.org>
      Signed-off-by: NDominik Brodowski <linux@dominikbrodowski.net>
      5fa9167a
  16. 16 11月, 2009 1 次提交
  17. 11 11月, 2009 1 次提交
  18. 09 11月, 2009 1 次提交
  19. 05 11月, 2009 2 次提交
  20. 29 9月, 2009 1 次提交
    • R
      isdn: fix netjet/isdnhdlc build errors · 8823ad31
      Randy Dunlap 提交于
      Commit cb3824ba didn't fix this problem.
      
      Fix build errors in netjet, using isdnhdlc module:
      
      drivers/built-in.o: In function `mode_tiger':
      netjet.c:(.text+0x1ca0c7): undefined reference to `isdnhdlc_rcv_init'
      netjet.c:(.text+0x1ca0d4): undefined reference to `isdnhdlc_out_init'
      drivers/built-in.o: In function `fill_dma':
      netjet.c:(.text+0x1ca2bd): undefined reference to `isdnhdlc_encode'
      drivers/built-in.o: In function `read_dma':
      netjet.c:(.text+0x1ca614): undefined reference to `isdnhdlc_decode'
      drivers/built-in.o: In function `nj_irq':
      netjet.c:(.text+0x1cb07a): undefined reference to `isdnhdlc_encode'
      
      drivers/built-in.o: In function `isdnhdlc_decode':
      (.text+0x1c2088): undefined reference to `crc_ccitt_table'
      drivers/built-in.o: In function `isdnhdlc_encode':
      (.text+0x1c2339): undefined reference to `crc_ccitt_table'
      Signed-off-by: NRandy Dunlap <randy.dunlap@oracle.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      8823ad31
  21. 27 7月, 2009 2 次提交
  22. 26 7月, 2009 8 次提交