1. 28 4月, 2022 1 次提交
  2. 07 4月, 2022 1 次提交
  3. 16 3月, 2022 2 次提交
    • M
      drm/amd/display: move FPU operations from dcn21 to dml/dcn20 folder · 22f87d99
      Melissa Wen 提交于
      dml/dcn20_fpu file centralizes all DCN2x functions that require FPU access.
      Therefore, this patch moves FPU-related code from dcn21 to dcn20_fpu. These
      include:
      - dcn21_populate_dml_pipes_from_context()
      - dcn21_validate_bandwidth_fp() and related:
        - dcn21_calculate_wm(),
        - patch_bounding_box(),
        - calculate_wm_set_for_vlevel()
      - renaming update_bw_bounding_box() to dcn21_update_bw_bounding_box(), move
      to dcn20_fpu with related static function construct_low_pstate_lvl()
      
      Also, make dcn21_fast_validate_bw() public in dcn21_resource as it is called
      by dcn21_validate_bandwidth_fp() now in dcn20_fpu.
      
      Reuse dcn20_fpu_adjust_dppclk() in dcn21_fast_validate_bw() as it isolates
      the same FPU operation.
      
      Include dchubbub.h as it is required in dcn21_populate_dml_pipes_from_context()
      Signed-off-by: NMelissa Wen <mwen@igalia.com>
      Acked-by: NAlan Liu <HaoPing.Liu@amd.com>
      Tested-by: NDaniel Wheeler <daniel.wheeler@amd.com>
      Signed-off-by: NAlex Deucher <alexander.deucher@amd.com>
      22f87d99
    • M
      drm/amd/display: move FPU-related code from dcn20 to dml folder · cf689e86
      Melissa Wen 提交于
      Move parts of dcn20 code that uses FPU to dml folder. It aims to isolate
      FPU operations as described by series:
      
      drm/amd/display: Introduce FPU directory inside DC
      https://patchwork.freedesktop.org/series/93042/
      
      This patch moves the following functions from dcn20_resource to
      dml/dcn20_fpu and calls of public functions in dcn20_resource are
      wrapped by DC_FP_START/END():
      
      - void dcn20_populate_dml_writeback_from_context
      - static bool is_dtbclk_required()
      - static enum dcn_zstate_support_state()
      - void dcn20_calculate_dlg_params()
      - static void swizzle_to_dml_params()
      - int dcn20_populate_dml_pipes_from_context()
      - void dcn20_calculate_wm()
      - void dcn20_cap_soc_clocks()
      - void dcn20_update_bounding_box()
      - void dcn20_patch_bounding_box()
      - bool dcn20_validate_bandwidth_fp()
      
      This movement also affects dcn21/30/31, as dcn20_calculate_dlg_params()
      is used by them. For this reason, I included dcn20_fpu headers in
      dcn20_resource headers to make dcn20_calculate_dlg_params() visible to
      dcn21/30/31.
      
      Three new functions are created to isolate well-delimited FPU
      operations:
      
      - void dcn20_fpu_set_wb_arb_params(): set cli_watermark,
        pstate_watermark and time_per_pixel from wb_arb_params (struct
      mcif_arb_params), since those uses FPU operations on double types:
      WritebackUrgentWatermark, WritebackDRAMClockChangeWatermark, '16.0'.
      - void dcn20_fpu_set_wm_ranges(): set min_fill_clk_mhz and
        max_fill_clk_mhz involves FPU calcs on dram_speed_mts (double type);
      - void dcn20_fpu_adjust_dppclk(): adjust operation on RequiredDPPCLK
        that is a double.
      Signed-off-by: NMelissa Wen <mwen@igalia.com>
      Acked-by: NAlan Liu <HaoPing.Liu@amd.com>
      Tested-by: NDaniel Wheeler <daniel.wheeler@amd.com>
      Signed-off-by: NAlex Deucher <alexander.deucher@amd.com>
      cf689e86
  4. 30 12月, 2021 1 次提交
  5. 29 12月, 2021 1 次提交
  6. 14 12月, 2021 1 次提交
    • I
      drm/amd/display: fix function scopes · 240e6d25
      Isabella Basso 提交于
      This turns previously global functions into static, thus removing
      compile-time warnings such as:
      
       warning: no previous prototype for 'get_highest_allowed_voltage_level'
       [-Wmissing-prototypes]
       742 | unsigned int get_highest_allowed_voltage_level(uint32_t chip_family, uint32_t hw_internal_rev, uint32_t pci_revision_id)
           |              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
       warning: no previous prototype for 'rv1_vbios_smu_send_msg_with_param'
       [-Wmissing-prototypes]
       102 | int rv1_vbios_smu_send_msg_with_param(struct clk_mgr_internal *clk_mgr, unsigned int msg_id, unsigned int param)
           |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      
      Changes since v1:
      - As suggested by Rodrigo Siqueira:
        1. Rewrite function signatures to make them more readable.
        2. Get rid of unused functions in order to remove 'defined but not
           used' warnings.
      Reviewed-by: NRodrigo Siqueira <Rodrigo.Siqueira@amd.com>
      Signed-off-by: NIsabella Basso <isabbasso@riseup.net>
      Signed-off-by: NAlex Deucher <alexander.deucher@amd.com>
      240e6d25
  7. 02 12月, 2021 1 次提交
  8. 07 10月, 2021 1 次提交
  9. 06 8月, 2021 1 次提交
    • R
      drm/amd/display: Move specific DCN2x code that uses FPU to DML · c8b3538d
      Rodrigo Siqueira 提交于
      The display core files rely on FPU, which requires to be compiled with
      special flags. Ideally, we don't want these FPU operations spread around
      the DC code; nevertheless, it happens in the current source. This commit
      introduces a new directory inside DML for centralizing shared DCN
      functions that require FPU and have been used outside DML. For
      illustrating this process of transferring FPU functions to the DML
      folder, this commit moves one of the functions
      dcn20_populate_dml_writeback_from_context) that require FPU access to a
      single shared file. Notice that this is the first part of the work, and
      it does not fix the FPU issue yet; we still need other patches for
      achieving the complete FPU isolation.
      
      Changes since V3:
      - Jun: Instead of creating a new directory to keep the FPU code, let's
      make the DML folder the only part that requires FPU access. Drop
      fpu_operation folder.
      - Christian: Fix function code style.
      
      Changes since V2:
      - Christian: Remove unnecessary wrapper.
      - lkp: Add missing prototype.
      - Only compile the FPU operations if the DCN option is enabled.
      
      Change since V1:
      - Update documentation and rebase.
      
      Cc: Harry Wentland <harry.wentland@amd.com>
      Cc: Anson Jacob <Anson.Jacob@amd.com>
      Cc: Christian König <christian.koenig@amd.com>
      Cc: Hersen Wu <hersenxs.wu@amd.com>
      Cc: Aric Cyr <aric.cyr@amd.com>
      Cc: Jun Lei <jun.lei@amd.com>
      Cc: Dmytro Laktyushkin <dmytro.laktyushkin@amd.com>
      Cc: Qingqing Zhuo <qingqing.zhuo@amd.com>
      Reported-by: Nkernel test robot <lkp@intel.com>
      Signed-off-by: NRodrigo Siqueira <Rodrigo.Siqueira@amd.com>
      Reviewed-by: NChristian König <christian.koenig@amd.com>
      Signed-off-by: NAlex Deucher <alexander.deucher@amd.com>
      c8b3538d
  10. 28 7月, 2021 2 次提交
  11. 23 7月, 2021 1 次提交
  12. 09 6月, 2021 2 次提交
  13. 11 5月, 2021 1 次提交
  14. 10 4月, 2021 2 次提交
  15. 24 3月, 2021 4 次提交
  16. 16 3月, 2021 1 次提交
  17. 11 3月, 2021 3 次提交
  18. 06 3月, 2021 2 次提交
  19. 19 2月, 2021 3 次提交
  20. 03 2月, 2021 2 次提交
  21. 21 1月, 2021 2 次提交
  22. 09 12月, 2020 1 次提交
  23. 02 12月, 2020 1 次提交
  24. 17 11月, 2020 1 次提交
  25. 11 11月, 2020 2 次提交