1. 17 6月, 2009 1 次提交
  2. 30 3月, 2009 6 次提交
    • M
      V4L/DVB (10772): siano: prevent duplicate variable declaration · 0d02efe4
      Michael Krufky 提交于
      Fix the following build error:
      
      drivers/media/dvb/siano/smsusb.o: In function `get_order':
      include/asm-generic/page.h:10: multiple definition of `sms_dbg'
      drivers/media/dvb/siano/sms1xxx.o:include/asm-generic/page.h:10: first defined here
      drivers/media/dvb/siano/smsdvb.o: In function `get_order':
      include/asm-generic/page.h:10: multiple definition of `sms_dbg'
      drivers/media/dvb/siano/sms1xxx.o:include/asm-generic/page.h:10: first defined here
      
      Thanks to Mauro Carvalho Chehab for his original patch to address this issue.
      Signed-off-by: NMichael Krufky <mkrufky@linuxtv.org>
      Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>
      0d02efe4
    • M
      V4L/DVB (10752): sms1xxx: load smsdvb module automatically based on device id · 05860f2d
      Michael Krufky 提交于
      The smsdvb module was separated from the core and usb code. This change loads
      smsdvb automatically for driver configurations that depend on it.
      Signed-off-by: NMichael Krufky <mkrufky@linuxtv.org>
      Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>
      05860f2d
    • M
      V4L/DVB (10751): sms1xxx: fix checkpatch.pl violations introduced by previous changeset · b9391f41
      Michael Krufky 提交于
      Fix checkpatch.pl violations introduced by previous changeset:
      
      ERROR: do not use C99 // comments
      156: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1373:
      +//#ifdef DVB_CORE
      
      ERROR: do not use C99 // comments
      157: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1374:
      +//	smsdvb_unregister();
      
      ERROR: do not use C99 // comments
      158: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1375:
      +//#endif
      
      WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
      163: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1380:
      +EXPORT_SYMBOL(smscore_onresponse);
      
      WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
      164: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1381:
      +EXPORT_SYMBOL(sms_get_board);
      
      WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
      165: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1382:
      +EXPORT_SYMBOL(sms_debug);
      
      WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
      166: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1383:
      +EXPORT_SYMBOL(smscore_putbuffer);
      
      WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
      167: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1384:
      +EXPORT_SYMBOL(smscore_registry_getmode);
      
      WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
      168: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1385:
      +EXPORT_SYMBOL(smscore_register_device);
      
      WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
      169: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1386:
      +EXPORT_SYMBOL(smscore_set_board_id);
      
      WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
      170: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1387:
      +EXPORT_SYMBOL(smscore_start_device);
      
      WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
      171: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1388:
      +EXPORT_SYMBOL(smsusb_id_table);
      
      WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
      172: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1389:
      +EXPORT_SYMBOL(smscore_unregister_device);
      
      WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
      173: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1390:
      +EXPORT_SYMBOL(smscore_getbuffer);
      
      WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
      174: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1391:
      +EXPORT_SYMBOL(smscore_get_device_mode);
      
      WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
      175: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1392:
      +EXPORT_SYMBOL(smscore_register_client);
      
      WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
      176: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1393:
      +EXPORT_SYMBOL(smscore_unregister_hotplug);
      
      WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
      177: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1394:
      +EXPORT_SYMBOL(smsclient_sendrequest);
      
      WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
      178: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1395:
      +EXPORT_SYMBOL(smscore_unregister_client);
      
      WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
      179: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1396:
      +EXPORT_SYMBOL(smscore_get_board_id);
      
      WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
      180: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1397:
      +EXPORT_SYMBOL(smscore_register_hotplug);
      
      WARNING: line over 80 characters
      391: FILE: linux/drivers/media/dvb/siano/smscoreapi.h:398:
      +extern int smscore_get_fw_filename(struct smscore_device_t *coredev, int mode, char* filename);
      
      ERROR: "foo* bar" should be "foo *bar"
      391: FILE: linux/drivers/media/dvb/siano/smscoreapi.h:398:
      +extern int smscore_get_fw_filename(struct smscore_device_t *coredev, int mode, char* filename);
      
      WARNING: line over 80 characters
      392: FILE: linux/drivers/media/dvb/siano/smscoreapi.h:399:
      +extern int smscore_send_fw_file(struct smscore_device_t *coredev, u8* ufwbuf,int size);
      
      ERROR: "foo* bar" should be "foo *bar"
      392: FILE: linux/drivers/media/dvb/siano/smscoreapi.h:399:
      +extern int smscore_send_fw_file(struct smscore_device_t *coredev, u8* ufwbuf,int size);
      
      ERROR: space required after that ',' (ctx:VxV)
      392: FILE: linux/drivers/media/dvb/siano/smscoreapi.h:399:
      +extern int smscore_send_fw_file(struct smscore_device_t *coredev, u8* ufwbuf,int size);
                                                                                   ^
      
      WARNING: __func__ should be used instead of gcc specific __FUNCTION__
      489: FILE: linux/drivers/media/dvb/siano/smsusb.c:443:
      +	printk(KERN_INFO"%s  Entering status %d.\n", __FUNCTION__, msg.event);
      
      WARNING: __func__ should be used instead of gcc specific __FUNCTION__
      501: FILE: linux/drivers/media/dvb/siano/smsusb.c:455:
      +	printk(KERN_INFO  "%s  Entering.\n", __FUNCTION__);
      
      ERROR: space prohibited before that '++' (ctx:WxB)
      505: FILE: linux/drivers/media/dvb/siano/smsusb.c:459:
      +	for (i = 0; i < intf->cur_altsetting->desc.bNumEndpoints; i ++)
       	                                                            ^
      
      WARNING: __func__ should be used instead of gcc specific __FUNCTION__
      517: FILE: linux/drivers/media/dvb/siano/smsusb.c:471:
      +			__FUNCTION__, rc);
      Signed-off-by: NMichael Krufky <mkrufky@linuxtv.org>
      [mchehab@redhat.com: sms_dbg were declared on 3 different files]
      Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>
      b9391f41
    • U
      V4L/DVB (10750): import changes from Siano · e0f14c25
      Uri Shkolnik 提交于
      Import the following changes from Uri Shkolnik
      
      * Two-ways merge with Siano internal repository
      * Continuing with DVB sub-system separation
      * kconfig and makefile updates
      * Code cleanup
      
      This is a work-in-progress sync with Siano's internal repository.
      
      Some changes had to be altered or dropped in order not to break the build.
      
      This breaks normal operation for the current driver, but it is being committed
      now for tracking purposes.
      
      These changes introduce the following checkpatch.pl violations:
      
      ERROR: do not use C99 // comments
      156: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1373:
      +//#ifdef DVB_CORE
      
      ERROR: do not use C99 // comments
      157: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1374:
      +//	smsdvb_unregister();
      
      ERROR: do not use C99 // comments
      158: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1375:
      +//#endif
      
      WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
      163: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1380:
      +EXPORT_SYMBOL(smscore_onresponse);
      
      WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
      164: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1381:
      +EXPORT_SYMBOL(sms_get_board);
      
      WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
      165: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1382:
      +EXPORT_SYMBOL(sms_debug);
      
      WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
      166: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1383:
      +EXPORT_SYMBOL(smscore_putbuffer);
      
      WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
      167: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1384:
      +EXPORT_SYMBOL(smscore_registry_getmode);
      
      WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
      168: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1385:
      +EXPORT_SYMBOL(smscore_register_device);
      
      WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
      169: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1386:
      +EXPORT_SYMBOL(smscore_set_board_id);
      
      WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
      170: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1387:
      +EXPORT_SYMBOL(smscore_start_device);
      
      WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
      171: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1388:
      +EXPORT_SYMBOL(smsusb_id_table);
      
      WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
      172: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1389:
      +EXPORT_SYMBOL(smscore_unregister_device);
      
      WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
      173: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1390:
      +EXPORT_SYMBOL(smscore_getbuffer);
      
      WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
      174: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1391:
      +EXPORT_SYMBOL(smscore_get_device_mode);
      
      WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
      175: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1392:
      +EXPORT_SYMBOL(smscore_register_client);
      
      WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
      176: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1393:
      +EXPORT_SYMBOL(smscore_unregister_hotplug);
      
      WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
      177: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1394:
      +EXPORT_SYMBOL(smsclient_sendrequest);
      
      WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
      178: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1395:
      +EXPORT_SYMBOL(smscore_unregister_client);
      
      WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
      179: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1396:
      +EXPORT_SYMBOL(smscore_get_board_id);
      
      WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
      180: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1397:
      +EXPORT_SYMBOL(smscore_register_hotplug);
      
      WARNING: line over 80 characters
      391: FILE: linux/drivers/media/dvb/siano/smscoreapi.h:398:
      +extern int smscore_get_fw_filename(struct smscore_device_t *coredev, int mode, char* filename);
      
      ERROR: "foo* bar" should be "foo *bar"
      391: FILE: linux/drivers/media/dvb/siano/smscoreapi.h:398:
      +extern int smscore_get_fw_filename(struct smscore_device_t *coredev, int mode, char* filename);
      
      WARNING: line over 80 characters
      392: FILE: linux/drivers/media/dvb/siano/smscoreapi.h:399:
      +extern int smscore_send_fw_file(struct smscore_device_t *coredev, u8* ufwbuf,int size);
      
      ERROR: "foo* bar" should be "foo *bar"
      392: FILE: linux/drivers/media/dvb/siano/smscoreapi.h:399:
      +extern int smscore_send_fw_file(struct smscore_device_t *coredev, u8* ufwbuf,int size);
      
      ERROR: space required after that ',' (ctx:VxV)
      392: FILE: linux/drivers/media/dvb/siano/smscoreapi.h:399:
      +extern int smscore_send_fw_file(struct smscore_device_t *coredev, u8* ufwbuf,int size);
                                                                                   ^
      
      WARNING: __func__ should be used instead of gcc specific __FUNCTION__
      489: FILE: linux/drivers/media/dvb/siano/smsusb.c:443:
      +	printk(KERN_INFO"%s  Entering status %d.\n", __FUNCTION__, msg.event);
      
      WARNING: __func__ should be used instead of gcc specific __FUNCTION__
      501: FILE: linux/drivers/media/dvb/siano/smsusb.c:455:
      +	printk(KERN_INFO  "%s  Entering.\n", __FUNCTION__);
      
      ERROR: space prohibited before that '++' (ctx:WxB)
      505: FILE: linux/drivers/media/dvb/siano/smsusb.c:459:
      +	for (i = 0; i < intf->cur_altsetting->desc.bNumEndpoints; i ++)
       	                                                            ^
      
      WARNING: __func__ should be used instead of gcc specific __FUNCTION__
      517: FILE: linux/drivers/media/dvb/siano/smsusb.c:471:
      +			__FUNCTION__, rc);
      
      total: 7 errors, 23 warnings, 524 lines checked
      Signed-off-by: NUri Shkolnik <uris@siano-ms.com>
      Signed-off-by: NMichael Krufky <mkrufky@linuxtv.org>
      Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>
      e0f14c25
    • M
      V4L/DVB (10749): sms1xxx: move smsusb_id_table into smsusb.c · 841a3f0d
      Michael Krufky 提交于
      Move the usb_device_id table to the smsusb module in preparation for the
      sms1xxx module to be split into sub-modules. This will allow the smsusb
      driver to start up automatically upon insertion of the USB device.
      Signed-off-by: NMichael Krufky <mkrufky@linuxtv.org>
      Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>
      841a3f0d
    • U
      V4L/DVB (10748): sms1xxx: restore smsusb_driver.name to smsusb · dba843af
      Uri Shkolnik 提交于
      The sms1xxx driver will be broken down into smaller modules,
      so the original name, smsusb, is more appropriate.
      Signed-off-by: NUri Shkolnik <uris@siano-ms.com>
      Signed-off-by: NMichael Krufky <mkrufky@linuxtv.org>
      Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>
      dba843af
  3. 30 12月, 2008 1 次提交
  4. 04 9月, 2008 1 次提交
  5. 20 7月, 2008 31 次提交