Logic sets a value and then reads it back to make sure it worked
and retries write on failures.  Since read and write share a buffer,
it needs to be set back up before writing though.

Issue is not seen a lot because 1) it doesn't need to retry for
a lot of tablets and 2) a lot of failures that need a retry are
from an -ETIMEDOUT and hopefully buffer is not touched in this case.

At least one user has shown logs with buffer being modified during
-ETIMEDOUT case with linux 3.7 kernel.
Signed-off-by: NChris Bagwell <chris@cnpbagwell.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Apparently some users of managed input devices are confused whether
input_unregister_device() is needed when working with them. Clarify
this in the kernel doc for devm_input_allocate_device(): in most cases
there is no need to call neither input_unregister_device() nor
input_free_device() when working with managed devices.
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

INT_PWM1 is already a bitmask, not the bit number, so shifting by INT_PWM1 is
incorrect.
Signed-off-by: NNickolai Zeldovich <nickolai@csail.mit.edu>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

If of_get_gpio_flags() returns an error (as in case when GPIO probe is
deferred) the driver would attempt to claim invalid GPIO. It should
propagate the error code up the stack instead so that the probe either
fails or will be retried later (in case of -EPROBE_DEFER).

Cc: stable@vger.kernel.org
Reported-by: NGabor Juhos <juhosg@openwrt.org>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

If GPIO probing is deferred, the driver tries to claim an invalid GPIO line
which leads to an error message like this:

  gpio-keys-polled buttons.2: unable to claim gpio 4294966779, err=-22
  gpio-keys-polled: probe of buttons.2 failed with error -22

We should make sure that error code returned by of_get_gpio_flags (including
-EPROBE_DEFER) is propagated up the stack.

Cc: stable@vger.kernel.org
Signed-off-by: NGabor Juhos <juhosg@openwrt.org>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Report only the position of the first finger as absolute non-MT coordinates,
instead of reporting both fingers alternatively. Actual MT events are
unaffected.

This fixes horizontal and improves vertical scrolling with the touchpad.

Cc: stable@vger.kernel.org
Signed-off-by: NChristophe TORDEUX <christophe@tordeux.net>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Prepare first set of updates for 3.8 merge window.

The driver's timer must be set up before enabling IRQ handler, otherwise
bad things may happen.
Reported-and-tested-by: NFengguang Wu <fengguang.wu@intel.com>
Signed-off-by: NPeter Popovec <popovec@fei.tuke.sk>
CC: stable@vger.kernel.org
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

The matrix-keymap module is currently lacking a proper module license,
add one so we don't have this module tainting the entire kernel. This
issue has been present since commit 1932811f (Input: matrix-keymap -
uninline and prepare for device tree support)
Signed-off-by: NFlorian Fainelli <florian@openwrt.org>
CC: stable@vger.kernel.org
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

This saves us a few lines of code.
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

This saves us a few lines of code.
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Commit f393ee2b forgot to add the
touch_max property for Wacom Bamboo Fun CTH-461/S, ID 056a:00d2.

This broke the touch functionality for that device. This patch,
(done with help of Ping Cheng), adds the correct value and makes
touch work again.
Signed-off-by: NDiego Calleja <diegocg@gmail.com>
Reviewed-by: NPing Cheng <pinglinux@gmail.com>
Cc: stable@kernel.org
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

This adds VID/PID combinations for MadCatz, PDP and PowerA (new).

Removed Pelican 'TSZ' Wired Xbox 360 Controller since it's clashing with Edge
wireless Controller and I failed to confirm the PID.
Signed-off-by: N"Guillermo A. Amaral B." <g@maral.me>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Fixed a few minor coding style issues in xpad driver.
Signed-off-by: N"Guillermo A. Amaral B." <g@maral.me>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Signed-off-by: NAlexander Shiyan <shc_work@mail.ru>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Let's switch to using devm_*() interfaces to manage our resources,
thus will simplify error unwinding a bit.
Reviewed-by: NAlban Bedel <alban.bedel@avionic-design.de>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Failures to build a keymap, request an IRQ, or register input device are
fatal for the driver, therefore the messages should have "error" severity
instead of "debug".
Reviewed-by: NAlban Bedel <alban.bedel@avionic-design.de>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

This matches structure of most other input drivers.
Reviewed-by: NAlban Bedel <alban.bedel@avionic-design.de>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

We need to use proper accessor functions instead of directly poking into
various structures.
Reviewed-by: NAlban Bedel <alban.bedel@avionic-design.de>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Use a temporary variable for our parent device (coming from I2C client
structure); we'll be also using it during conversion to managed resources.
Reviewed-by: NAlban Bedel <alban.bedel@avionic-design.de>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Signed-off-by: NAlban Bedel <alban.bedel@avionic-design.de>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Signed-off-by: NAlban Bedel <alban.bedel@avionic-design.de>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

The kernel does not contain the symbol SA1100_BITSY so the driver
is never compiled and can be removed safely.
Signed-off-by: NAlexander Shiyan <shc_work@mail.ru>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Now we can register the BU21013_ts touch screen when booting with Device
Tree enabled. Here we parse all the necessary components previously
expected to be passed from platform data.
Acked-by: NArnd Bergmann <arnd@arndb.de>
Acked-by: NLinus Walleij <linus.walleij@linaro.org>
Signed-off-by: NLee Jones <lee.jones@linaro.org>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

These GPIO init and exit functions have no place in platform data, they
should be part of the driver instead,
Acked-by: NArnd Bergmann <arnd@arndb.de>
Acked-by: NLinus Walleij <linus.walleij@linaro.org>
Signed-off-by: NLee Jones <lee.jones@linaro.org>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Currently the BU21013 Touch Screen driver requests a regulator by the
name of 'V-TOUCH', which doesn't exist anywhere in the kernel. The
correct name, as referenced in platform regulator code is 'avdd'. Here,
when we request a regulator, we use the correct name instead.
Acked-by: NArnd Bergmann <arnd@arndb.de>
Acked-by: NLinus Walleij <linus.walleij@linaro.org>
Signed-off-by: NLee Jones <lee.jones@linaro.org>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

We're currently carrying two 'struct bu21013_platform_device's which
are identical for no apparent reason. Here we remove the extra burden
and apply the same information to the two different instances of the
bu21012_tp driver registration.

[Dmitry Torokhov: picked it up to (hopefully) reduce merge conflict with
 bu21013_ts update that follows.]
Acked-by: NArnd Bergmann <arnd@arndb.de>
Acked-by: NLinus Walleij <linus.walleij@linaro.org>
Signed-off-by: NLee Jones <lee.jones@linaro.org>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Disable hardware if active when suspending if the hw can not
wake the system from suspend.

[Dmitry Torokhov: use input_dev->users instead of a separate flag]
Signed-off-by: NJonas Aaberg <jonas.aberg@stericsson.com>
Signed-off-by: NPhilippe Langlais <philippe.langlais@linaro.org>
Reviewed-by: NBengt Jonsson <bengt.g.jonsson@stericsson.com>
Signed-off-by: NLee Jones <lee.jones@linaro.org>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Instead of reporting the initial stage when the device is registered we
should do it when the device is opened (so there are users).
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

devm_* functions are device managed and make error handling and code
simpler. While at it also fix error exit paths.
Signed-off-by: NSachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

clk_{un}prepare is mandatory for platforms using common clock framework.
Because for SPEAr we don't do anything in clk_{un}prepare() calls, just
call them once in probe/remove.
Signed-off-by: NVipul Kumar Samar <vipulkumar.samar@st.com>
Signed-off-by: NViresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

In imx_keypad_inhibit(), all 8 columns were set to open-drain, in
contrast to the rest of the driver, where only the enabled columns
are modified/used.

Contrary to the normal expectation, this also affects column I/Os not
even mapped via IOMUX to the KPP hardware module but used as a GPIO.
Therefore only init enabled columns to open-drain and leave all others
with their default reset value of 0, i.e. totem-pole.
Signed-off-by: NAndreas Pretzsch <apr@cn-eng.de>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

We do not need to call tasklet_disable() before calling tasklet_kill() if
taskelt does not reschedult itself.
Signed-off-by: NXiaotian Feng <dannyfeng@tencent.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

To facilitate upcoming cleanup in twl stack switch from using
TWL4030_MODULE_PM_MASTER define to usingTWL_MODULE_PM_MASTER.
There are no functional changes.
Signed-off-by: NPeter Ujfalusi <peter.ujfalusi@ti.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

This patch allows the STMPE driver to be successfully probed and
initialised when Device Tree support is enabled. Besides the usual
platform data changes, we also separate the process of filling in
the 'in use' pin bitmap, as we have to extract the information from
Device Tree in the DT boot case.
Acked-by: NArnd Bergmann <arnd@arndb.de>
Acked-by: NLinus Walleij <linus.walleij@linaro.org>
Signed-off-by: NLee Jones <lee.jones@linaro.org>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

CONFIG_HOTPLUG is going away as an option so __devexit is no
longer needed.
Signed-off-by: NBill Pemberton <wfp5p@virginia.edu>
Acked-by: NMark Brown <broonie@opensource.wolfsonmicro.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

CONFIG_HOTPLUG is going away as an option so __devinit is no longer
needed.
Signed-off-by: NBill Pemberton <wfp5p@virginia.edu>
Acked-by: NMark Brown <broonie@opensource.wolfsonmicro.com>
Acked-by: NJavier Martinez Canillas <javier@dowhile0.org>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

CONFIG_HOTPLUG is going away as an option so __devinitconst is no
longer needed.
Signed-off-by: NBill Pemberton <wfp5p@virginia.edu>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

CONFIG_HOTPLUG is going away as an option so __devinitdata is no
longer needed.
Signed-off-by: NBill Pemberton <wfp5p@virginia.edu>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

CONFIG_HOTPLUG is going away as an option so __devexit_p is no longer
needed.
Signed-off-by: NBill Pemberton <wfp5p@virginia.edu>
Acked-by: NRussell King <rmk+kernel@arm.linux.org.uk>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>