Add the still missing dependencies for triggered buffer support.

Fixes: 	95c12bba ("iio: accel: Add buffer mode for Sensortek STK8312")
Signed-off-by: NHartmut Knaack <knaack.h@gmx.de>
Reviewed-by: NTiberiu Breana <tiberiu.a.breana@intel.com>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

Drop the otherwise unused definition of the channel-array size and use it
directly in _probe - makes it a bit more obvious.
Signed-off-by: NHartmut Knaack <knaack.h@gmx.de>
Acked-by: NAntoine Tenart <antoine.tenart@free-electrons.com>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

Use augmented assignment to subtract the offset for negative temperature
values.
Specify the amount of private data to be allocated through
devm_iio_device_alloc() with sizeof(*priv), as it is shorter and common
practice in IIO.
Signed-off-by: NHartmut Knaack <knaack.h@gmx.de>
Acked-by: NAntoine Tenart <antoine.tenart@free-electrons.com>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

Mark berlin2_adc_channels array as constant.
Signed-off-by: NHartmut Knaack <knaack.h@gmx.de>
Acked-by: NAntoine Tenart <antoine.tenart@free-electrons.com>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

Pass up the real error code returned by platform_get_irq_byname().
Signed-off-by: NHartmut Knaack <knaack.h@gmx.de>
Acked-by: NAntoine Tenart <antoine.tenart@free-electrons.com>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

Signed-off-by: NJoo Aun Saw <jasaw@dius.com.au>
Acked-by: NDaniel Baluta <daniel.baluta@intel.com>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

Signed-off-by: NJoo Aun Saw <jasaw@dius.com.au>
Acked-by: NDaniel Baluta <daniel.baluta@intel.com>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

Running generic_buffer without enabling any channel of the
sensor will fail without printing any error message.

Add an error message that indicates buffer enable failed.
Signed-off-by: NIrina Tirdea <irina.tirdea@intel.com>
Acked-by: NHartmut Knaack <knaack.h@gmx.de>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

When the the sensor data uses 32 bits out of 32, generic_buffer prints
the value 0 for all data read.

In this case, the mask is shifted 32 bits, which is beyond the size of
an integer. This will lead to the mask always being 0. Before printing,
the mask is applied to the raw value, thus generating a final value of 0.

Fix the mask by shifting a 64 bit value instead of an integer.
Signed-off-by: NIrina Tirdea <irina.tirdea@intel.com>
Acked-by: NHartmut Knaack <knaack.h@gmx.de>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

Fix kernel doc for the iio_dev_attr structure by adding its missing field.
Signed-off-by: NCristina Opriceana <cristina.opriceana@gmail.com>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

Fix buffer name from kernel doc according to the function parameter.
Signed-off-by: NCristina Opriceana <cristina.opriceana@gmail.com>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

Fix kernel docs warnings by adding the missing fields,
each with its associated description.
Signed-off-by: NCristina Opriceana <cristina.opriceana@gmail.com>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

Fix kernel docs for structures and functions in order to
remove some warnings when the documentation gets generated.
Signed-off-by: NCristina Opriceana <cristina.opriceana@gmail.com>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

This patch adds the missing fields in kernel docs to remove
some warnings that appear when the IIO Documentation DocBook
is generated.
Signed-off-by: NCristina Opriceana <cristina.opriceana@gmail.com>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

When setting the trigger state, the device power state is set through
buffer preenable and postdisable hooks. There is no need
to also set it in the trigger set state call.

Remove duplicate set power state from the trigger set
state call.
Signed-off-by: NIrina Tirdea <irina.tirdea@intel.com>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

Runtime resume function is called with the data->mutex lock held.
Add a comment to indicate this.
Signed-off-by: NIrina Tirdea <irina.tirdea@intel.com>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

Define and use a descriptive name for the repetition registers data mask,
instead of a 'magic' value.
Signed-off-by: NHartmut Knaack <knaack.h@gmx.de>
Acked-by: NIrina Tirdea <irina.tirdea@intel.com>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

Keep the mutex locked, until the content of data->buffer has been pushed
out.
Signed-off-by: NHartmut Knaack <knaack.h@gmx.de>
Acked-by: NIrina Tirdea <irina.tirdea@intel.com>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

Translates the magic constant numbers to named macros and add some
additional comments about their meaning.

The diff is made towards togreg branch as that branch seems to have the
most recent updates of mlx90614 driver (many are yet to be merged).
Signed-off-by: NCrt Mori <cmo@melexis.com>
Acked-by: NPeter Meerwald <pmeerw@pmeerw.net>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

This patch changes two variables to arrays to improve code readibility.
Signed-off-by: NTeodora Baluta <teodora.baluta@intel.com>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

The I2C core always reports the MODALIAS uevent as "i2c:<client name"
regardless if the driver was matched using the I2C id_table or the
of_match_table. So technically there's no need for a driver to export
the OF table since currently it's not used.

In fact, the I2C device ID table is mandatory for I2C drivers since
a i2c_device_id is passed to the driver's probe function even if the
I2C core used the OF table to match the driver.

And since the I2C core uses different tables, OF-only drivers needs to
have duplicated data that has to be kept in sync and also the dev node
compatible manufacturer prefix is stripped when reporting the MODALIAS.

To avoid the above, the I2C core behavior may be changed in the future
to not require an I2C device table for OF-only drivers and report the
OF module alias. So, it's better to also export the OF table to prevent
breaking module autoloading if that happens.
Signed-off-by: NJavier Martinez Canillas <javier@osg.samsung.com>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

The I2C core always reports the MODALIAS uevent as "i2c:<client name"
regardless if the driver was matched using the I2C id_table or the
of_match_table. So the driver needs to export the I2C table and this
be built into the module or udev won't have the necessary information
to auto load the correct module when the device is added.
Signed-off-by: NJavier Martinez Canillas <javier@osg.samsung.com>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

Make scale and offset optional by adding -ENOENT check as not all
drivers implement them.
Signed-off-by: NJoo Aun Saw <jasaw@dius.com.au>
Acked-by: NHartmut Knaack <knaack.h@gmx.de>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

This adds support for the lsm303agr magnetometer.
Signed-off-by: NGiuseppe Barba <giuseppe.barba@st.com>
Acked-by: NDenis Ciocca <denis.ciocca@st.com>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

This adds support for the lsm303agr accelerometer.
Signed-off-by: NGiuseppe Barba <giuseppe.barba@st.com>
Acked-by: NDenis Ciocca <denis.ciocca@st.com>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

Add irq trigger handling for magnetometer also
Signed-off-by: NGiuseppe Barba <giuseppe.barba@st.com>
Acked-by: NDenis Ciocca <denis.ciocca@st.com>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

Some sensors could have only one full scale value. This means that the
sensor hasn't a full scale register. This commit add a check on the
configured full scale address to support such kind of sensors.
Signed-off-by: NGiuseppe Barba <giuseppe.barba@st.com>
Acked-by: NDenis Ciocca <denis.ciocca@st.com>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

This patch permits to configure the WhoAmI register address
because some device could have not a standard address for
this register.
Signed-off-by: NGiuseppe Barba <giuseppe.barba@st.com>
Reviewed-by: NDenis Ciocca <denis.ciocca@st.com>
Acked-by: NDenis Ciocca <denis.ciocca@st.com>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

Since patch "i2c / ACPI: Use 0 to indicate that device does not have
interrupt assigned" [1], 0 is not a valid i2c client irq anymore, so
change all driver's checks accordingly.

The same issue occurs when the device is instantiated via device tree
with no IRQ, or from the i2c sysfs interface, even before the patch
above.

[1] http://lkml.kernel.org/g/<1430908148-201129-3-git-send-email-mika.westerberg@linux.intel.com>
Signed-off-by: NOctavian Purdila <octavian.purdila@intel.com>
Reviewed-by: NMika Westerberg <mika.westerberg@linux.intel.com>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

This patch indends to make some cleanup and send printf
error messages to stderr. The changes were performed with coccinelle
for failure messages and manual for other cases, such as wrong usage
messages.
Signed-off-by: NCristina Opriceana <cristina.opriceana@gmail.com>
Reviewed-by: NHartmut Knaack <knaack.h@gmx.de>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

Calculation of the length of an array can be done with the ARRAY_SIZE
macro to make code more abstract and remove the associated
checkpatch.pl warning.
Signed-off-by: NCristina Opriceana <cristina.opriceana@gmail.com>
Acked-by: NHartmut Knaack <knaack.h@gmx.de>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

Single statement blocks don’t need braces.
Found with checkpatch.pl.
Signed-off-by: NCristina Opriceana <cristina.opriceana@gmail.com>
Acked-by: NHartmut Knaack <knaack.h@gmx.de>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

Remove explicit NULL comparison and write it in its simpler form as
recommended by checkpatch.pl.
Signed-off-by: NCristina Opriceana <cristina.opriceana@gmail.com>
Reviewed-by: NHartmut Knaack <knaack.h@gmx.de>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

Add support for TXC PA12203001 als and proximity sensor.
Support for raw illuminance and proximity readings.
Signed-off-by: NAdriana Reus <adriana.reus@intel.com>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

TI's opt3001 light sensor is a simple and yet powerful
little device. The device provides 99% IR rejection,
automatic full-scale, very low power consumption and
measurements from 0.01 to 83k lux.

This patch adds support for that device using the IIO
framework.

See http://www.ti.com/product/opt3001 for more information.
Signed-off-by: NFelipe Balbi <balbi@ti.com>
Signed-off-by: NAndreas Dannenberg <dannenberg@ti.com>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

This cleans up the most ugly workaround in this driver. There are no
functional changes yet in the decoding algorithm, but we improve the
following things:
 * Get rid of spurious warning messages on systems with fast HRTIMER.
 * If the clock is not fast enough for decoding to work, we give
   up immediately.
 * In that case we return EAGAIN instead of EIO, so it's easier to
   discriminate causes of failure.

Returning EAGAIN is somewhat controversial: It's technically correct
as a faster clock might become available. OTOH once all clocks are
enabled this is a permanent error. There is no ECLOCKTOOSLOW error
code.
Signed-off-by: NHarald Geyer <harald@ccbib.org>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

We just do the assignments in two steps.
Signed-off-by: NHarald Geyer <harald@ccbib.org>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

Explain why the driver needs a mutex.
Signed-off-by: NHarald Geyer <harald@ccbib.org>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

* add spaces around binary operators in cases where it reduces readability
* align multiline statements around opening parenthesis
Reported-by: NHartmut Knaack <knaack.h@gmx.de>
	in Message-ID: <55919E72.3010807@gmx.de>
Signed-off-by: NHarald Geyer <harald@ccbib.org>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

The driver currently does not take into account the minimum sample time
as per the Figure 6-8 Chapter 9.1.1 12-bit ADC electrical characteristics.
We set a static amount of cycles instead of considering the sample time
as a given value, which depends on hardware characteristics.

Determine sampling frequencies by first reading the device tree property
node and then calculating the required Long Sample Time Adder (LSTAdder)
value, based on the ADC clock frequency and sample time value obtained
from the device tree. This LSTAdder value is then used for calculating
the sampling frequencies possible.

In case the sample time property is not specified through the device
tree, a safe default value of 1000ns is assumed.
Signed-off-by: NSanchayan Maity <maitysanchayan@gmail.com>
Acked-by: NStefan Agner <stefan@agner.ch>
Acked-by: NFugang Duan <B38611@freescale.com>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>