Skip to content

K
Kernel

openeuler / Kernel
接近 2 年 前同步成功

通知 8
Star 0
Fork 0
K
Kernel
切换分支/标签
  1. 06 12月, 2014 1 次提交
  3. 10 9月, 2014 1 次提交
  5. 13 8月, 2014 1 次提交
  7. 19 6月, 2014 1 次提交
  9. 25 3月, 2014 1 次提交
  11. 22 10月, 2013 1 次提交
  13. 24 9月, 2013 1 次提交
  15. 20 9月, 2013 1 次提交
  17. 14 8月, 2013 1 次提交
  19. 05 8月, 2013 2 次提交
  21. 29 5月, 2013 1 次提交
  23. 05 2月, 2013 1 次提交
  25. 09 1月, 2013 1 次提交
  27. 08 12月, 2012 1 次提交
  29. 04 12月, 2012 1 次提交
  31. 04 11月, 2012 1 次提交
  33. 09 10月, 2012 2 次提交
  35. 08 10月, 2012 1 次提交
    • P
      drivers/net/ethernet/marvell/skge.c: fix error return code · bbcf61fb
      由 Peter Senna Tschudin 提交于 
      The function skge_probe() return 0 for success and negative value
for most of its internal tests failures. There is one exception
that is error case going to err_out_led_off:. For this error case, the
function abort its success execution path, but returns non negative
value, making it difficult for a caller function to notice the error.

This patch fixes the error case that do not return negative value.

This was found by Coccinelle, but the code change was made by hand.
This patch is not robot generated.

A simplified version of the semantic match that finds this problem is
as follows: (http://coccinelle.lip6.fr/)

// <smpl>
(
if@p1 (\(ret < 0\|ret != 0\))
 { ... return ret; }
|
ret@p1 = 0
)
... when != ret = e1
    when != &ret
*if(...)
{
  ... when != ret = e2
      when forall
 return ret;
}
// </smpl>
Signed-off-by: NPeter Senna Tschudin <peter.senna@gmail.com>
Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      bbcf61fb
  37. 08 2月, 2012 1 次提交
  39. 01 2月, 2012 1 次提交
  41. 24 1月, 2012 1 次提交
  43. 23 1月, 2012 2 次提交
  45. 04 1月, 2012 1 次提交
  47. 31 12月, 2011 1 次提交
  49. 23 11月, 2011 1 次提交
  51. 09 11月, 2011 1 次提交
  53. 19 10月, 2011 1 次提交
  55. 08 10月, 2011 1 次提交
  57. 07 10月, 2011 1 次提交
  59. 28 9月, 2011 1 次提交
    • S
      skge: handle irq better on single port card · a9e9fd71
      由 Stephen Hemminger 提交于 
      Most boards with SysKonnect/Marvell Ethernet have only a single port.
For the single port case, use the standard Ethernet driver convention
of allocating IRQ when device is brought up rather than at probe time.

This patch also adds some additional read after writes to avoid any
PCI posting problems when setting the IRQ mask.

The error handling of dual port cards is also changed.  If second port
can not be brought up, then just fail. No point in continuing, since
the failure is most certainly because of out of memory.

It is worth noting that the dual port skge device has a single irq but two
seperate status rings and therefore has two NAPI objects, one for
each port.
Signed-off-by: NStephen Hemminger <shemminger@vyatta.com>
Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      a9e9fd71
  61. 23 9月, 2011 1 次提交
  63. 18 8月, 2011 1 次提交
  65. 12 8月, 2011 1 次提交
  67. 07 7月, 2011 4 次提交